cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-08-24 00:19:21 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

fix(cuesheet): prevent stale column width on refresh

Browse Source
This commit is contained in:
Carlos Valente
2026-08-23 13:08:34 +02:00
committed by Carlos Valente
parent 805663e2ea
commit c19aa4ca28
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/client/src/views/cuesheet/cuesheet-table/CuesheetTable.tsx
+1 -1
View File
@@ -200,7 +200,7 @@ export default function CuesheetTable({
return colSizes;
// eslint-disable-next-line react-compiler/react-compiler -- unfortunately this is what we need
// eslint-disable-next-line react-hooks/exhaustive-deps -- this works well and follows documentation
}, [table.state.columnResizing, table.state.columnSizing]);
}, [columns, table.state.columnResizing, table.state.columnSizing]);
const allLeafColumns = table.getAllLeafColumns();
const { rows } = table.getRowModel();
e2e/tests/features/202-cuesheet.spec.ts
+2 -2
View File
@@ -9,13 +9,13 @@ test('cuesheet displays events', async ({ page }) => {
test('cuesheet persists column visibility', async ({ page }) => {
await page.goto('/cuesheet');
const noteHeader = page.getByRole('columnheader', { name: 'Note' });
const noteHeader = page.getByRole('columnheader', { name: 'Note', exact: true });
const noteCell = page.getByTestId('cuesheet-event').first().getByTestId('cuesheet-cell-note');
await expect(noteHeader).toBeVisible();
await expect(noteCell).toBeVisible();
await page.getByRole('button', { name: 'Columns' }).click();
await page.getByRole('checkbox', { name: 'Note' }).click();
await page.getByRole('checkbox', { name: 'Note', exact: true }).click();
await expect(noteHeader).toBeHidden();
await expect(noteCell).toBeHidden();