runtime: manually initialize xorshift state

This ensures:

 1. The xorshift state is initialized during interp.
 2. The xorshift state gets initialized to a real random number on
    hardware that supports it at runtime.

This fixes a big binary size regression from the previous commit. It's
still not perfect: most programs increase binary size by a few bytes.
But it's not nearly as bad as before.
This commit is contained in:
Ayke van Laethem
2025-02-19 15:34:18 +01:00
committed by Ron Evans
parent 811b13a9d3
commit f4fd79f7be
5 changed files with 8 additions and 5 deletions
+2 -2
View File
@@ -43,8 +43,8 @@ func TestBinarySize(t *testing.T) {
tests := []sizeTest{
// microcontrollers
{"hifive1b", "examples/echo", 4560, 280, 0, 2268},
{"microbit", "examples/serial", 2908, 388, 8, 2272},
{"wioterminal", "examples/pininterrupt", 7293, 1487, 116, 6912},
{"microbit", "examples/serial", 2916, 388, 8, 2272},
{"wioterminal", "examples/pininterrupt", 7315, 1489, 116, 6912},
// TODO: also check wasm. Right now this is difficult, because
// wasm binaries are run through wasm-opt and therefore the
+3 -3
View File
@@ -23,13 +23,13 @@ func fastrand() uint32 {
return xorshift32State
}
func init() {
func initRand() {
r, _ := hardwareRand()
xorshift64State = uint64(r | 1) // protect against 0
xorshift32State = uint32(xorshift64State)
}
var xorshift32State uint32
var xorshift32State uint32 = 1
func xorshift32(x uint32) uint32 {
// Algorithm "xor" from p. 4 of Marsaglia, "Xorshift RNGs".
@@ -49,7 +49,7 @@ func fastrand64() uint64 {
return xorshift64State
}
var xorshift64State uint64
var xorshift64State uint64 = 1
// 64-bit xorshift multiply rng from http://vigna.di.unimi.it/ftp/papers/xorshift.pdf
func xorshiftMult64(x uint64) uint64 {
+1
View File
@@ -35,6 +35,7 @@ func wasmEntryReactor() {
heapStart = uintptr(unsafe.Pointer(&heapStartSymbol))
heapEnd = uintptr(wasm_memory_size(0) * wasmPageSize)
initHeap()
initRand()
if hasScheduler {
// A package initializer might do funky stuff like start a goroutine and
+1
View File
@@ -247,6 +247,7 @@ func sleep(duration int64) {
// With a scheduler, init and the main function are invoked in a goroutine before starting the scheduler.
func run() {
initHeap()
initRand()
go func() {
initAll()
callMain()
+1
View File
@@ -13,6 +13,7 @@ const hasParallelism = false
// With the "none" scheduler, init and the main function are invoked directly.
func run() {
initHeap()
initRand()
initAll()
callMain()
mainExited = true