compiler: ensure that any passed in target, if it does not point to a .json file, is a full LLVM triple

Signed-off-by: Ron Evans <ron@hybridgroup.com>
This commit is contained in:
Ron Evans
2019-09-18 10:43:20 +02:00
committed by Ayke
parent 86b888fdcb
commit a5fb785334
2 changed files with 20 additions and 1 deletions
+1 -1
View File
@@ -206,7 +206,7 @@ func LoadTarget(target string) (*TargetSpec, error) {
// Load target from given triple, ignore GOOS/GOARCH environment
// variables.
tripleSplit := strings.Split(target, "-")
if len(tripleSplit) == 1 {
if len(tripleSplit) < 3 {
return nil, errors.New("expected a full LLVM target or a custom target in -target flag")
}
goos := tripleSplit[2]
+19
View File
@@ -0,0 +1,19 @@
package main
import "testing"
func TestLoadTarget(t *testing.T) {
_, err := LoadTarget("arduino")
if err != nil {
t.Error("LoadTarget test failed:", err)
}
_, err = LoadTarget("notexist")
if err == nil {
t.Error("LoadTarget should have failed with non existing target")
}
if err.Error() != "expected a full LLVM target or a custom target in -target flag" {
t.Error("LoadTarget failed for wrong reason:", err)
}
}