tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-18 11:33:59 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

reflect: document which Convert() cases are still unimplemented

Browse Source
This commit is contained in:
Damian Gryski
2023-03-22 09:33:57 -07:00
committed by Ayke
parent 855e12df51
commit 6b73b5e486
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/reflect/value.go
+6 -3
View File
@@ -1154,8 +1154,6 @@ func convertOp(src Value, typ Type) (Value, bool) {
} }
} }
// TODO(dgryski): Implement other cases
case String: case String:
rtype := typ.(*rawType) rtype := typ.(*rawType)
if typ.Kind() == Slice && !rtype.elem().isNamed() { if typ.Kind() == Slice && !rtype.elem().isNamed() {
@@ -1166,9 +1164,14 @@ func convertOp(src Value, typ Type) (Value, bool) {
return cvtStringRunes(src, rtype), true return cvtStringRunes(src, rtype), true
} }
} }
} }
// TODO(dgryski): Unimplemented:
// Chan
// Identical underlying types
// Non-defined pointers types with same underlying base type
// Interface <-> Type conversions
return Value{}, false return Value{}, false
} }