reflect: document which Convert() cases are still unimplemented

This commit is contained in:
Damian Gryski
2023-03-22 09:33:57 -07:00
committed by Ayke
parent 855e12df51
commit 6b73b5e486
+6 -3
View File
@@ -1154,8 +1154,6 @@ func convertOp(src Value, typ Type) (Value, bool) {
}
}
// TODO(dgryski): Implement other cases
case String:
rtype := typ.(*rawType)
if typ.Kind() == Slice && !rtype.elem().isNamed() {
@@ -1166,9 +1164,14 @@ func convertOp(src Value, typ Type) (Value, bool) {
return cvtStringRunes(src, rtype), true
}
}
}
// TODO(dgryski): Unimplemented:
// Chan
// Identical underlying types
// Non-defined pointers types with same underlying base type
// Interface <-> Type conversions
return Value{}, false
}