tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-07-26 06:38:42 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

transform: optimize range over []byte(string)

Browse Source 
Fixes #2700
This commit is contained in:
Elias Naur
2024-10-14 18:59:07 +02:00
committed by Ayke
parent 45cc5b58cd
commit 539cc5c47b
3 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
transform/testdata/stringtobytes.ll
Vendored
+8
View File
@@ -5,6 +5,8 @@ target triple = "x86_64--linux"
declare { ptr, i64, i64 } @runtime.stringToBytes(ptr, i64)
declare void @printByte(i8)
declare void @printSlice(ptr nocapture readonly, i64, i64)
declare void @writeToSlice(ptr nocapture, i64, i64)
@@ -17,6 +19,12 @@ entry:
%2 = extractvalue { ptr, i64, i64 } %0, 1
%3 = extractvalue { ptr, i64, i64 } %0, 2
call fastcc void @printSlice(ptr %1, i64 %2, i64 %3)
; print(slice[0])
%indexaddr.ptr1 = extractvalue { ptr, i64, i64 } %0, 0
%4 = getelementptr inbounds i8, ptr %indexaddr.ptr1, i64 0
%5 = load i8, ptr %4, align 1
call fastcc void @printByte(i8 %5)
ret void
}
transform/testdata/stringtobytes.out.ll
Vendored
+5
View File
@@ -5,6 +5,8 @@ target triple = "x86_64--linux"
declare { ptr, i64, i64 } @runtime.stringToBytes(ptr, i64)
declare void @printByte(i8)
declare void @printSlice(ptr nocapture readonly, i64, i64)
declare void @writeToSlice(ptr nocapture, i64, i64)
@@ -12,6 +14,9 @@ declare void @writeToSlice(ptr nocapture, i64, i64)
define void @testReadOnly() {
entry:
call fastcc void @printSlice(ptr @str, i64 6, i64 6)
%0 = getelementptr inbounds i8, ptr @str, i64 0
%1 = load i8, ptr %0, align 1
call fastcc void @printByte(i8 %1)
ret void
}
transform/util.go
+6 -3
View File
@@ -38,15 +38,18 @@ func hasFlag(call, param llvm.Value, kind string) bool {
func isReadOnly(value llvm.Value) bool {
uses := getUses(value)
for _, use := range uses {
if !use.IsAGetElementPtrInst().IsNil() {
switch {
case !use.IsAGetElementPtrInst().IsNil():
if !isReadOnly(use) {
return false
}
} else if !use.IsACallInst().IsNil() {
case !use.IsACallInst().IsNil():
if !hasFlag(use, value, "readonly") {
return false
}
} else {
case !use.IsALoadInst().IsNil():
// Loads are read-only.
default:
// Unknown instruction, might not be readonly.
return false
}