Merge pull request #3106 from portapack-mayhem/next

v2.4.0

.github/pull_request_template.md

@@ -1,67 +1,15 @@
 <!--
 👋 Thank you for your contribution!
 
-⚠️ Before you start, please review our Contributing Guidelines:
-https://github.com/portapack-mayhem/mayhem-firmware/wiki/Contributing-Guidelines
+⚠️ To help avoid extensive change requests or potential rejection, please review our simple Contributing Guidelines before you start coding: https://github.com/portapack-mayhem/mayhem-firmware/wiki/Contributing-Guidelines.
+
+Thank you again for contributing!
 -->
 
-## Brief description of what you did
+## Brief description what you did
+<!-- Describe your changes in detail here. What problem does this PR solve? What features does it add or fix? -->
 
-<!-- Replace this line with a description of your changes. What problem does this PR solve? What does it add or fix?
-Don't forget to describe how maintainers can test your modifications! -->
-
----
-
-## Proof that your changes work
-
-> ⚠️ **PRs without proof will not be merged.** Please provide evidence for every section below that applies to your change.
->
-> 🛈 **Trusted contributors:** If you have a track record of merged PRs that were properly tested and documented, maintainers may waive one or more of the proof sections below at their discretion. You are still encouraged to include whatever evidence you have, but sections may be marked `N/A — trusted contributor` with a short note. First-time contributors must provide full proof. See the [Contributing Guidelines](https://github.com/portapack-mayhem/mayhem-firmware/wiki/Contributing-Guidelines) and [Trusted Contributors](https://github.com/portapack-mayhem/mayhem-firmware/wiki/Trusted-Contributors) articles for details.
-
-### 🖥️ Proof it compiles
-
-Attach a log snippet showing a successful build from the final firmware size/space summary in the build output. Example: `Space remaining in flash ROM: 19552 bytes ( 1.9 % )`.
-
-<!-- Paste log below -->
-
-### 📱 Proof of testing on a real device
-
-Attach photos, screenshots, or a short video of your changes running on actual PortaPack hardware. **Emulator or simulator output is not a substitute for real-device testing.**
-
-<!-- Paste photo / video / screenshot below -->
-
-### 📡 Proof against a real emitter/receiver (if applicable)
-
-If your PR involves RX/TX, protocol decoding, signal generation, or any RF-related functionality, you **must** demonstrate it working against a real emitter or receiver. Include photos, videos, logs, or waterfall/spectrum screenshots.
-
-If this section does not apply to your PR, write `N/A` below and briefly explain why.
-
-<!-- Paste RF evidence, or write N/A with a short justification -->
-
----
-
-## 📚 Wiki documentation commitment
-
-**By submitting this PR, you acknowledge that once it is merged you are responsible for creating or updating the corresponding page on the [project wiki](https://github.com/portapack-mayhem/mayhem-firmware/wiki).**
-
-Your wiki article should include:
-
-- A **screenshot of the main app screen** (strongly recommended)
-- A clear **description** of what the app does
-- An explanation of the **controls** and UI elements
-- Any known **limitations**, quirks, or caveats
-- Anything else a user should know to use the app effectively (dependencies, required hardware, file formats, etc.)
-
-If you are modifying an existing app, make sure the wiki page reflects your changes.
-
----
 
 ## Checklist
-
 - [ ] Kept changes minimal and limited to necessary files
 - [ ] Verified functionality remains intact and code compiles
-- [ ] Attached proof that the code compiles successfully *(or marked N/A as a trusted contributor)*
-- [ ] Attached proof of testing on real PortaPack hardware *(or marked N/A as a trusted contributor)*
-- [ ] Attached proof of testing against a real emitter/receiver (if RF-related), or marked N/A with justification
-- [ ] I understand that by getting this PR merged, I am implicitly agreeing to create or update the corresponding wiki page (including a main-screen screenshot, description, controls, and limitations)
-- [ ] Reviewed the [Contributing Guidelines](https://github.com/portapack-mayhem/mayhem-firmware/wiki/Contributing-Guidelines)

SECURITY.md

@@ -1,17 +1 @@
-# Security Policy
-
-## Scope and Threat Model
-This repository hosts the codebase for an embedded system designed for security research. Because the system operates primarily offline, traditional network-based vulnerabilities are generally not applicable. However, we still welcome and review security reports concerning the code within this repository. 
-
-## Reporting a Vulnerability
-If you discover a vulnerability within this tool itself, please submit a report. Please be aware that the maintainers do not promise assistance with obtaining CVE IDs or managing formal security advisories.
-
-## Out of Scope
-* **Vulnerabilities found *using* this tool:** Please do not submit reports here for vulnerabilities you have discovered in other systems or targets using this tool. This channel is strictly for reporting vulnerabilities found *in* the tool itself. 
-* **Other Repositories:** For security issues concerning related tools, such as MayhemHub, please submit your reports directly to their respective repositories.
-
-## Research Attribution
-If you utilize this tool to successfully discover vulnerabilities in external systems, we would greatly appreciate it if you credit or mention our project in your published research or write-ups.
-
-## Legal and Security Disclaimer  
-For comprehensive guidelines regarding the legal and secure usage of this tool, as well as our full liability disclaimer, please refer to: [Intended-Use-and-Legality](https://github.com/portapack-mayhem/mayhem-firmware/wiki/). Users are expected to comply with all applicable laws and regulations when using this software and/or hardware.
+Please check [Intended-Use-and-Legality](https://github.com/portapack-mayhem/mayhem-firmware/wiki/)

firmware/application/CMakeLists.txt

@@ -332,6 +332,7 @@ set(CPPSRC
 	${CPLD_H4M_DATA_CPP}
 	${HACKRF_CPLD_DATA_CPP}
 	ui_external_items_menu_loader.cpp
+	view_factory_base.cpp
 )
 
 set_source_files_properties(${CPPSRC} PROPERTIES COMPILE_FLAGS -flto) # Add lto flag to the non-external sources only

firmware/application/apps/analog_audio_app.cpp

@@ -419,10 +419,10 @@ void AnalogAudioView::on_baseband_bandwidth_changed(uint32_t bandwidth_hz) {
 }
 
 void AnalogAudioView::on_modulation_changed(ReceiverModel::Mode modulation) {
-    waterfall.stop();
+    baseband::spectrum_streaming_stop();
     update_modulation(modulation);
     on_show_options_modulation();
-    waterfall.start();
+    baseband::spectrum_streaming_start();
 }
 
 void AnalogAudioView::remove_options_widget() {

firmware/application/apps/pocsag_app.cpp

@@ -28,7 +28,6 @@
 #include "string_format.hpp"
 #include "utility.hpp"
 #include "file_path.hpp"
-#include "usb_serial_asyncmsg.hpp"
 
 using namespace portapack;
 using namespace pocsag;
@@ -63,7 +62,6 @@ POCSAGSettingsView::POCSAGSettingsView(
          &check_small_font,
          &check_hide_bad,
          &check_hide_addr_only,
-         &check_numeric_detect,
          &opt_filter_mode,
          &field_filter_address,
          &button_save});
@@ -74,7 +72,6 @@ POCSAGSettingsView::POCSAGSettingsView(
     check_small_font.set_value(settings_.enable_small_font);
     check_hide_bad.set_value(settings_.hide_bad_data);
     check_hide_addr_only.set_value(settings_.hide_addr_only);
-    check_numeric_detect.set_value(settings_.enable_numeric_detect);
     opt_filter_mode.set_by_value(settings_.filter_mode);
     field_filter_address.set_value(settings_.filter_address);
 
@@ -84,7 +81,6 @@ POCSAGSettingsView::POCSAGSettingsView(
         settings_.enable_small_font = check_small_font.value();
         settings_.hide_bad_data = check_hide_bad.value();
         settings_.hide_addr_only = check_hide_addr_only.value();
-        settings_.enable_numeric_detect = check_numeric_detect.value();
         settings_.filter_mode = opt_filter_mode.selected_index_value();
         settings_.filter_address = field_filter_address.to_integer();
         settings_.baud_rate = opt_baud_rate.selected_index_value();
@@ -223,24 +219,12 @@ void POCSAGAppView::handle_decoded(Timestamp timestamp, const std::string& prefi
         return;
     }
 
-    // Type indicator with its own color.
-    std::string type_str;
-    bool numeric_detect = settings_.enable_numeric_detect;
-    if (numeric_detect && pocsag_state.detected == pocsag::DET_NUMERIC)
-        type_str = STR_COLOR_GREEN "n";
-    else if (numeric_detect && pocsag_state.detected == pocsag::DET_ALPHA)
-        type_str = STR_COLOR_LIGHT_GREY "a";
-    else if (pocsag_state.out_type == ADDRESS)
-        type_str = STR_COLOR_DARK_YELLOW "t";
-    else
-        type_str = "";
+    // Color indicates the message has a lot of decoding errors.
+    std::string color = bad_data ? STR_COLOR_MAGENTA : STR_COLOR_WHITE;
 
-    // Header: timestamp+baud in light grey, capcode+function in white.
-    std::string console_info = "\n" STR_COLOR_LIGHT_GREY + prefix;
-    console_info += STR_COLOR_WHITE " #" + to_string_dec_uint(pocsag_state.address);
+    std::string console_info = "\n" + color + prefix;
+    console_info += " #" + to_string_dec_uint(pocsag_state.address);
     console_info += " F" + to_string_dec_uint(pocsag_state.function);
-    if (!type_str.empty())
-        console_info += " " + type_str;
 
     if (pocsag_state.out_type == ADDRESS) {
         last_address = pocsag_state.address;
@@ -256,111 +240,23 @@ void POCSAGAppView::handle_decoded(Timestamp timestamp, const std::string& prefi
             }
         }
 
-        /* Serial: tone-only page */
-        if (portapack::usb_serial.serial_connected()) {
-            std::string s = "\r\nPOCSAG " + to_string_dec_uint(current_bitrate) + " " + to_string_dec_uint(pocsag_state.address) + " " + std::string(1, 'A' + pocsag_state.function) + (current_inverted ? " I" : " S") + " tone";
-            UsbSerialAsyncmsg::asyncmsg(s);
-        }
-
     } else if (pocsag_state.out_type == MESSAGE) {
-        if (pocsag_state.new_message) {
+        if (pocsag_state.address != last_address) {
+            // New message
             last_address = pocsag_state.address;
-            serial_numeric_sent = 0;
             console.writeln(console_info);
-
-            // If heuristic chose numeric, show numeric line first (green).
-            if (numeric_detect &&
-                pocsag_state.detected == pocsag::DET_NUMERIC &&
-                pocsag_state.numeric_len > 0) {
-                std::string num_str(pocsag_state.numeric_buf, pocsag_state.numeric_len);
-                console.write(STR_COLOR_GREEN + num_str);
-                console.writeln("");
-            }
-
-            // Alpha decode (already has per-char color escapes from decoder).
-            console.write(pocsag_state.output);
-
-            /* Serial: header + first chunk.
-             * hex field contains rendered alpha as hex bytes (color escapes
-             * stripped).  Non-printable chars show as '.' (0x2E),
-             * uncorrectable chars show as '?' (0x3F) — original 7-bit
-             * values are not preserved.
-             * Numeric decode goes in the quoted message field only. */
-            if (portapack::usb_serial.serial_connected()) {
-                /* Build hex representation of decoded alpha characters. */
-                std::string raw;
-                for (size_t i = 0; i < pocsag_state.output.size(); ++i)
-                    raw += to_string_hex((uint8_t)pocsag_state.output[i], 2);
-
-                std::string s = "\r\nPOCSAG " + to_string_dec_uint(current_bitrate) + " " + to_string_dec_uint(pocsag_state.address) + " " + std::string(1, 'A' + pocsag_state.function) + (current_inverted ? " I" : " S");
-
-                if (numeric_detect && pocsag_state.detected == pocsag::DET_NUMERIC) {
-                    s += " numeric \"";
-                    if (pocsag_state.numeric_len > 0)
-                        s += std::string(pocsag_state.numeric_buf, pocsag_state.numeric_len);
-                    s += "\"";
-                    serial_numeric_sent = pocsag_state.numeric_len;
-                } else {
-                    /* For alpha, the quoted text is the same chars as raw but as ASCII.
-                     * Escape " and \ to avoid breaking the quoted field. */
-                    s += " alpha \"";
-                    for (size_t i = 0; i < pocsag_state.output.size(); ++i) {
-                        if (pocsag_state.output[i] == '"' || pocsag_state.output[i] == '\\') {
-                            s += '\\';
-                        }
-                        s += pocsag_state.output[i];
-                    }
-                    s += "\"";
-                }
-                s += " hex:" + raw;
-                UsbSerialAsyncmsg::asyncmsg(s);
-            }
+            console.write(color + pocsag_state.output);
         } else {
-            // Message continues from previous batch.
-            bool is_numeric = numeric_detect && pocsag_state.detected == pocsag::DET_NUMERIC;
-
-            // GUI: show numeric continuation if applicable.
-            if (is_numeric && pocsag_state.numeric_len > serial_numeric_sent) {
-                std::string num_str(pocsag_state.numeric_buf + serial_numeric_sent,
-                                    pocsag_state.numeric_len - serial_numeric_sent);
-                console.write(STR_COLOR_GREEN + num_str);
-            }
-            console.write(pocsag_state.output);
-
-            /* Serial: continuation chunk with full header.
-             * Type label carries over from first batch (numeric+ or alpha+). */
-            if (portapack::usb_serial.serial_connected()) {
-                std::string raw;
-                std::string decoded;
-                for (size_t i = 0; i < pocsag_state.output.size(); ++i) {
-                    if (pocsag_state.output[i] == '"' || pocsag_state.output[i] == '\\')
-                        decoded += '\\';
-                    decoded += pocsag_state.output[i];
-                    raw += to_string_hex((uint8_t)pocsag_state.output[i], 2);
-                }
-                if (!decoded.empty() || pocsag_state.numeric_len > serial_numeric_sent) {
-                    std::string s = "\r\nPOCSAG " + to_string_dec_uint(current_bitrate) + " " + to_string_dec_uint(pocsag_state.address) + " " + std::string(1, 'A' + pocsag_state.function) + (current_inverted ? " I" : " S") + (is_numeric ? " numeric+" : " alpha+") + " \"";
-                    if (is_numeric && pocsag_state.numeric_len > serial_numeric_sent)
-                        s += std::string(pocsag_state.numeric_buf + serial_numeric_sent,
-                                         pocsag_state.numeric_len - serial_numeric_sent);
-                    else
-                        s += decoded;
-                    s += "\" hex:" + raw;
-                    UsbSerialAsyncmsg::asyncmsg(s);
-                }
-            }
-            serial_numeric_sent = pocsag_state.numeric_len;
+            // Message continues...
+            console.write(color + pocsag_state.output);
         }
 
         if (logging()) {
-            std::string log_entry = to_string_dec_uint(pocsag_state.address) +
-                                    " F" + to_string_dec_uint(pocsag_state.function);
-            if (numeric_detect &&
-                pocsag_state.detected == pocsag::DET_NUMERIC &&
-                pocsag_state.numeric_len > 0)
-                log_entry += " N:" + std::string(pocsag_state.numeric_buf, pocsag_state.numeric_len);
-            log_entry += " " + pocsag_state.output;
-            logger.log_decoded(timestamp, log_entry);
+            logger.log_decoded(
+                timestamp,
+                to_string_dec_uint(pocsag_state.address) +
+                    " F" + to_string_dec_uint(pocsag_state.function) +
+                    " " + pocsag_state.output);
         }
     }
 }
@@ -404,19 +300,13 @@ void POCSAGAppView::on_packet(const POCSAGPacketMessage* message) {
         image_status.set_foreground(Theme::getInstance()->fg_magenta->foreground);
         pocsag_state.codeword_index = 0;
         pocsag_state.errors = 0;
-        current_bitrate = message->packet.bitrate();
-        current_inverted = message->packet.inverted();
 
         // Handle multiple messages (if any).
         while (pocsag_decode_batch(message->packet, pocsag_state))
             handle_decoded(message->packet.timestamp(), prefix);
 
-        // Handle the remainder. Skip if decoder is still in
-        // STATE_HAVE_ADDRESS — the address was at the end of this
-        // batch and we can't yet tell if it's tone-only or has
-        // message data in the next batch.
-        if (pocsag_state.mode != STATE_HAVE_ADDRESS)
-            handle_decoded(message->packet.timestamp(), prefix);
+        // Handle the remainder.
+        handle_decoded(message->packet.timestamp(), prefix);
     }
 
     // Set status icon color to indicate state machine state.

firmware/application/apps/pocsag_app.hpp

@@ -125,7 +125,6 @@ struct POCSAGSettings {
     bool enable_raw_log = false;
     bool hide_bad_data = false;
     bool hide_addr_only = false;
-    bool enable_numeric_detect = true; /* heuristic alpha/numeric type detection */
     uint8_t filter_mode = false;
     int32_t baud_rate = -1;
     uint32_t filter_address = 0;
@@ -151,8 +150,8 @@ class POCSAGSettingsView : public View {
 
     Labels labels{
         {{2 * 8, 0 * 16}, "Baud:", Theme::getInstance()->fg_light->foreground},
-        {{2 * 8, 14 * 16}, "Filter Mode:", Theme::getInstance()->fg_light->foreground},
-        {{2 * 8, 15 * 16}, "Filter Addr:", Theme::getInstance()->fg_light->foreground},
+        {{2 * 8, 12 * 16}, "Filter Mode:", Theme::getInstance()->fg_light->foreground},
+        {{2 * 8, 13 * 16}, "Filter Addr:", Theme::getInstance()->fg_light->foreground},
     };
 
     Checkbox check_log{
@@ -180,26 +179,21 @@ class POCSAGSettingsView : public View {
         22,
         "Hide Addr Only"};
 
-    Checkbox check_numeric_detect{
-        {2 * 8, 12 * 16},
-        22,
-        "Detect Numeric"};
-
     OptionsField opt_filter_mode{
-        {15 * 8, 14 * 16},
+        {15 * 8, 12 * 16},
         4,
         {{"None", FILTER_NONE},
          {"Drop", FILTER_DROP},
          {"Keep", FILTER_KEEP}}};
 
     SymField field_filter_address{
-        {15 * 8, 15 * 16},
+        {15 * 8, 13 * 16},
         7,
         SymField::Type::Dec,
         true /*explicit_edit*/};
 
     Button button_save{
-        {UI_POS_X_CENTER(10), UI_POS_Y(17), 10 * 8, 2 * 16},
+        {UI_POS_X_CENTER(10), UI_POS_Y(16), 10 * 8, 2 * 16},
         "Save"};
 };
 
@@ -237,7 +231,6 @@ class POCSAGAppView : public View {
             {"filter_address"sv, &settings_.filter_address},
             {"hide_bad_data"sv, &settings_.hide_bad_data},
             {"hide_addr_only"sv, &settings_.hide_addr_only},
-            {"numeric_detect"sv, &settings_.enable_numeric_detect},
             {"baud_rate"sv, &settings_.baud_rate},
         }};
 
@@ -248,10 +241,6 @@ class POCSAGAppView : public View {
     void on_stats(const POCSAGStatsMessage* stats);
 
     uint32_t last_address = 0;
-    uint16_t current_bitrate = 0;    /* bitrate of current packet being decoded */
-    bool current_inverted = false;   /* polarity of current packet being decoded */
-    uint8_t serial_numeric_sent = 0; /* numeric chars already sent to serial/GUI */
-
     pocsag::EccContainer ecc{};
     pocsag::POCSAGState pocsag_state{&ecc};
     POCSAGLogger logger{};

firmware/application/apps/ui_battinfo.cpp

@@ -27,8 +27,6 @@
 #include "portapack.hpp"
 #include "battery.hpp"
 #include <cstring>
-#include "ui_settings.hpp"
-#include "portapack_persistent_memory.hpp"
 
 using namespace portapack;
 
@@ -140,8 +138,10 @@ void BattinfoView::update_result() {
     }
     if ((valid_mask & battery::BatteryManagement::BATT_VALID_PERCENT) == battery::BatteryManagement::BATT_VALID_PERCENT) {
         text_method.set("IC");
+        button_mode.set_text("Volt");
     } else {
         text_method.set("Voltage");
+        button_mode.set_text("IC");
     }
     if (uichg) set_dirty();
     // to update status bar too, send message in behalf of batt manager
@@ -158,9 +158,8 @@ BattinfoView::BattinfoView(NavigationView& nav)
                   &text_current,
                   &text_charge,
                   &text_method,
-                  &button_settings,
+                  &button_mode,
                   &button_exit,
-                  &text_capacity,
                   // &text_cycles,
                   // &text_warn,
                   &text_ttef});
@@ -168,11 +167,17 @@ BattinfoView::BattinfoView(NavigationView& nav)
     button_exit.on_select = [this, &nav](Button&) {
         nav.pop();
     };
-    button_settings.on_select = [this, &nav](Button&) {
-        nav.replace<SetBatteryView>();
+    button_mode.on_select = [this, &nav](Button&) {
+        if (button_mode.text() == "IC") {
+            battery::BatteryManagement::set_calc_override(false);
+            persistent_memory::set_ui_override_batt_calc(false);
+            button_mode.set_text("Volt");
+        } else {
+            battery::BatteryManagement::set_calc_override(true);
+            persistent_memory::set_ui_override_batt_calc(true);
+            button_mode.set_text("IC");
+        }
     };
-    text_capacity.set(to_string_dec_uint(persistent_memory::battery_cap_mah()) + " mAh");
-    if (!persistent_memory::battery_cap_valid()) text_capacity.set_style(Theme::getInstance()->fg_red);
     update_result();
     if (thread == nullptr) thread = chThdCreateFromHeap(NULL, 1024, NORMALPRIO + 10, BattinfoView::static_fn, this);
 }

firmware/application/apps/ui_battinfo.hpp

@@ -54,53 +54,48 @@ class BattinfoView : public View {
     int32_t current = 0;
 
     Labels labels{
-        {{UI_POS_X(2), UI_POS_Y(1)}, "Percent:", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(2), UI_POS_Y(2)}, "Voltage:", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(2), UI_POS_Y(3)}, "Method:", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(2), UI_POS_Y(4)}, "Capacity:", Theme::getInstance()->fg_light->foreground},
+        {{2 * 8, 1 * 16}, "Percent:", Theme::getInstance()->fg_light->foreground},
+        {{2 * 8, 2 * 16}, "Voltage:", Theme::getInstance()->fg_light->foreground},
+        {{2 * 8, 3 * 16}, "Method:", Theme::getInstance()->fg_light->foreground},
     };
 
     Labels labels_opt{
-        {{UI_POS_X(2), UI_POS_Y(5)}, "Current:", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(2), UI_POS_Y(6)}, "Charge:", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(2), UI_POS_Y(7)}, "TTF/E:", Theme::getInstance()->fg_light->foreground},
-        // {{UI_POS_X(2), UI_POS_Y(8)}, "Cycles:", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(2), UI_POS_Y(10)}, "Change settings:", Theme::getInstance()->fg_light->foreground},
+        {{2 * 8, 4 * 16}, "Current:", Theme::getInstance()->fg_light->foreground},
+        {{2 * 8, 5 * 16}, "Charge:", Theme::getInstance()->fg_light->foreground},
+        {{2 * 8, 6 * 16}, "TTF/E:", Theme::getInstance()->fg_light->foreground},
+        // {{2 * 8, 7 * 16}, "Cycles:", Theme::getInstance()->fg_light->foreground},
+        {{2 * 8, 10 * 16}, "Change method:", Theme::getInstance()->fg_light->foreground},
     };
 
     Text text_percent{
-        {UI_POS_X(13), UI_POS_Y(1), UI_POS_WIDTH(11), UI_POS_HEIGHT(1)},
+        {13 * 8, 1 * 16, 10 * 16, 16},
         "-"};
     Text text_voltage{
-        {UI_POS_X(13), UI_POS_Y(2), UI_POS_WIDTH(11), UI_POS_HEIGHT(1)},
+        {13 * 8, 2 * 16, 10 * 16, 16},
         "-"};
     Text text_method{
-        {UI_POS_X(13), UI_POS_Y(3), UI_POS_WIDTH(11), UI_POS_HEIGHT(1)},
-        "-"};
-    Text text_capacity{
-        {UI_POS_X(13), UI_POS_Y(4), UI_POS_WIDTH(11), UI_POS_HEIGHT(1)},
+        {13 * 8, 3 * 16, 10 * 16, 16},
         "-"};
     Text text_current{
-        {UI_POS_X(13), UI_POS_Y(5), UI_POS_WIDTH(11), UI_POS_HEIGHT(1)},
+        {13 * 8, 4 * 16, 10 * 16, 16},
         "-"};
     Text text_charge{
-        {UI_POS_X(13), UI_POS_Y(6), UI_POS_WIDTH(11), UI_POS_HEIGHT(1)},
+        {13 * 8, 5 * 16, 10 * 16, 16},
         "-"};
     Text text_ttef{
-        {UI_POS_X(13), UI_POS_Y(7), UI_POS_WIDTH(11), UI_POS_HEIGHT(1)},
+        {13 * 8, 6 * 16, 10 * 16, 16},
         "-"};
-
     /* Text text_cycles{
-        {UI_POS_X(13), UI_POS_Y(8), UI_POS_WIDTH(11), UI_POS_HEIGHT(1)},
+        {13 * 8, 7 * 16, 10 * 16, 16},
         "-"};
 
     Text text_warn{
-        {UI_POS_X(1), UI_POS_Y(9), screen_width, UI_POS_HEIGHT(2)},
+        {1 * 8, 8 * 16, screen_width, 2 * 16},
         ""}; */
 
-    Button button_settings{
-        {UI_POS_X(2), UI_POS_Y(11) + 5, UI_POS_WIDTH(10), UI_POS_HEIGHT(2)},
-        "Settings"};
+    Button button_mode{
+        {2 * 8, 11 * 16 + 5, 5 * 16, 32},
+        "Volt"};
 
     Button button_exit{
         {UI_POS_X_CENTER(12), UI_POS_Y_BOTTOM(4), UI_POS_WIDTH(12), UI_POS_HEIGHT(2)},
@@ -111,4 +106,4 @@ class BattinfoView : public View {
 
 } /* namespace ui */
 
-#endif /*__UI_BATTINFO__*/
+#endif /*__UI_BATTINFO__*/

firmware/application/apps/ui_settings.cpp

@@ -1160,8 +1160,6 @@ SetBatteryView::SetBatteryView(NavigationView& nav) {
     add_children({&labels,
                   &button_save,
                   &button_cancel,
-                  &field_battcap,
-                  &button_help_cap,
                   &checkbox_overridebatt,
                   &checkbox_battery_charge_hint});
 
@@ -1171,44 +1169,21 @@ SetBatteryView::SetBatteryView(NavigationView& nav) {
         pmem::set_ui_override_batt_calc(checkbox_overridebatt.value());
         pmem::set_ui_battery_charge_hint(checkbox_battery_charge_hint.value());
         battery::BatteryManagement::set_calc_override(checkbox_overridebatt.value());
-        if (((uint32_t)field_battcap.value() != pmem::battery_cap_mah()) || (!pmem::battery_cap_valid())) {
-            pmem::set_battery_cap_mah(field_battcap.value());
-            i2cdev::I2cDev_MAX17055* dev = (i2cdev::I2cDev_MAX17055*)i2cdev::I2CDevManager::get_dev_by_model(I2C_DEVMDL::I2CDEVMDL_MAX17055);
-            if (dev && !dev->reInit()) {
-                nav.display_modal("Error", "Battery gauge re-init failed");
-                return;
-            }
-        }
         send_system_refresh();
         nav.pop();
     };
 
     button_reset.on_select = [&nav, this](Button&) {
         auto dev = (i2cdev::I2cDev_MAX17055*)i2cdev::I2CDevManager::get_dev_by_model(I2C_DEVMDL::I2CDEVMDL_MAX17055);
-        if (dev && dev->reset_learned())
+        if (dev->reset_learned())
             nav.display_modal("Reset", "Battery parameters reset");
         else
             nav.display_modal("Error", "Error parameter reset");
     };
 
-    button_help_cap.on_select = [&nav, this](Button&) {
-        nav.display_modal("Battery Capacity",
-                          "Only change default, if you\n"
-                          "   changed the battery!\n"
-                          "Defaults:\n"
-                          "H4 + Hackrf One: 2500\n"
-                          "H4 + Hackrf Pro: 2000\n"
-                          "H4Pro + Hackrf Pro: custom\n"
-                          "PortaRf: 3000\n"
-
-        );
-    };
-
     checkbox_overridebatt.set_value(pmem::ui_override_batt_calc());
     checkbox_battery_charge_hint.set_value(pmem::ui_battery_charge_hint());
 
-    field_battcap.set_value(pmem::battery_cap_mah());
-
     button_cancel.on_select = [&nav, this](Button&) {
         nav.pop();
     };

firmware/application/apps/ui_settings.hpp

@@ -1045,36 +1045,21 @@ class SetBatteryView : public View {
    private:
     int32_t selected = 0;
     Labels labels{
-        {{UI_POS_X_CENTER(26), UI_POS_Y(0)}, "Override batt calculation", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X_CENTER(24), UI_POS_Y(1)}, "method to voltage based", Theme::getInstance()->fg_light->foreground},
+        {{1 * 8, 1 * 16}, "Override batt calculation", Theme::getInstance()->fg_light->foreground},
+        {{1 * 8, 2 * 16}, "method to voltage based", Theme::getInstance()->fg_light->foreground},
         /**/
-        {{UI_POS_X_CENTER(29), UI_POS_Y(4)}, "Display a hint to remind you", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X_CENTER(16), UI_POS_Y(5)}, "when you charge", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X_CENTER(17), UI_POS_Y(8)}, "Battery capacity", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(7), UI_POS_Y(9)}, "mAh", Theme::getInstance()->fg_light->foreground}};
+        {{1 * 8, 6 * 16}, "Display a hint to remind you", Theme::getInstance()->fg_light->foreground},
+        {{1 * 8, 7 * 16}, "when you charge", Theme::getInstance()->fg_light->foreground}};
 
-    Labels labels2{{{UI_POS_X(1), UI_POS_Y(11)}, "Reset IC's learned params.", Theme::getInstance()->fg_light->foreground}};
-
-    NumberField field_battcap{
-        {UI_POS_X(1), UI_POS_Y(9)},
-        5,
-        {BATT_18650_MIN_MAH, BATT_18650_MAX_MAH},
-        100,
-        ' ',
-    };
-
-    Button button_help_cap{
-        {UI_POS_X(12), UI_POS_Y(9), UI_POS_WIDTH(5), UI_POS_HEIGHT(1)},
-        "Help",
-    };
+    Labels labels2{{{1 * 8, 11 * 16}, "Reset IC's learned params.", Theme::getInstance()->fg_light->foreground}};
 
     Checkbox checkbox_overridebatt{
-        {UI_POS_X(2), UI_POS_Y(2)},
+        {2 * 8, 4 * 16},
         23,
         "Override"};
 
     Checkbox checkbox_battery_charge_hint{
-        {UI_POS_X(2), UI_POS_Y(6)},
+        {2 * 8, 9 * 16},
         23,
         "Charge hint"};
 

firmware/application/audio.cpp

@@ -225,15 +225,8 @@ volume_range_t volume_range() {
     return audio_codec->headphone_gain_range();
 }
 
-bool set_volume(const volume_t volume) {
-    // add retry method
-    for (int i = 0; i < 100; ++i) {
-        if (audio_codec->set_headphone_volume(volume)) {
-            return true;
-        }
-        chThdSleepMilliseconds(2);
-    }
-    return false;
+void set_volume(const volume_t volume) {
+    audio_codec->set_headphone_volume(volume);
 }
 
 } /* namespace headphone */

firmware/application/audio.hpp

@@ -49,7 +49,7 @@ class Codec {
     virtual void headphone_enable() = 0;
     virtual void headphone_disable() = 0;
     virtual volume_range_t headphone_gain_range() const = 0;
-    virtual bool set_headphone_volume(const volume_t volume) = 0;
+    virtual void set_headphone_volume(const volume_t volume) = 0;
 
     virtual void microphone_enable(int8_t alc_mode, bool mic_to_HP_enabled) = 0;  // added user-GUI  AK4951 ,selected ALC mode.
     virtual void microphone_disable() = 0;
@@ -93,7 +93,7 @@ namespace headphone {
 
 volume_range_t volume_range();
 
-bool set_volume(const volume_t volume);
+void set_volume(const volume_t volume);
 
 } /* namespace headphone */
 

firmware/application/baseband_api.cpp

@@ -393,11 +393,6 @@ void set_moreserx_config(uint8_t mode) {
     send_message(&message);
 }
 
-void set_tonedetect_config(uint8_t squelch, uint32_t ctcss_freq_x10) {
-    const ToneDetectConfigureMessage message{squelch, ctcss_freq_x10};
-    send_message(&message);
-}
-
 void set_morsetx_config(uint8_t mode, uint32_t tone, float fm_delta) {
     const MorseTXConfigureMessage message{mode, tone, fm_delta};
     send_message(&message);

firmware/application/baseband_api.hpp

@@ -108,7 +108,6 @@ void set_siggen_config(const uint32_t bw, const uint32_t shape, const uint32_t d
 void set_spectrum_painter_config(const uint16_t width, const uint16_t height, bool update, int32_t bw);
 void set_subghzd_config(uint8_t modulation, uint32_t sampling_rate);
 void set_moreserx_config(uint8_t mode);
-void set_tonedetect_config(uint8_t squelch, uint32_t ctcss_freq_x10 = 0);
 void set_morsetx_config(uint8_t mode, uint32_t tone, float fm_delta);
 void set_morsetx_key(bool key_down);
 void set_wefax_config(uint8_t lpm, uint8_t ioc);

firmware/application/event_m0.cpp

@@ -37,20 +37,8 @@
 
 #include "ch.h"
 
-#include "hackrf_gpio.hpp"
-using namespace hackrf::one;
-
-#include "irq_rtc.hpp"
-
-#include "i2c_lld.h"
-
-#include "i2cdevmanager.hpp"
-#include "i2cdev_ppmod.hpp"
-
-#include "lpc43xx.inc"
-#include "nvic.h"
-#include "lpc43xx_m0.h"
-#include "rffc507x_spi.hpp"
+#include "lpc43xx_cpp.hpp"
+using namespace lpc43xx;
 
 #include <array>
 
@@ -146,194 +134,7 @@ void EventDispatcher::set_display_sleep(const bool sleep) {
         // Let frame sync handler turn on backlight after repaint.
     }
     EventDispatcher::display_sleep = sleep;
-}
-
-void EventDispatcher::charge_deep_sleep(const bool sleep) {
-    bool detect = false;
-    uint8_t valid_mask = 0;
-    uint8_t percent = 0;
-    uint16_t voltage = 0;
-    int32_t current = 0;
-
-    constexpr I2CConfig i2c_config_12mhz{
-        .high_count = 15,
-        .low_count = 15,
-    };
-
-    if (sleep) {
-        auto dev = (i2cdev::I2cDev_PPmod*)i2cdev::I2CDevManager::get_dev_by_model(I2C_DEVMDL::I2CDECMDL_PPMOD);
-        if (dev) dev->send_poweroff_command();
-
-        rffc507x::spi::SPI().power_down();
-        portapack::shutdown(false, true);
-
-        // Unmount SD card and stop driver
-        f_mount(nullptr, reinterpret_cast<const TCHAR*>(_T("")), 0);
-        sdcDisconnect(&SDCD1);
-        sdcStop(&SDCD1);
-
-        // Signal application shutdown
-        ShutdownMessage shutdown_message;
-        shared_memory.application_queue.push(shutdown_message);
-        shared_memory.baseband_message = nullptr;
-
-        // Disable core interrupts and system tick
-        nvicDisableVector(DMA_IRQn);
-        nvicDisableVector(M4CORE_IRQn);
-        chSysDisable();
-        systick_stop();
-
-        SCB->ICSR |= SCB_ICSR_PENDSTCLR_Msk;
-
-#ifdef PRALINE
-        // Power management and GPIO configuration for Praline hardware
-        gpio_vaa_disable.set();
-        gpio_1v2_enable.clear();
-        LPC_GPIO->DIR[0] &= ~0xFFFF4000;
-        LPC_GPIO->DIR[1] &= ~0xFFFF1000;
-        LPC_GPIO->DIR[2] &= ~((1 << 14) | (1 << 13) | (1 << 12) | (1 << 11) | (1 << 10) | (1 << 6) | (1 << 0));
-        LPC_GPIO->DIR[3] &= ~((1 << 7) | (1 << 5));
-        LPC_GPIO->DIR[5] &= ~(1 << 16);
-#else
-        // Power management and GPIO configuration for legacy hardware
-        gpio_og_vaa_disable.set();
-        gpio_r9_vaa_disable.clear();
-        LPC_GPIO->DIR[0] &= ~0xFFFF4000;
-        LPC_GPIO->DIR[1] &= ~0xFFFF1000;
-        LPC_GPIO->DIR[2] &= ~((1 << 14) | (1 << 13) | (1 << 12) | (1 << 11) | (1 << 10) | (1 << 6) | (1 << 0));
-        LPC_GPIO->DIR[3] &= ~((1 << 7) | (1 << 5));
-        LPC_GPIO->DIR[5] &= ~(1 << 16);
-#endif
-
-        // Power down peripherals (CGU cleanup)
-        LPC_RGU->RESET_CTRL[0] = (1 << 5);  // USB0 Reset
-        LPC_CGU->PLL0USB_CTRL.PD = 1;
-        LPC_CGU->BASE_USB0_CLK.PD = 1;
-        LPC_CREG->CREG0 |= (1 << 5);
-
-        LPC_CGU->BASE_USB1_CLK.PD = 1;
-        LPC_CGU->BASE_UART0_CLK.PD = 1;
-        LPC_CGU->BASE_UART1_CLK.PD = 1;
-        LPC_CGU->BASE_UART2_CLK.PD = 1;
-        LPC_CGU->BASE_UART3_CLK.PD = 1;
-        LPC_CGU->BASE_SPI_CLK.PD = 1;
-        LPC_CGU->BASE_PERIPH_CLK.PD = 1;
-        LPC_CGU->BASE_SDIO_CLK.PD = 1;
-        LPC_CGU->BASE_SSP0_CLK.PD = 1;
-        LPC_CGU->BASE_SSP1_CLK.PD = 1;
-        LPC_CGU->BASE_LCD_CLK.PD = 1;
-        LPC_CGU->BASE_OUT_CLK.PD = 1;
-
-        (*(volatile uint32_t*)(&LPC_CGU->PLL0AUDIO_CTRL)) |= (1 << 0);
-
-        LPC_ADC0->CR &= ~(1 << 21);
-        LPC_ADC1->CR &= ~(1 << 21);
-        led_rx.off();
-        led_usb.off();
-
-        rtc_wakeup_init();
-        NVIC_EnableIRQ(I2C0_OR_I2C1_IRQn);
-
-        while (1) {
-            // --- Battery Status Check (I2C) ---
-            detect = battery::BatteryManagement::isDetected();
-            if (detect) {
-                battery::BatteryManagement::getBatteryInfo(valid_mask, percent, voltage, current);
-
-                bool is_full = (valid_mask == 31 && percent == 100 && current <= 10) ||
-                               (valid_mask == 1 && percent == 100);
-
-                if (is_full) {
-                    // Case 1: Battery full (All LEDs off)
-                    led_rx.off();
-                    led_tx.off();
-                } else if ((voltage < 4150 && current < 10) || valid_mask == 0) {
-                    // Case 2: Not full but low current draw (<10mA) -> Charging error
-                    led_tx.on();  // LED indicates error/idle
-                    led_rx.off();
-                } else {
-                    // Case 3: Actively charging
-                    led_rx.on();  // LED indicates charging
-                    led_tx.off();
-                }
-            } else {
-                // Case 4: Battery IC not detected -> Error or H2 or older, so don't show that as an error.
-                led_tx.on();
-                led_rx.on();
-            }
-
-            // Shut down I2C and power down the APB bus for sleep
-            portapack::i2c0.stop();
-            LPC_CGU->BASE_APB1_CLK.PD = 1;
-
-            // Save interrupt states before mass disable
-            uint32_t saved_iser0 = NVIC->ISER[0];
-            uint32_t saved_iser1 = NVIC->ISER[1];
-            uint32_t saved_iser2 = NVIC->ISER[2];
-
-            // Disable and clear all pending interrupts
-            NVIC->ICER[0] = 0xFFFFFFFF;
-            NVIC->ICER[1] = 0xFFFFFFFF;
-            NVIC->ICER[2] = 0xFFFFFFFF;
-
-            NVIC->ICPR[0] = 0xFFFFFFFF;
-            NVIC->ICPR[1] = 0xFFFFFFFF;
-            NVIC->ICPR[2] = 0xFFFFFFFF;
-
-            // Re-enable only necessary wakeup sources
-            NVIC_EnableIRQ(RTC_IRQn);
-            NVIC_EnableIRQ(EVENTROUTER_IRQn);
-
-            // Configure RTC wakeup interval
-            if (valid_mask != 0 || detect) {
-                rtc_wakeup(60);
-            } else {
-                rtc_wakeup(3);
-            }
-
-            LPC_RTC->ILR = 3;
-            LPC_EVENTROUTER->CLR_STAT = 0xFFFFFFFF;
-            NVIC_ClearPendingIRQ(RTC_IRQn);
-            NVIC_ClearPendingIRQ(EVENTROUTER_IRQn);
-
-            __disable_irq();
-
-            // Configure and enter Deep Sleep
-            SCB->SCR |= SCB_SCR_SLEEPDEEP_Msk;
-
-            __DSB();
-            __ISB();
-
-            // CPU enters sleep here
-            __WFI();
-
-            // --- WAKEUP SEQUENCE ---
-            __enable_irq();
-            SCB->SCR &= ~SCB_SCR_SLEEPDEEP_Msk;
-
-            // Cleanup RTC and restore peripheral clocks
-            LPC_RTC->AMR = 0xFF;
-            LPC_RTC->ILR = 3;
-            LPC_CGU->BASE_APB1_CLK.PD = 0;
-            LPC_RGU->RESET_CTRL[1] = (1 << 16);
-
-            // Short delay for power stability (3V3 rail)
-            for (volatile int d = 0; d < 10000; d++);
-
-            // Restart I2C controller
-            LPC_CGU->BASE_APB1_CLK.PD = 0;
-            portapack::i2c0.start(i2c_config_12mhz);
-
-            // Restore original interrupt enable states
-            NVIC->ISER[0] = saved_iser0;
-            NVIC->ISER[1] = saved_iser1;
-            NVIC->ISER[2] = saved_iser2;
-
-        }  // End of while(1) deep sleep loop
-    } else {
-        portapack::display.wake(true);
-    }
-}
+};
 
 eventmask_t EventDispatcher::wait() {
     return chEvtWaitAny(ALL_EVENTS);

firmware/application/event_m0.hpp

@@ -63,8 +63,6 @@ class EventDispatcher {
 
     static void set_display_sleep(const bool sleep);
 
-    static void charge_deep_sleep(const bool sleep);
-
     static inline void check_fifo_isr() {
         if (!shared_memory.application_queue.is_empty()) {
             events_flag_isr(EVT_MASK_APPLICATION);

firmware/application/external/analogtv/ui_tv.cpp

@@ -131,39 +131,35 @@ void TVView::on_channel_spectrum(
     // I was hoping that by doing this, I can have a longer buffer like 39936, then the frame will looks better vertically
     // however this is useless until now.
 
-    // Left the original comment, but rewrote the function.
-
-    // Shift the last 128 pixels of the previous packet to the front
-    // This overlap handles an x_correction shift of up to 128 pixels seamlessly.
-    for (size_t i = 0; i < 128; i++) {
-        window_buffer[i] = window_buffer[i + 256];
-    }
-
-    // Load the new 256 pixels into the remainder of the buffer
     for (size_t i = 0; i < 256; i++) {
-        window_buffer[i + 128] = 255 - spectrum.db[i];
+        // video_buffer[i+count*256] = spectrum_rgb4_lut[spectrum.db[i]];
+        video_buffer_int[i + count * 256] = 255 - spectrum.db[i];
     }
+    count = count + 1;
+    if (count == 52 - 1) {
+        ui::Color line_buffer[128];
+        Coord line;
+        uint32_t bmp_px;
 
-    ui::Color line_buffer[128];
+        /*for (line = 0; line < 104; line++)
+                {
+                        for (bmp_px = 0; bmp_px < 128; bmp_px++)
+                        {
+                                //line_buffer[bmp_px] = video_buffer[bmp_px+line*128];
+                                line_buffer[bmp_px] = spectrum_rgb4_lut[video_buffer_int[bmp_px+line*128 + x_correction]];
+                        }
 
-    // Render the first line of this batch (matches original doubled-height behavior)
-    for (size_t bmp_px = 0; bmp_px < 128; bmp_px++) {
-        line_buffer[bmp_px] = spectrum_rgb4_lut[window_buffer[bmp_px + x_correction]];
-    }
-    display.render_line({0, (Coord)(count * 4 + 100)}, 128, line_buffer);
-    display.render_line({0, (Coord)(count * 4 + 101)}, 128, line_buffer);
+                        display.render_line({ 0, line + 100 }, 128, line_buffer);
+                }*/
+        for (line = 0; line < 208; line = line + 2) {
+            for (bmp_px = 0; bmp_px < 128; bmp_px++) {
+                // line_buffer[bmp_px] = video_buffer[bmp_px+line*128];
+                line_buffer[bmp_px] = spectrum_rgb4_lut[video_buffer_int[bmp_px + line / 2 * 128 + x_correction]];
+            }
 
-    // Render the second line of this batch
-    for (size_t bmp_px = 0; bmp_px < 128; bmp_px++) {
-        line_buffer[bmp_px] = spectrum_rgb4_lut[window_buffer[bmp_px + 128 + x_correction]];
-    }
-    display.render_line({0, (Coord)(count * 4 + 102)}, 128, line_buffer);
-    display.render_line({0, (Coord)(count * 4 + 103)}, 128, line_buffer);
-
-    count++;
-
-    // Reset at 52 (52 * 2 lines = 104 lines total)
-    if (count >= 52) {
+            display.render_line({0, line + 100}, 128, line_buffer);
+            display.render_line({0, line + 101}, 128, line_buffer);
+        }
         count = 0;
     }
 }

firmware/application/external/analogtv/ui_tv.hpp

@@ -79,9 +79,8 @@ class TVView : public Widget {
     void paint(Painter& painter) override;
     void on_channel_spectrum(const ChannelSpectrum& spectrum);
     void on_adjust_xcorr(uint8_t xcorr);
-    // 256 samples from current callback + 128 overlap from the previous callback
-    uint8_t window_buffer[384]{0};
-
+    // ui::Color video_buffer[13312];
+    uint8_t video_buffer_int[13312 + 128]{0};  // 128 is for the over length caused by x_correction
     uint32_t count = 0;
     uint8_t x_correction = 0;
 

firmware/application/external/detector_rx/ui_detector_rx.cpp

@@ -26,7 +26,6 @@
 #include "ui_freqman.hpp"
 #include "baseband_api.hpp"
 #include "file.hpp"
-#include "file_path.hpp"
 #include "oversample.hpp"
 #include "ui_font_fixed_8x16.hpp"
 
@@ -36,112 +35,36 @@ using portapack::memory::map::backup_ram;
 
 namespace ui::external_app::detector_rx {
 
+// Function to map the value from one range to another
 int32_t DetectorRxView::map(int32_t value, int32_t fromLow, int32_t fromHigh, int32_t toLow, int32_t toHigh) {
     return toLow + (value - fromLow) * (toHigh - toLow) / (fromHigh - fromLow);
 }
 
 void DetectorRxView::focus() {
-    button_index.focus();
+    field_lna.focus();
 }
 
 DetectorRxView::~DetectorRxView() {
+    // reset performance counters request to default
     shared_memory.request_m4_performance_counter = 0;
     receiver_model.disable();
     audio::output::stop();
     baseband::shutdown();
 }
 
-std::string DetectorRxView::format_freq_mhz(int64_t freq_hz) {
-    int64_t mhz = freq_hz / 1000000;
-    int64_t khz_frac = (freq_hz % 1000000) / 1000;
-    return "< " + to_string_dec_uint(mhz) + "." + to_string_dec_uint(khz_frac, 3, '0') + " MHz >";
-}
-
-void DetectorRxView::load_freqman() {
-    freqman_load_options options{};
-    options.load_freqs = true;
-    options.load_ranges = true;
-    options.load_hamradios = false;
-    options.load_repeaters = false;
-
-    if (!load_freqman_file(freq_file_stem, frequency_list, options) || frequency_list.empty()) {
-        button_file.set_text("No file!");
-        button_index.set_text("");
-        text_entry_desc.set("");
-        button_freq.set_text("");
-        frequency_list.clear();
-        return;
-    }
-
-    current_index = 0;
-    init_current_entry();
-    button_file.set_text(freq_file_stem);
-}
-
-void DetectorRxView::init_current_entry() {
-    if (frequency_list.empty()) return;
-
-    auto& entry = *frequency_list[current_index];
-    if (entry.type == freqman_type::Range) {
-        minfreq = entry.frequency_a;
-        maxfreq = entry.frequency_b;
-        current_freq = minfreq;
-        current_step = is_valid(entry.step) ? freqman_entry_get_step_value(entry.step) : DETECTOR_BW;
-    } else {
-        current_freq = entry.frequency_a;
-        minfreq = current_freq;
-        maxfreq = current_freq;
-        current_step = DETECTOR_BW;
-    }
-
-    update_entry_display();
-    update_freq_display();
-    receiver_model.set_target_frequency(current_freq);
-}
-
-void DetectorRxView::update_entry_display() {
-    if (frequency_list.empty()) return;
-
-    auto& entry = *frequency_list[current_index];
-    button_index.set_text(
-        to_string_dec_uint(current_index + 1) + "/" +
-        to_string_dec_uint(frequency_list.size()));
-    text_entry_desc.set(entry.description);
-}
-
-void DetectorRxView::update_freq_display() {
-    if (auto_scan && (minfreq != maxfreq)) {
-        if (last_update_was_auto_range_type != 1) {
-            button_freq.set_text("RANGE SCAN...");
-            last_update_was_auto_range_type = 1;
-        }
-    } else {
-        button_freq.set_text(format_freq_mhz(current_freq));
-        last_update_was_auto_range_type = 0;
-    }
-}
-
 void DetectorRxView::on_timer() {
-    if (frequency_list.empty() || !auto_scan) return;
+    freq_index++;
+    if (freq_mode == 0 && freq_index >= tetra_uplink_monitoring_frequencies_hz.size()) freq_index = 0;  // TETRA UP
+    if (freq_mode == 1 && freq_index >= lora_monitoring_frequencies_hz.size()) freq_index = 0;          // Lora
+    if (freq_mode == 2 && freq_index >= remotes_monitoring_frequencies_hz.size()) freq_index = 0;       // Remotes
 
-    auto& entry = *frequency_list[current_index];
-    if (entry.type == freqman_type::Range) {
-        current_freq += current_step;
-        if (current_freq > maxfreq) {
-            if (auto_advance) {
-                current_index = (current_index + 1) % frequency_list.size();
-                init_current_entry();
-                return;
-            }
-            current_freq = minfreq;
-        }
-        receiver_model.set_target_frequency(current_freq);
-        update_freq_display();
-    } else if (auto_advance) {
-        // Single frequency: advance to next entry
-        current_index = (current_index + 1) % frequency_list.size();
-        init_current_entry();
-    }
+    if (freq_mode == 2)
+        freq_ = remotes_monitoring_frequencies_hz[freq_index];
+    else if (freq_mode == 1)
+        freq_ = lora_monitoring_frequencies_hz[freq_index];
+    else
+        freq_ = tetra_uplink_monitoring_frequencies_hz[freq_index];
+    receiver_model.set_target_frequency(freq_);
 }
 
 DetectorRxView::DetectorRxView(NavigationView& nav)
@@ -152,22 +75,21 @@ DetectorRxView::DetectorRxView(NavigationView& nav)
         &field_vga,
         &field_rf_amp,
         &field_volume,
-        &button_file,
-        &button_index,
-        &text_entry_desc,
+        &text_frequency,
+        &freq_stats_rssi,
+        &freq_stats_db,
         &text_beep_squelch,
         &field_beep_squelch,
-        &freq_stats_db,
-        &freq_stats_rssi,
-        &button_freq,
-        &button_auto_scan,
-        &button_auto_advance,
         &rssi,
         &rssi_graph,
+        &field_mode,
     });
 
+    // activate vertical bar mode
     rssi.set_vertical_rssi(true);
 
+    freq_ = receiver_model.target_frequency();
+
     field_beep_squelch.set_value(beep_squelch);
     field_beep_squelch.on_change = [this](int32_t v) {
         beep_squelch = v;
@@ -175,85 +97,29 @@ DetectorRxView::DetectorRxView(NavigationView& nav)
 
     rssi_graph.set_nb_columns(256);
 
-    // FILE button opens file picker
-    button_file.on_select = [this](Button&) {
-        auto open_view = nav_.push<FileLoadView>(".TXT");
-        open_view->push_dir(freqman_dir);
-        open_view->on_changed = [this](std::filesystem::path new_file_path) {
-            if (new_file_path.native().find((u"/" / freqman_dir).native()) != 0) {
-                button_file.set_text("Invalid file");
-                return;
-            }
-            freq_file_stem = new_file_path.stem().string();
-            load_freqman();
-        };
-    };
-
-    // Index encoder: rotate to change entry, click does nothing
-    button_index.on_change = [this]() {
-        if (frequency_list.empty()) return;
-        int32_t delta = button_index.get_encoder_delta();
-        button_index.set_encoder_delta(0);
-        if (delta == 0) return;
-
-        // Use signed arithmetic for index wraparound to avoid unsigned promotion issues.
-        const int32_t list_size = static_cast<int32_t>(frequency_list.size());
-        int32_t idx = static_cast<int32_t>(current_index);
-        if (delta > 0) {
-            idx = (idx + 1) % list_size;
-        } else {
-            idx = (idx - 1 + list_size) % list_size;
-        }
-        current_index = static_cast<size_t>(idx);
-        init_current_entry();
-    };
-
-    // Frequency encoder: rotate to step within range
-    button_freq.on_change = [this]() {
-        if (frequency_list.empty()) return;
-        auto& entry = *frequency_list[current_index];
-        if (entry.type != freqman_type::Range) {
-            button_freq.set_encoder_delta(0);
-            return;
-        }
-
-        int32_t delta = button_freq.get_encoder_delta();
-        button_freq.set_encoder_delta(0);
-        if (delta == 0) return;
-
-        if (delta > 0) {
-            current_freq += current_step;
-            if (current_freq > maxfreq) current_freq = minfreq;
-        } else {
-            current_freq -= current_step;
-            if (current_freq < minfreq) current_freq = maxfreq;
-        }
-        receiver_model.set_target_frequency(current_freq);
-        update_freq_display();
-    };
-
-    // Auto-scan toggle
-    button_auto_scan.on_select = [this](Button&) {
-        auto_scan = !auto_scan;
-        button_auto_scan.set_text(auto_scan ? "AUTOSCAN" : "NO SCAN");
-        update_freq_display();
-    };
-    button_auto_scan.set_text(auto_scan ? "AUTOSCAN" : "NO SCAN");
-
-    // Auto-advance toggle
-    button_auto_advance.on_select = [this](Button&) {
-        auto_advance = !auto_advance;
-        button_auto_advance.set_text(auto_advance ? "AUTOADV" : "NO ADV");
-    };
-    button_auto_advance.set_text(auto_advance ? "AUTOADV" : "NO ADV");
-
     change_mode();
     rssi.set_peak(true, 3000);
 
+    // FILL STEP OPTIONS
     freq_stats_rssi.set_style(Theme::getInstance()->bg_darkest);
     freq_stats_db.set_style(Theme::getInstance()->bg_darkest);
 
-    load_freqman();
+    field_mode.on_change = [this](size_t, int32_t value) {
+        freq_mode = value;
+        freq_index = 0;
+        switch (value) {
+            case 1:  // Lora
+                text_frequency.set("   433, 868, 915 Mhz");
+                break;
+            case 2:  // Remotes
+                text_frequency.set("        433, 315 Mhz");
+                break;
+            default:
+            case 0:  // TETRA UP
+                text_frequency.set("         380-390 Mhz");
+                break;
+        }
+    };
 }
 
 void DetectorRxView::on_statistics_update(const ChannelStatistics& statistics) {
@@ -264,23 +130,25 @@ void DetectorRxView::on_statistics_update(const ChannelStatistics& statistics) {
 
     rssi_graph.add_values(rssi.get_min(), rssi.get_avg(), rssi.get_max(), statistics.max_db);
 
+    // refresh db
     if (last_max_db != statistics.max_db) {
         last_max_db = statistics.max_db;
         freq_stats_db.set("Power: " + to_string_dec_int(statistics.max_db) + " db");
         rssi.set_db(statistics.max_db);
     }
-
+    // refresh rssi
     if (last_min_rssi != rssi_graph.get_graph_min() || last_avg_rssi != rssi_graph.get_graph_avg() || last_max_rssi != rssi_graph.get_graph_max()) {
         last_min_rssi = rssi_graph.get_graph_min();
         last_avg_rssi = rssi_graph.get_graph_avg();
         last_max_rssi = rssi_graph.get_graph_max();
-        freq_stats_rssi.set("RSSI:" + to_string_dec_uint(last_min_rssi) + "/" + to_string_dec_uint(last_avg_rssi) + "/" + to_string_dec_uint(last_max_rssi));
+        freq_stats_rssi.set("RSSI: " + to_string_dec_uint(last_min_rssi) + "/" + to_string_dec_uint(last_avg_rssi) + "/" + to_string_dec_uint(last_max_rssi));
     }
 
     if (statistics.max_db > beep_squelch) {
         baseband::request_audio_beep(map(statistics.max_db, -100, 20, 400, 2600), 24000, 150);
     }
-}
+
+} /* on_statistic_updates */
 
 size_t DetectorRxView::change_mode() {
     audio::output::stop();
@@ -292,13 +160,14 @@ size_t DetectorRxView::change_mode() {
     receiver_model.set_modulation(ReceiverModel::Mode::Capture);
 
     baseband::set_sample_rate(DETECTOR_BW, get_oversample_rate(DETECTOR_BW));
+    // The radio needs to know the effective sampling rate.
     auto actual_sampling_rate = get_actual_sample_rate(DETECTOR_BW);
     receiver_model.set_sampling_rate(actual_sampling_rate);
     receiver_model.set_baseband_bandwidth(filter_bandwidth_for_sampling_rate(actual_sampling_rate));
 
     audio::set_rate(audio_sampling_rate);
     audio::output::start();
-    receiver_model.set_headphone_volume(receiver_model.headphone_volume());
+    receiver_model.set_headphone_volume(receiver_model.headphone_volume());  // WM8731 hack.
 
     receiver_model.enable();
 

firmware/application/external/detector_rx/ui_detector_rx.hpp

@@ -29,7 +29,6 @@
 #include "audio.hpp"
 #include "baseband_api.hpp"
 #include "file.hpp"
-#include "freqman.hpp"
 #include "freqman_db.hpp"
 #include "portapack_persistent_memory.hpp"
 #include "radio_state.hpp"
@@ -61,35 +60,20 @@ class DetectorRxView : public View {
     int32_t map(int32_t value, int32_t fromLow, int32_t fromHigh, int32_t toLow, int32_t toHigh);
     size_t change_mode();
     void on_statistics_update(const ChannelStatistics& statistics);
+    void set_display_freq(int64_t freq);
     void on_timer();
-    void load_freqman();
-    void init_current_entry();
-    void update_entry_display();
-    void update_freq_display();
-    std::string format_freq_mhz(int64_t freq_hz);
-
-    freqman_db frequency_list{};
-    size_t current_index{0};
-    int64_t current_freq{0};
-    int64_t minfreq{0};
-    int64_t maxfreq{0};
-    int32_t current_step{DETECTOR_BW};
-    std::string freq_file_stem{"DETECTOR"};
-    bool auto_scan{true};
-    bool auto_advance{false};
-    uint8_t last_update_was_auto_range_type = -1;
 
+    uint8_t freq_index = 0;
+    rf::Frequency freq_ = {433920000};
     int32_t beep_squelch = 0;
     audio::Rate audio_sampling_rate = audio::Rate::Hz_48000;
+    uint8_t freq_mode = 0;
 
     app_settings::SettingsManager settings_{
         "rx_detector",
         app_settings::Mode::RX,
         {
             {"beep_squelch"sv, &beep_squelch},
-            {"freq_file"sv, &freq_file_stem},
-            {"auto_scan"sv, &auto_scan},
-            {"auto_advance"sv, &auto_advance},
         }};
 
     Labels labels{
@@ -109,55 +93,41 @@ class DetectorRxView : public View {
     AudioVolumeField field_volume{
         {UI_POS_X_RIGHT(2), UI_POS_Y(0)}};
 
-    // Row 1: filename + auto advance
-    Button button_file{
-        {UI_POS_X(0), UI_POS_Y(1), UI_POS_WIDTH(20), UI_POS_DEFAULT_HEIGHT},
-        ""};
+    OptionsField field_mode{
+        {UI_POS_X(0), UI_POS_Y(1)},
+        9,
+        {
+            {"TETRA UP", 0},
+            {"Lora", 1},
+            {"Remotes", 2},
+        }};
 
-    Button button_auto_advance{
-        {UI_POS_X_RIGHT(9), UI_POS_Y(1), UI_POS_WIDTH(9), UI_POS_DEFAULT_HEIGHT},
-        "NO ADV"};
-
-    // Row 2: index encoder + description + auto scan
-    ButtonWithEncoder button_index{
-        {UI_POS_X(0), UI_POS_Y(2), UI_POS_WIDTH(4), UI_POS_DEFAULT_HEIGHT},
-        ""};
-
-    Text text_entry_desc{
-        {UI_POS_X(4), UI_POS_Y(2), UI_POS_WIDTH(17), UI_POS_DEFAULT_HEIGHT},
-        ""};
-
-    Button button_auto_scan{
-        {UI_POS_X_RIGHT(9), UI_POS_Y(2), UI_POS_WIDTH(9), UI_POS_DEFAULT_HEIGHT},
-        "AUTO SCAN"};
-
-    // Row 3: frequency encoder + bip level
-    ButtonWithEncoder button_freq{
-        {UI_POS_X(0), UI_POS_Y(3), UI_POS_WIDTH(20), UI_POS_DEFAULT_HEIGHT},
+    Text text_frequency{
+        {UI_POS_X_RIGHT(20), UI_POS_Y(1), UI_POS_WIDTH(20), UI_POS_DEFAULT_HEIGHT},
         ""};
 
     Text text_beep_squelch{
-        {UI_POS_X_RIGHT(9), UI_POS_Y(3), UI_POS_WIDTH(4), UI_POS_DEFAULT_HEIGHT},
+        {UI_POS_X_RIGHT(9), UI_POS_Y(2), UI_POS_WIDTH(4), UI_POS_DEFAULT_HEIGHT},
         "Bip>"};
 
     NumberField field_beep_squelch{
-        {UI_POS_X_RIGHT(5), UI_POS_Y(3)},
+        {UI_POS_X_RIGHT(5), UI_POS_Y(2)},
         4,
         {-100, 20},
         1,
         ' ',
     };
 
-    // Row 4: Power + RSSI on same line
-    Text freq_stats_db{
-        {UI_POS_X(0), UI_POS_Y(4), UI_POS_WIDTH(15), UI_POS_DEFAULT_HEIGHT},
-    };
-
+    // RSSI: XX/XX/XXX
     Text freq_stats_rssi{
-        {UI_POS_X(15), UI_POS_Y(4), UI_POS_WIDTH(15), UI_POS_DEFAULT_HEIGHT},
+        {UI_POS_X(0), UI_POS_Y(2), UI_POS_WIDTH(15), UI_POS_DEFAULT_HEIGHT},
+    };
+
+    // Power: -XXX db
+    Text freq_stats_db{
+        {UI_POS_X(0), UI_POS_Y(3), UI_POS_WIDTH(15), UI_POS_DEFAULT_HEIGHT},
     };
 
-    // Row 5+: RSSI graph + vertical bar
     RSSIGraph rssi_graph{
         {UI_POS_X(0), UI_POS_Y(5), UI_POS_WIDTH_REMAINING(5), UI_POS_HEIGHT_REMAINING(6)},
     };
@@ -177,6 +147,55 @@ class DetectorRxView : public View {
         [this](const Message* const) {
             this->on_timer();
         }};
+
+    const std::vector<uint32_t> remotes_monitoring_frequencies_hz = {
+        // Around 315 MHz (common for older remotes, key fobs in some regions)
+        // Window centered on 315 MHz, covers 314.625 - 315.375 MHz
+        315000000,
+
+        // Around 433.92 MHz (very common for remotes, sensors, key fobs globally)
+        // Window centered on 433.92 MHz, covers 433.545 - 434.295 MHz
+        433920000,
+    };
+    const std::vector<uint32_t> lora_monitoring_frequencies_hz = {
+        // EU433 Band (Europe, typically 433.05 MHz to 434.79 MHz)
+        // Scanning the approximate range 433.0 MHz to 434.8 MHz with 750kHz steps
+        433375000,  // Covers 433.000 - 433.750 MHz
+        434125000,  // Covers 433.750 - 434.500 MHz (includes 433.92 MHz)
+        434875000,  // Covers 434.500 - 435.250 MHz (covers up to 434.79 MHz)
+
+        // EU868 Band (Europe, typically 863 MHz to 870 MHz, specific channels around 868 MHz)
+        // Targeting common LoRaWAN channel groups (approx 867.0 - 868.6 MHz) with 750kHz steps
+        867375000,  // Covers 867.000 - 867.750 MHz
+        868125000,  // Covers 867.750 - 868.500 MHz
+        868875000,  // Covers 868.500 - 869.250 MHz (covers up to 868.6 MHz)
+
+        // US915 Band (North America, typically 902 MHz to 928 MHz, specific channels around 915 MHz)
+        // Providing a few sample windows around the 915 MHz area with 750kHz steps.
+        // This band is wide; a full scan would require many more frequencies.
+        914250000,  // Covers 913.875 - 914.625 MHz
+        915000000,  // Covers 914.625 - 915.375 MHz (Centered on 915 MHz)
+        915750000,  // Covers 915.375 - 916.125 MHz
+    };
+    const std::vector<uint32_t> tetra_uplink_monitoring_frequencies_hz = {
+        // Band starts at 380,000,000 Hz, ends at 390,000,000 Hz.
+        // First center: 380,000,000 + 375,000 = 380,375,000 Hz
+        // Last center:  380,375,000 + 13 * 750,000 = 390,125,000 Hz (14 frequencies total for this band)
+        380375000,  // Covers 380.000 - 380.750 MHz
+        381125000,  // Covers 380.750 - 381.500 MHz
+        381875000,  // Covers 381.500 - 382.250 MHz
+        382625000,  // Covers 382.250 - 383.000 MHz
+        383375000,  // Covers 383.000 - 383.750 MHz
+        384125000,  // Covers 383.750 - 384.500 MHz
+        384875000,  // Covers 384.500 - 385.250 MHz
+        385625000,  // Covers 385.250 - 386.000 MHz
+        386375000,  // Covers 386.000 - 386.750 MHz
+        387125000,  // Covers 386.750 - 387.500 MHz
+        387875000,  // Covers 387.500 - 388.250 MHz
+        388625000,  // Covers 388.250 - 389.000 MHz
+        389375000,  // Covers 389.000 - 389.750 MHz
+        390125000,  // Covers 389.750 - 390.500 MHz
+    };
 };
 
 }  // namespace ui::external_app::detector_rx

firmware/application/external/epirb_tx/ui_epirb_tx.cpp

@@ -98,39 +98,6 @@ void EPIRBTXAppView::on_timer() {
     }
 }
 
-void EPIRBTXAppView::update_bpsk_frequency() {
-    bool was_transmitting = false;
-    if (transmitting && (am_enabled || transmitting_bpsk)) {
-        // We need to stop transmission before changing frequency
-        transmitter_model.disable();
-        was_transmitting = true;
-    }
-    transmitter_model.set_target_frequency(bpsk_frequency);
-    // Update displayed frequency
-    tx_view.on_show();
-    if (was_transmitting) {
-        // Start over
-        start_tx();
-    }
-}
-
-void EPIRBTXAppView::update_am_transmission() {
-    if (am_enabled && transmitting && !transmitting_bpsk) {
-        // Start am transmission
-        // Restore am frequency
-        epirb_tx_message.mode_bpsk = false;
-        transmitter_model.set_target_frequency(am_frequency);
-        // Send config to baseband
-        baseband::set_epirb_tx_config(epirb_tx_message);
-        // Start transmitting
-        transmitter_model.enable();
-    } else if (transmitting && !transmitting_bpsk) {
-        // Stop am transmission
-        transmitter_model.disable();
-        tx_view.set_transmitting(false);
-    }
-}
-
 void EPIRBTXAppView::update_frame(bool updateConfig) {
     if (mode_file) {
         // In file mode, currently selected beacon has changed => load the new one
@@ -169,17 +136,17 @@ void EPIRBTXAppView::update_frame(bool updateConfig) {
 }
 
 void EPIRBTXAppView::update_config() {
-    if (!epirb_tx_message.mode_bpsk) {
+    if (epirb_tx_message.mode_bpsk) {
+        // Already in BPSK mode => backup bpsk frequency
+        bpsk_frequency = transmitter_model.target_frequency();
+    } else {
         // Previously in AM mode => restore bpsk frequency
         transmitter_model.set_target_frequency(bpsk_frequency);
-        // Update displayed frequency
-        tx_view.on_show();
     }
     // Set mode to bpsk
     epirb_tx_message.mode_bpsk = true;
-    transmitting_bpsk = true;
     // Set pre/post count
-    epirb_tx_message.pre_count = (160 * TONES_SAMPLERATE) / 1000;   // 160 ms carrier (COSPAS spec.)
+    epirb_tx_message.pre_count = (150 * TONES_SAMPLERATE) / 1000;   // 150 ms
     epirb_tx_message.post_count = (100 * TONES_SAMPLERATE) / 1000;  // 100 ms
     // Send config to baseband
     baseband::set_epirb_tx_config(epirb_tx_message);
@@ -211,12 +178,15 @@ void EPIRBTXAppView::stop_tx() {
 void EPIRBTXAppView::on_tx_progress(const uint32_t progress, const bool done) {
     (void)progress;
     if (done) {
-        transmitting_bpsk = false;
         if (am_enabled) {
             // BPSK frame sent, switch back to 121.5 AM signal
             epirb_tx_message.mode_bpsk = false;
-            // Start am transmission
-            update_am_transmission();
+            // Backup bpsk frequency for next run
+            bpsk_frequency = transmitter_model.target_frequency();
+            // Restore am frequency
+            transmitter_model.set_target_frequency(am_frequency);
+            // Send config to baseband
+            baseband::set_epirb_tx_config(epirb_tx_message);
         } else {
             // End of BPSK frame
             transmitter_model.disable();
@@ -292,8 +262,6 @@ EPIRBTXAppView::EPIRBTXAppView(
                   &checkbox_am,
                   &field_am_frequency,
                   &checkbox_send_on_change,
-                  &options_am_channel,
-                  &options_bpsk_channel,
                   &tx_view});
 
     text_beacon.set_style(Theme::getInstance()->fg_light);
@@ -311,11 +279,6 @@ EPIRBTXAppView::EPIRBTXAppView(
     options_mode.set_by_value(!mode_file);
     transmitter_model.set_target_frequency(bpsk_frequency);
     field_am_frequency.set_value(am_frequency);
-    options_am_channel.set_by_value(am_channel);
-    options_am_channel.set_style((am_channel == (uint8_t)AmChannel::REAL) ? Theme::getInstance()->fg_red : Theme::getInstance()->bg_darkest);
-    manual_am_frequency = am_frequency;
-    options_bpsk_channel.set_by_value(bpsk_channel);
-    manual_bpsk_frequency = bpsk_frequency;
     field_delay.set_value(delay);
     options_beacon_type.set_by_value(beacon_type);
     options_beacon_protocol.set_by_value(beacon_protocol);
@@ -329,23 +292,23 @@ EPIRBTXAppView::EPIRBTXAppView(
     update_mode();
     update_location();
 
-    options_mode.on_change = [this](size_t, OptionsField::value_t value) {
-        mode_file = (((BeaconMode)value) == BeaconMode::FILE);
+    options_mode.on_change = [this](size_t index, OptionsField::value_t) {
+        mode_file = (index == 0);
         update_mode();
         update_frame();
         set_dirty();
     };
 
-    options_beacon_type.on_change = [this](size_t, OptionsField::value_t value) {
-        beacon_params.type = (BeaconType)value;
-        beacon_type = value;
+    options_beacon_type.on_change = [this](size_t index, OptionsField::value_t) {
+        beacon_params.type = (BeaconType)index;
+        beacon_type = index;
         update_frame();
         set_dirty();
     };
 
-    options_beacon_protocol.on_change = [this](size_t, OptionsField::value_t value) {
-        beacon_params.protocol = (BeaconProtocol)value;
-        beacon_protocol = value;
+    options_beacon_protocol.on_change = [this](size_t index, OptionsField::value_t) {
+        beacon_params.protocol = (BeaconProtocol)index;
+        beacon_protocol = index;
         update_frame();
         set_dirty();
     };
@@ -357,71 +320,6 @@ EPIRBTXAppView::EPIRBTXAppView(
         set_dirty();
     };
 
-    options_am_channel.on_change = [this](size_t, OptionsField::value_t v) {
-        bool is_real = false;
-        switch ((AmChannel)v) {
-            case AmChannel::REAL:
-                is_real = true;
-                am_frequency = AM_REAL_FREQUENCY;
-                break;
-            case AmChannel::MANUAL:
-                am_frequency = manual_am_frequency;
-                break;
-            default:
-                v = (uint8_t)AmChannel::TEST;
-                // fallthrough
-            case AmChannel::TEST:
-                am_frequency = AM_TEST_FREQUENCY;
-                break;
-        }
-        // Actual frequency change will be done by field_am_frequency.on_change()
-        field_am_frequency.set_value(am_frequency);
-        am_channel = v;
-        options_am_channel.set_style(is_real ? Theme::getInstance()->fg_red : Theme::getInstance()->bg_darkest);
-        set_dirty();
-    };
-
-    options_bpsk_channel.on_change = [this](size_t, OptionsField::value_t v) {
-        switch ((BpskChannel)v) {
-            case BpskChannel::MANUAL:
-                bpsk_frequency = manual_bpsk_frequency;
-                break;
-            case BpskChannel::B:
-                bpsk_frequency = BPSK_FREQUENCY_B;
-                break;
-            case BpskChannel::C:
-                bpsk_frequency = BPSK_FREQUENCY_C;
-                break;
-            case BpskChannel::F:
-                bpsk_frequency = BPSK_FREQUENCY_F;
-                break;
-            case BpskChannel::G:
-                bpsk_frequency = BPSK_FREQUENCY_G;
-                break;
-            case BpskChannel::J:
-                bpsk_frequency = BPSK_FREQUENCY_J;
-                break;
-            case BpskChannel::K:
-                bpsk_frequency = BPSK_FREQUENCY_K;
-                break;
-            case BpskChannel::N:
-                bpsk_frequency = BPSK_FREQUENCY_N;
-                break;
-            case BpskChannel::O:
-                bpsk_frequency = BPSK_FREQUENCY_O;
-                break;
-            default:
-                v = (uint8_t)BpskChannel::HAM;
-                // fallthrough
-            case BpskChannel::HAM:
-                bpsk_frequency = BPSK_FREQUENCY_HAM;
-                break;
-        }
-        bpsk_channel = v;
-        update_bpsk_frequency();
-        set_dirty();
-    };
-
     checkbox_beacon_internal.on_select = [this](Checkbox&, bool v) {
         beacon_internal = v;
         beacon_params.is_internal = v;
@@ -460,7 +358,7 @@ EPIRBTXAppView::EPIRBTXAppView(
 
     field_am_frequency.on_change = [this](rf::Frequency freq) {
         am_frequency = freq;
-        if (transmitting && !transmitting_bpsk && am_enabled)
+        if (transmitting && !epirb_tx_message.mode_bpsk && am_enabled)
             // Update transmitter frequency
             transmitter_model.set_target_frequency(am_frequency);
     };
@@ -499,8 +397,6 @@ EPIRBTXAppView::EPIRBTXAppView(
     checkbox_am.on_select = [this](Checkbox&, bool v) {
         beacon_params.has_121_5 = v;
         am_enabled = v;
-        update_am_transmission();
-        // We update the additional location device data in the frame based on this
         if (!mode_file) update_frame(false);
     };
 
@@ -508,21 +404,7 @@ EPIRBTXAppView::EPIRBTXAppView(
     field_am_frequency.on_edit = [this, &nav]() {
         auto new_view = nav.push<FrequencyKeypadView>(field_am_frequency.value());
         new_view->on_changed = [this](rf::Frequency f) {
-            switch (f) {
-                case AM_REAL_FREQUENCY:
-                    am_channel = (uint8_t)AmChannel::REAL;
-                    break;
-                case AM_TEST_FREQUENCY:
-                    am_channel = (uint8_t)AmChannel::TEST;
-                    break;
-                default:
-                    manual_am_frequency = f;
-                    am_channel = (uint8_t)AmChannel::MANUAL;
-                    break;
-            }
-            // Actual frequency change will be done by options_am_channel.on_change()
-            options_am_channel.set_by_value(am_channel);
-            set_dirty();
+            field_am_frequency.set_value(f);
         };
     };
 
@@ -533,43 +415,8 @@ EPIRBTXAppView::EPIRBTXAppView(
     tx_view.on_edit_frequency = [this, &nav]() {
         auto new_view = nav.push<FrequencyKeypadView>(transmitter_model.target_frequency());
         new_view->on_changed = [this](rf::Frequency f) {
+            transmitter_model.set_target_frequency(f);
             bpsk_frequency = f;
-            switch (f) {
-                case BPSK_FREQUENCY_HAM:
-                    bpsk_channel = (uint8_t)BpskChannel::HAM;
-                    break;
-                case BPSK_FREQUENCY_B:
-                    bpsk_channel = (uint8_t)BpskChannel::B;
-                    break;
-                case BPSK_FREQUENCY_C:
-                    bpsk_channel = (uint8_t)BpskChannel::C;
-                    break;
-                case BPSK_FREQUENCY_F:
-                    bpsk_channel = (uint8_t)BpskChannel::F;
-                    break;
-                case BPSK_FREQUENCY_G:
-                    bpsk_channel = (uint8_t)BpskChannel::G;
-                    break;
-                case BPSK_FREQUENCY_J:
-                    bpsk_channel = (uint8_t)BpskChannel::J;
-                    break;
-                case BPSK_FREQUENCY_K:
-                    bpsk_channel = (uint8_t)BpskChannel::K;
-                    break;
-                case BPSK_FREQUENCY_N:
-                    bpsk_channel = (uint8_t)BpskChannel::N;
-                    break;
-                case BPSK_FREQUENCY_O:
-                    bpsk_channel = (uint8_t)BpskChannel::O;
-                    break;
-                default:
-                    bpsk_channel = (uint8_t)BpskChannel::MANUAL;
-                    manual_bpsk_frequency = bpsk_frequency;
-                    break;
-            }
-            // Actual frequency change will be done by options_bpsk_channel.on_change()
-            options_bpsk_channel.set_by_value(bpsk_channel);
-            set_dirty();
         };
     };
 

firmware/application/external/epirb_tx/ui_epirb_tx.hpp

@@ -37,26 +37,8 @@
 #define BEACON_HEXA_HALF_SIZE 18
 #define BEACON_SIZE 18
 
-#define AM_TEST_FREQUENCY 121375000
-#define AM_REAL_FREQUENCY 121500000
-
-#define BPSK_FREQUENCY_HAM 433025000
-#define BPSK_FREQUENCY_B 406025000
-#define BPSK_FREQUENCY_C 406028000
-#define BPSK_FREQUENCY_F 406037000
-#define BPSK_FREQUENCY_G 406040000
-#define BPSK_FREQUENCY_J 406049000
-#define BPSK_FREQUENCY_K 406052000
-#define BPSK_FREQUENCY_N 406061000
-#define BPSK_FREQUENCY_O 406064000
-
 namespace ui::external_app::epirb_tx {
 
-enum class BeaconMode {
-    FILE = 0,
-    MODE_MANUAL = 1
-};
-
 enum class BeaconType {
     EPIRB = 0,
     ELT = 1,
@@ -69,25 +51,6 @@ enum class BeaconProtocol {
     NATIONAL = 2
 };
 
-enum class AmChannel {
-    TEST = 0,
-    REAL = 1,
-    MANUAL = 2
-};
-
-enum class BpskChannel {
-    HAM = 0,
-    B = 1,
-    C = 2,
-    F = 3,
-    G = 4,
-    J = 5,
-    K = 6,
-    N = 7,
-    O = 8,
-    MANUAL = 10
-};
-
 struct Location {
     std::string locator;
     bool south;
@@ -132,8 +95,6 @@ class EPIRBTXAppView : public View {
     std::string frame_to_hex_string(bool start);
     void generate_frame(BeaconParams params);
     void update_frame(bool updateConfig = true);
-    void update_bpsk_frequency();
-    void update_am_transmission();
     void update_mode();
     void update_location(bool updateLocatorField = true);
 
@@ -153,33 +114,25 @@ class EPIRBTXAppView : public View {
     // Frequency of the transmitter before starting the app (used to restore frequency when leaving)
     rf::Frequency original_frequency{0};
     // Frequency of the AM emergency signal
-    rf::Frequency am_frequency{AM_TEST_FREQUENCY};
+    rf::Frequency am_frequency{121500000};
     // Frequency of the 406 MHz BPSK signal
-    rf::Frequency bpsk_frequency{BPSK_FREQUENCY_HAM};
-    // Selected am channel
-    uint8_t am_channel{(uint8_t)AmChannel::TEST};
-    // Selected bpsk channel
-    uint8_t bpsk_channel{(uint8_t)BpskChannel::HAM};
-    // Manual AM frequency value
-    rf::Frequency manual_am_frequency{AM_TEST_FREQUENCY};
-    // Manual BPSK frequency value
-    rf::Frequency manual_bpsk_frequency{BPSK_FREQUENCY_HAM};
+    rf::Frequency bpsk_frequency{406025000};
 
     // True when using a beacon from the BEACONS.TXT file
-    bool mode_file{false};
+    bool mode_file{true};
     // True when looping on sending beacons is enabled
     bool loop_enabled{true};
     // True if AM emergency signal transmission is enabled
     bool am_enabled{true};
     // True if we want to send a new frame each time the user changes the current beacon
-    bool send_on_change{true};
+    bool send_on_change{false};
     // The current locator string
     std::string locator{"JN03RO"};
     // The delay between each frame when on loop mode
     uint32_t delay{50};
-    uint8_t beacon_type{(uint8_t)BeaconType::EPIRB};
+    uint8_t beacon_type{0};
     // Currently selected beacon protocol
-    uint8_t beacon_protocol{(uint8_t)BeaconProtocol::USER};
+    uint8_t beacon_protocol{0};
     // Currently selected beacon country
     uint32_t beacon_country{227};
     // Current beacon's internal state (true for internal location system)
@@ -197,8 +150,6 @@ class EPIRBTXAppView : public View {
             {"sbeacon"sv, &selected_beacon},
             {"amfreq"sv, &am_frequency},
             {"bpskfreq"sv, &bpsk_frequency},
-            {"amchan"sv, &am_channel},
-            {"bpskchan"sv, &bpsk_channel},
             {"loop"sv, &loop_enabled},
             {"delay"sv, &delay},
             {"file"sv, &mode_file},
@@ -215,8 +166,6 @@ class EPIRBTXAppView : public View {
     uint32_t last_frame_time{0};
     // True when transmission is enabled
     bool transmitting{false};
-    // True when transmitting a BPSK frame
-    bool transmitting_bpsk{false};
     // True when currently looping on sending beacons
     bool loop{false};
 
@@ -230,9 +179,7 @@ class EPIRBTXAppView : public View {
         {{UI_POS_X(0), UI_POS_Y(0)}, "Source:", Theme::getInstance()->fg_light->foreground},
         {{UI_POS_X(0), UI_POS_Y(6)}, "Frame:", Theme::getInstance()->fg_light->foreground},
         {{UI_POS_X(0), UI_POS_Y(10)}, "Next frame in   s.", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(0), UI_POS_Y(12)}, "AM frequency:         MHz", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(0), UI_POS_Y(14)}, "AM   chan.:", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(0), UI_POS_Y(15)}, "BPSK chan.:", Theme::getInstance()->fg_light->foreground},
+        {{UI_POS_X(0), UI_POS_Y(12)}, "AM frequency          MHz", Theme::getInstance()->fg_light->foreground},
         {{UI_POS_X(17), UI_POS_Y(9)}, "s.", Theme::getInstance()->fg_light->foreground}};
 
     // For file mode
@@ -284,15 +231,15 @@ class EPIRBTXAppView : public View {
     OptionsField options_beacon_type{
         {UI_POS_X(9), UI_POS_Y(1)},
         7,
-        {{"EPIRB", (uint8_t)BeaconType::EPIRB},
-         {"ELT", (uint8_t)BeaconType::ELT},
-         {"PLB", (uint8_t)BeaconType::PLB}}};
+        {{"EPIRB", 0},
+         {"ELT", 1},
+         {"PLB", 2}}};
     OptionsField options_beacon_protocol{
         {UI_POS_X(9 + 7), UI_POS_Y(1)},
         30,
-        {{"User", (uint8_t)BeaconProtocol::USER},
-         {"Standard", (uint8_t)BeaconProtocol::STANDARD},
-         {"National", (uint8_t)BeaconProtocol::NATIONAL}}};
+        {{"User", 0},
+         {"Standard", 1},
+         {"National", 2}}};
     OptionsField options_beacon_country{
         {UI_POS_X(9), UI_POS_Y(2)},
         7,
@@ -314,8 +261,8 @@ class EPIRBTXAppView : public View {
     OptionsField options_mode{
         {UI_POS_X(7), UI_POS_Y(0)},
         30,
-        {{"File (BEACONS.TXT)", (uint8_t)BeaconMode::FILE},
-         {"Manual (Editor)", (uint8_t)BeaconMode::MODE_MANUAL}}};
+        {{"File (BEACONS.TXT)", 0},
+         {"Manual (Editor)", 1}}};
 
     // Frame content
     Text text_frame{
@@ -358,25 +305,6 @@ class EPIRBTXAppView : public View {
         "START"};
     const Style& style_tx_start = *Theme::getInstance()->fg_green;
     const Style& style_tx_stop = *Theme::getInstance()->fg_red;
-    OptionsField options_am_channel{
-        {UI_POS_X(11), UI_POS_Y(14)},
-        20,
-        {{"121.375 MHz (Test)", 0},
-         {"121.500 MHz /!\\Real", 1},
-         {"Manual", 2}}};
-    OptionsField options_bpsk_channel{
-        {UI_POS_X(11), UI_POS_Y(15)},
-        20,
-        {{"433.025 MHz (Ham)", (uint8_t)BpskChannel::HAM},
-         {"406.025 MHz (B)", (uint8_t)BpskChannel::B},
-         {"406.028 MHz (C)", (uint8_t)BpskChannel::C},
-         {"406.037 MHz (F)", (uint8_t)BpskChannel::F},
-         {"406.040 MHz (G)", (uint8_t)BpskChannel::G},
-         {"406.049 MHz (J)", (uint8_t)BpskChannel::J},
-         {"406.052 MHz (K)", (uint8_t)BpskChannel::K},
-         {"406.061 MHz (N)", (uint8_t)BpskChannel::N},
-         {"406.064 MHz (O)", (uint8_t)BpskChannel::O},
-         {"Manual", (uint8_t)BpskChannel::MANUAL}}};
 
     // Transmitter view
     TransmitterView tx_view{

firmware/application/external/ert/ert_app.cpp

@@ -100,7 +100,7 @@ namespace ui::external_app::ert_app {
 
 ERTAppView::ERTAppView(NavigationView& nav)
     : nav_{nav} {
-    baseband::run_prepared_image(portapack::memory::map::m4_code.base());
+    baseband::run_image(portapack::spi_flash::image_tag_ert);
 
     add_children({
         &field_frequency,

firmware/application/external/ert/main.cpp

@@ -77,7 +77,7 @@ __attribute__((section(".external_app.app_ert.application_information"), used))
     /*.menu_location = */ app_location_t::RX,
     /*.desired_menu_position = */ -1,
 
-    /*.m4_app_tag = portapack::spi_flash::image_tag_ert */ {'P', 'E', 'R', 'T'},
+    /*.m4_app_tag = portapack::spi_flash::image_tag_none */ {'P', 'E', 'R', 'T'},
     /*.m4_app_offset = */ 0x00000000,  // will be filled at compile time
 };
 }

firmware/application/external/external.cmake

@@ -309,10 +309,8 @@ set(EXTCPPSRC
 	external/morseradiotx/main.cpp
 	external/morseradiotx/ui_morse_radiotx.cpp
 
-	#keeloqtx
   	external/keeloqtx/main.cpp
   	external/keeloqtx/ui_keeloqtx.cpp
-
 	#rtty_rx
 	external/rtty_rx/main.cpp
 	external/rtty_rx/ui_rtty_rx.cpp
@@ -327,10 +325,6 @@ set(EXTCPPSRC
 	external/pocsag_tx/main.cpp
 	external/pocsag_tx/ui_pocsag_tx.cpp
 
-	#flex_tx
-	external/flex_tx/main.cpp
-	external/flex_tx/ui_flex_tx.cpp
-
 	#time_sink
 	external/time_sink/main.cpp
 	external/time_sink/ui_time_sink.cpp
@@ -346,14 +340,6 @@ set(EXTCPPSRC
 	#p25_tx
 	external/p25_tx/main.cpp
 	external/p25_tx/ui_p25_tx.cpp
-
-	#two_tone_pager
-	external/two_tone_pager/main.cpp
-	external/two_tone_pager/ui_two_tone_pager.cpp
-
-	#two_tone_rx
-	external/two_tone_rx/main.cpp
-	external/two_tone_rx/ui_two_tone_rx.cpp 
 )
 
 set(EXTAPPLIST
@@ -436,12 +422,9 @@ set(EXTAPPLIST
 	rtty_rx
 	rtty_tx
 	pocsag_tx
-	flex_tx
 	time_sink
 	kiss_tnc
 	p25_tx
-	two_tone_pager
-	two_tone_rx
 )
 
 # sdusb has type conflicts with PRALINE (HackRF Pro) - add only for non-PRALINE builds

firmware/application/external/external.ld

@@ -106,9 +106,6 @@ MEMORY
     ram_external_app_epirb_tx              (rwx) : org = 0xAE010000, len = 32k
     ram_external_app_fpv_detect            (rwx) : org = 0xAE020000, len = 32k
     ram_external_app_p25_tx                (rwx) : org = 0xAE030000, len = 32k
-    ram_external_app_two_tone_pager        (rwx) : org = 0xAE040000, len = 32k
-    ram_external_app_two_tone_rx           (rwx) : org = 0xAE050000, len = 32k
-    ram_external_app_flex_tx               (rwx) : org = 0xAE060000, len = 32k
 }
 
 SECTIONS
@@ -610,22 +607,4 @@ SECTIONS
         KEEP(*(.external_app.app_p25_tx.application_information));
         *(*ui*external_app*p25_tx*);
     } > ram_external_app_p25_tx
-
-    .external_app_two_tone_pager : ALIGN(4) SUBALIGN(4)
-    {
-        KEEP(*(.external_app.app_two_tone_pager.application_information));
-        *(*ui*external_app*two_tone_pager*);
-    } > ram_external_app_two_tone_pager
-
-    .external_app_two_tone_rx : ALIGN(4) SUBALIGN(4)
-    {
-        KEEP(*(.external_app.app_two_tone_rx.application_information));
-        *(*ui*external_app*two_tone_rx*);
-    } > ram_external_app_two_tone_rx
-
-    .external_app_flex_tx : ALIGN(4) SUBALIGN(4)
-    {
-        KEEP(*(.external_app.app_flex_tx.application_information));
-        *(*ui*external_app*flex_tx*);
-    } > ram_external_app_flex_tx
 }

firmware/application/external/extsensors/ui_extsensors.cpp

@@ -77,10 +77,6 @@ void ExtSensorsView::on_any() {
     has_data = true;
 }
 
-void ExtSensorsView::on_show() {
-    i2cdev::I2CDevManager::set_autoscan_interval(3);
-}
-
 void ExtSensorsView::on_gps(const GPSPosDataMessage* msg) {
     on_any();
     std::string tmp = to_string_decimal(msg->lat, 5);

firmware/application/external/extsensors/ui_extsensors.hpp

@@ -78,8 +78,6 @@ class ExtSensorsView : public View {
     void on_orientation(const OrientationDataMessage* msg);
     void on_environment(const EnvironmentDataMessage* msg);
 
-    void on_show() override;
-
     MessageHandlerRegistration message_handler_gps{
         Message::ID::GPSPosData,
         [this](Message* const p) {

firmware/application/external/flex_rx/ui_flex_rx.cpp

@@ -4,15 +4,11 @@
 #include "portapack_persistent_memory.hpp"
 #include "string_format.hpp"
 #include "memory_map.hpp"
-#include "usb_serial_asyncmsg.hpp"
 
 using namespace portapack;
 
 namespace ui::external_app::flex_rx {
 
-static const int flex_tz_table[] = {0, 60, 120, 180, 240, 300, 360, 420, 480, 540, 600, 660, 720,
-                                    210, 270, 330, 0, 345, 390, 570, -210, -660, -600, -540, -480, -420, -360, -300, -240, -180, -120, -60};
-
 FlexAppView::FlexAppView(NavigationView& nav)
     : nav_{nav} {
     // Load baseband image for FLEX decoding
@@ -23,8 +19,6 @@ FlexAppView::FlexAppView(NavigationView& nav)
                   &field_lna,
                   &field_vga,
                   &rssi,
-                  &text_status1,
-                  &text_status2,
                   &console});
 
     // Restore saved frequency
@@ -45,7 +39,6 @@ FlexAppView::FlexAppView(NavigationView& nav)
     // Initialize FLEX baseband
     baseband::set_flex_config();
 
-    text_status1.set("No signal");
     console.writeln("Ready");
 }
 
@@ -58,9 +51,54 @@ void FlexAppView::focus() {
     field_frequency.focus();
 }
 
-// Add message to console
+// Redraw all messages to console
+void FlexAppView::redraw_console() {
+    console.clear(true);
+    bool first = true;
+    for (const auto& msg : messages) {
+        if (!first) {
+            console.writeln("");  // Blank line between messages
+        }
+        first = false;
+        console.writeln(msg);
+    }
+}
+
+// Add message to log with automatic line wrapping
 void FlexAppView::log_message(const std::string& message) {
-    console.writeln(message);
+    const size_t chars_per_line = screen_width / 8;
+    // Console height accounts for status bar and controls row
+    const size_t console_lines = (screen_height - 2 * 16) / 16;
+
+    messages.push_back(message);
+
+    // Calculate total lines used (messages + blank lines between them)
+    size_t total_lines = 0;
+    for (size_t i = 0; i < messages.size(); i++) {
+        if (i > 0) total_lines++;  // Count blank line separator
+        size_t msg_lines = (messages[i].length() + chars_per_line - 1) / chars_per_line;
+        if (msg_lines == 0) msg_lines = 1;
+        total_lines += msg_lines;
+    }
+
+    // If console would overflow, remove oldest messages and redraw
+    if (total_lines > console_lines) {
+        while (total_lines > console_lines && !messages.empty()) {
+            const auto& oldest = messages.front();
+            size_t oldest_lines = (oldest.length() + chars_per_line - 1) / chars_per_line;
+            if (oldest_lines == 0) oldest_lines = 1;
+            total_lines -= oldest_lines;
+            if (messages.size() > 1) total_lines--;  // Remove separator line too
+            messages.erase(messages.begin());
+        }
+        redraw_console();
+    } else {
+        // Just append new message
+        if (messages.size() > 1) {
+            console.writeln("");  // Blank line before new message
+        }
+        console.writeln(message);
+    }
 }
 
 // Update frequency and save for persistence
@@ -69,234 +107,9 @@ void FlexAppView::update_freq(rf::Frequency f) {
     receiver_model.set_target_frequency(f);
 }
 
-// Type tag from numeric type code
-static const char* flex_type_tag(uint32_t type) {
-    switch (type) {
-        case 0:
-            return "SEC";
-        case 1:
-            return "INS";
-        case 2:
-            return "TON";
-        case 3:
-            return "NUM";
-        case 4:
-            return "SNUM";
-        case 5:
-            return "ALN";
-        case 6:
-            return "HEX";
-        case 7:
-            return "NNUM";
-        case 8:
-            return "SHORT";
-        case 9:
-            return "BIW";
-        default:
-            return "UNK";
-    }
-}
-
 // Handle decoded FLEX packet from baseband
 void FlexAppView::on_packet(const FlexPacketMessage* message) {
-    const auto& pkt = message->packet;
-    const char* type = flex_type_tag(pkt.type);
-    const char* pol = pkt.is_inverted ? "I" : "N";
-
-    // Update status row 1: C/F speed polarity time timezone
-    {
-        std::string s1 = "C" + to_string_dec_uint(pkt.cycle) +
-                         "/F" + to_string_dec_uint(pkt.frame) +
-                         " " + to_string_dec_uint(pkt.bitrate) +
-                         " " + pol;
-        if (status_time_[0]) {
-            s1 += "  ";
-            s1 += status_time_;
-        }
-        if (status_tz_[0]) {
-            s1 += " ";
-            s1 += status_tz_;
-        }
-        text_status1.set(s1);
-    }
-
-    // Update status row 2 from BIW data
-    if (pkt.type == 9) {
-        switch (pkt.biw_field) {
-            case 0:  // SSID1
-                status_lid_ = pkt.biw_v1;
-                status_cz_ = pkt.biw_v2;
-                break;
-            case 2: {  // Time
-                uint32_t si = (pkt.biw_v3 * 75) / 10;
-                auto h = to_string_dec_uint(pkt.biw_v1, 2, '0');
-                auto m = to_string_dec_uint(pkt.biw_v2, 2, '0');
-                auto sec = to_string_dec_uint(si, 2, '0');
-                // Store for row 1
-                auto ts = h + ":" + m + ":" + sec;
-                memcpy(status_time_, ts.c_str(), ts.size() + 1);
-                break;
-            }
-            case 5: {  // SysInfo (timezone)
-                if (pkt.biw_v1 == 4 || pkt.biw_v1 == 5) {
-                    uint16_t zone = pkt.biw_v2 & 0x1F;
-                    int ofs = (zone < 32) ? flex_tz_table[zone] : 0;
-                    int hrs = ofs / 60;
-                    int mins = (ofs < 0 ? -ofs : ofs) % 60;
-                    auto tzs = std::string("UTC") + (ofs >= 0 ? "+" : "") +
-                               to_string_dec_int(hrs);
-                    if (mins != 0)
-                        tzs += ":" + to_string_dec_int(mins, 2, '0');
-                    memcpy(status_tz_, tzs.c_str(), tzs.size() + 1);
-                }
-                break;
-            }
-            case 7:  // SSID2
-                status_cc_ = pkt.biw_v1;
-                break;
-        }
-        // Rebuild row 2
-        std::string s2;
-        if (status_lid_) s2 += "LID:" + to_string_dec_uint(status_lid_);
-        if (status_cz_) {
-            s2 += " CZ:";
-            s2 += to_string_dec_uint(status_cz_);
-        }
-        if (status_cc_) {
-            s2 += " CC:";
-            s2 += to_string_dec_uint(status_cc_);
-        }
-        if (pkt.fiw_roaming) s2 += " R";
-        text_status2.set(s2);
-    }
-
-    // Console: skip BIW, tone-only (V=010), SHORT reserved (t=3)
-    bool skip_gui = (pkt.type == 9 || pkt.type == 2);
-    if (pkt.type == 8 && pkt.function == 3) skip_gui = true;
-    if (!skip_gui) {
-        auto cf = to_string_dec_uint(pkt.cycle) + "/" + to_string_dec_uint(pkt.frame);
-        std::string line = cf + " " + to_string_dec_uint(pkt.bitrate) +
-                           " " + pol + " " + std::string(1, pkt.phase) + " ";
-
-        if (pkt.type == 1 && pkt.message[0] == 'i' && pkt.message[2] == 't') {
-            // INS temp group: "1234567 +GRP5@F42"
-            line += to_string_dec_uint(pkt.capcode);
-            line += " +TG";
-            line += to_string_dec_uint(pkt.biw_v1);
-            line += "@F";
-            line += to_string_dec_uint(pkt.biw_v2);
-        } else if (pkt.type == 1) {
-            // Other INS types
-            line += to_string_dec_uint(pkt.capcode);
-            line += " INS ";
-            line += pkt.message;
-        } else if (pkt.addr_type == 2) {
-            // Temp group delivery: "GRP5 ALN message"
-            uint32_t slot = (uint32_t)(pkt.capcode + 0x8000 - 0x1F7800) & 0x0F;
-            line += "TG";
-            line += to_string_dec_uint(slot);
-            line += " ";
-            line += type;
-            if (pkt.message[0]) {
-                line += " ";
-                line += pkt.message;
-            }
-        } else {
-            line += to_string_dec_uint(pkt.capcode);
-            if (pkt.is_priority) line += " P";
-            line += " ";
-            line += type;
-            if (pkt.message[0]) {
-                line += " ";
-                line += pkt.message;
-            }
-        }
-        log_message(line);
-    }
-
-    // Serial: pipe-delimited
-    if (portapack::usb_serial.serial_connected()) {
-        std::string s;
-        s = "FLEX|";
-        s += to_string_dec_uint(pkt.cycle);
-        s += '/';
-        s += to_string_dec_uint(pkt.frame);
-        s += '|';
-        s += to_string_dec_uint(pkt.bitrate);
-        s += '|';
-        s += pol;
-        s += '|';
-        s += pkt.phase;
-
-        if (pkt.type == 9) {
-            s += "|BIW|w=";
-            s += to_string_dec_uint(pkt.function);
-            s += "|t=";
-            s += to_string_dec_uint(pkt.biw_field);
-            s += '|';
-            s += to_string_dec_uint(pkt.biw_v1);
-            s += '|';
-            s += to_string_dec_uint(pkt.biw_v2);
-            s += '|';
-            s += to_string_dec_uint(pkt.biw_v3);
-        } else {
-            s += '|';
-            s += type;
-            s += "|cap=";
-            s += to_string_dec_uint(pkt.capcode);
-            if (pkt.is_priority) s += "|pri=1";
-            if (pkt.addr_type == 2) {
-                // Temporary address: show slot number
-                // capcode = aw - 0x8000, aw = capcode + 0x8000
-                // slot = (aw - 0x1F7800) & 0x0F = (capcode + 0x8000 - 0x1F7800) & 0x0F
-                uint32_t slot = (uint32_t)(pkt.capcode + 0x8000 - 0x1F7800) & 0x0F;
-                s += "|slot=";
-                s += to_string_dec_uint(slot);
-            }
-            if (pkt.has_flags) {
-                if (pkt.type == 7) {
-                    s += "|seq=";
-                    s += to_string_dec_uint(pkt.seq);
-                    s += "|new=";
-                    s += to_string_dec_uint(pkt.is_new);
-                    s += "|fmt=";
-                    s += pkt.nnum_s ? "idrom" : "std";
-                } else {
-                    s += "|frag=";
-                    s += (pkt.frag == 3) ? "first" : to_string_dec_uint(pkt.frag).c_str();
-                    s += "|mf=";
-                    s += to_string_dec_uint(pkt.more_frag);
-                    s += "|seq=";
-                    s += to_string_dec_uint(pkt.seq);
-                    if (pkt.frag == 3) {
-                        s += "|new=";
-                        s += to_string_dec_uint(pkt.is_new);
-                        s += "|md=";
-                        s += to_string_dec_uint(pkt.maildrop);
-                        s += "|sig=";
-                        s += to_string_hex(pkt.sig, 2);
-                    }
-                    if (pkt.type == 0) {
-                        static const char* enc[] = {"alpha", "sep", "bin", "rsvd"};
-                        s += "|enc=";
-                        s += enc[pkt.sec_enc & 3];
-                    }
-                    if (pkt.type == 6 && pkt.frag == 3) {
-                        uint8_t b = pkt.function & 0x0F;
-                        s += "|bb=";
-                        s += to_string_dec_uint(b == 0 ? 16 : b);
-                        if (pkt.function & 0x10) s += "|rtl=1";
-                    }
-                }
-            }
-            if (pkt.message[0]) {
-                s += "|\"";
-                s += pkt.message;
-                s += '"';
-            }
-        }
-        UsbSerialAsyncmsg::asyncmsg(s);
-    }
+    log_message(message->packet.message);
 }
 
 // Handle stats message (currently unused)
@@ -305,15 +118,12 @@ void FlexAppView::on_stats(const FlexStatsMessage*) {
 
 // Debug handler - uncomment to see baseband debug messages
 void FlexAppView::on_debug(const FlexDebugMessage* message) {
-    if (portapack::usb_serial.serial_connected()) {
-        std::string s = "DBG|";
-        s += message->text;
-        s += "|";
-        s += to_string_dec_int(message->val1);
-        s += "|";
-        s += to_string_dec_int(message->val2);
-        UsbSerialAsyncmsg::asyncmsg(s);
-    }
+    (void)message;  // Suppress unused parameter warning
+    // std::string text = "DBG: ";
+    // text += message->text;
+    // text += " " + to_string_hex(message->val1, 8);
+    // text += " " + to_string_hex(message->val2, 8);
+    // log_message(text);
 }
 
 }  // namespace ui::external_app::flex_rx

firmware/application/external/flex_rx/ui_flex_rx.hpp

@@ -26,19 +26,17 @@ class FlexAppView : public View {
     NavigationView& nav_;
 
     // Saved settings
-    rf::Frequency frequency_value{931740000};
+    rf::Frequency frequency_value{931740000};  // Default FLEX frequency
 
     RxRadioState radio_state_{};
 
-    // Status bar state (updated from BIW packets)
-    char status_time_[12]{};  // "HH:MM:SS"
-    char status_tz_[12]{};    // "UTC+N"
-    uint16_t status_lid_{0};
-    uint16_t status_cz_{0};
-    uint16_t status_cc_{0};
+    // Message storage for console redraw
+    static constexpr size_t MAX_MESSAGES = 20;
+    std::vector<std::string> messages{};
 
     // Helper methods
     void log_message(const std::string& message);
+    void redraw_console();
     void update_freq(rf::Frequency f);
 
     // UI Elements - Row 0, dynamically positioned
@@ -56,17 +54,9 @@ class FlexAppView : public View {
     RSSI rssi{
         {UI_POS_X(21), 0, UI_POS_WIDTH(9), 4}};
 
-    // Status rows (rows 1-2)
-    Text text_status1{
-        {0, 1 * 16, screen_width, 16},
-        ""};
-    Text text_status2{
-        {0, 2 * 16, screen_width, 16},
-        ""};
-
-    // Message display area (below status rows)
+    // Message display area (below controls, account for status bar)
     Console console{
-        {0, 3 * 16, screen_width, screen_height - 4 * 16}};
+        {0, 1 * 16, screen_width, screen_height - 2 * 16}};
 
     // Persistent settings manager
     app_settings::SettingsManager settings_{

firmware/application/external/flex_tx/main.cpp

@@ -1,62 +0,0 @@
-#include "ui.hpp"
-#include "ui_flex_tx.hpp"
-#include "ui_navigation.hpp"
-#include "external_app.hpp"
-
-namespace ui::external_app::flex_tx {
-void initialize_app(ui::NavigationView& nav) {
-    nav.push<FlexTXView>();
-}
-}  // namespace ui::external_app::flex_tx
-
-extern "C" {
-
-__attribute__((section(".external_app.app_flex_tx.application_information"), used)) application_information_t _application_information_flex_tx = {
-    /*.memory_location = */ (uint8_t*)0x00000000,
-    /*.externalAppEntry = */ ui::external_app::flex_tx::initialize_app,
-    /*.header_version = */ CURRENT_HEADER_VERSION,
-    /*.app_version = */ VERSION_MD5,
-
-    /*.app_name = */ "FLEX TX",
-    /*.bitmap_data = */ {
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0xFC,
-        0x3F,
-        0xFE,
-        0x7F,
-        0x02,
-        0x40,
-        0xBA,
-        0x45,
-        0x02,
-        0x40,
-        0xFE,
-        0x7F,
-        0xFE,
-        0x7F,
-        0x92,
-        0x7C,
-        0x92,
-        0x7C,
-        0xFC,
-        0x3F,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-    },
-    /*.icon_color = */ ui::Color::cyan().v,
-    /*.menu_location = */ app_location_t::TX,
-    /*.desired_menu_position = */ -1,
-
-    /*.m4_app_tag = portapack::spi_flash::image_tag_fsktx */ {'P', 'F', 'S', 'K'},
-    /*.m4_app_offset = */ 0x00000000,
-};
-}

firmware/application/external/flex_tx/ui_flex_tx.cpp

@@ -1,903 +0,0 @@
-#include "ui_flex_tx.hpp"
-
-#include "baseband_api.hpp"
-#include "string_format.hpp"
-#include "ui_textentry.hpp"
-#include "portapack_persistent_memory.hpp"
-#include "portapack_shared_memory.hpp"
-#include "rtc_time.hpp"
-
-#include <cstring>
-
-using namespace portapack;
-
-namespace ui::external_app::flex_tx {
-
-#define MAX_FLEX_MSG 240
-#define BCH_POLY 0x769
-#define DATA_MASK 0x1FFFFF
-
-// ===== Bit reversal =====
-
-static uint32_t reverse_bits32(uint32_t v) {
-    v = ((v >> 1) & 0x55555555) | ((v & 0x55555555) << 1);
-    v = ((v >> 2) & 0x33333333) | ((v & 0x33333333) << 2);
-    v = ((v >> 4) & 0x0F0F0F0F) | ((v & 0x0F0F0F0F) << 4);
-    v = ((v >> 8) & 0x00FF00FF) | ((v & 0x00FF00FF) << 8);
-    v = (v >> 16) | (v << 16);
-    return v;
-}
-
-// ===== BCH(31,21) encoder =====
-
-static uint32_t flex_encode_word(uint32_t dw) {
-    uint32_t data = dw >> 11;
-    uint32_t dividend = data << 10;
-    for (int i = 30; i >= 10; i--) {
-        if ((dividend >> i) & 1)
-            dividend ^= BCH_POLY << (i - 10);
-    }
-    uint32_t ecc = dividend & 0x3FF;
-    uint32_t code31 = (data << 10) | ecc;
-    uint32_t p = 0, tmp = code31;
-    while (tmp) {
-        p ^= (tmp & 1);
-        tmp >>= 1;
-    }
-    return (code31 << 1) | p;
-}
-
-static uint32_t flex_enc(uint32_t data21) {
-    return flex_encode_word(reverse_bits32(data21));
-}
-
-// ===== Checksum =====
-
-static uint32_t flex_checksum(uint32_t d) {
-    uint32_t s = (d & 0xF) + ((d >> 4) & 0xF) + ((d >> 8) & 0xF) +
-                 ((d >> 12) & 0xF) + ((d >> 16) & 0xF) + ((d >> 20) & 0x1);
-    return (d & ~0xFU) | ((0xF - (s & 0xF)) & 0xF);
-}
-
-// ===== Year equivalence =====
-
-static int flex_is_leap(int y) {
-    return (y % 4 == 0 && y % 100 != 0) || (y % 400 == 0);
-}
-
-static int flex_jan1_dow(int y) {
-    static const int t[] = {0, 3, 2, 5, 0, 3, 5, 1, 4, 6, 2, 4};
-    return (y + y / 4 - y / 100 + y / 400 + t[0] + 1) % 7;
-}
-
-static int flex_equiv_year(int year) {
-    if (year >= 1994 && year <= 2025)
-        return year;
-    int target_leap = flex_is_leap(year);
-    int target_dow = flex_jan1_dow(year);
-    for (int y = 2025; y >= 1994; y--) {
-        if (flex_is_leap(y) == target_leap &&
-            flex_jan1_dow(y) == target_dow)
-            return y;
-    }
-    return 1994 + ((year - 1994) & 0x1F);
-}
-
-// ===== FIW =====
-
-static uint32_t flex_fiw(uint32_t cycle, uint32_t frame, uint32_t roaming) {
-    uint32_t d = 0;
-    d |= (cycle & 0xF) << 4;
-    d |= (frame & 0x7F) << 8;
-    d |= (roaming & 1) << 15;
-    // r=0, t=0 (single transmission, no low traffic flags)
-    return flex_enc(flex_checksum(d));
-}
-
-// ===== BIW1 =====
-
-static uint32_t flex_biw1(uint32_t astart, uint32_t vstart, uint32_t collapse) {
-    uint32_t d = 0;
-    d |= ((astart - 1) & 0x03) << 8;
-    d |= (vstart & 0x3F) << 10;
-    d |= (collapse & 0x07) << 18;
-    return flex_enc(flex_checksum(d));
-}
-
-// ===== BIW Date (type 001) =====
-
-static uint32_t flex_biw_date(uint32_t year_field, uint32_t month, uint32_t day) {
-    uint32_t d = 0;
-    d |= (1U) << 4;  // type = 001
-    d |= (year_field & 0x1F) << 7;
-    d |= (day & 0x1F) << 12;
-    d |= (month & 0x0F) << 17;
-    return flex_enc(flex_checksum(d));
-}
-
-// ===== BIW Time (type 010) =====
-
-static uint32_t flex_biw_time(uint32_t hour, uint32_t minute, uint32_t second_step) {
-    uint32_t d = 0;
-    d |= (2U) << 4;  // type = 010
-    d |= (hour & 0x1F) << 7;
-    d |= (minute & 0x3F) << 12;
-    d |= (second_step & 0x07) << 18;
-    return flex_enc(flex_checksum(d));
-}
-
-// ===== BIW SysInfo (type 101) =====
-
-static uint32_t flex_biw_sysinfo(uint32_t a_type, uint32_t info) {
-    uint32_t d = 0;
-    d |= (5U) << 4;  // type = 101
-    d |= (a_type & 0x0F) << 7;
-    d |= (info & 0x03FF) << 11;
-    return flex_enc(flex_checksum(d));
-}
-
-// ===== BIW SSID1 (type 000) =====
-
-static uint32_t flex_biw_ssid1(uint32_t local_id, uint32_t coverage_zone) {
-    uint32_t d = 0;
-    // type = 000 (no bits to set)
-    d |= (coverage_zone & 0x1F) << 7;
-    d |= (local_id & 0x01FF) << 12;
-    return flex_enc(flex_checksum(d));
-}
-
-// ===== BIW SSID2 (type 111) =====
-
-static uint32_t flex_biw_ssid2(uint32_t country_code, uint32_t tmf) {
-    uint32_t d = 0;
-    d |= (7U) << 4;  // type = 111
-    d |= (tmf & 0x0F) << 7;
-    d |= (country_code & 0x03FF) << 11;
-    return flex_enc(flex_checksum(d));
-}
-
-// ===== Short address =====
-
-static uint32_t flex_short_addr(uint64_t capcode) {
-    return flex_enc((uint32_t)(capcode + 0x8000) & DATA_MASK);
-}
-
-// ===== Long address (2 words) =====
-
-static int flex_long_addr(uint64_t capcode, uint32_t out[2]) {
-    uint64_t result;
-    uint32_t w1, w2;
-    if (capcode >= 2101249ULL && capcode <= 1075843072ULL) {
-        result = capcode - 2068481ULL;
-        w1 = (result % 32768) + 1;
-        w2 = 2097151U - (result / 32768);
-    } else if (capcode >= 1075843073ULL && capcode <= 3223326720ULL) {
-        result = capcode - 2068481ULL;
-        w1 = (result % 32768) + 1;
-        w2 = (result / 32768) + 1933312U;
-    } else if (capcode >= 3223326721ULL && capcode <= 4297068542ULL) {
-        result = capcode - 2068479ULL;
-        w1 = (result % 32768) + 2064383U;
-        w2 = (result / 32768) + 1867776U;
-    } else {
-        return -1;
-    }
-    out[0] = flex_enc(w1 & DATA_MASK);
-    out[1] = flex_enc(w2 & DATA_MASK);
-    return 0;
-}
-
-// ===== Vector words =====
-
-static uint32_t flex_alpha_vector(uint32_t mw_start, uint32_t mw_count) {
-    uint32_t d = 0;
-    d |= (5U & 0x07) << 4;
-    d |= (mw_start & 0x7F) << 7;
-    d |= (mw_count & 0x7F) << 14;
-    return flex_enc(flex_checksum(d));
-}
-
-static uint32_t flex_numeric_vector(uint32_t type, uint32_t mw_start, uint32_t mw_count, uint32_t kbit) {
-    uint32_t n_field = (mw_count > 0) ? mw_count - 1 : 0;
-    uint32_t d = 0;
-    d |= (type & 0x07) << 4;
-    d |= (mw_start & 0x7F) << 7;
-    d |= (n_field & 0x07) << 14;
-    d |= (kbit & 0x0F) << 17;
-    return flex_enc(flex_checksum(d));
-}
-
-// Short vector (type 2, t=00): BCD digits in vector word
-// Short addr: 3 digits in d0-d11. Long addr: 3 + 5 in 2nd word.
-// Tone-only: call with empty string (all digits become space 0xC).
-static uint32_t flex_short_vector(int is_long, const std::string& msg, uint32_t* vy_out) {
-    static const char bcd_chars[20] = "0123456789.U -][";
-    auto to_bcd = [&](char c) -> uint8_t {
-        for (int k = 0; k < 16; k++)
-            if (bcd_chars[k] == c) return k;
-        return 0xC;  // space
-    };
-
-    int max_digits = is_long ? 8 : 3;
-    uint8_t digits[8];
-    for (int i = 0; i < 8; i++) {
-        digits[i] = (i < (int)msg.size() && i < max_digits) ? to_bcd(msg[i]) : 0xC;
-    }
-
-    uint32_t vw = 0;
-    vw |= (2U & 0x07) << 4;  // type = 010
-    // t1t0 = 00 (numeric) — bits 7-8 stay 0
-    vw |= ((uint32_t)digits[0] & 0xF) << 9;
-    vw |= ((uint32_t)digits[1] & 0xF) << 13;
-    vw |= ((uint32_t)digits[2] & 0xF) << 17;
-
-    if (is_long && vy_out) {
-        uint32_t d2 = 0;
-        for (int i = 0; i < 5 && (i + 3) < max_digits; i++)
-            d2 |= ((uint32_t)digits[i + 3] & 0xF) << (i * 4);
-        *vy_out = flex_enc(d2);
-    }
-    return flex_enc(flex_checksum(vw));
-}
-
-// ===== Block interleave =====
-
-static void flex_interleave_block(uint32_t blk, uint32_t* frame_words) {
-    uint32_t src[8];
-    uint8_t dst[32];
-    memcpy(src, frame_words + blk * 8, sizeof(src));
-    for (uint32_t i = 0; i < 32; i++) {
-        dst[i] = (uint8_t)((((src[0] >> (31 - i)) & 1) << 7) |
-                           (((src[1] >> (31 - i)) & 1) << 6) |
-                           (((src[2] >> (31 - i)) & 1) << 5) |
-                           (((src[3] >> (31 - i)) & 1) << 4) |
-                           (((src[4] >> (31 - i)) & 1) << 3) |
-                           (((src[5] >> (31 - i)) & 1) << 2) |
-                           (((src[6] >> (31 - i)) & 1) << 1) |
-                           (((src[7] >> (31 - i)) & 1) << 0));
-    }
-    memcpy(frame_words + blk * 8, dst, sizeof(dst));
-}
-
-// ===== Alpha encoding =====
-
-static int flex_encode_alpha(const std::string& msg, uint32_t* words, int max_words, uint32_t seq, uint32_t msg_r) {
-    int wc = 0;
-    uint32_t hdr = 0;
-    hdr |= (3U << 11);
-    hdr |= ((seq & 0x3F) << 13);
-    hdr |= ((msg_r & 1U) << 19);
-    words[wc++] = hdr;
-
-    size_t ci = 0;
-    uint32_t dw = 0;
-    uint8_t ch;
-    ch = (ci < msg.size()) ? msg[ci++] : 0x03;
-    dw |= ((uint32_t)(ch & 0x7F)) << 7;
-    ch = (ci < msg.size()) ? msg[ci++] : 0x03;
-    dw |= ((uint32_t)(ch & 0x7F)) << 14;
-    words[wc++] = dw;
-
-    while (ci < msg.size() && wc < max_words) {
-        dw = 0;
-        for (int s = 0; s < 3; s++) {
-            ch = (ci < msg.size()) ? msg[ci++] : 0x03;
-            dw |= ((uint32_t)(ch & 0x7F)) << (s * 7);
-        }
-        words[wc++] = dw;
-    }
-
-    // Signature
-    {
-        uint32_t sig_sum = 0;
-        for (int i = 1; i < wc; i++) {
-            uint32_t c0 = (words[i] >> 0) & 0x7F;
-            uint32_t c1 = (words[i] >> 7) & 0x7F;
-            uint32_t c2 = (words[i] >> 14) & 0x7F;
-            if (c0 != 0x03) sig_sum += c0;
-            if (c1 != 0x03) sig_sum += c1;
-            if (c2 != 0x03) sig_sum += c2;
-        }
-        words[1] = (words[1] & ~0x7FU) | ((~sig_sum) & 0x7F);
-    }
-
-    // K checksum
-    {
-        uint32_t k_sum = 0;
-        for (int i = 0; i < wc; i++) {
-            k_sum += words[i] & 0xFF;
-            k_sum += (words[i] >> 8) & 0xFF;
-            k_sum += (words[i] >> 16) & 0x1F;
-        }
-        words[0] |= ((~k_sum) & 0x3FF);
-    }
-
-    for (int i = 0; i < wc; i++)
-        words[i] = flex_enc(words[i]);
-
-    return wc;
-}
-
-// ===== Numeric BCD encoding =====
-
-static int flex_encode_numeric(const std::string& msg, uint32_t* words, int max_words, uint32_t* k_out) {
-    static const char bcd[20] = "0123456789.U -][";
-    uint32_t mw[8] = {0};
-    int bit = 2;
-    int word_idx = 0;
-    for (size_t i = 0; i < msg.size(); i++) {
-        uint8_t nib = 0;
-        for (int k = 0; k < 16; k++)
-            if (bcd[k] == msg[i]) {
-                nib = k;
-                break;
-            }
-        for (int b = 0; b < 4; b++) {
-            word_idx = bit / 21;
-            if (word_idx >= 8) break;
-            if (nib & (1 << b))
-                mw[word_idx] |= (1U << (bit % 21));
-            bit++;
-        }
-    }
-    word_idx = (bit > 0) ? (bit - 1) / 21 : 0;
-    {
-        int end_bit = (word_idx + 1) * 21;
-        while (bit + 4 <= end_bit) {
-            for (int b = 0; b < 4; b++) {
-                if (0x0C & (1 << b))
-                    mw[bit / 21] |= (1U << (bit % 21));
-                bit++;
-            }
-        }
-    }
-    uint32_t kb = 0;
-    for (int i = 0; i <= word_idx; i++) {
-        kb += mw[i] & 0xFF;
-        kb += (mw[i] >> 8) & 0xFF;
-        kb += (mw[i] >> 16) & 0x1F;
-    }
-    kb &= 0xFF;
-    kb = (kb & 0x3F) + (kb >> 6);
-    kb = ~kb;
-    mw[0] |= ((kb >> 4) & 0x03);
-    *k_out = kb & 0x0F;
-    int wc = word_idx + 1;
-    for (int i = 0; i < wc && i < max_words; i++)
-        words[i] = flex_enc(mw[i]);
-    return wc;
-}
-
-// ===== Sync patterns =====
-
-static const uint8_t bs1[] = {0xAA, 0xAA, 0xAA, 0xAA};
-static const uint8_t a1[] = {0x78, 0xF3, 0x59, 0x39};
-static const uint8_t b_code[4] = {0x55, 0x55, 0x00, 0x00};
-static const uint8_t ar[] = {0xCB, 0x20, 0x59, 0x39};
-
-static void write_word(uint8_t*& p, uint32_t w) {
-    *p++ = (w >> 24) & 0xFF;
-    *p++ = (w >> 16) & 0xFF;
-    *p++ = (w >> 8) & 0xFF;
-    *p++ = w & 0xFF;
-}
-
-// ===== Build frame =====
-
-static size_t build_frame(uint8_t* buf, uint64_t capcode, int msg_type, const std::string& msg, uint32_t cycle, uint32_t frame, uint32_t msg_r, const FlexBIWParams& bp) {
-    uint8_t* p = buf;
-
-    // S1 sync
-    memcpy(p, bs1, 4);
-    p += 4;
-    memcpy(p, a1, 4);
-    p += 4;
-    memcpy(p, b_code, 2);
-    p += 2;
-    for (int i = 0; i < 4; i++) *p++ = ~a1[i];
-
-    // FIW
-    write_word(p, flex_fiw(cycle, frame, bp.roaming));
-
-    // S2
-    {
-        uint8_t s2[5];
-        memset(s2, 0, 5);
-        uint64_t bits = 0;
-        bits |= (uint64_t)0xA << 36;
-        bits |= (uint64_t)0xED84 << 20;
-        bits |= (uint64_t)0x5 << 16;
-        bits |= (uint64_t)0x127B;
-        s2[0] = (bits >> 32) & 0xFF;
-        s2[1] = (bits >> 24) & 0xFF;
-        s2[2] = (bits >> 16) & 0xFF;
-        s2[3] = (bits >> 8) & 0xFF;
-        s2[4] = bits & 0xFF;
-        memcpy(p, s2, 5);
-        p += 5;
-    }
-
-    // Build extra BIW words (max 3 slots)
-    uint32_t extra_biw[4];
-    int extra_count = 0;
-
-    // Slot priority: SSID1 first (always when enabled), then Time, Date, TZ, SSID2
-    if (bp.send_ssid1 && extra_count < 3)
-        extra_biw[extra_count++] = flex_biw_ssid1(bp.local_id, bp.coverage_zone);
-    if (bp.send_time && extra_count < 3) {
-        uint32_t sec_step = (uint32_t)(bp.second * 2 / 15);  // 7.5s steps
-        if (sec_step > 7) sec_step = 7;
-        extra_biw[extra_count++] = flex_biw_time(bp.hour, bp.minute, sec_step);
-    }
-    if (bp.send_date && extra_count < 3) {
-        uint32_t year_field = (uint32_t)(bp.year - 1994);
-        extra_biw[extra_count++] = flex_biw_date(year_field, bp.month, bp.day);
-    }
-    if (bp.send_tz && extra_count < 3) {
-        uint32_t tz_info = (uint32_t)bp.tz_code & 0x1F;
-        if (bp.send_dst)
-            tz_info |= (0U << 5);  // L0=0 means DST active
-        else
-            tz_info |= (1U << 5);  // L0=1 means standard time
-        extra_biw[extra_count++] = flex_biw_sysinfo(0x04, tz_info);
-    }
-    if (bp.send_ssid2 && extra_count < 3)
-        extra_biw[extra_count++] = flex_biw_ssid2(bp.country_code, 0);
-
-    uint32_t fw[88];
-    uint32_t mw[84];
-    int mwc = 0;
-    uint32_t num_k = 0;
-
-    if (msg_type == 0)
-        mwc = flex_encode_alpha(msg, mw, 84, bp.msg_number, msg_r);
-    else if (msg_type == 1)
-        mwc = flex_encode_numeric(msg, mw, 84, &num_k);
-
-    // Address encoding
-    int is_long = (capcode >= 2101249ULL);
-    int addr_words = is_long ? 2 : 1;
-    int vec_words = is_long ? 2 : 1;
-    int astart = 1 + extra_count;
-    int vstart = astart + addr_words;
-    int mstart = vstart + vec_words;
-
-    fw[0] = flex_biw1(astart, vstart, 0);
-
-    // Extra BIW words (words 1..extra_count)
-    for (int i = 0; i < extra_count; i++)
-        fw[1 + i] = extra_biw[i];
-
-    // Address words
-    if (is_long) {
-        uint32_t la[2];
-        if (flex_long_addr(capcode, la) < 0) return 0;
-        fw[astart] = la[0];
-        fw[astart + 1] = la[1];
-    } else {
-        fw[astart] = flex_short_addr(capcode);
-    }
-
-    // Vector + message
-    if (msg_type == 0) {
-        fw[vstart] = flex_alpha_vector(mstart, mwc);
-        if (is_long && mwc > 0) {
-            fw[vstart + 1] = mw[0];
-            for (int i = 0; i < mwc - 1 && (mstart + i) < 88; i++)
-                fw[mstart + i] = mw[i + 1];
-            mwc = (mwc > 0) ? mwc - 1 : 0;
-        } else {
-            for (int i = 0; i < mwc && (mstart + i) < 88; i++)
-                fw[mstart + i] = mw[i];
-        }
-    } else if (msg_type == 1) {
-        fw[vstart] = flex_numeric_vector(3, mstart, mwc, num_k);
-        if (is_long) {
-            fw[vstart + 1] = (mwc > 0) ? mw[0] : flex_enc(0);
-            for (int i = 1; i < mwc && (mstart + i - 1) < 88; i++)
-                fw[mstart + i - 1] = mw[i];
-        } else {
-            for (int i = 0; i < mwc && (mstart + i) < 88; i++)
-                fw[mstart + i] = mw[i];
-        }
-    } else {
-        // Type 2 = short/tone (empty msg), Type 3 = short numeric (msg digits)
-        std::string short_msg = (msg_type == 3) ? msg : "";
-        uint32_t short_vy = 0;
-        fw[vstart] = flex_short_vector(is_long, short_msg, &short_vy);
-        if (is_long)
-            fw[vstart + 1] = short_vy;
-    }
-
-    // Idle fill
-    int mf_words = mwc;
-    if (is_long && mwc > 0 && msg_type == 1)
-        mf_words = mwc - 1;
-    for (int i = mstart + mf_words; i < 88; i++)
-        fw[i] = (i & 1) ? 0x00000000 : 0xFFFFFFFF;
-
-    for (int blk = 0; blk < 11; blk++)
-        flex_interleave_block(blk, fw);
-
-    memcpy(p, fw, 88 * 4);
-    p += 88 * 4;
-
-    // Trailing idle
-    *p++ = 0xAA;
-    *p++ = 0xAA;
-    *p++ = 0xAA;
-    *p++ = 0xAA;
-
-    return (size_t)(p - buf);
-}
-
-// ===== ERS =====
-
-static size_t build_ers(uint8_t* buf, int cycles) {
-    uint8_t* p = buf;
-    uint8_t ar_inv[4];
-    for (int i = 0; i < 4; i++) ar_inv[i] = ~ar[i];
-    for (int c = 0; c < cycles; c++) {
-        *p++ = 0xAA;
-        *p++ = 0xAA;
-        memcpy(p, ar, 4);
-        p += 4;
-        *p++ = 0x55;
-        *p++ = 0x55;
-        memcpy(p, ar_inv, 4);
-        p += 4;
-    }
-    return (size_t)(p - buf);
-}
-
-// ===== FlexParamsView =====
-
-FlexParamsView::FlexParamsView(NavigationView& nav, FlexBIWParams& params)
-    : params_(params), nav_(nav) {
-    add_children({&labels,
-                  &check_date, &field_year, &field_month, &field_day,
-                  &check_time, &field_hour, &field_minute, &field_second,
-                  &check_tz, &options_tz, &check_dst,
-                  &check_ssid1, &field_local_id, &labels_cz, &field_coverage,
-                  &check_ssid2, &field_country, &check_roaming,
-                  &labels_msg, &field_msg_number,
-                  &check_ers, &field_ers_count,
-                  &button_save, &button_cancel});
-
-    // Populate from params
-    check_date.set_value(params_.send_date);
-    field_year.set_value(params_.year);
-    field_month.set_value(params_.month);
-    field_day.set_value(params_.day);
-
-    check_time.set_value(params_.send_time);
-    field_hour.set_value(params_.hour);
-    field_minute.set_value(params_.minute);
-    field_second.set_value(params_.second);
-
-    check_tz.set_value(params_.send_tz);
-    options_tz.set_by_value(params_.tz_code);
-    check_dst.set_value(params_.send_dst);
-
-    check_ssid1.set_value(params_.send_ssid1);
-    field_local_id.set_value(params_.local_id);
-    field_coverage.set_value(params_.coverage_zone);
-
-    check_ssid2.set_value(params_.send_ssid2);
-    field_country.set_value(params_.country_code);
-    check_roaming.set_value(params_.roaming);
-
-    field_msg_number.set_value(params_.msg_number);
-
-    check_ers.set_value(params_.send_ers);
-    field_ers_count.set_value(params_.ers_count);
-
-    // Roaming implies SSID1 + SSID2
-    check_roaming.on_select = [this](Checkbox&, bool v) {
-        on_roaming_changed(v);
-    };
-
-    button_save.on_select = [this, &nav](Button&) {
-        int32_t yr = field_year.value();
-        if (yr > 2025) {
-            int equiv = flex_equiv_year(yr);
-            nav.display_modal(
-                "Year > 2025",
-                "Valid: 1994-2025\nEquiv for " + to_string_dec_uint(yr) + ": " + to_string_dec_uint(equiv));
-            field_year.set_value(equiv);
-            return;
-        }
-        params_.send_date = check_date.value();
-        params_.year = yr;
-        params_.month = field_month.value();
-        params_.day = field_day.value();
-        params_.send_time = check_time.value();
-        params_.hour = field_hour.value();
-        params_.minute = field_minute.value();
-        params_.second = field_second.value();
-        params_.send_tz = check_tz.value();
-        params_.tz_code = options_tz.selected_index_value();
-        params_.send_dst = check_dst.value();
-        params_.send_ssid1 = check_ssid1.value();
-        params_.local_id = field_local_id.value();
-        params_.coverage_zone = field_coverage.value();
-        params_.send_ssid2 = check_ssid2.value();
-        params_.country_code = field_country.value();
-        params_.roaming = check_roaming.value();
-        params_.msg_number = field_msg_number.value();
-        params_.send_ers = check_ers.value();
-        params_.ers_count = field_ers_count.value();
-        nav.pop();
-    };
-
-    button_cancel.on_select = [&nav](Button&) {
-        nav.pop();
-    };
-}
-
-void FlexParamsView::on_roaming_changed(bool v) {
-    if (v) {
-        check_ssid1.set_value(true);
-        check_ssid2.set_value(true);
-    }
-}
-
-void FlexParamsView::focus() {
-    button_save.focus();
-}
-
-// ===== Serial message handler =====
-
-void FlexTXView::on_serial_msg(const FlexTosendMessage data) {
-    field_capcode.set_value(data.capcode);
-    capcode_value = data.capcode;
-    options_type.set_selected_index(data.type);
-    message = std::string((char*)data.msg, data.msglen);
-    buffer = message;
-    text_message.set(message);
-    if (message.length() > 30 && message.length() <= 60)
-        text_message_l2.set(message.substr(29));
-    else if (message.length() > 60)
-        text_message_l2.set(message.substr(29, 27) + "...");
-    else
-        text_message_l2.set("");
-    field_capcode.dirty();
-    options_type.dirty();
-    text_message.dirty();
-    text_message_l2.dirty();
-    tx_view.focus();
-    if (start_tx()) tx_view.set_transmitting(true);
-}
-
-// ===== TX =====
-
-void FlexTXView::on_tx_progress(const uint32_t progress, const bool done) {
-    if (done) {
-        if (tx_phase_ == 0) return;  // stopped by user
-        int ers_n = tx_steps_total_ - 2;
-        if (tx_phase_ == 1 && ers_remaining_ > 0) {
-            tx_step_++;
-            text_capinfo.set("[" + to_string_dec_uint(tx_step_) + "/" + to_string_dec_uint(tx_steps_total_) +
-                             "] ERS " + to_string_dec_uint(tx_step_) + "/" + to_string_dec_uint(ers_n));
-            uint8_t* data = shared_memory.bb_data.data;
-            size_t total = build_ers(data, 42);
-            ers_remaining_--;
-            uint32_t total_bits = total * 8;
-            progressbar.set_max(total_bits / 64);
-            baseband::set_fsk_data(total_bits, 2280000 / 1600, 4500, 64);
-        } else if (tx_phase_ == 1) {
-            tx_phase_ = 2;
-            tx_step_++;
-            text_capinfo.set("[" + to_string_dec_uint(tx_step_) + "/" + to_string_dec_uint(tx_steps_total_) +
-                             "] Frame 1/2 (new)");
-            send_frame(1);
-        } else if (tx_phase_ == 2) {
-            tx_phase_ = 3;
-            tx_step_++;
-            text_capinfo.set("[" + to_string_dec_uint(tx_step_) + "/" + to_string_dec_uint(tx_steps_total_) +
-                             "] Frame 2/2 (dup)");
-            send_frame(0);
-        } else {
-            biw_params_.msg_number = (biw_params_.msg_number + 1) & 63;
-            transmitter_model.disable();
-            progressbar.set_value(0);
-            tx_view.set_transmitting(false);
-            tx_phase_ = 0;
-            set_dirty();  // repaint capcode info
-        }
-    } else {
-        if (tx_phase_ != 0)
-            progressbar.set_value(progress);
-    }
-}
-
-bool FlexTXView::start_tx() {
-    uint64_t capcode = field_capcode.to_integer();
-    capcode_value = capcode;
-    if (capcode < 1 || capcode > 4297068542ULL) {
-        nav_.display_modal("Bad capcode", "Capcode: 1-4297068542");
-        return false;
-    }
-
-    int msg_type = options_type.selected_index();
-    if (msg_type == 1) {
-        if (message.find_first_not_of("0123456789.U -][") != std::string::npos) {
-            nav_.display_modal("Bad message", "Numeric: 0-9 . U - ] [ space");
-            return false;
-        }
-    }
-
-    transmitter_model.set_sampling_rate(2280000);
-    transmitter_model.set_baseband_bandwidth(1'750'000);
-    transmitter_model.enable();
-
-    int ers_n = (biw_params_.send_ers && biw_params_.ers_count > 0) ? biw_params_.ers_count : 0;
-    tx_steps_total_ = ers_n + 2;
-    tx_step_ = 0;
-
-    if (ers_n > 0) {
-        tx_phase_ = 1;
-        ers_remaining_ = ers_n;
-        tx_step_++;
-        text_capinfo.set("[" + to_string_dec_uint(tx_step_) + "/" + to_string_dec_uint(tx_steps_total_) +
-                         "] ERS " + to_string_dec_uint(tx_step_) + "/" + to_string_dec_uint(ers_n));
-        uint8_t* data = shared_memory.bb_data.data;
-        size_t total = build_ers(data, 42);
-        ers_remaining_--;
-        uint32_t total_bits = total * 8;
-        progressbar.set_max(total_bits / 64);
-        baseband::set_fsk_data(total_bits, 2280000 / 1600, 4500, 64);
-    } else {
-        tx_phase_ = 2;
-        tx_step_++;
-        text_capinfo.set("[" + to_string_dec_uint(tx_step_) + "/" + to_string_dec_uint(tx_steps_total_) +
-                         "] Frame 1/2 (new)");
-        send_frame(1);
-    }
-
-    return true;
-}
-
-void FlexTXView::send_frame(uint32_t msg_r) {
-    uint64_t capcode = field_capcode.to_integer();
-    int msg_type = options_type.selected_index();
-
-    uint8_t* data = shared_memory.bb_data.data;
-    size_t total = 0;
-
-    total += build_ers(data + total, 8);
-    total += build_frame(data + total, capcode, msg_type, message, 0, 0, msg_r, biw_params_);
-
-    uint32_t total_bits = total * 8;
-    progressbar.set_max(total_bits / 64);
-    baseband::set_fsk_data(total_bits, 2280000 / 1600, 4500, 64);
-}
-
-// ===== UI =====
-
-void FlexTXView::focus() {
-    field_capcode.focus();
-}
-
-FlexTXView::~FlexTXView() {
-    transmitter_model.disable();
-    baseband::shutdown();
-}
-
-void FlexTXView::paint(Painter&) {
-    message = buffer;
-    text_message.set(message);
-    if (message.length() > 30 && message.length() <= 60)
-        text_message_l2.set(message.substr(29));
-    else if (message.length() > 60)
-        text_message_l2.set(message.substr(29, 27) + "...");
-    else
-        text_message_l2.set("");
-
-    // Capcode info line
-    uint64_t cap = field_capcode.to_integer();
-    std::string info;
-    if (cap == 0) {
-        info = "Invalid";
-    } else if (cap <= 1933312ULL) {
-        info = "Short addr";
-    } else if (cap >= 2062336ULL && cap <= 2062351ULL) {
-        info = "Temp grp #" + to_string_dec_uint(cap - 2062336ULL);
-    } else if (cap >= 2062352ULL && cap <= 2062367ULL) {
-        info = "Operator msg";
-    } else if (cap >= 2058240ULL && cap <= 2062335ULL) {
-        info = "Network addr";
-    } else if (cap >= 2041856ULL && cap <= 2058239ULL) {
-        info = "Info service";
-    } else if (cap > 1933312ULL && cap < 2101249ULL) {
-        info = "Reserved";
-    } else if (cap >= 2101249ULL && cap <= 4297068542ULL) {
-        info = "Long addr";
-    } else {
-        info = "Invalid";
-    }
-    // Computed frame/phase for all valid addresses
-    if (cap >= 1 && cap <= 4297068542ULL) {
-        static const char ph[] = "ABCD";
-        int frame = (int)((cap / 16) % 128);
-        int phase = (int)((cap / 4) % 4);
-        info += ", F" + to_string_dec_uint(frame) +
-                " " + std::string(1, ph[phase]);
-    }
-    text_capinfo.set(info);
-}
-
-void FlexTXView::on_set_text(NavigationView& nav) {
-    text_prompt(nav, buffer, MAX_FLEX_MSG, ENTER_KEYBOARD_MODE_ALPHA);
-}
-
-FlexTXView::FlexTXView(NavigationView& nav)
-    : nav_(nav) {
-    baseband::run_prepared_image(portapack::memory::map::m4_code.base());
-
-    // Init random msg number from RTC
-    {
-        rtc::RTC datetime;
-        rtc_time::now(datetime);
-        int seed = datetime.second() + datetime.minute() * 7 + datetime.hour();
-        biw_params_.msg_number = seed & 63;
-        if (biw_params_.msg_number == 0)
-            biw_params_.msg_number = 1;
-    }
-
-    // Always populate date/time/dst from RTC
-    {
-        rtc::RTC datetime;
-        rtc_time::now(datetime);
-        int real_year = datetime.year();
-        biw_params_.year = flex_equiv_year(real_year);
-        biw_params_.month = datetime.month();
-        biw_params_.day = datetime.day();
-        biw_params_.hour = datetime.hour();
-        biw_params_.minute = datetime.minute();
-        biw_params_.second = datetime.second();
-        biw_params_.send_dst = portapack::persistent_memory::dst_enabled() ? 1 : 0;
-    }
-
-    add_children({&labels, &text_capinfo, &field_capcode, &options_speed, &options_type,
-                  &text_message, &text_message_l2,
-                  &button_message, &button_params, &progressbar, &tx_view});
-
-    options_speed.set_selected_index(0);
-    options_type.set_selected_index(0);
-    field_capcode.set_value(capcode_value);
-
-    field_capcode.on_change = [this](SymField&) {
-        set_dirty();  // trigger repaint to update capcode info text
-    };
-
-    button_message.on_select = [this, &nav](Button&) {
-        this->on_set_text(nav);
-    };
-
-    button_params.on_select = [this, &nav](Button&) {
-        nav.push<FlexParamsView>(biw_params_);
-    };
-
-    tx_view.on_edit_frequency = [this, &nav]() {
-        auto new_view =
-            nav.push<FrequencyKeypadView>(transmitter_model.target_frequency());
-        new_view->on_changed = [this](rf::Frequency f) {
-            transmitter_model.set_target_frequency(f);
-        };
-    };
-
-    tx_view.on_start = [this]() {
-        if (start_tx()) tx_view.set_transmitting(true);
-    };
-
-    tx_view.on_stop = [this]() {
-        tx_phase_ = 0;
-        tx_view.set_transmitting(false);
-        transmitter_model.disable();
-        progressbar.set_value(0);
-        set_dirty();  // repaint capcode info
-    };
-}
-
-}  // namespace ui::external_app::flex_tx

firmware/application/external/flex_tx/ui_flex_tx.hpp

@@ -1,251 +0,0 @@
-#ifndef __UI_FLEX_TX_H__
-#define __UI_FLEX_TX_H__
-
-#include "ui.hpp"
-#include "ui_widget.hpp"
-#include "ui_navigation.hpp"
-#include "ui_receiver.hpp"
-#include "ui_transmitter.hpp"
-#include "message.hpp"
-#include "transmitter_model.hpp"
-#include "app_settings.hpp"
-#include "radio_state.hpp"
-
-namespace ui::external_app::flex_tx {
-
-struct FlexBIWParams {
-    int32_t send_date{1};
-    int32_t send_time{1};
-    int32_t send_tz{1};
-    int32_t send_dst{0};
-    int32_t send_ssid1{0};
-    int32_t send_ssid2{0};
-    int32_t roaming{0};
-    int32_t year{2015};
-    int32_t month{1};
-    int32_t day{1};
-    int32_t hour{0};
-    int32_t minute{0};
-    int32_t second{0};
-    int32_t tz_code{0};
-    int32_t local_id{0};
-    int32_t coverage_zone{0};
-    int32_t country_code{0};
-    int32_t msg_number{0};
-    int32_t send_ers{1};
-    int32_t ers_count{1};
-};
-
-class FlexParamsView : public View {
-   public:
-    FlexParamsView(NavigationView& nav, FlexBIWParams& params);
-
-    std::string title() const override { return "FLEX Params"; };
-    void focus() override;
-
-   private:
-    FlexBIWParams& params_;
-    NavigationView& nav_;
-
-    void on_roaming_changed(bool v);
-
-    Labels labels{
-        {{12 * 8, 1 * 16}, "-", Theme::getInstance()->fg_light->foreground},
-        {{15 * 8, 1 * 16}, "-", Theme::getInstance()->fg_light->foreground},
-        {{10 * 8, 2 * 16}, ":", Theme::getInstance()->fg_light->foreground},
-        {{13 * 8, 2 * 16}, ":", Theme::getInstance()->fg_light->foreground},
-    };
-
-    Checkbox check_date{{0 * 8, 1 * 16}, 4, "Date", true};
-    NumberField field_year{{8 * 8, 1 * 16}, 4, {1994, 2099}, 1, '0', true};
-    NumberField field_month{{13 * 8, 1 * 16}, 2, {1, 12}, 1, '0', true};
-    NumberField field_day{{16 * 8, 1 * 16}, 2, {1, 31}, 1, '0', true};
-
-    Checkbox check_time{{0 * 8, 2 * 16}, 4, "Time", true};
-    NumberField field_hour{{8 * 8, 2 * 16}, 2, {0, 23}, 1, '0', true};
-    NumberField field_minute{{11 * 8, 2 * 16}, 2, {0, 59}, 1, '0', true};
-    NumberField field_second{{14 * 8, 2 * 16}, 2, {0, 59}, 1, '0', true};
-
-    Checkbox check_tz{{0 * 8, 3 * 16}, 2, "TZ", true};
-    OptionsField options_tz{
-        {6 * 8, 3 * 16},
-        9,
-        {{"UTC+0   ", 0},
-         {"UTC+1   ", 1},
-         {"UTC+2   ", 2},
-         {"UTC+3   ", 3},
-         {"UTC+4   ", 4},
-         {"UTC+5   ", 5},
-         {"UTC+6   ", 6},
-         {"UTC+7   ", 7},
-         {"UTC+8   ", 8},
-         {"UTC+9   ", 9},
-         {"UTC+10  ", 10},
-         {"UTC+11  ", 11},
-         {"UTC+12  ", 12},
-         {"UTC+3:30", 13},
-         {"UTC+4:30", 14},
-         {"UTC+5:30", 15},
-         {"UTC+5:45", 17},
-         {"UTC+6:30", 18},
-         {"UTC+9:30", 19},
-         {"UTC-3:30", 20},
-         {"UTC-11  ", 21},
-         {"UTC-10  ", 22},
-         {"UTC-9   ", 23},
-         {"UTC-8   ", 24},
-         {"UTC-7   ", 25},
-         {"UTC-6   ", 26},
-         {"UTC-5   ", 27},
-         {"UTC-4   ", 28},
-         {"UTC-3   ", 29},
-         {"UTC-2   ", 30},
-         {"UTC-1   ", 31}}};
-    Checkbox check_dst{{18 * 8, 3 * 16}, 3, "DST", true};
-
-    Checkbox check_ssid1{{0 * 8, 5 * 16}, 5, "LocID", true};
-    NumberField field_local_id{{9 * 8, 5 * 16}, 3, {0, 511}, 1, '0'};
-    Labels labels_cz{
-        {{12 * 8, 5 * 16}, "CovZone", Theme::getInstance()->fg_light->foreground},
-    };
-    NumberField field_coverage{{20 * 8, 5 * 16}, 2, {0, 31}, 1, '0'};
-
-    Checkbox check_ssid2{{0 * 8, 6 * 16}, 11, "CountryCode", true};
-    NumberField field_country{{15 * 8, 6 * 16}, 4, {0, 1023}, 1, '0'};
-    Checkbox check_roaming{{0 * 8, 7 * 16}, 4, "Roam", true};
-
-    Labels labels_msg{
-        {{0 * 8, 9 * 16}, "Msg#:", Theme::getInstance()->fg_light->foreground},
-    };
-    NumberField field_msg_number{{5 * 8, 9 * 16}, 2, {0, 63}, 1, '0'};
-
-    Checkbox check_ers{{0 * 8, 10 * 16}, 3, "ERS", true};
-    NumberField field_ers_count{{8 * 8, 10 * 16}, 2, {1, 10}, 1, ' '};
-
-    Button button_save{{1 * 8, 12 * 16, 12 * 8, 32}, "Save"};
-    Button button_cancel{{16 * 8, 12 * 16, 12 * 8, 32}, "Cancel"};
-};
-
-class FlexTXView : public View {
-   public:
-    FlexTXView(NavigationView& nav);
-    ~FlexTXView();
-
-    FlexTXView(const FlexTXView&) = delete;
-    FlexTXView& operator=(const FlexTXView&) = delete;
-
-    void focus() override;
-    void paint(Painter&) override;
-    std::string title() const override { return "FLEX TX"; };
-
-    FlexBIWParams biw_params_{};
-
-   private:
-    std::string buffer{"FLEX TEST"};
-    std::string message{};
-    NavigationView& nav_;
-    int tx_phase_{0};
-    int ers_remaining_{0};
-    int tx_step_{0};
-    int tx_steps_total_{0};
-
-    int64_t capcode_value{1000};
-
-    TxRadioState radio_state_{
-        931740000 /* frequency */,
-        1750000 /* bandwidth */,
-        2280000 /* sampling rate */
-    };
-    app_settings::SettingsManager settings_{
-        "tx_flex",
-        app_settings::Mode::TX,
-        {{"capcode", &capcode_value},
-         {"biw_date", &biw_params_.send_date},
-         {"biw_time", &biw_params_.send_time},
-         {"biw_tz", &biw_params_.send_tz},
-         {"biw_ssid1", &biw_params_.send_ssid1},
-         {"biw_ssid2", &biw_params_.send_ssid2},
-         {"biw_roam", &biw_params_.roaming},
-         {"biw_tzc", &biw_params_.tz_code},
-         {"biw_lid", &biw_params_.local_id},
-         {"biw_cz", &biw_params_.coverage_zone},
-         {"biw_cc", &biw_params_.country_code},
-         {"biw_ers", &biw_params_.send_ers},
-         {"biw_ersc", &biw_params_.ers_count}}};
-
-    void on_set_text(NavigationView& nav);
-    void on_tx_progress(const uint32_t progress, const bool done);
-    void on_serial_msg(const FlexTosendMessage data);
-    bool start_tx();
-    void send_frame(uint32_t msg_r);
-
-    Labels labels{
-        {{1 * 8, 4 * 8}, "Capcode:", Theme::getInstance()->fg_light->foreground},
-        {{3 * 8, 6 * 8}, "Speed:", Theme::getInstance()->fg_light->foreground},
-        {{4 * 8, 8 * 8}, "Type:", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(0), 12 * 8}, "Message:", Theme::getInstance()->fg_light->foreground}};
-
-    Text text_capinfo{
-        {UI_POS_X(0), 2 * 8, screen_width, 16},
-        ""};
-
-    SymField field_capcode{
-        {10 * 8, 4 * 8},
-        10};
-
-    OptionsField options_speed{
-        {10 * 8, 6 * 8},
-        10,
-        {{"1600/2FSK ", 0}}};
-
-    OptionsField options_type{
-        {10 * 8, 8 * 8},
-        14,
-        {{"Alphanumeric ", 0},
-         {"Numeric      ", 1},
-         {"Short/tone   ", 2},
-         {"Short numeric", 3}}};
-
-    Text text_message{
-        {UI_POS_X(0), 14 * 8, screen_width, 16},
-        ""};
-    Text text_message_l2{
-        {UI_POS_X(0), 16 * 8, screen_width, 16},
-        ""};
-
-    Button button_message{
-        {UI_POS_X(0), 18 * 8, 13 * 8, 32},
-        "Set message"};
-
-    Button button_params{
-        {14 * 8, 18 * 8, 13 * 8, 32},
-        "Set params"};
-
-    ProgressBar progressbar{
-        {16, 210, UI_POS_WIDTH_REMAINING(4), 16}};
-
-    TransmitterView tx_view{
-        (int16_t)UI_POS_Y_BOTTOM(4),
-        10000,
-        9};
-
-    MessageHandlerRegistration message_handler_tx_progress{
-        Message::ID::TXProgress,
-        [this](const Message* const p) {
-            const auto message =
-                *reinterpret_cast<const TXProgressMessage*>(p);
-            this->on_tx_progress(message.progress, message.done);
-        }};
-
-    MessageHandlerRegistration message_handler_flex_tosend{
-        Message::ID::FlexTosend,
-        [this](const Message* const p) {
-            const auto message =
-                *reinterpret_cast<const FlexTosendMessage*>(p);
-            this->on_serial_msg(message);
-        }};
-};
-
-}  // namespace ui::external_app::flex_tx
-
-#endif

firmware/application/external/fpv_detect/ui_fpv_detect.cpp

@@ -3,11 +3,13 @@
 /*
  * FPV RX — how frequency search and lock work
  *
- * 1. Power metric: We use channelized power that portapack RSSI algo included.
+ * 1. Power metric: We use channelized power (baseband IQ magnitude² in the
+ *    capture bandwidth), not raw RF RSSI. Stats come from ChannelStatsCollector
+ *    over filtered IQ, so we see power in the tuned channel, not wideband.
  *
  * 2. Scanning: We step through FPV bands/channels (A/B/E/F/R, 8 ch each). When
  *    power on the current channel exceeds the detect threshold, we enter
- *    "Candidate" and run verification - with some edge detecting algo.
+ *    "Candidate" and run verification — we do not lock on a single peak.
  *
  * 3. Verification (making sure the drone is on that freq):
  *    - Multiple samples: verify_hits / verify_misses over several updates.
@@ -175,7 +177,7 @@ void FpvDetectView::reset_detector(bool retune_current) {
     }
 }
 
-bool FpvDetectView::is_possible_freq_spike(const ChannelStatistics& statistics) const {
+bool FpvDetectView::is_possible_analog_carrier(const ChannelStatistics& statistics) const {
     return statistics.max_db >= detect_threshold_db();
 }
 
@@ -390,17 +392,17 @@ void FpvDetectView::update_state_badge() {
             text_state.set("SCANNING");
             break;
         case DetectState::Candidate:
-            text_state.set("CHECKING");
+            text_state.set("VERIFY FPV");
             break;
         case DetectState::Locked:
-            text_state.set("FREQ FOUND");
+            text_state.set("DRONE FOUND");
             break;
     }
 }
 
 void FpvDetectView::update_confidence_text() {
     char buf[16];
-    std::snprintf(buf, sizeof(buf), "Posi %u%%", static_cast<unsigned>(candidate_confidence_));
+    std::snprintf(buf, sizeof(buf), "Conf %u%%", static_cast<unsigned>(candidate_confidence_));
     text_confidence.set(buf);
 }
 
@@ -410,21 +412,21 @@ void FpvDetectView::update_status_text() {
     switch (detect_state_) {
         case DetectState::Scanning:
             if (band_mode < FPV_NUM_BANDS) {
-                std::snprintf(buf, sizeof(buf), "Scanning band %c", band_labels[band_mode]);
+                std::snprintf(buf, sizeof(buf), "Scanning band %c for analog FPV", band_labels[band_mode]);
             } else {
-                std::snprintf(buf, sizeof(buf), "Scanning all from list");
+                std::snprintf(buf, sizeof(buf), "Scanning all FPV bands");
             }
             break;
 
         case DetectState::Candidate:
-            std::snprintf(buf, sizeof(buf), "CHKING %c%d  %ld MHz",
+            std::snprintf(buf, sizeof(buf), "VERIFYING %c%d  %ld MHz",
                           band_labels[candidate_band_],
                           static_cast<int>(candidate_ch_ + 1),
                           static_cast<long>(fpv_frequencies[candidate_band_][candidate_ch_] / 1000000LL));
             break;
 
         case DetectState::Locked:
-            std::snprintf(buf, sizeof(buf), "FREQ FOUND %c%d  %ld",
+            std::snprintf(buf, sizeof(buf), "!!! DRONE FOUND !!! %c%d  %ld",
                           band_labels[candidate_band_],
                           static_cast<int>(candidate_ch_ + 1),
                           static_cast<long>(fpv_frequencies[candidate_band_][candidate_ch_] / 1000000LL));
@@ -451,7 +453,7 @@ void FpvDetectView::update_detail_text() {
             break;
 
         case DetectState::Locked:
-            std::snprintf(buf, sizeof(buf), "LOCKED %c%d  posi %u%%  hold %u",
+            std::snprintf(buf, sizeof(buf), "LOCKED %c%d  conf %u%%  hold %u",
                           band_labels[candidate_band_],
                           static_cast<int>(candidate_ch_ + 1),
                           static_cast<unsigned>(candidate_confidence_),
@@ -603,7 +605,7 @@ void FpvDetectView::on_statistics_update(const ChannelStatistics& statistics) {
 
     switch (detect_state_) {
         case DetectState::Scanning:
-            if (is_possible_freq_spike(statistics)) {
+            if (is_possible_analog_carrier(statistics)) {
                 enter_candidate(statistics);
             }
             break;

firmware/application/external/fpv_detect/ui_fpv_detect.hpp

@@ -72,7 +72,7 @@ class FpvDetectView : public View {
     void step_scan();
     void reset_detector(bool retune_current);
 
-    bool is_possible_freq_spike(const ChannelStatistics& statistics) const;
+    bool is_possible_analog_carrier(const ChannelStatistics& statistics) const;
     void enter_candidate(const ChannelStatistics& statistics);
     void evaluate_candidate_sample(const ChannelStatistics& statistics);
     void enter_lock();
@@ -162,7 +162,7 @@ class FpvDetectView : public View {
     Text text_freq{{UI_POS_X_RIGHT(20), UI_POS_Y(1), UI_POS_WIDTH(20), UI_POS_DEFAULT_HEIGHT}, ""};
 
     Text text_state{{UI_POS_X(0), UI_POS_Y(2), UI_POS_WIDTH(12), UI_POS_DEFAULT_HEIGHT}, "SCANNING"};
-    Text text_confidence{{UI_POS_X(12), UI_POS_Y(2), UI_POS_WIDTH(8), UI_POS_DEFAULT_HEIGHT}, "Posi 0%"};
+    Text text_confidence{{UI_POS_X(12), UI_POS_Y(2), UI_POS_WIDTH(8), UI_POS_DEFAULT_HEIGHT}, "Conf 0%"};
     Text text_detect_label{{UI_POS_X_RIGHT(10), UI_POS_Y(2), UI_POS_WIDTH(5), UI_POS_DEFAULT_HEIGHT}, "Thr>"};
 
     NumberField field_detect_threshold{
@@ -176,8 +176,8 @@ class FpvDetectView : public View {
     Text freq_stats_rssi{{UI_POS_X(0), UI_POS_Y(3), UI_POS_WIDTH(15), UI_POS_DEFAULT_HEIGHT}, "RSSI 0/0/0"};
     Text freq_stats_db{{UI_POS_X_RIGHT(14), UI_POS_Y(3), UI_POS_WIDTH(14), UI_POS_DEFAULT_HEIGHT}, "PWR -120 dB"};
 
-    Text text_status{{UI_POS_X(0), UI_POS_Y(4), UI_POS_WIDTH(30), UI_POS_DEFAULT_HEIGHT}, "SCANNING FOR FREQS"};
-    Text text_detail{{UI_POS_X(0), UI_POS_Y(5), UI_POS_WIDTH(30), UI_POS_DEFAULT_HEIGHT}, "Waiting for FPV FREQ"};
+    Text text_status{{UI_POS_X(0), UI_POS_Y(4), UI_POS_WIDTH(30), UI_POS_DEFAULT_HEIGHT}, "SCANNING FOR ANALOG FPV"};
+    Text text_detail{{UI_POS_X(0), UI_POS_Y(5), UI_POS_WIDTH(30), UI_POS_DEFAULT_HEIGHT}, "Waiting for FPV-like carrier"};
 
     RSSIGraph rssi_graph{{UI_POS_X(0), UI_POS_Y(6), UI_POS_WIDTH_REMAINING(5), UI_POS_HEIGHT_REMAINING(7)}};
     RSSI rssi{{UI_POS_X_RIGHT(5), UI_POS_Y(6), UI_POS_WIDTH(5), UI_POS_HEIGHT_REMAINING(7)}};

firmware/application/external/morseradiotx/ui_morse_radiotx.cpp

@@ -27,9 +27,6 @@ MorseRadiotxView::MorseRadiotxView(ui::NavigationView& nav)
                   &chk_trans,
                   &bandwidth,
                   &chk_callsgn,
-                  &chk_loop,
-                  &wait_time,
-                  &progressbar,
                   &txt_last,
                   &console_text,
                   &btn_clear,
@@ -72,7 +69,6 @@ MorseRadiotxView::MorseRadiotxView(ui::NavigationView& nav)
     options_mode.set_selected_index(current_mode, true);
     tone_.set_value(tone, true);
     wpm_.set_value(wpm, true);
-    wait_time.set_value(1, true);
     bandwidth.set_value(band, true);
 
     btn_ptt.on_select = [this](Button&) {
@@ -160,14 +156,6 @@ MorseRadiotxView::MorseRadiotxView(ui::NavigationView& nav)
             transmitter_model.set_target_frequency(f);
         };
     };
-
-    chk_trans.on_select = [this](Checkbox&, bool v) {
-        if (v) chk_loop.set_value(false);
-    };
-
-    chk_loop.on_select = [this](Checkbox&, bool v) {
-        if (v) chk_trans.set_value(false);
-    };
 }
 
 MorseRadiotxView::~MorseRadiotxView() {
@@ -209,15 +197,19 @@ MorseRadiotxView::MorseTimings MorseRadiotxView::calculate_morse_timings(uint32_
 
 void MorseRadiotxView::transmit_morse_message() {
     std::string full_message = "";
+    // cal sign
+    if (chk_callsgn.value() && !call_sign.empty()) {
+        full_message = call_sign;
+        if (!chk_trans.value() && !msg_buffer.empty()) {
+            full_message += " " + msg_buffer;
+        }
+    } else {
+        if (!chk_trans.value()) full_message = msg_buffer;
+    }
 
-    if (chk_trans.value()) {
+    if (full_message.empty() && !chk_trans.value()) {
         ptt_button_visibility(false);
         return;
-    } else {
-        full_message = msg_buffer;
-        if (chk_callsgn.value() && !call_sign.empty()) {  // call sign
-            full_message += " " + call_sign;
-        }
     }
 
     // enable transmit
@@ -227,63 +219,46 @@ void MorseRadiotxView::transmit_morse_message() {
         ui_toggle();
     }
 
-    uint8_t loop_seconds = static_cast<uint8_t>(wait_time.value());
-    progressbar.set_max(loop_seconds * 2);
-
-    do {
-        for (size_t i = 0; i < full_message.length(); i++) {
-            if (chThdShouldTerminate()) break;
-
-            char c = full_message[i];
-
-            std::string s_char(1, c);
-            // space
-            if (c == ' ') {
-                console_text.write(" ");
-                chThdSleepMilliseconds(current_timings.word_gap);
-                continue;
-            }
-
-            const char* pattern = morse_decoder_.get_morse_pattern(c);
-
-            if (pattern != nullptr) {
-                txt_last.set(pattern);
-
-                // write blue char to console
-                console_text.write(STR_COLOR_BLUE + s_char);
-
-                // Morze (dih/dah) send
-                for (int j = 0; pattern[j] != '\0'; j++) {
-                    baseband::set_morsetx_key(true);
-                    if (pattern[j] == '.') {
-                        chThdSleepMilliseconds(current_timings.dot_ms);
-                    } else if (pattern[j] == '-') {
-                        chThdSleepMilliseconds(current_timings.dash_ms);
-                    }
-                    if (chThdShouldTerminate()) break;
-                    // pause between signs
-                    baseband::set_morsetx_key(false);
-                    chThdSleepMilliseconds(current_timings.symbol_gap);
-                }
-                if (chThdShouldTerminate()) break;
-                if (current_timings.char_gap > current_timings.symbol_gap) {
-                    chThdSleepMilliseconds(current_timings.char_gap - current_timings.symbol_gap);
-                }
-            }
-        }
+    for (size_t i = 0; i < full_message.length(); i++) {
         if (chThdShouldTerminate()) break;
-        if (chk_loop.value()) {
+
+        char c = full_message[i];
+
+        std::string s_char(1, c);
+        // space
+        if (c == ' ') {
             console_text.write(" ");
-            for (uint8_t s = 0; s < (loop_seconds * 2); s++) {
-                if (chThdShouldTerminate()) break;
-                progressbar.set_value(s + 1);
-                if (!chk_loop.value()) break;
-                chThdSleepMilliseconds(500);
-            }
-            progressbar.set_value(0);
+            chThdSleepMilliseconds(current_timings.word_gap);
+            continue;
         }
-        if (!chk_loop.value()) break;
-    } while (chk_loop.value() && !chThdShouldTerminate());
+
+        const char* pattern = morse_decoder_.get_morse_pattern(c);
+
+        if (pattern != nullptr) {
+            txt_last.set(pattern);
+
+            // write blue char to console
+            console_text.write(STR_COLOR_BLUE + s_char);
+
+            // Morze (dih/dah) send
+            for (int j = 0; pattern[j] != '\0'; j++) {
+                baseband::set_morsetx_key(true);
+                if (pattern[j] == '.') {
+                    chThdSleepMilliseconds(current_timings.dot_ms);
+                } else if (pattern[j] == '-') {
+                    chThdSleepMilliseconds(current_timings.dash_ms);
+                }
+                if (chThdShouldTerminate()) break;
+                // pause between signs
+                baseband::set_morsetx_key(false);
+                chThdSleepMilliseconds(current_timings.symbol_gap);
+            }
+            if (chThdShouldTerminate()) break;
+            if (current_timings.char_gap > current_timings.symbol_gap) {
+                chThdSleepMilliseconds(current_timings.char_gap - current_timings.symbol_gap);
+            }
+        }
+    }
 
     if (chk_trans.value()) ptt_button_visibility(false);
     baseband::set_morsetx_key(false);
@@ -381,17 +356,13 @@ void MorseRadiotxView::ui_toggle() {
         wpm_.set_style(Theme::getInstance()->fg_dark);
         wpm_.set_focusable(false);
         btn_message.set_style(Theme::getInstance()->fg_dark);
-        btn_message.set_focusable(false);
         btn_calls.set_style(Theme::getInstance()->fg_dark);
-        btn_calls.set_focusable(false);
         chk_trans.set_style(Theme::getInstance()->fg_dark);
         chk_trans.set_focusable(false);
-        chk_callsgn.set_style(Theme::getInstance()->fg_dark);
-        chk_callsgn.set_focusable(false);
-        wait_time.set_style(Theme::getInstance()->fg_dark);
-        wait_time.set_focusable(false);
         bandwidth.set_style(Theme::getInstance()->fg_dark);
         bandwidth.set_focusable(false);
+        chk_callsgn.set_style(Theme::getInstance()->fg_dark);
+        chk_callsgn.set_focusable(false);
 
     } else {
         options_mode.set_style(Theme::getInstance()->bg_darker);
@@ -399,15 +370,11 @@ void MorseRadiotxView::ui_toggle() {
         wpm_.set_style(Theme::getInstance()->bg_darker);
         wpm_.set_focusable(true);
         btn_message.set_style(Theme::getInstance()->bg_darker);
-        btn_message.set_focusable(true);
         btn_calls.set_style(Theme::getInstance()->bg_darker);
-        btn_calls.set_focusable(true);
         chk_trans.set_style(Theme::getInstance()->bg_darker);
         chk_trans.set_focusable(true);
         chk_callsgn.set_style(Theme::getInstance()->bg_darker);
         chk_callsgn.set_focusable(true);
-        wait_time.set_style(Theme::getInstance()->bg_darker);
-        wait_time.set_focusable(true);
         ptt_button_visibility(true);
         tone_.set_style(Theme::getInstance()->bg_darker);
         tone_.set_focusable(true);

firmware/application/external/morseradiotx/ui_morse_radiotx.hpp

@@ -118,20 +118,15 @@ class MorseRadiotxView : public ui::View {
         {{"AM", 0}, {"FM", 1}, {"DSB", 2}, {"USB", 3}, {"LSB", 4}}};
     NumberField tone_{{UI_POS_X(14), UI_POS_Y(0)}, 4, {400, 1400}, 10, ' ', true};
     NumberField wpm_{{UI_POS_X(25), UI_POS_Y(0)}, 2, {10, 45}, 1, ' ', true};
-    NumberField wait_time{{UI_POS_X(10), UI_POS_Y(4)}, 3, {1, 99}, 1, ' ', true};  // wait between tx-es in loop mode (sec)
-    FloatField bandwidth{{UI_POS_X(6), UI_POS_Y(5)}, 4, {1.0, 16.0}, 0.1, ' ', true, 1};
-
-    ProgressBar progressbar{
-        {UI_POS_X(0), UI_POS_Y(6), screen_width, 16}};
+    FloatField bandwidth{{UI_POS_X(20), UI_POS_Y(3)}, 4, {1.0, 16.0}, 0.1, ' ', true, 1};
 
     ui::Text txt_msg{{UI_POS_X(0), UI_POS_Y(1), UI_POS_MAXWIDTH, UI_POS_HEIGHT(1)}, "[" + msg_buffer + "] "};
     ui::Button btn_message{{UI_POS_X(0), UI_POS_Y(2), UI_POS_WIDTH(11), UI_POS_HEIGHT(1)}, "Message"};
-    ui::Button btn_calls{{UI_POS_X(0), UI_POS_Y(3), UI_POS_WIDTH(11), UI_POS_HEIGHT(1)}, (call_sign.empty()) ? "call sign?" : call_sign};
+    ui::Button btn_calls{{UI_POS_X(0), UI_POS_Y(4), UI_POS_WIDTH(11), UI_POS_HEIGHT(1)}, (call_sign.empty()) ? "call sign?" : call_sign};
     Checkbox chk_trans{{UI_POS_X(14), UI_POS_Y(2)}, 13, "Manual trans.", true};
-    Checkbox chk_callsgn{{UI_POS_X(14), UI_POS_Y(3)}, 9, "Call sign", true};
-    Checkbox chk_loop{{UI_POS_X(14), UI_POS_Y(4)}, 4, "loop", true};
-    ui::Text txt_last{{UI_POS_X(10), UI_POS_Y(7), UI_POS_WIDTH_REMAINING(10), UI_POS_HEIGHT(1)}, ""};
-    ui::Console console_text{{UI_POS_X(0), UI_POS_Y(9), UI_POS_MAXWIDTH, UI_POS_HEIGHT_REMAINING(14)}};
+    Checkbox chk_callsgn{{UI_POS_X(14), UI_POS_Y(4)}, 13, "Call sign", true};
+    ui::Text txt_last{{UI_POS_X(10), UI_POS_Y(5), UI_POS_WIDTH_REMAINING(10), UI_POS_HEIGHT(1)}, ""};
+    ui::Console console_text{{UI_POS_X(0), UI_POS_Y(7), UI_POS_MAXWIDTH, UI_POS_HEIGHT_REMAINING(14)}};
     ui::Button btn_clear{{UI_POS_X(0), UI_POS_Y_BOTTOM(5), UI_POS_WIDTH(5), UI_POS_HEIGHT(1)}, "CLR"};
     ui::Button btn_ptt{{UI_POS_X_CENTER(12), UI_POS_Y_BOTTOM(7), UI_POS_WIDTH(12), UI_POS_HEIGHT(3)}, "PTT"};
 
@@ -140,11 +135,10 @@ class MorseRadiotxView : public ui::View {
         {{UI_POS_X(9), UI_POS_Y(0)}, "Tone:", Theme::getInstance()->fg_light->foreground},
         {{UI_POS_X(18), UI_POS_Y(0)}, "Hz", Theme::getInstance()->fg_light->foreground},
         {{UI_POS_X(21), UI_POS_Y(0)}, "WPM:", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(0), UI_POS_Y(5)}, "BandW:", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(10), UI_POS_Y(5)}, "kHz", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(0), UI_POS_Y(4)}, "Wait time: ", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(0), UI_POS_Y(7)}, "Last seq:", Theme::getInstance()->fg_light->foreground},
-        {{UI_POS_X(0), UI_POS_Y(8)}, "Sent Message:", Theme::getInstance()->fg_light->foreground},
+        {{UI_POS_X(14), UI_POS_Y(3)}, "BandW:", Theme::getInstance()->fg_light->foreground},
+        {{UI_POS_X(24), UI_POS_Y(3)}, "kHz", Theme::getInstance()->fg_light->foreground},
+        {{UI_POS_X(0), UI_POS_Y(5)}, "Last seq:", Theme::getInstance()->fg_light->foreground},
+        {{UI_POS_X(0), UI_POS_Y(6)}, "Sent Message:", Theme::getInstance()->fg_light->foreground},
         {{UI_POS_X_RIGHT(7), UI_POS_Y_BOTTOM(5)}, "Vol.:", Theme::getInstance()->fg_light->foreground},
     };
 

firmware/application/external/pocsag_tx/ui_pocsag_tx.cpp

@@ -56,8 +56,7 @@ void POCSAGTXView::on_remete(const PocsagTosendMessage data) {
     if (data.function == 'C') tmp = 2;
     if (data.function == 'D') tmp = 3;
     options_function.set_selected_index(tmp);
-    /* 'S' = Standard (CCIR Rec. 584 polarity), 'I' = Inverted */
-    options_polarity.set_selected_index(data.polarity == 'S' ? 0 : 1);
+    options_phase.set_selected_index(data.phase == 'P' ? 0 : 1);
     field_address.set_value(data.addr);
     message = (char*)data.msg;
     buffer = message;
@@ -65,7 +64,7 @@ void POCSAGTXView::on_remete(const PocsagTosendMessage data) {
     options_bitrate.dirty();
     options_type.dirty();
     options_function.dirty();
-    options_polarity.dirty();
+    options_phase.dirty();
     field_address.dirty();
     text_message.dirty();
     tx_view.focus();
@@ -96,34 +95,12 @@ bool POCSAGTXView::start_tx() {
 
     if (type == MessageType::NUMERIC_ONLY) {
         // Check for invalid characters
-        const char* p = message.c_str();
-        bool is_valid = true;
-        while (*p != '\0') {
-            const char c = *p;
-            // Check if char is NOT in the allowed set
-            if (!((c >= '0' && c <= '9') || c == 'S' || c == 'U' ||
-                  c == ' ' || c == '-' || c == '[' || c == ']')) {
-                is_valid = false;
-                break;
-            }
-            p++;
-        }
-        if (!is_valid) {
+        if (message.find_first_not_of("0123456789SU -][") != std::string::npos) {
             nav_.display_modal("Bad message", "A numeric only message must\nonly contain:\n0123456789SU][- or space.");
             return false;
         }
     }
-    /*
-     * TX polarity inversion (CCIR Rec. 584):
-     *
-     * The FSK modulator (proc_fsk.cpp) maps bit 1 to positive deviation.
-     * Standard POCSAG requires bit 1 to negative deviation.
-     *
-     * "Standard" (value 0): invert codewords so that original bit 1 becomes
-     *   bit 0 in the modulator, producing negative deviation. This is the standard.
-     * "Inverted" (value 1): send codewords as-is. Bit 1 produces positive deviation.
-     */
-    bool invert_polarity = (options_polarity.selected_index_value() == 0);
+    MessageType phase = (MessageType)options_phase.selected_index_value();
 
     pocsag_encode(type, BCH_code, options_function.selected_index_value(), message, address, codewords);
 
@@ -141,7 +118,10 @@ bool POCSAGTXView::start_tx() {
 
     bi = 0;
     for (i = 0; i < codewords.size(); i++) {
-        codeword = invert_polarity ? ~(codewords[i]) : codewords[i];
+        if (phase == 0)
+            codeword = ~(codewords[i]);
+        else
+            codeword = codewords[i];
 
         data_ptr[bi++] = (codeword >> 24) & 0xFF;
         data_ptr[bi++] = (codeword >> 16) & 0xFF;
@@ -186,17 +166,15 @@ POCSAGTXView::POCSAGTXView(
                   &field_address,
                   &options_type,
                   &options_function,
-                  &options_polarity,
+                  &options_phase,
                   &text_message,
                   &text_message_l2,
                   &button_message,
                   &progressbar,
                   &tx_view});
 
-    options_bitrate.set_selected_index(1);   // 1200 bps
-    options_type.set_selected_index(2);      // Alphanumeric
-    options_function.set_selected_index(0);  // Function A
-    options_polarity.set_selected_index(0);  // Standard (CCIR Rec. 584)
+    options_bitrate.set_selected_index(1);  // 1200bps
+    options_type.set_selected_index(0);     // Address only
 
     field_address.set_value(persistent_memory::pocsag_last_address());
 

firmware/application/external/pocsag_tx/ui_pocsag_tx.hpp

@@ -84,7 +84,7 @@ class POCSAGTXView : public View {
         {{3 * 8, 6 * 8}, "Address:", Theme::getInstance()->fg_light->foreground},
         {{6 * 8, 8 * 8}, "Type:", Theme::getInstance()->fg_light->foreground},
         {{2 * 8, 10 * 8}, "Function:", Theme::getInstance()->fg_light->foreground},
-        {{2 * 8, 12 * 8}, "Polarity:", Theme::getInstance()->fg_light->foreground},
+        {{5 * 8, 12 * 8}, "Phase:", Theme::getInstance()->fg_light->foreground},
         {{UI_POS_X(0), 14 * 8}, "Message:", Theme::getInstance()->fg_light->foreground}};
 
     OptionsField options_bitrate{
@@ -113,20 +113,12 @@ class POCSAGTXView : public View {
          {"C", 2},
          {"D", 3}}};
 
-    /*
-     * TX polarity (CCIR Rec. 584):
-     *   "Standard" (value 0): bit 1 = negative deviation (CCIR Rec. 584 standard).
-     *              Codewords are bitwise-inverted before the FSK modulator
-     *              because the modulator maps bit 1 to positive deviation.
-     *   "Inverted" (value 1): bit 1 = positive deviation (non-standard).
-     *              Codewords are sent as-is to the modulator.
-     */
-    OptionsField options_polarity{
+    OptionsField options_phase{
         {11 * 8, 12 * 8},
-        8,
+        1,
         {
-            {"Standard", 0},
-            {"Inverted", 1},
+            {"P", 0},
+            {"N", 1},
         }};
 
     Text text_message{

firmware/application/external/sdusb/ui_sd_over_usb.cpp

@@ -45,7 +45,7 @@ SdOverUsbView::SdOverUsbView(NavigationView& nav)
         sdcDisconnect(&SDCD1);
         sdcStop(&SDCD1);
 
-        portapack::shutdown(true, false);
+        portapack::shutdown(true);
         baseband::run_prepared_image(portapack::memory::map::m4_code.base());
         m0_halt();
         /* will not return*/

firmware/application/external/time_sink/ui_time_sink.cpp

@@ -33,7 +33,7 @@ namespace ui::external_app::time_sink {
 
 TimeSinkWaveformWidget::TimeSinkWaveformWidget(
     Rect parent_rect,
-    const int8_t* data,
+    const int16_t* data,
     size_t length,
     Color color)
     : Widget{parent_rect},
@@ -71,10 +71,10 @@ void TimeSinkWaveformWidget::set_persistence_frames(uint8_t frames) {
     }
 }
 
-Coord TimeSinkWaveformWidget::sample_to_y(const Rect& r, int8_t sample) const {
+Coord TimeSinkWaveformWidget::sample_to_y(const Rect& r, int16_t sample) const {
     const int32_t y_center = r.top() + (r.height() / 2);
     const int32_t y_span = std::max<int32_t>(1, r.height() - 1);
-    const int32_t y = y_center - (static_cast<int32_t>(sample) * y_span) / 256;
+    const int32_t y = y_center - (static_cast<int32_t>(sample) * y_span) / 65536;
     return static_cast<Coord>(std::clamp<int32_t>(y, r.top(), r.bottom() - 1));
 }
 
@@ -115,6 +115,7 @@ void TimeSinkWaveformWidget::paint(Painter& painter) {
         current_y_[x] = sample_to_y(r, data_[src_index]);
     }
 
+    // Draw first, then erase stale pixels so the trace never disappears mid-refresh.
     for (size_t x = 0; x < columns; ++x) {
         display.draw_pixel(
             {static_cast<Coord>(r.left() + x), current_y_[x]},
@@ -125,13 +126,13 @@ void TimeSinkWaveformWidget::paint(Painter& painter) {
         const size_t expired_slot = history_head_;
 
         for (size_t x = 0; x < columns; ++x) {
-            const auto expired_y = sample_to_y(r, history_samples_[expired_slot][x]);
+            const auto expired_y = history_y_[expired_slot][x];
             bool keep = (expired_y == current_y_[x]);
 
             if (!keep) {
                 for (size_t i = 1; i < history_count_; ++i) {
                     const size_t slot = (history_head_ + i) % max_persistence_frames;
-                    if (sample_to_y(r, history_samples_[slot][x]) == expired_y) {
+                    if (history_y_[slot][x] == expired_y) {
                         keep = true;
                         break;
                     }
@@ -150,10 +151,7 @@ void TimeSinkWaveformWidget::paint(Painter& painter) {
     }
 
     const size_t tail_slot = (history_head_ + history_count_) % max_persistence_frames;
-    for (size_t x = 0; x < columns; ++x) {
-        const size_t src_index = (x * length_) / columns;
-        history_samples_[tail_slot][x] = data_[src_index];
-    }
+    std::copy_n(current_y_.begin(), columns, history_y_[tail_slot].begin());
     ++history_count_;
 }
 
@@ -340,7 +338,8 @@ void TimeSinkView::on_channel_spectrum(const ChannelSpectrum& spectrum) {
         const size_t src_index =
             (trigger_index + offset) % source_count;
         const int32_t centered = static_cast<int32_t>(spectrum.db[src_index]) - 128;
-        waveform_buffer[x] = static_cast<int8_t>(std::clamp<int32_t>(centered, -128, 127));
+        const int32_t scaled = centered * 256;
+        waveform_buffer[x] = static_cast<int16_t>(std::clamp<int32_t>(scaled, -32768, 32767));
     }
 
     waveform.set_dirty();
@@ -350,4 +349,4 @@ void TimeSinkView::on_freqchg(int64_t freq) {
     field_frequency.set_value(freq);
 }
 
-}  // namespace ui::external_app::time_sink
+}  // namespace ui::external_app::time_sink

firmware/application/external/time_sink/ui_time_sink.hpp

@@ -40,7 +40,7 @@ constexpr size_t time_sink_waveform_points = 240;
 
 class TimeSinkWaveformWidget : public Widget {
    public:
-    TimeSinkWaveformWidget(Rect parent_rect, const int8_t* data, size_t length, Color color);
+    TimeSinkWaveformWidget(Rect parent_rect, const int16_t* data, size_t length, Color color);
     TimeSinkWaveformWidget(const TimeSinkWaveformWidget&) = delete;
     TimeSinkWaveformWidget(TimeSinkWaveformWidget&&) = delete;
     TimeSinkWaveformWidget& operator=(const TimeSinkWaveformWidget&) = delete;
@@ -56,13 +56,13 @@ class TimeSinkWaveformWidget : public Widget {
     static constexpr size_t max_persistence_frames = 16;  // this is sad that we cant have 32 histories in ext app due to memory constraints
 
     void reset_cache();
-    Coord sample_to_y(const Rect& r, int8_t sample) const;
+    Coord sample_to_y(const Rect& r, int16_t sample) const;
 
-    const int8_t* data_;
+    const int16_t* data_;
     size_t length_;
     Color color_;
     std::array<Coord, max_columns> current_y_{};
-    std::array<std::array<int8_t, max_columns>, max_persistence_frames> history_samples_{};
+    std::array<std::array<Coord, max_columns>, max_persistence_frames> history_y_{};
     size_t history_count_{0};
     size_t history_head_{0};
     uint8_t persistence_frames_{1};
@@ -120,7 +120,7 @@ class TimeSinkView : public View {
             {"trigger_level"sv, &trigger_level},
         }};
 
-    int8_t waveform_buffer[waveform_points]{0};
+    int16_t waveform_buffer[waveform_points]{0};
     ChannelSpectrumFIFO* fifo = nullptr;
 
     Labels labels{
@@ -235,4 +235,4 @@ class TimeSinkView : public View {
 
 }  // namespace ui::external_app::time_sink
 
-#endif  // __UI_TIME_SINK_APP_H__
+#endif  // __UI_TIME_SINK_APP_H__

firmware/application/external/two_tone_pager/main.cpp

@@ -1,86 +0,0 @@
-/*
- * Copyright (C) 2024 PortaPack Mayhem
- *
- * This file is part of PortaPack.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2, or (at your option)
- * any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street,
- * Boston, MA 02110-1301, USA.
- */
-
-#include "ui.hpp"
-#include "ui_two_tone_pager.hpp"
-#include "ui_navigation.hpp"
-#include "external_app.hpp"
-
-namespace ui::external_app::two_tone_pager {
-void initialize_app(ui::NavigationView& nav) {
-    nav.push<TwoTonePagerView>();
-}
-}  // namespace ui::external_app::two_tone_pager
-
-extern "C" {
-
-__attribute__((section(".external_app.app_two_tone_pager.application_information"), used)) application_information_t _application_information_two_tone_pager = {
-    /*.memory_location = */ (uint8_t*)0x00000000,
-    /*.externalAppEntry = */ ui::external_app::two_tone_pager::initialize_app,
-    /*.header_version = */ CURRENT_HEADER_VERSION,
-    /*.app_version = */ VERSION_MD5,
-
-    /*.app_name = */ "2-Tone TX",
-    /*.bitmap_data = */ {
-        // 16×16 pager icon — two-tone radio / pager device
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0xFC,
-        0x3F,
-        0xFE,
-        0x7F,
-        0x02,
-        0x40,
-        0xBA,
-        0x45,
-        0x02,
-        0x40,
-        0xFE,
-        0x7F,
-        0xFE,
-        0x7F,
-        0x92,
-        0x7C,
-        0x92,
-        0x7C,
-        0xFC,
-        0x3F,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-    },
-    /*.icon_color = */ ui::Color::orange().v,
-    /*.menu_location = */ app_location_t::TX,
-    /*.desired_menu_position = */ -1,
-
-    // Uses the proc_tones baseband processor (same as Morse TX)
-    /*.m4_app_tag = portapack::spi_flash::image_tag_tones */ {'P', 'T', 'O', 'N'},
-    /*.m4_app_offset = */ 0x00000000,  // filled at compile time
-};
-
-}  // extern "C"

firmware/application/external/two_tone_pager/ui_two_tone_pager.cpp

@@ -1,616 +0,0 @@
-/*
- * Copyright (C) 2024 PortaPack Mayhem
- *
- * This file is part of PortaPack.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2, or (at your option)
- * any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street,
- * Boston, MA 02110-1301, USA.
- */
-
-#include "ui_two_tone_pager.hpp"
-
-#include "portapack.hpp"
-#include "baseband_api.hpp"
-#include "portapack_shared_memory.hpp"
-#include "string_format.hpp"
-#include "theme.hpp"
-
-#include <algorithm>
-#include <cstring>
-
-using namespace portapack;
-
-namespace ui::external_app::two_tone_pager {
-
-// ---------------------------------------------------------------------------
-// Tone tables — store only freq×10 values; names are generated at runtime
-// to keep static data small and avoid const-char-pointer patching issues.
-// ---------------------------------------------------------------------------
-
-static const uint32_t MOTO_FREQS[45] = {
-    2885,
-    3047,
-    3217,
-    3396,
-    3586,
-    3786,
-    3998,
-    4221,
-    4457,
-    4705,
-    4968,
-    5246,
-    5539,
-    5848,
-    6174,
-    6519,
-    6883,
-    7268,
-    7674,
-    8102,
-    8555,
-    9032,
-    9537,
-    10073,
-    10642,
-    11225,
-    11247,
-    11534,
-    11852,
-    11885,
-    12178,
-    12514,
-    12555,
-    12858,
-    13258,
-    13576,
-    13950,
-    13996,
-    14768,
-    15579,
-    16430,
-    17325,
-    18262,
-    19245,
-    20275,
-};
-
-// Index 0 = None (0), indices 1-50 = standard CTCSS tones
-static const uint32_t CTCSS_FREQS[51] = {
-    0,
-    670,
-    719,
-    744,
-    770,
-    797,
-    825,
-    854,
-    885,
-    915,
-    948,
-    974,
-    1000,
-    1035,
-    1072,
-    1109,
-    1148,
-    1188,
-    1230,
-    1273,
-    1318,
-    1365,
-    1413,
-    1462,
-    1500,
-    1514,
-    1567,
-    1598,
-    1622,
-    1655,
-    1679,
-    1713,
-    1738,
-    1773,
-    1799,
-    1835,
-    1862,
-    1899,
-    1928,
-    1966,
-    1995,
-    2035,
-    2065,
-    2107,
-    2181,
-    2257,
-    2291,
-    2336,
-    2418,
-    2503,
-    2541,
-};
-
-// Generate a display name from a freq×10 value ("288.5Hz", "None" for 0)
-static std::string freq_name(uint32_t freq_x10) {
-    if (freq_x10 == 0) return "None";
-    return to_string_dec_uint(freq_x10 / 10) + "." +
-           to_string_dec_uint(freq_x10 % 10) + "Hz";
-}
-
-// Common timing profiles used in the field
-struct TimingPreset {
-    uint32_t dur_a;  // ms
-    uint32_t dur_b;  // ms
-    uint32_t gap;    // ms
-};
-
-static const TimingPreset TIMING_PRESETS[4] = {
-    {1000, 3000, 0},  // Moto Std
-    {700, 1000, 0},   // Short Alert
-    {2000, 1000, 0},  // Fire Std
-    {3000, 3000, 0},  // Long Alert
-};
-
-// ---------------------------------------------------------------------------
-// Helpers
-// ---------------------------------------------------------------------------
-
-// Parse one unsigned decimal integer from *p, advancing p past the digits and
-// an optional trailing comma.
-static uint32_t parse_uint_field(const char*& p) {
-    uint32_t v = 0;
-    while (*p >= '0' && *p <= '9')
-        v = v * 10 + (*p++ - '0');
-    if (*p == ',')
-        ++p;
-    return v;
-}
-
-// Phase-delta for the 32-bit sine-table accumulator used by proc_tones.
-// delta = freq_hz * 2^32 / sample_rate
-// Using freq_x10 to avoid floating-point: delta = (freq_x10 * 2^32) / (sample_rate * 10)
-uint32_t TwoTonePagerView::tone_delta(uint32_t freq_x10) const {
-    if (freq_x10 == 0) return 0;
-    return static_cast<uint32_t>(
-        (static_cast<uint64_t>(freq_x10) << 32) /
-        (static_cast<uint64_t>(SAMPLE_RATE) * 10ULL));
-}
-
-uint32_t TwoTonePagerView::ms_to_samples(uint32_t ms) const {
-    return static_cast<uint32_t>(
-        (static_cast<uint64_t>(ms) * SAMPLE_RATE) / 1000ULL);
-}
-
-// ---------------------------------------------------------------------------
-// Preset encode / decode
-// ---------------------------------------------------------------------------
-
-std::string TwoTonePagerView::encode_preset() const {
-    return to_string_dec_uint(ctcss_idx) + "," +
-           to_string_dec_uint(tone_a_idx) + "," +
-           to_string_dec_uint(tone_b_idx) + "," +
-           to_string_dec_uint(dur_a) + "," +
-           to_string_dec_uint(dur_b) + "," +
-           to_string_dec_uint(gap_ms) + "," +
-           to_string_dec_uint(custom_freq_a_hz) + "," +
-           to_string_dec_uint(custom_freq_b_hz);
-}
-
-void TwoTonePagerView::decode_preset(const std::string& s) {
-    const char* p = s.c_str();
-    uint32_t ci = parse_uint_field(p);
-    uint32_t ai = parse_uint_field(p);
-    uint32_t bi = parse_uint_field(p);
-    uint32_t da = parse_uint_field(p);
-    uint32_t db = parse_uint_field(p);
-    uint32_t gp = parse_uint_field(p);
-
-    uint32_t cfa = (*p != '\0') ? parse_uint_field(p) : 405;
-    uint32_t cfb = (*p != '\0') ? parse_uint_field(p) : 814;
-
-    ctcss_idx = std::min(ci, static_cast<uint32_t>(CTCSS_COUNT - 1));
-    tone_a_idx = std::min(ai, CUSTOM_TONE_IDX);
-    tone_b_idx = std::min(bi, CUSTOM_TONE_IDX);
-    dur_a = std::max(uint32_t{100}, std::min(da, uint32_t{9900}));
-    dur_b = std::max(uint32_t{100}, std::min(db, uint32_t{9900}));
-    gap_ms = std::min(gp, uint32_t{9900});
-    custom_freq_a_hz = std::max(uint32_t{100}, std::min(cfa, uint32_t{9999}));
-    custom_freq_b_hz = std::max(uint32_t{100}, std::min(cfb, uint32_t{9999}));
-}
-
-std::string& TwoTonePagerView::slot_ref(uint32_t slot) {
-    switch (slot) {
-        case 2:
-            return preset_2;
-        case 3:
-            return preset_3;
-        case 4:
-            return preset_4;
-        case 5:
-            return preset_5;
-        default:
-            return preset_1;
-    }
-}
-
-std::string& TwoTonePagerView::slot_name_ref(uint32_t slot) {
-    switch (slot) {
-        case 2:
-            return preset_name_2;
-        case 3:
-            return preset_name_3;
-        case 4:
-            return preset_name_4;
-        case 5:
-            return preset_name_5;
-        default:
-            return preset_name_1;
-    }
-}
-
-void TwoTonePagerView::update_slot_name_display() {
-    const auto& name = slot_name_ref(preset_slot);
-    std::string display = name.empty() ? "(none)" : name;
-    if (display.size() > 8) display = display.substr(0, 8);
-    text_slot_name.set(display);
-}
-
-void TwoTonePagerView::save_preset(uint32_t slot) {
-    slot_ref(slot) = encode_preset();
-    text_status.set("Saved to slot " + to_string_dec_uint(slot));
-}
-
-void TwoTonePagerView::load_preset(uint32_t slot) {
-    decode_preset(slot_ref(slot));
-
-    // Update all UI fields without firing their on_change callbacks
-    options_ctcss.set_selected_index(ctcss_idx, false);
-    options_tone_a.set_selected_index(tone_a_idx, false);
-    options_tone_b.set_selected_index(tone_b_idx, false);
-    field_dur_a.set_value(static_cast<int32_t>(dur_a), false);
-    field_dur_b.set_value(static_cast<int32_t>(dur_b), false);
-    field_gap.set_value(static_cast<int32_t>(gap_ms), false);
-    symfield_custom_a.set_value(custom_freq_a_hz);
-    symfield_custom_b.set_value(custom_freq_b_hz);
-    options_timing.set_selected_index(detect_timing_preset(), false);
-
-    update_tx_time();
-    update_slot_name_display();
-    text_status.set("Loaded slot " + to_string_dec_uint(slot));
-}
-
-// ---------------------------------------------------------------------------
-// Timing presets
-// ---------------------------------------------------------------------------
-
-size_t TwoTonePagerView::detect_timing_preset() const {
-    for (size_t i = 0; i < 4; i++) {
-        if (TIMING_PRESETS[i].dur_a == dur_a &&
-            TIMING_PRESETS[i].dur_b == dur_b &&
-            TIMING_PRESETS[i].gap == gap_ms)
-            return i;
-    }
-    return 4;  // "Custom"
-}
-
-void TwoTonePagerView::apply_timing_preset(size_t idx) {
-    if (idx >= 4) return;  // "Custom" — do not override current values
-    dur_a = TIMING_PRESETS[idx].dur_a;
-    dur_b = TIMING_PRESETS[idx].dur_b;
-    gap_ms = TIMING_PRESETS[idx].gap;
-    field_dur_a.set_value(static_cast<int32_t>(dur_a), false);
-    field_dur_b.set_value(static_cast<int32_t>(dur_b), false);
-    field_gap.set_value(static_cast<int32_t>(gap_ms), false);
-    update_tx_time();
-}
-
-// ---------------------------------------------------------------------------
-// UI helpers
-// ---------------------------------------------------------------------------
-
-void TwoTonePagerView::update_tx_time() {
-    uint32_t total_ms = dur_a + gap_ms + dur_b;
-    std::string name_a = (tone_a_idx == CUSTOM_TONE_IDX)
-                             ? to_string_dec_uint(custom_freq_a_hz) + "Hz"
-                             : freq_name(MOTO_FREQS[tone_a_idx]);
-    std::string name_b = (tone_b_idx == CUSTOM_TONE_IDX)
-                             ? to_string_dec_uint(custom_freq_b_hz) + "Hz"
-                             : freq_name(MOTO_FREQS[tone_b_idx]);
-    text_time.set("TX time: " +
-                  to_string_dec_uint(total_ms / 1000) + "." +
-                  to_string_dec_uint((total_ms / 100) % 10) + "s" +
-                  "  A:" + name_a + " B:" + name_b);
-}
-
-// ---------------------------------------------------------------------------
-// Transmission
-// ---------------------------------------------------------------------------
-
-bool TwoTonePagerView::start_tx() {
-    auto& td = shared_memory.bb_data.tones_data;
-
-    const uint32_t freq_a_x10 = (tone_a_idx == CUSTOM_TONE_IDX)
-                                    ? custom_freq_a_hz * 10
-                                    : MOTO_FREQS[tone_a_idx];
-    const uint32_t freq_b_x10 = (tone_b_idx == CUSTOM_TONE_IDX)
-                                    ? custom_freq_b_hz * 10
-                                    : MOTO_FREQS[tone_b_idx];
-    const uint32_t delta_a = tone_delta(freq_a_x10);
-    const uint32_t delta_b = tone_delta(freq_b_x10);
-    const uint32_t delta_c = tone_delta(CTCSS_FREQS[ctcss_idx]);
-    const uint32_t samp_a = ms_to_samples(dur_a);
-    const uint32_t samp_b = ms_to_samples(dur_b);
-    const uint32_t samp_g = ms_to_samples(gap_ms);
-    const bool with_ctcss = (ctcss_idx > 0);
-
-    // Clear tone defs we'll use
-    memset(&td, 0, sizeof(td));
-
-    uint8_t tone_count;
-
-    if (!with_ctcss) {
-        // Single-tone sequential mode
-        // tone_defs[0] = Tone A,  tone_defs[1] = Tone B
-        td.tone_defs[0].delta = delta_a;
-        td.tone_defs[0].duration = samp_a;
-        td.tone_defs[1].delta = delta_b;
-        td.tone_defs[1].duration = samp_b;
-
-        if (gap_ms > 0) {
-            td.silence = samp_g;
-            td.message[0] = 0;    // Tone A
-            td.message[1] = 255;  // Silence (any index ≥ 32 triggers silence)
-            td.message[2] = 1;    // Tone B
-            tone_count = 3;
-        } else {
-            td.message[0] = 0;  // Tone A
-            td.message[1] = 1;  // Tone B
-            tone_count = 2;
-        }
-    } else {
-        // Dual-tone mode: CTCSS mixed simultaneously with pager tones.
-        //
-        // proc_tones dual-tone indexing for digit n:
-        //   main delta = tone_deltas[n * 2]   = tone_defs[n*2].delta
-        //   sub  delta = tone_deltas[n*2 + 1] = tone_defs[n*2+1].delta
-        //   duration   = tone_durations[n]    = tone_defs[n].duration
-        //
-        // digit 0 → Tone A (main) + CTCSS (sub),  duration from tone_defs[0]
-        // digit 1 → Tone B (main) + CTCSS (sub),  duration from tone_defs[1]
-        td.tone_defs[0].delta = delta_a;  // digit 0 main
-        td.tone_defs[0].duration = samp_a;
-        td.tone_defs[1].delta = delta_c;  // digit 0 sub (CTCSS); also digit 1 duration source
-        td.tone_defs[1].duration = samp_b;
-        td.tone_defs[2].delta = delta_b;  // digit 1 main (Tone B)
-        td.tone_defs[2].duration = 0;     // duration for digit 1 comes from tone_defs[1]
-        td.tone_defs[3].delta = delta_c;  // digit 1 sub (CTCSS)
-        td.tone_defs[3].duration = 0;
-
-        if (gap_ms > 0) {
-            td.silence = samp_g;
-            td.message[0] = 0;
-            td.message[1] = 255;
-            td.message[2] = 1;
-            tone_count = 3;
-        } else {
-            td.message[0] = 0;
-            td.message[1] = 1;
-            tone_count = 2;
-        }
-    }
-
-    progressbar.set_max(tone_count);
-    progressbar.set_value(0);
-
-    transmitter_model.set_baseband_bandwidth(1'750'000);
-    transmitter_model.enable();
-
-    baseband::set_tones_config(
-        transmitter_model.channel_bandwidth(),
-        0,  // no pre-silence
-        tone_count,
-        with_ctcss,  // dual_tone flag
-        false);      // no audio monitor output
-
-    return true;
-}
-
-void TwoTonePagerView::stop_tx() {
-    transmitter_model.disable();
-    baseband::kill_tone();
-    tx_view.set_transmitting(false);
-    text_status.set("Stopped.");
-}
-
-void TwoTonePagerView::on_tx_progress(uint32_t progress, bool done) {
-    if (done) {
-        transmitter_model.disable();
-        progressbar.set_value(0);
-        tx_view.set_transmitting(false);
-        text_status.set("Done.");
-    } else {
-        progressbar.set_value(progress);
-    }
-}
-
-// ---------------------------------------------------------------------------
-// View lifecycle
-// ---------------------------------------------------------------------------
-
-void TwoTonePagerView::focus() {
-    options_tone_a.focus();
-}
-
-TwoTonePagerView::~TwoTonePagerView() {
-    transmitter_model.disable();
-    baseband::shutdown();
-}
-
-TwoTonePagerView::TwoTonePagerView(NavigationView& nav)
-    : nav_(nav) {
-    baseband::run_prepared_image(portapack::memory::map::m4_code.base());
-
-    // Clamp restored settings to valid ranges before touching UI
-    ctcss_idx = std::min(ctcss_idx, static_cast<uint32_t>(CTCSS_COUNT - 1));
-    tone_a_idx = std::min(tone_a_idx, CUSTOM_TONE_IDX);
-    tone_b_idx = std::min(tone_b_idx, CUSTOM_TONE_IDX);
-    dur_a = std::max(uint32_t{100}, std::min(dur_a, uint32_t{9900}));
-    dur_b = std::max(uint32_t{100}, std::min(dur_b, uint32_t{9900}));
-    gap_ms = std::min(gap_ms, uint32_t{9900});
-    preset_slot = std::max(uint32_t{1}, std::min(preset_slot, uint32_t{5}));
-    custom_freq_a_hz = std::max(uint32_t{100}, std::min(custom_freq_a_hz, uint32_t{9999}));
-    custom_freq_b_hz = std::max(uint32_t{100}, std::min(custom_freq_b_hz, uint32_t{9999}));
-
-    // Build CTCSS options list
-    {
-        std::vector<std::pair<std::string, int32_t>> opts;
-        opts.reserve(CTCSS_COUNT);
-        for (size_t i = 0; i < CTCSS_COUNT; i++)
-            opts.push_back({freq_name(CTCSS_FREQS[i]), static_cast<int32_t>(i)});
-        options_ctcss.set_options(std::move(opts));
-    }
-
-    // Build Motorola tone options (same pool for both A and B); "Custom" appended
-    {
-        std::vector<std::pair<std::string, int32_t>> opts;
-        opts.reserve(MOTO_TONE_COUNT + 1);
-        for (size_t i = 0; i < MOTO_TONE_COUNT; i++)
-            opts.push_back({freq_name(MOTO_FREQS[i]), static_cast<int32_t>(i)});
-        opts.push_back({"Custom", static_cast<int32_t>(CUSTOM_TONE_IDX)});
-        options_tone_a.set_options(opts);
-        options_tone_b.set_options(std::move(opts));
-    }
-
-    add_children({&labels,
-                  &options_ctcss,
-                  &options_tone_a,
-                  &options_tone_b,
-                  &symfield_custom_a,
-                  &symfield_custom_b,
-                  &field_dur_a,
-                  &field_dur_b,
-                  &field_gap,
-                  &options_timing,
-                  &field_slot,
-                  &button_save,
-                  &button_load,
-                  &text_slot_name,
-                  &text_time,
-                  &text_status,
-                  &progressbar,
-                  &tx_view});
-
-    // Restore saved indices into the options / number fields (no callbacks)
-    options_ctcss.set_selected_index(ctcss_idx, false);
-    options_tone_a.set_selected_index(tone_a_idx, false);
-    options_tone_b.set_selected_index(tone_b_idx, false);
-    symfield_custom_a.set_value(custom_freq_a_hz);
-    symfield_custom_b.set_value(custom_freq_b_hz);
-    field_dur_a.set_value(static_cast<int32_t>(dur_a), false);
-    field_dur_b.set_value(static_cast<int32_t>(dur_b), false);
-    field_gap.set_value(static_cast<int32_t>(gap_ms), false);
-    options_timing.set_selected_index(detect_timing_preset(), false);
-    field_slot.set_value(static_cast<int32_t>(preset_slot), false);
-
-    update_tx_time();
-    update_slot_name_display();
-
-    // --- Callbacks ---
-
-    options_ctcss.on_change = [this](size_t i, int32_t) {
-        ctcss_idx = static_cast<uint32_t>(i);
-    };
-
-    options_tone_a.on_change = [this](size_t i, int32_t) {
-        tone_a_idx = static_cast<uint32_t>(i);
-        update_tx_time();
-    };
-
-    options_tone_b.on_change = [this](size_t i, int32_t) {
-        tone_b_idx = static_cast<uint32_t>(i);
-        update_tx_time();
-    };
-
-    symfield_custom_a.on_change = [this](SymField&) {
-        uint32_t v = static_cast<uint32_t>(symfield_custom_a.to_integer());
-        custom_freq_a_hz = std::max(uint32_t{100}, std::min(v, uint32_t{9999}));
-        update_tx_time();
-    };
-
-    symfield_custom_b.on_change = [this](SymField&) {
-        uint32_t v = static_cast<uint32_t>(symfield_custom_b.to_integer());
-        custom_freq_b_hz = std::max(uint32_t{100}, std::min(v, uint32_t{9999}));
-        update_tx_time();
-    };
-
-    field_dur_a.on_change = [this](int32_t v) {
-        dur_a = static_cast<uint32_t>(v);
-        options_timing.set_selected_index(detect_timing_preset(), false);
-        update_tx_time();
-    };
-
-    field_dur_b.on_change = [this](int32_t v) {
-        dur_b = static_cast<uint32_t>(v);
-        options_timing.set_selected_index(detect_timing_preset(), false);
-        update_tx_time();
-    };
-
-    field_gap.on_change = [this](int32_t v) {
-        gap_ms = static_cast<uint32_t>(v);
-        options_timing.set_selected_index(detect_timing_preset(), false);
-        update_tx_time();
-    };
-
-    options_timing.on_change = [this](size_t i, int32_t) {
-        apply_timing_preset(i);
-    };
-
-    field_slot.on_change = [this](int32_t v) {
-        preset_slot = static_cast<uint32_t>(v);
-        update_slot_name_display();
-    };
-
-    button_save.on_select = [this](Button&) {
-        text_prompt(nav_, slot_name_ref(preset_slot), 12, ENTER_KEYBOARD_MODE_ALPHA,
-                    [this](std::string&) {
-                        save_preset(preset_slot);
-                        update_slot_name_display();
-                    });
-    };
-
-    button_load.on_select = [this](Button&) {
-        load_preset(preset_slot);
-    };
-
-    tx_view.on_edit_frequency = [this, &nav]() {
-        auto new_view = nav.push<FrequencyKeypadView>(transmitter_model.target_frequency());
-        new_view->on_changed = [this](rf::Frequency f) {
-            transmitter_model.set_target_frequency(f);
-        };
-    };
-
-    tx_view.on_start = [this]() {
-        if (start_tx()) {
-            tx_view.set_transmitting(true);
-            text_status.set("Transmitting...");
-        }
-    };
-
-    tx_view.on_stop = [this]() {
-        stop_tx();
-    };
-}
-
-}  // namespace ui::external_app::two_tone_pager

firmware/application/external/two_tone_pager/ui_two_tone_pager.hpp

@@ -1,250 +0,0 @@
-/*
- * Copyright (C) 2024 PortaPack Mayhem
- *
- * This file is part of PortaPack.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2, or (at your option)
- * any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street,
- * Boston, MA 02110-1301, USA.
- */
-
-#ifndef __UI_TWO_TONE_PAGER_H__
-#define __UI_TWO_TONE_PAGER_H__
-
-#include "ui.hpp"
-#include "ui_widget.hpp"
-#include "ui_navigation.hpp"
-#include "ui_transmitter.hpp"
-#include "ui_textentry.hpp"
-#include "app_settings.hpp"
-#include "radio_state.hpp"
-#include "portapack.hpp"
-#include "message.hpp"
-#include "string_format.hpp"
-
-namespace ui::external_app::two_tone_pager {
-
-class TwoTonePagerView : public View {
-   public:
-    TwoTonePagerView(NavigationView& nav);
-    ~TwoTonePagerView();
-
-    TwoTonePagerView(const TwoTonePagerView&) = delete;
-    TwoTonePagerView(TwoTonePagerView&&) = delete;
-    TwoTonePagerView& operator=(const TwoTonePagerView&) = delete;
-    TwoTonePagerView& operator=(TwoTonePagerView&&) = delete;
-
-    void focus() override;
-    std::string title() const override { return "2-Tone TX"; };
-
-   private:
-    NavigationView& nav_;
-
-    static constexpr uint32_t SAMPLE_RATE = 1536000;
-    static constexpr size_t MOTO_TONE_COUNT = 45;
-    static constexpr size_t CTCSS_COUNT = 51;
-    static constexpr uint32_t CUSTOM_TONE_IDX = MOTO_TONE_COUNT;  // sentinel: one past the table, use custom Hz field
-
-    TxRadioState radio_state_{
-        154280000ULL,  // 154.280 MHz — common VHF paging frequency
-        1750000,
-        SAMPLE_RATE};
-
-    // Persisted settings
-    uint32_t ctcss_idx{0};
-    uint32_t tone_a_idx{8};   // 405.3 Hz
-    uint32_t tone_b_idx{24};  // 813.9 Hz
-    uint32_t dur_a{1000};
-    uint32_t dur_b{3000};
-    uint32_t gap_ms{0};
-    uint32_t preset_slot{1};
-    uint32_t custom_freq_a_hz{405};  // used when tone_a_idx == CUSTOM_TONE_IDX
-    uint32_t custom_freq_b_hz{814};
-
-    // Five preset slots — encoded tone/timing data and a user-chosen display name
-    std::string preset_1{"0,8,24,1000,3000,0"};
-    std::string preset_2{"0,8,24,1000,3000,0"};
-    std::string preset_3{"0,8,24,1000,3000,0"};
-    std::string preset_4{"0,8,24,1000,3000,0"};
-    std::string preset_5{"0,8,24,1000,3000,0"};
-    std::string preset_name_1{""};
-    std::string preset_name_2{""};
-    std::string preset_name_3{""};
-    std::string preset_name_4{""};
-    std::string preset_name_5{""};
-
-    app_settings::SettingsManager settings_{
-        "tx_twotone",
-        app_settings::Mode::TX,
-        {
-            {"ctcss"sv, &ctcss_idx},
-            {"tone_a"sv, &tone_a_idx},
-            {"tone_b"sv, &tone_b_idx},
-            {"dur_a"sv, &dur_a},
-            {"dur_b"sv, &dur_b},
-            {"gap"sv, &gap_ms},
-            {"slot"sv, &preset_slot},
-            {"custom_a"sv, &custom_freq_a_hz},
-            {"custom_b"sv, &custom_freq_b_hz},
-            {"preset1"sv, &preset_1},
-            {"preset2"sv, &preset_2},
-            {"preset3"sv, &preset_3},
-            {"preset4"sv, &preset_4},
-            {"preset5"sv, &preset_5},
-            {"pname1"sv, &preset_name_1},
-            {"pname2"sv, &preset_name_2},
-            {"pname3"sv, &preset_name_3},
-            {"pname4"sv, &preset_name_4},
-            {"pname5"sv, &preset_name_5},
-        }};
-
-    bool start_tx();
-    void stop_tx();
-    void on_tx_progress(uint32_t progress, bool done);
-    void apply_timing_preset(size_t idx);
-    void save_preset(uint32_t slot);
-    void load_preset(uint32_t slot);
-    std::string encode_preset() const;
-    void decode_preset(const std::string& s);
-    std::string& slot_ref(uint32_t slot);
-    std::string& slot_name_ref(uint32_t slot);
-    uint32_t tone_delta(uint32_t freq_x10) const;
-    uint32_t ms_to_samples(uint32_t ms) const;
-    size_t detect_timing_preset() const;
-    void update_tx_time();
-    void update_slot_name_display();
-
-    // --- Widgets ---
-
-    Labels labels{
-        {{0 * 8, 1 * 16}, "CTCSS:", Theme::getInstance()->fg_light->foreground},
-        {{0 * 8, 2 * 16}, "A:", Theme::getInstance()->fg_light->foreground},
-        {{13 * 8, 2 * 16}, "B:", Theme::getInstance()->fg_light->foreground},
-        {{0 * 8, 3 * 16}, "ADur:", Theme::getInstance()->fg_light->foreground},
-        {{9 * 8, 3 * 16}, "ms", Theme::getInstance()->fg_light->foreground},
-        {{12 * 8, 3 * 16}, "BDur:", Theme::getInstance()->fg_light->foreground},
-        {{21 * 8, 3 * 16}, "ms", Theme::getInstance()->fg_light->foreground},
-        {{0 * 8, 4 * 16}, "Gap: ", Theme::getInstance()->fg_light->foreground},
-        {{9 * 8, 4 * 16}, "ms", Theme::getInstance()->fg_light->foreground},
-        {{0 * 8, 5 * 16}, "Timing:", Theme::getInstance()->fg_light->foreground},
-        {{0 * 8, 6 * 16}, "Slot: ", Theme::getInstance()->fg_light->foreground},
-        {{0 * 8, 9 * 16}, "AHz:", Theme::getInstance()->fg_light->foreground},
-        {{8 * 8, 9 * 16}, "Hz", Theme::getInstance()->fg_light->foreground},
-        {{13 * 8, 9 * 16}, "BHz:", Theme::getInstance()->fg_light->foreground},
-        {{21 * 8, 9 * 16}, "Hz", Theme::getInstance()->fg_light->foreground},
-    };
-
-    OptionsField options_ctcss{
-        {7 * 8, 1 * 16},
-        9,
-        {}};
-
-    OptionsField options_tone_a{
-        {3 * 8, 2 * 16},
-        9,
-        {}};
-
-    OptionsField options_tone_b{
-        {16 * 8, 2 * 16},
-        9,
-        {}};
-
-    NumberField field_dur_a{
-        {5 * 8, 3 * 16},
-        4,
-        {100, 9900},
-        100,
-        ' '};
-
-    NumberField field_dur_b{
-        {17 * 8, 3 * 16},
-        4,
-        {100, 9900},
-        100,
-        ' '};
-
-    // Digit-by-digit entry for custom tone frequency (integer Hz, 4 slots, 0100–9999)
-    SymField symfield_custom_a{
-        {4 * 8, 9 * 16},
-        4,
-        SymField::Type::Dec};
-
-    SymField symfield_custom_b{
-        {17 * 8, 9 * 16},
-        4,
-        SymField::Type::Dec};
-
-    NumberField field_gap{
-        {5 * 8, 4 * 16},
-        4,
-        {0, 9900},
-        50,
-        ' '};
-
-    OptionsField options_timing{
-        {8 * 8, 5 * 16},
-        12,
-        {{"Moto Std", 0},
-         {"Short Alert", 1},
-         {"Fire Std", 2},
-         {"Long Alert", 3},
-         {"Custom", 4}}};
-
-    NumberField field_slot{
-        {7 * 8, 6 * 16},
-        1,
-        {1, 5},
-        1,
-        ' '};
-
-    Button button_save{
-        {9 * 8, 6 * 16, 6 * 8, 20},
-        "Save"};
-
-    Button button_load{
-        {16 * 8, 6 * 16, 6 * 8, 20},
-        "Load"};
-
-    // Shows the name of the currently selected preset slot (up to 8 visible chars)
-    Text text_slot_name{
-        {22 * 8, 6 * 16, 8 * 8, 16},
-        ""};
-
-    Text text_time{
-        {0, 7 * 16, 30 * 8, 16},
-        ""};
-
-    Text text_status{
-        {0, 8 * 16, 30 * 8, 16},
-        ""};
-
-    ProgressBar progressbar{
-        {2 * 8, 14 * 16, UI_POS_WIDTH_REMAINING(4), 16}};
-
-    TransmitterView tx_view{
-        (int16_t)UI_POS_Y_BOTTOM(4),
-        10000,
-        9};
-
-    MessageHandlerRegistration message_handler_tx_progress{
-        Message::ID::TXProgress,
-        [this](const Message* const p) {
-            const auto msg = *reinterpret_cast<const TXProgressMessage*>(p);
-            this->on_tx_progress(msg.progress, msg.done);
-        }};
-};
-
-}  // namespace ui::external_app::two_tone_pager
-
-#endif /* __UI_TWO_TONE_PAGER_H__ */

firmware/application/external/two_tone_rx/main.cpp

@@ -1,86 +0,0 @@
-/*
- * Copyright (C) 2024 PortaPack Mayhem
- *
- * This file is part of PortaPack.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2, or (at your option)
- * any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street,
- * Boston, MA 02110-1301, USA.
- */
-
-#include "ui.hpp"
-#include "ui_two_tone_rx.hpp"
-#include "ui_navigation.hpp"
-#include "external_app.hpp"
-
-namespace ui::external_app::two_tone_rx {
-void initialize_app(ui::NavigationView& nav) {
-    nav.push<TwoToneRxView>();
-}
-}  // namespace ui::external_app::two_tone_rx
-
-extern "C" {
-
-__attribute__((section(".external_app.app_two_tone_rx.application_information"), used)) application_information_t _application_information_two_tone_rx = {
-    /*.memory_location = */ (uint8_t*)0x00000000,
-    /*.externalAppEntry = */ ui::external_app::two_tone_rx::initialize_app,
-    /*.header_version = */ CURRENT_HEADER_VERSION,
-    /*.app_version = */ VERSION_MD5,
-
-    /*.app_name = */ "2-Tone RX",
-    /*.bitmap_data = */ {
-        // 16×16 icon — pager device with receive arrow
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0xFC,
-        0x3F,
-        0xFE,
-        0x7F,
-        0x02,
-        0x40,
-        0xBA,
-        0x5D,
-        0x02,
-        0x40,
-        0xFE,
-        0x7F,
-        0xFE,
-        0x7F,
-        0x12,
-        0x48,
-        0x12,
-        0x48,
-        0xFC,
-        0x3F,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-        0x00,
-    },
-    /*.icon_color = */ ui::Color::yellow().v,
-    /*.menu_location = */ app_location_t::RX,
-    /*.desired_menu_position = */ -1,
-
-    // Uses the proc_tonedetect baseband processor
-    /*.m4_app_tag = portapack::spi_flash::image_tag_tonedetect */ {'P', 'T', 'N', 'E'},
-    /*.m4_app_offset = */ 0x00000000,  // filled at compile time
-};
-
-}  // extern "C"

firmware/application/external/two_tone_rx/ui_two_tone_rx.cpp

@@ -1,599 +0,0 @@
-/*
- * Copyright (C) 2024 PortaPack Mayhem
- *
- * This file is part of PortaPack.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2, or (at your option)
- * any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street,
- * Boston, MA 02110-1301, USA.
- */
-
-#include "ui_two_tone_rx.hpp"
-#include "audio.hpp"
-#include "baseband_api.hpp"
-#include "portapack.hpp"
-#include "string_format.hpp"
-
-using namespace portapack;
-
-namespace ui::external_app::two_tone_rx {
-
-static constexpr uint32_t DETECT_WINDOW_MS = 40;
-static constexpr Coord screen_width_px = 240;
-static constexpr Coord screen_height_px = 320;
-static constexpr Coord tone_log_top = 4 * 16;
-static constexpr Coord waterfall_top = 13 * 16;
-static constexpr Coord waterfall_height = 6 * 16;
-static constexpr Rect tone_log_rect{0, tone_log_top, 30 * 8, waterfall_top - tone_log_top};
-
-// ---------------------------------------------------------------------------
-// Tone tables
-// ---------------------------------------------------------------------------
-
-static const uint32_t MOTO_FREQS[45] = {
-    2885,
-    3047,
-    3217,
-    3396,
-    3586,
-    3786,
-    3998,
-    4221,
-    4457,
-    4705,
-    4968,
-    5246,
-    5539,
-    5848,
-    6174,
-    6519,
-    6883,
-    7268,
-    7674,
-    8102,
-    8555,
-    9032,
-    9537,
-    10073,
-    10642,
-    11225,
-    11247,
-    11534,
-    11852,
-    11885,
-    12178,
-    12514,
-    12555,
-    12858,
-    13258,
-    13576,
-    13950,
-    13996,
-    14768,
-    15579,
-    16430,
-    17325,
-    18262,
-    19245,
-    20275,
-};
-
-// Index 0 = None (0), indices 1–50 = standard CTCSS tones (freq × 10)
-static const uint32_t CTCSS_FREQS[51] = {
-    0,
-    670,
-    719,
-    744,
-    770,
-    797,
-    825,
-    854,
-    885,
-    915,
-    948,
-    974,
-    1000,
-    1035,
-    1072,
-    1109,
-    1148,
-    1188,
-    1230,
-    1273,
-    1318,
-    1365,
-    1413,
-    1462,
-    1500,
-    1514,
-    1567,
-    1598,
-    1622,
-    1655,
-    1679,
-    1713,
-    1738,
-    1773,
-    1799,
-    1835,
-    1862,
-    1899,
-    1928,
-    1966,
-    1995,
-    2035,
-    2065,
-    2107,
-    2181,
-    2257,
-    2291,
-    2336,
-    2418,
-    2503,
-    2541,
-};
-
-static std::string ctcss_name(uint32_t freq_x10) {
-    if (freq_x10 == 0) return "None";
-    return to_string_dec_uint(freq_x10 / 10) + "." +
-           to_string_dec_uint(freq_x10 % 10) + "Hz";
-}
-
-// ---------------------------------------------------------------------------
-// MOTO table helpers
-// ---------------------------------------------------------------------------
-
-static constexpr uint32_t MOTO_NONE = 255;
-static constexpr uint32_t MOTO_TRANSITION_SNAP_HZ = 30;   // stricter live transition tolerance
-static constexpr uint32_t MOTO_FINAL_MATCH_HZ = 60;       // looser phase-end/logging tolerance
-static constexpr uint32_t MOTO_TRANSITION_DELTA_HZ = 25;  // raw shift needed to confirm close-in A→B handoff
-
-static uint32_t abs_diff_u32(uint32_t a, uint32_t b) {
-    return (a > b) ? (a - b) : (b - a);
-}
-
-// Return the nearest MOTO table index within match_hz, or MOTO_NONE.
-static uint32_t moto_index(uint32_t freq_hz, uint32_t match_hz = MOTO_TRANSITION_SNAP_HZ) {
-    if (freq_hz == 0) return MOTO_NONE;
-    uint32_t best_idx = MOTO_NONE;
-    uint32_t best_diff = match_hz + 1;
-    for (size_t i = 0; i < 45; i++) {
-        const uint32_t hz = MOTO_FREQS[i] / 10;
-        const uint32_t diff = (freq_hz > hz) ? (freq_hz - hz) : (hz - freq_hz);
-        if (diff < best_diff) {
-            best_diff = diff;
-            best_idx = i;
-        }
-    }
-    return best_idx;
-}
-
-// Format a detected tone for display, snapping to nearest MOTO table entry.
-static std::string format_tone(uint32_t freq_hz, uint32_t duration_ms) {
-    const uint32_t idx = moto_index(freq_hz, MOTO_FINAL_MATCH_HZ);
-    std::string freq_str;
-    if (idx != MOTO_NONE) {
-        const uint32_t matched_x10 = MOTO_FREQS[idx];
-        freq_str = to_string_dec_uint(matched_x10 / 10) + "." +
-                   to_string_dec_uint(matched_x10 % 10) + "Hz";
-    } else {
-        freq_str = to_string_dec_uint(freq_hz) + "Hz";
-    }
-    return freq_str + " " + to_string_dec_uint(duration_ms) + "ms";
-}
-
-// ---------------------------------------------------------------------------
-// Waterfall rect
-// ---------------------------------------------------------------------------
-static constexpr ui::Rect waterfall_rect{0, waterfall_top, screen_width_px, waterfall_height};
-
-// ---------------------------------------------------------------------------
-// TwoToneRxView
-// ---------------------------------------------------------------------------
-
-void TwoToneRxView::focus() {
-    button_startstop.focus();
-}
-
-void TwoToneRxView::on_hide() {
-    if (running_) stop_rx();
-}
-
-TwoToneRxView::TwoToneRxView(NavigationView& nav)
-    : nav_{nav} {
-    prior_antenna_bias_ = get_antenna_bias();
-    debug_file_.append(u"DEBUG/TWOTONERX.TXT");
-    debug_file_.write_entry("==== two_tone_rx session start ====");
-
-    add_children({
-        &field_frequency,
-        &field_rf_amp,
-        &field_lna,
-        &field_vga,
-        &rssi,
-        &field_volume,
-        &labels,
-        &options_ctcss,
-        &field_squelch,
-        &button_startstop,
-        &button_clear,
-        &text_status,
-        &check_bias_t,
-        &tone_log_view,
-    });
-
-    // Populate CTCSS options
-    using opt_t = std::pair<std::string, int32_t>;
-    options_ctcss.set_options([&]() {
-        std::vector<opt_t> opts;
-        opts.reserve(51);
-        for (size_t i = 0; i < 51; i++)
-            opts.push_back({ctcss_name(CTCSS_FREQS[i]), (int32_t)i});
-        return opts;
-    }());
-    options_ctcss.set_by_value((int32_t)ctcss_idx);
-    options_ctcss.on_change = [this](size_t, int32_t v) {
-        ctcss_idx = (uint32_t)v;
-        if (running_) baseband::set_tonedetect_config((uint8_t)squelch_val, CTCSS_FREQS[ctcss_idx]);
-    };
-
-    field_squelch.set_value((int32_t)squelch_val);
-    field_squelch.on_change = [this](int32_t v) {
-        squelch_val = (uint32_t)v;
-        if (running_) baseband::set_tonedetect_config((uint8_t)squelch_val, CTCSS_FREQS[ctcss_idx]);
-    };
-
-    button_startstop.on_select = [this](Button&) {
-        if (running_)
-            stop_rx();
-        else
-            start_rx();
-    };
-
-    button_clear.on_select = [this](Button&) {
-        tone_log_entries_.clear();
-        tone_log_view.set_dirty();
-        text_status.set("");
-        reset_detect_state();
-    };
-
-    check_bias_t.set_value(bias_t_enabled);
-    check_bias_t.on_select = [this](Checkbox&, bool v) {
-        bias_t_enabled = v;
-        apply_bias_t(running_);
-    };
-
-    field_frequency.set_step(12500);
-    tone_log_view.set_parent_rect(tone_log_rect);
-}
-
-TwoToneRxView::~TwoToneRxView() {
-    if (running_) stop_rx();
-}
-
-void TwoToneRxView::reset_detect_state() {
-    detect_state_ = DetectState::IDLE;
-    phase_window_count_ = 0;
-    phase_freq_accum_ = 0;
-    phase_valid_windows_ = 0;
-    phase_last_freq_ = 0;
-    phase_last_is_first_ = true;
-    t1_avg_freq_ = 0;
-    t1_window_count_ = 0;
-    t1_transition_candidate_windows_ = 0;
-    t2_zero_window_count_ = 0;
-    debug_trace_active_ = false;
-    debug_trace_id_ = 0;
-}
-
-void TwoToneRxView::start_rx() {
-    baseband::run_prepared_image(portapack::memory::map::m4_code.base());
-
-    audio::set_rate(audio::Rate::Hz_24000);
-    audio::output::start();
-
-    receiver_model.set_hidden_offset(0);
-    receiver_model.set_sampling_rate(3072000);
-    receiver_model.set_baseband_bandwidth(1750000);
-    receiver_model.enable();
-    apply_bias_t(true);
-
-    baseband::set_tonedetect_config((uint8_t)squelch_val, CTCSS_FREQS[ctcss_idx]);
-
-    add_child(&waterfall);
-    waterfall.set_parent_rect(waterfall_rect);
-
-    running_ = true;
-    button_startstop.set_text("Stop");
-    text_status.set("");
-}
-
-void TwoToneRxView::stop_rx() {
-    remove_child(&waterfall);
-
-    apply_bias_t(false);
-    receiver_model.disable();
-    baseband::shutdown();
-    audio::output::stop();
-
-    running_ = false;
-    button_startstop.set_text("Start");
-    text_status.set("");
-    reset_detect_state();
-}
-
-void TwoToneRxView::apply_bias_t(bool active) {
-    if (active && bias_t_enabled) {
-        set_antenna_bias(true);
-        receiver_model.set_antenna_bias();
-        applied_bias_t_ = true;
-        return;
-    }
-
-    if (!applied_bias_t_) return;
-
-    set_antenna_bias(prior_antenna_bias_);
-    receiver_model.set_antenna_bias();
-    applied_bias_t_ = false;
-}
-
-void TwoToneRxView::debug_log(const std::string& line) {
-    const std::string trace_prefix = debug_trace_active_
-                                         ? ("#" + to_string_dec_uint(debug_trace_id_) + " ")
-                                         : "";
-    const std::string entry = "[D] " + trace_prefix + line;
-    debug_file_.write_entry(entry);
-}
-
-void TwoToneRxView::debug_trace_begin(const std::string& line) {
-    if (!debug_trace_active_) {
-        debug_trace_id_ = ++debug_trace_counter_;
-        debug_trace_active_ = true;
-    }
-    debug_log(line);
-}
-
-void TwoToneRxView::finalize_detected_pair(uint32_t t2_avg, uint32_t t2_dur, const char* reason) {
-    const uint32_t t1_dur = t1_window_count_ * DETECT_WINDOW_MS;
-    const std::string suffix = std::string(" via ") + reason;
-
-    if (t1_avg_freq_ > 0 && t2_avg > 0 &&
-        t1_dur >= 500 && t2_dur >= 500 &&
-        moto_index(t1_avg_freq_, MOTO_FINAL_MATCH_HZ) != MOTO_NONE &&
-        moto_index(t2_avg, MOTO_FINAL_MATCH_HZ) != MOTO_NONE) {
-        debug_trace_begin("END ok T1=" + format_tone(t1_avg_freq_, t1_dur) +
-                          " T2=" + format_tone(t2_avg, t2_dur) + suffix);
-        log_tone_pair(t1_avg_freq_, t1_dur, t2_avg, t2_dur);
-    } else {
-        debug_trace_begin("END drop T1=" + format_tone(t1_avg_freq_, t1_dur) +
-                          " T2=" + format_tone(t2_avg, t2_dur) + suffix);
-    }
-}
-
-// ---------------------------------------------------------------------------
-// on_tone_data — window-based two-tone detection state machine
-//
-// Every 40 ms the baseband sends tone_end=false with a raw frequency estimate
-// for that window (freq_hz=0 if no stable QCII candidate).
-// When the CTCSS gate closes it sends tone_end=true (freq_hz=0).
-//
-// First and last windows of each phase are discarded:
-//   - "First" is tracked with phase_last_is_first_.
-//   - "Last" is phase_last_freq_, never added to the accumulator while
-//     pending; discarded when the phase ends.
-//
-// T1→T2 transition: consecutive windows that snap to different MOTO table
-// entries. The transition window becomes T2's first window.
-//
-// Final matching is done from the phase-average raw estimates collected here,
-// not from the per-window nearest-table snap used for transition detection.
-// ---------------------------------------------------------------------------
-void TwoToneRxView::on_tone_data(const ToneDetectDataMessage* msg) {
-    if (!running_) return;
-
-    if (msg->tone_end) {
-        // Gate closed — finalize whatever phase we're in
-        if (detect_state_ == DetectState::T2_COLLECTING) {
-            // phase_last_freq_ is the last T2 window → discard it
-            uint32_t t2_avg = (phase_valid_windows_ > 0)
-                                  ? (phase_freq_accum_ / phase_valid_windows_)
-                                  : phase_last_freq_;
-            uint32_t t2_dur = phase_window_count_ * DETECT_WINDOW_MS;
-            finalize_detected_pair(t2_avg, t2_dur, "tone_end");
-        } else if (debug_trace_active_) {
-            debug_log("END before T2");
-        }
-        reset_detect_state();
-        text_status.set("");
-        return;
-    }
-
-    // tone_end=false: this is a 40 ms measurement window
-    const uint32_t freq = msg->freq_hz;
-    if (freq == 0) {
-        if (detect_state_ == DetectState::T2_COLLECTING) {
-            const uint32_t t2_avg = (phase_valid_windows_ > 0)
-                                        ? (phase_freq_accum_ / phase_valid_windows_)
-                                        : phase_last_freq_;
-            const uint32_t t2_dur = phase_window_count_ * DETECT_WINDOW_MS;
-
-            if (t2_avg > 0 && t2_dur >= 2000) {
-                finalize_detected_pair(t2_avg, t2_dur, "t2_break");
-                reset_detect_state();
-                text_status.set("");
-                return;
-            }
-        }
-
-        // A single weak/noisy dropout is tolerated during T2 so standard 3 s
-        // B tones are not lost to one marginal 40 ms estimate window.
-        if (detect_state_ == DetectState::T2_COLLECTING && t2_zero_window_count_ == 0) {
-            t2_zero_window_count_++;
-            if (debug_trace_active_) {
-                debug_log("T2 zero dropout");
-            }
-            text_status.set("T1:" + format_tone(t1_avg_freq_, t1_window_count_ * DETECT_WINDOW_MS) +
-                            " T2 ?");
-            return;
-        }
-
-        // Otherwise, treat the missing estimate as a break in the sequence.
-        if (debug_trace_active_) {
-            debug_log("RESET zero");
-        }
-        reset_detect_state();
-        text_status.set("");
-        return;
-    }
-
-    t2_zero_window_count_ = 0;
-
-    switch (detect_state_) {
-        case DetectState::IDLE:
-            detect_state_ = DetectState::T1_COLLECTING;
-            phase_window_count_ = 1;
-            phase_freq_accum_ = 0;
-            phase_valid_windows_ = 0;
-            phase_last_freq_ = freq;
-            phase_last_is_first_ = true;
-            text_status.set("T1 ...");
-            break;
-
-        case DetectState::T1_COLLECTING: {
-            // Check for T1→T2 MOTO index transition.
-            // Skip if phase_last_freq_ is the first (noisy) window — it's
-            // marked for discard and must not trigger a false transition.
-            if (freq > 0 && phase_last_freq_ > 0 && !phase_last_is_first_) {
-                const uint32_t t1_ref_freq = (phase_valid_windows_ > 0)
-                                                 ? (phase_freq_accum_ / phase_valid_windows_)
-                                                 : phase_last_freq_;
-                const uint32_t idx_ref = moto_index(t1_ref_freq, MOTO_FINAL_MATCH_HZ);
-                const uint32_t idx_last = moto_index(phase_last_freq_);
-                const uint32_t idx_cur = moto_index(freq);
-                const uint32_t idx_cur_final = moto_index(freq, MOTO_FINAL_MATCH_HZ);
-
-                bool transition_detected = false;
-                if (idx_last != MOTO_NONE && idx_cur != MOTO_NONE && idx_last != idx_cur) {
-                    if (!debug_trace_active_) {
-                        debug_trace_begin("T1 start " + format_tone(t1_ref_freq, phase_window_count_ * DETECT_WINDOW_MS));
-                    }
-                    debug_log("T1->T2 snap " + format_tone(phase_last_freq_, DETECT_WINDOW_MS) +
-                              " -> " + format_tone(freq, DETECT_WINDOW_MS));
-                    transition_detected = true;
-                } else if (idx_ref != MOTO_NONE &&
-                           idx_cur_final != MOTO_NONE &&
-                           idx_cur_final != idx_ref &&
-                           abs_diff_u32(freq, t1_ref_freq) >= MOTO_TRANSITION_DELTA_HZ) {
-                    t1_transition_candidate_windows_++;
-                    if (debug_trace_active_) {
-                        debug_log("T1 cand " + to_string_dec_uint(t1_transition_candidate_windows_) +
-                                  " ref=" + to_string_dec_uint(t1_ref_freq) +
-                                  " cur=" + to_string_dec_uint(freq));
-                    }
-                    transition_detected = (t1_transition_candidate_windows_ >= 2);
-                } else {
-                    if (debug_trace_active_ && t1_transition_candidate_windows_ > 0) {
-                        debug_log("T1 cand reset");
-                    }
-                    t1_transition_candidate_windows_ = 0;
-                }
-
-                if (transition_detected) {
-                    // Transition detected.
-                    // phase_last_freq_ is the last T1 window → discard.
-                    t1_avg_freq_ = (phase_valid_windows_ > 0)
-                                       ? (phase_freq_accum_ / phase_valid_windows_)
-                                       : phase_last_freq_;
-                    t1_window_count_ = phase_window_count_;
-
-                    // Start T2 with current window as first (also discarded)
-                    detect_state_ = DetectState::T2_COLLECTING;
-                    phase_window_count_ = 1;
-                    phase_freq_accum_ = 0;
-                    phase_valid_windows_ = 0;
-                    phase_last_freq_ = freq;
-                    phase_last_is_first_ = true;
-                    t1_transition_candidate_windows_ = 0;
-                    t2_zero_window_count_ = 0;
-
-                    if (!debug_trace_active_) {
-                        debug_trace_begin("T1 start " + format_tone(t1_avg_freq_, t1_window_count_ * DETECT_WINDOW_MS));
-                    }
-                    debug_log("T2 start " + format_tone(freq, DETECT_WINDOW_MS));
-                    text_status.set("T1:" + format_tone(t1_avg_freq_, t1_window_count_ * DETECT_WINDOW_MS) + " T2...");
-                    break;
-                }
-            }
-
-            // No transition: promote pending window into accumulator (unless first)
-            if (!phase_last_is_first_ && phase_last_freq_ > 0) {
-                phase_freq_accum_ += phase_last_freq_;
-                phase_valid_windows_++;
-            }
-            phase_last_freq_ = freq;
-            phase_last_is_first_ = false;
-            phase_window_count_++;
-
-            if (!debug_trace_active_ &&
-                phase_window_count_ >= 3 &&
-                moto_index(phase_last_freq_, MOTO_FINAL_MATCH_HZ) != MOTO_NONE) {
-                const uint32_t t1_ref_freq = (phase_valid_windows_ > 0)
-                                                 ? (phase_freq_accum_ / phase_valid_windows_)
-                                                 : phase_last_freq_;
-                debug_trace_begin("T1 start " + format_tone(t1_ref_freq, phase_window_count_ * DETECT_WINDOW_MS));
-            }
-
-            text_status.set("T1 " + to_string_dec_uint(phase_window_count_ * DETECT_WINDOW_MS) + "ms...");
-            break;
-        }
-
-        case DetectState::T2_COLLECTING:
-            // Promote pending window into accumulator (unless first)
-            if (!phase_last_is_first_ && phase_last_freq_ > 0) {
-                phase_freq_accum_ += phase_last_freq_;
-                phase_valid_windows_++;
-            }
-            phase_last_freq_ = freq;
-            phase_last_is_first_ = false;
-            phase_window_count_++;
-
-            text_status.set("T1:" + format_tone(t1_avg_freq_, t1_window_count_ * DETECT_WINDOW_MS) +
-                            " T2 " + to_string_dec_uint(phase_window_count_ * DETECT_WINDOW_MS) + "ms");
-            break;
-    }
-}
-
-void TwoToneRxView::log_tone_pair(uint32_t f1, uint32_t d1_ms, uint32_t f2, uint32_t d2_ms) {
-    // Keep the oldest entry at the top so newer pairs appear below it.
-    tone_log_entries_.push_back({++next_log_serial_, format_tone(f1, d1_ms) + " " + format_tone(f2, d2_ms)});
-    tone_log_view.set_dirty();
-}
-
-}  // namespace ui::external_app::two_tone_rx
-
-namespace ui {
-
-template <>
-void RecentEntriesTable<ui::external_app::two_tone_rx::TwoToneLogEntries>::draw(
-    const Entry& entry,
-    const Rect& target_rect,
-    Painter& painter,
-    const Style& style,
-    ui::RecentEntriesColumns&) {
-    std::string line = entry.line;
-    line.resize(target_rect.width() / 8, ' ');
-    painter.draw_string(target_rect.location(), style, line);
-}
-
-}  // namespace ui

firmware/application/external/two_tone_rx/ui_two_tone_rx.hpp

@@ -1,214 +0,0 @@
-/*
- * Copyright (C) 2024 PortaPack Mayhem
- *
- * This file is part of PortaPack.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2, or (at your option)
- * any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street,
- * Boston, MA 02110-1301, USA.
- */
-
-#ifndef __UI_TWO_TONE_RX_H__
-#define __UI_TWO_TONE_RX_H__
-
-#include "ui.hpp"
-#include "ui_navigation.hpp"
-#include "ui_receiver.hpp"
-#include "ui_freq_field.hpp"
-#include "ui_spectrum.hpp"
-#include "app_settings.hpp"
-#include "radio_state.hpp"
-#include "message.hpp"
-#include "string_format.hpp"
-#include "log_file.hpp"
-#include "recent_entries.hpp"
-
-namespace ui::external_app::two_tone_rx {
-
-struct TwoToneLogEntry {
-    using Key = uint32_t;
-
-    static constexpr Key invalid_key = 0;
-
-    Key serial{};
-    std::string line{};
-
-    Key key() const { return serial; }
-};
-
-using TwoToneLogEntries = RecentEntries<TwoToneLogEntry>;
-
-class TwoToneRxView : public View {
-   public:
-    TwoToneRxView(NavigationView& nav);
-    ~TwoToneRxView();
-
-    TwoToneRxView(const TwoToneRxView&) = delete;
-    TwoToneRxView(TwoToneRxView&&) = delete;
-    TwoToneRxView& operator=(const TwoToneRxView&) = delete;
-    TwoToneRxView& operator=(TwoToneRxView&&) = delete;
-
-    void focus() override;
-    void on_hide() override;
-    std::string title() const override { return "2-Tone RX"; };
-
-   private:
-    NavigationView& nav_;
-
-    RxRadioState radio_state_{};
-
-    bool running_{false};
-
-    TwoToneLogEntries tone_log_entries_{};
-    uint32_t next_log_serial_{0};
-
-    uint32_t squelch_val{50};
-    uint32_t ctcss_idx{0};
-    bool bias_t_enabled{false};
-    bool prior_antenna_bias_{false};
-    bool applied_bias_t_{false};
-    LogFile debug_file_{};
-
-    app_settings::SettingsManager settings_{
-        "rx_twotone",
-        app_settings::Mode::RX,
-        {
-            {"tone_sq"sv, &squelch_val},
-            {"ctcss"sv, &ctcss_idx},
-            {"bias_t"sv, &bias_t_enabled},
-        }};
-
-    void start_rx();
-    void stop_rx();
-    void apply_bias_t(bool active);
-    void debug_log(const std::string& line);
-    void debug_trace_begin(const std::string& line);
-    void on_tone_data(const ToneDetectDataMessage* msg);
-    void log_tone_pair(uint32_t f1, uint32_t d1_ms, uint32_t f2, uint32_t d2_ms);
-    void finalize_detected_pair(uint32_t t2_avg, uint32_t t2_dur, const char* reason);
-    void reset_detect_state();
-
-    // ── Two-tone detection state machine ─────────────────────────────────────
-    //
-    // Each 40 ms measurement window from the baseband arrives as tone_end=false.
-    // tone_end=true signals that the CTCSS gate closed (end of transmission).
-    //
-    // Collection rule: discard first and last window of each phase.
-    //   - "First" is always discarded (may contain carrier ramp-up).
-    //   - "Last" is never added to the accumulator while pending; it is
-    //     discarded when the next window confirms it is not the last, OR when
-    //     the phase ends (tone_end=true or T1→T2 transition).
-    //
-    // Transition detection: two consecutive windows that snap to different MOTO
-    // table entries trigger T1→T2. The transition window becomes T2's first
-    // window (also discarded as T2's first).
-
-    enum class DetectState : uint8_t { IDLE,
-                                       T1_COLLECTING,
-                                       T2_COLLECTING };
-    DetectState detect_state_{DetectState::IDLE};
-
-    // Per-phase window collection
-    uint32_t phase_window_count_{0};   // total windows seen in this phase (including first)
-    uint32_t phase_freq_accum_{0};     // sum of non-first, non-last window frequencies
-    uint32_t phase_valid_windows_{0};  // count of windows in phase_freq_accum_
-    uint32_t phase_last_freq_{0};      // pending window (not yet added; discarded if last)
-    bool phase_last_is_first_{true};   // true when phase_last_freq_ is window 1 (discard)
-
-    // T1 result (stored at T1→T2 transition for use when pair is logged)
-    uint32_t t1_avg_freq_{0};
-    uint32_t t1_window_count_{0};
-    uint8_t t1_transition_candidate_windows_{0};
-    uint8_t t2_zero_window_count_{0};
-    bool debug_trace_active_{false};
-    uint32_t debug_trace_id_{0};
-    uint32_t debug_trace_counter_{0};
-
-    // ── Row 0: frequency + RF controls ───────────────────────────────────────
-
-    RxFrequencyField field_frequency{
-        {UI_POS_X(0), UI_POS_Y(0)},
-        nav_};
-    RFAmpField field_rf_amp{
-        {UI_POS_X(13), UI_POS_Y(0)}};
-    LNAGainField field_lna{
-        {UI_POS_X(15), UI_POS_Y(0)}};
-    VGAGainField field_vga{
-        {UI_POS_X(18), UI_POS_Y(0)}};
-    RSSI rssi{
-        {UI_POS_X(21), UI_POS_Y(0), UI_POS_WIDTH_REMAINING(24), 4}};
-    AudioVolumeField field_volume{
-        {UI_POS_X_RIGHT(2), UI_POS_Y(0)}};
-
-    // ── Row 1: CTCSS / Squelch / Start+Stop / Clear ──────────────────────────
-
-    Labels labels{
-        {{0 * 8, 1 * 16}, "CTCSS:", Theme::getInstance()->fg_light->foreground},
-        {{15 * 8, 1 * 16}, "Sq:", Theme::getInstance()->fg_light->foreground},
-    };
-
-    OptionsField options_ctcss{
-        {7 * 8, 1 * 16},
-        8,
-        {}};
-
-    NumberField field_squelch{
-        {19 * 8, 1 * 16},
-        2,
-        {0, 99},
-        1,
-        ' '};
-
-    Button button_startstop{
-        {21 * 8, 1 * 16, 5 * 8, 18},
-        "Start"};
-
-    Button button_clear{
-        {26 * 8, 1 * 16, 4 * 8, 18},
-        "Clr"};
-
-    // ── Row 2: live status (active tone in progress) + Bias-T toggle ─────────
-
-    Text text_status{
-        {0, 2 * 16 + 4, 20 * 8, 16},
-        ""};
-
-    Checkbox check_bias_t{
-        {20 * 8, 2 * 16 + 2},
-        9,
-        "Bias-T",
-        true};
-
-    ui::RecentEntriesColumns tone_log_columns{{
-        {"Tones", 0},
-    }};
-    ui::RecentEntriesTable<TwoToneLogEntries> tone_log_view{tone_log_entries_, tone_log_columns};
-
-    // ── Waterfall (rest of screen) ────────────────────────────────────────────
-
-    spectrum::WaterfallView waterfall{};
-
-    // ── Message handler ───────────────────────────────────────────────────────
-
-    MessageHandlerRegistration message_handler_tone{
-        Message::ID::ToneDetectData,
-        [this](const Message* const p) {
-            const auto* msg = reinterpret_cast<const ToneDetectDataMessage*>(p);
-            this->on_tone_data(msg);
-        }};
-};
-
-}  // namespace ui::external_app::two_tone_rx
-
-#endif /* __UI_TWO_TONE_RX_H__ */

firmware/application/freqman_db.cpp

@@ -134,7 +134,6 @@ options_t freqman_steps = {
     {"100kHz (FM2)", 100000},
     {"250kHz  (N2)", 250000},
     {"500kHz (WFM)", 500000},
-    {"750kHz      ", 750000},
     {"1MHz        ", 1000000},
 };
 
@@ -157,7 +156,6 @@ options_t freqman_steps_short = {
     {"100kHz", 100000},
     {"250kHz", 250000},
     {"500kHz", 500000},
-    {"750kHz", 750000},
     {"1MHz", 1000000},
 };
 

firmware/application/freqman_db.hpp

@@ -102,7 +102,6 @@ enum class freqman_type : uint8_t {
     _100kHz,
     _250kHz,
     _500kHz,
-    _750kHz,
     _1MHz,
     Unknown,
  * };
@@ -131,7 +130,6 @@ enum class freqman_type : uint8_t {
     freqman_step_info{ freqman_step::_100kHz,  "100kHz",  "100kHz (FM2)", 100'000 },
     freqman_step_info{ freqman_step::_250kHz,  "250kHz",  "250kHz  (N2)", 250'000 },
     freqman_step_info{ freqman_step::_500kHz,  "500kHz",  "500kHz (WFM)", 500'000 },
-    freqman_step_info{ freqman_step::_750kHz,  "750kHz",  "750kHz      ", 750'000 },
     freqman_step_info{ freqman_step::_1MHz,    "1MHz",    "1MHz        ", 1'000'000 },
     freqman_step_info{ freqman_step::Unknown,  "Unknown", "Unknown     ", 0 },
  * };

firmware/application/hackrf_core_mini.c

@@ -1,5 +1,4 @@
 #include "gpio_lpc.h"
-#include "gpio.h"
 
 typedef enum {
     LED1 = 0,
@@ -9,7 +8,7 @@ typedef enum {
 } led_t;
 
 /* GPIO Output PinMux */
-static struct gpio gpio_led[] = {
+static struct gpio_t gpio_led[] = {
     GPIO(2, 1),
     GPIO(2, 2),
     GPIO(2, 8),

firmware/application/hw/max2831.cpp

@@ -182,24 +182,20 @@ void MAX2831::set_mode(const Mode mode) {
         case Mode::Shutdown:
             gpio_max2831_rx_enable.write(0); /* RXTX=0 */
             gpio_max283x_enable.write(0);    /* ENABLE=0 */
-            set_rssi_mux(0);
             break;
         case Mode::Standby:
             gpio_max2831_rx_enable.write(1); /* RXTX=1 */
             gpio_max283x_enable.write(0);    /* ENABLE=0 */
-            set_rssi_mux(0);
             break;
         case Mode::Transmit:
         case Mode::Tx_Calibration:
             gpio_max2831_rx_enable.write(1); /* RXTX=1 for TX */
             gpio_max283x_enable.write(1);    /* ENABLE=1 */
-            set_rssi_mux(2);                 // transmit power
             break;
         case Mode::Receive:
         case Mode::Rx_Calibration:
             gpio_max2831_rx_enable.write(0); /* RXTX=0 for RX */
             gpio_max283x_enable.write(1);    /* ENABLE=1 */
-            set_rssi_mux(1);                 // RSSI
             break;
     }
 
@@ -479,38 +475,5 @@ void MAX2831::write(const address_t reg_num, const reg_t value) {
     }
 }
 
-void MAX2831::set_rssi_mux(const uint8_t mode) {
-    /* RSSI MUX allows switching the RSSI output between different internal signals.
-     * 0 = disable mux
-     * 1 = RSSI
-     * 2 = TX_POWER
-     * 3 = TEMP
-     */
-    uint16_t mux_val = 0;
-
-    // Select the appropriate constant based on the input mode.
-    if (mode == 0) {
-        mux_val = 0;
-    } else {
-        // Select the appropriate constant based on the input mode.
-        switch (mode) {
-            case 3:
-                mux_val = REG8_RSSI_MUX_TEMP;
-                break;
-            case 2:
-                mux_val = REG8_RSSI_MUX_TX_POWER;
-                break;
-            case 1:
-            default:
-                mux_val = REG8_RSSI_MUX_RSSI;
-                break;
-        }
-        mux_val |= REG8_RSSI_EN;
-    }
-
-    set_reg_field(8, REG8_RSSI_MUX_MASK | REG8_RSSI_EN, mux_val);
-    flush_reg(8);
-}
-
 }  // namespace max2831
 #endif

firmware/application/hw/max2831.hpp

@@ -151,7 +151,6 @@ constexpr uint16_t REG8_RSSI_MUX_MASK = 0x0300; /* D9:D8 */
 constexpr uint16_t REG8_RSSI_MUX_RSSI = (0 << REG8_RSSI_MUX_SHIFT);
 constexpr uint16_t REG8_RSSI_MUX_TEMP = (1 << REG8_RSSI_MUX_SHIFT);
 constexpr uint16_t REG8_RSSI_MUX_TX_POWER = (2 << REG8_RSSI_MUX_SHIFT);
-constexpr uint16_t REG8_RSSI_EN = (1 << 10);
 
 constexpr uint16_t REG8_RXVGA_GAIN_SPI_EN_SHIFT = 12;
 constexpr uint16_t REG8_RXVGA_GAIN_SPI_EN = (1 << REG8_RXVGA_GAIN_SPI_EN_SHIFT);
@@ -214,8 +213,6 @@ class MAX2831 : public MAX283x {
     reg_t read(const address_t reg_num) override;
     void write(const address_t reg_num, const reg_t value) override;
 
-    void set_rssi_mux(const uint8_t mode);
-
    private:
     spi::arbiter::Target& _target;
     Mode _mode{Mode::Standby};

firmware/application/hw/rffc507x_spi.cpp

@@ -103,13 +103,5 @@ data_t SPI::transfer_word(const Direction direction, const address_t address, co
     return data_in;
 }
 
-void SPI::power_down() {
-    // A 0x01 address the MIX_CTRL register. A 0x0000
-    transfer_word(Direction::Write, 0x01, 0x0000);
-
-    // a chip 300 µA-es Power Down
-    transfer_word(Direction::Write, 0x00, 0x0000);
-}
-
 }  // namespace spi
 }  // namespace rffc507x

firmware/application/hw/rffc507x_spi.hpp

@@ -41,7 +41,6 @@ class SPI {
     };
 
     void init();
-    void power_down();
 
     reg_t read(const address_t address) {
         return transfer_word(Direction::Read, address, 0);

firmware/application/irq_rtc.cpp

@@ -27,8 +27,6 @@
 using namespace lpc43xx;
 
 #include "event_m0.hpp"
-#include "nvic.h"
-#include "lpc43xx.inc"
 
 static Thread* thread_rtc_event = NULL;
 
@@ -38,84 +36,6 @@ void rtc_interrupt_enable() {
     nvicEnableVector(RTC_IRQn, CORTEX_PRIORITY_MASK(LPC_RTC_IRQ_PRIORITY));
 }
 
-void rtc_reset_default() {
-    // 1. FULL RTC CLEANUP/RESET
-    LPC_RTC->CIIR = 0;
-    LPC_RTC->AMR = 0xFF;  // Disable all alarms
-    LPC_RTC->ILR = 3;     // Clear stuck interrupt flags
-    LPC_RTC->ASEC = 0;
-    LPC_RTC->AMIN = 0;
-    LPC_RTC->AHRS = 0;
-
-    // 2. RESET EVENT ROUTER
-    // Reset to edge-triggered (Garantálja, hogy nem ragad be az ébresztés!)
-    LPC_EVENTROUTER->EDGE |= (1 << 5);
-
-    // DISABLE RTC channel routing
-    LPC_EVENTROUTER->CLR_EN = (1 << 5);
-
-    // Clear pending events
-    LPC_EVENTROUTER->CLR_STAT = 0xFFFFFFFF;
-}
-
-void rtc_wakeup_init() {
-    rtc_reset_default();
-
-    // 1. Force RTC Clock (In case it was modified by the app)
-    // Bit 0: Enable, Bit 4: Calibration OFF
-    LPC_RTC->CCR = (1 << 0);
-
-    // 2. EVENT ROUTER CONFIGURATION
-    LPC_EVENTROUTER->HILO |= (1 << 5);
-    LPC_EVENTROUTER->EDGE |= (1 << 5);       // <-- JAVÍTVA! (Itt volt a hiba a te kódodban)
-    LPC_EVENTROUTER->CLR_STAT = 0xFFFFFFFF;  // Clear pending events
-    LPC_EVENTROUTER->SET_EN = (1 << 5);      // Enable RTC channel routing
-
-    // 3. NVIC Cleanup
-    NVIC_ClearPendingIRQ(RTC_IRQn);
-    NVIC_ClearPendingIRQ(EVENTROUTER_IRQn);
-    NVIC_EnableIRQ(RTC_IRQn);
-    NVIC_EnableIRQ(EVENTROUTER_IRQn);
-}
-
-void rtc_wakeup(uint32_t sleep_seconds) {
-    // 1. Safety cleanup after application tasks
-    LPC_RTC->CCR &= ~(1 << 4);  // Disable calibration (Important!)
-
-    uint32_t sec = LPC_RTC->SEC;
-    uint32_t min = LPC_RTC->MIN;
-    uint32_t hrs = LPC_RTC->HRS;
-
-    sec += sleep_seconds;
-    while (sec >= 60) {
-        sec -= 60;
-        min++;
-    }
-    while (min >= 60) {
-        min -= 60;
-        hrs++;
-    }
-    while (hrs >= 24) {
-        hrs -= 24;
-    }
-
-    // 2. Write values to alarm registers
-    LPC_RTC->ASEC = sec;
-    LPC_RTC->AMIN = min;
-    LPC_RTC->AHRS = hrs;
-
-    // Mask for SEC, MIN, HRS (Disable all other alarm triggers)
-    uint32_t mask = 0xFF ^ ((1 << 0) | (1 << 1) | (1 << 2));
-    LPC_RTC->AMR = mask;
-
-    // Verify write (Sync with RTC domain)
-    while (LPC_RTC->ASEC != sec);
-    while (LPC_RTC->AMR != mask);
-
-    // Brief extra delay to allow internal logic to settle/latch
-    for (volatile int i = 0; i < 5000; i++) __asm__("nop");
-}
-
 extern "C" {
 
 CH_IRQ_HANDLER(RTC_IRQHandler) {

firmware/application/irq_rtc.hpp

@@ -22,11 +22,6 @@
 #ifndef __IPC_RTC_H__
 #define __IPC_RTC_H__
 
-#include <cstdint>
-
 void rtc_interrupt_enable();
-void rtc_reset_default();
-void rtc_wakeup_init();
-void rtc_wakeup(uint32_t sleep_seconds);
 
 #endif /*__IPC_RTC_H__*/

firmware/application/main.cpp

@@ -141,8 +141,6 @@ Continuous (Fox-oring)
 #include <string.h>
 #include "i2cdevmanager.hpp"
 
-#include "lpc43xx.inc"
-
 #include "rffc507x.hpp" /* c/m, avoiding initial short ON Ant_DC_Bias pulse, from cold reset  */
 rffc507x::RFFC507x first_if;
 ui::SystemView* system_view_ptr;
@@ -183,8 +181,6 @@ static void event_loop() {
 }
 
 int main(void) {
-    rtc_reset_default();
-
 #ifndef PRALINE      // Do not perform quick set up of GP01_RFF507X = 1 for PRALINE
     first_if.init(); /* To avoid initial short Ant_DC_Bias pulse ,we need quick set up GP01_RFF507X =1 */
 #endif

firmware/application/portapack.cpp

@@ -339,20 +339,6 @@ static void shutdown_base() {
     clock_manager.shutdown();
 }
 
-static void shutdown_base_12mhz() {
-    i2c0.stop();
-
-    set_clock_config(clock_config_irc);
-
-    cgu::pll1::disable();
-
-    set_idivc_base_clocks(cgu::CLK_SEL::IRC);
-
-    i2c0.start(i2c_config_boot_clock);
-
-    clock_manager.shutdown();
-}
-
 static void set_cpu_clock_speed() {
     /* Incantation from LPC43xx UM10503 section 12.2.1.1, to bring the M4
      * core clock speed to the 110 - 204MHz range.
@@ -650,7 +636,7 @@ init_status_t init() {
     // This function returns LD_SUCCESS (0) if the FPGA confirms the bitstream
     // Call fpga_bridge_init and continue boot regardless of result
     // (Watchdog was resetting device when we halted with while(1))
-    int load_result = fpga_bridge_init(&shared_memory.bb_data.data[0]);
+    int load_result = fpga_bridge_init();
     (void)load_result;  // Ignore result for now, just let boot continue
 
     /* RELEASE FPGA RESET */
@@ -712,7 +698,7 @@ init_status_t init() {
     return return_code;
 }
 
-void shutdown(const bool leave_screen_on, const bool slow_clock) {
+void shutdown(const bool leave_screen_on) {
     gpdma::controller.disable();
 
     if (!leave_screen_on) {
@@ -726,11 +712,7 @@ void shutdown(const bool leave_screen_on, const bool slow_clock) {
 
     hackrf::cpld::init_from_eeprom();
 
-    if (slow_clock) {
-        shutdown_base_12mhz();
-    } else {
-        shutdown_base();
-    }
+    shutdown_base();
 }
 
 void setEventDispatcherToUSBSerial(EventDispatcher* evt) {

firmware/application/portapack.hpp

@@ -78,7 +78,7 @@ void set_antenna_bias(const bool v);
 bool get_antenna_bias();
 
 init_status_t init();
-void shutdown(const bool leave_screen_on = false, const bool slow_clock = false);
+void shutdown(const bool leave_screen_on = false);
 
 void setEventDispatcherToUSBSerial(EventDispatcher* evt);
 

firmware/application/radio.cpp

@@ -606,4 +606,4 @@ uint32_t register_read(const size_t register_number) {
 
 } /* namespace debug */
 
-} /* namespace radio */
+} /* namespace radio */

firmware/application/radio.hpp

@@ -136,4 +136,4 @@ uint32_t register_read(const size_t register_number);
 
 } /* namespace radio */
 
-#endif /*__RADIO_H__*/
+#endif /*__RADIO_H__*/

firmware/application/string_format.cpp

@@ -104,7 +104,7 @@ std::string to_string_bin(
     if (l >= 33) l = 32;
     char p[33];
     for (uint8_t c = 0; c < l; c++) {
-        if (n & (1UL << (l - 1 - c)))
+        if (n & (1 << (l - 1 - c)))
             p[c] = '1';
         else
             p[c] = '0';
@@ -130,19 +130,28 @@ std::string to_string_dec_uint(
     return q;
 }
 
-std::string to_string_dec_int(const int32_t n, const int32_t l, const char fill) {
+std::string to_string_dec_int(
+    const int32_t n,
+    const int32_t l,
+    const char fill) {
     const size_t negative = (n < 0) ? 1 : 0;
-    uint32_t n_abs = negative ? static_cast<uint32_t>(-(int64_t)n) : static_cast<uint32_t>(n);
-    char p[24];
-    int32_t safe_l = std::min<int32_t>(l, sizeof(p) - 1);
+    uint32_t n_abs = negative ? -n : n;
+
+    char p[16];
     auto term = p + sizeof(p) - 1;
-    auto q = to_string_dec_uint_pad_internal(term, n_abs, safe_l - negative, fill);
+    auto q = to_string_dec_uint_pad_internal(term, n_abs, l - negative, fill);
+
+    // Add sign.
     if (negative) {
         *(--q) = '-';
     }
-    while ((term - q) < safe_l) {
-        *(--q) = (fill ? fill : ' ');
+
+    // Right justify.
+    // (This code is redundant and won't do anything if a fill character was specified)
+    while ((term - q) < l) {
+        *(--q) = ' ';
     }
+
     return q;
 }
 
@@ -250,32 +259,38 @@ std::string to_string_time_ms(const uint32_t ms) {
     return final_str;
 }
 
+static char* to_string_hex_internal(char* ptr, uint64_t value, uint8_t length) {
+    if (length == 0)
+        return ptr;
+
+    *(--ptr) = uint_to_char(value & 0xF, 16);
+    return to_string_hex_internal(ptr, value >> 4, length - 1);
+}
+
 std::string to_string_hex(uint64_t value, int32_t length) {
     constexpr uint8_t buffer_length = 33;
     char buffer[buffer_length];
+
     char* ptr = &buffer[buffer_length - 1];
     *ptr = '\0';
-    length = std::min<int32_t>(buffer_length - 1, length);
-    for (int32_t i = 0; i < length; ++i) {
-        *(--ptr) = uint_to_char(value & 0xF, 16);
-        value >>= 4;
-    }
-    return std::string(ptr);
+
+    length = std::min<uint8_t>(buffer_length - 1, length);
+    return to_string_hex_internal(ptr, value, length);
 }
 
 std::string to_string_hex_array(uint8_t* array, int32_t length) {
-    std::string s;
-    s.resize(length * 2);
-    for (int i = 0; i < length; i++) {
-        s[i * 2] = uint_to_char((array[i] >> 4) & 0xF, 16);
-        s[i * 2 + 1] = uint_to_char(array[i] & 0xF, 16);
-    }
-    return s;
+    std::string str_return;
+    str_return.reserve(length * 2);
+
+    for (uint8_t i = 0; i < length; i++)
+        str_return += to_string_hex(array[i], 2);
+
+    return str_return;
 }
 
 std::string to_string_datetime(const rtc::RTC& value, const TimeFormat format) {
     std::string string{""};
-    string.reserve(20);
+
     if (format == YMDHMS) {
         string += to_string_dec_uint(value.year(), 4) + "-" +
                   to_string_dec_uint(value.month(), 2, '0') + "-" +
@@ -292,33 +307,20 @@ std::string to_string_datetime(const rtc::RTC& value, const TimeFormat format) {
 }
 
 std::string to_string_timestamp(const rtc::RTC& value) {
-    std::string result;
-    // YYYYMMDDHHMMSS = 14 characters
-    result.reserve(14);
-    result += to_string_dec_uint(value.year(), 4, '0');
-    result += to_string_dec_uint(value.month(), 2, '0');
-    result += to_string_dec_uint(value.day(), 2, '0');
-    result += to_string_dec_uint(value.hour(), 2, '0');
-    result += to_string_dec_uint(value.minute(), 2, '0');
-    result += to_string_dec_uint(value.second(), 2, '0');
-
-    return result;
+    return to_string_dec_uint(value.year(), 4, '0') +
+           to_string_dec_uint(value.month(), 2, '0') +
+           to_string_dec_uint(value.day(), 2, '0') +
+           to_string_dec_uint(value.hour(), 2, '0') +
+           to_string_dec_uint(value.minute(), 2, '0') +
+           to_string_dec_uint(value.second(), 2, '0');
 }
 
 std::string to_string_FAT_timestamp(const FATTimestamp& timestamp) {
-    std::string result;
-    // YYYY-MM-DD HH:MM = 16 characters
-    result.reserve(16);
-    result += to_string_dec_uint((timestamp.FAT_date >> 9) + 1980);
-    result += '-';
-    result += to_string_dec_uint((timestamp.FAT_date >> 5) & 0xF, 2, '0');
-    result += '-';
-    result += to_string_dec_uint((timestamp.FAT_date & 0x1F), 2, '0');
-    result += ' ';
-    result += to_string_dec_uint((timestamp.FAT_time >> 11), 2, '0');
-    result += ':';
-    result += to_string_dec_uint((timestamp.FAT_time >> 5) & 0x3F, 2, '0');
-    return result;
+    return to_string_dec_uint((timestamp.FAT_date >> 9) + 1980) + "-" +
+           to_string_dec_uint((timestamp.FAT_date >> 5) & 0xF, 2, '0') + "-" +
+           to_string_dec_uint((timestamp.FAT_date & 0x1F), 2, '0') + " " +
+           to_string_dec_uint((timestamp.FAT_time >> 11), 2, '0') + ":" +
+           to_string_dec_uint((timestamp.FAT_time >> 5) & 0x3F, 2, '0');
 }
 
 std::string to_string_file_size(uint32_t file_size) {
@@ -337,25 +339,20 @@ std::string to_string_file_size(uint32_t file_size) {
 }
 
 std::string to_string_mac_address(const uint8_t* macAddress, uint8_t length, bool noColon) {
-    if (length == 0 || macAddress == nullptr) return "";
-    std::string result;
-    // Size = 2 chars per byte + 1 colon between bytes (if used)
-    result.reserve((length * 2) + (noColon ? 0 : length - 1));
-    constexpr char hex_chars[] = "0123456789ABCDEF";
-    for (int i = 0; i < length; i++) {
-        // Append the colon separator (if not the first byte)
-        if (i > 0 && !noColon) {
-            result += ':';
-        }
-        result += hex_chars[(macAddress[i] >> 4) & 0x0F];
-        result += hex_chars[macAddress[i] & 0x0F];
+    std::string string;
+
+    string += to_string_hex(macAddress[0], 2);
+
+    for (int i = 1; i < length; i++) {
+        string += noColon ? to_string_hex(macAddress[i], 2) : ":" + to_string_hex(macAddress[i], 2);
     }
-    return result;
+
+    return string;
 }
 
 std::string to_string_formatted_mac_address(const char* macAddress) {
     std::string formattedAddress;
-    formattedAddress.reserve(17);
+
     for (int i = 0; i < 12; i += 2) {
         if (i > 0) {
             formattedAddress += ':';
@@ -380,16 +377,16 @@ void generateRandomMacAddress(char* macAddress) {
 
 uint64_t readUntil(File& file, char* result, std::size_t maxBufferSize, char delimiter) {
     std::size_t bytesRead = 0;
-    if (maxBufferSize == 0) return 0;
+
     while (true) {
         char ch;
         File::Result<File::Size> readResult = file.read(&ch, 1);
 
         if (readResult.is_ok() && readResult.value() > 0) {
             if (ch == delimiter) {
-                // Found the delimiter character, stop reading
+                // Found a space character, stop reading
                 break;
-            } else if (bytesRead < maxBufferSize - 1) {
+            } else if (bytesRead < maxBufferSize) {
                 // Append the character to the result if there's space
                 result[bytesRead++] = ch;
             } else {
@@ -411,13 +408,12 @@ std::string unit_auto_scale(double n, const uint32_t base_unit, uint32_t precisi
     const uint32_t powers_of_ten[5] = {1, 10, 100, 1000, 10000};
     std::string string{""};
     uint32_t prefix_index = base_unit;
-    if (prefix_index > 6) prefix_index = 6;
     double integer_part;
     double fractional_part;
 
     precision = std::min((uint32_t)4, precision);
 
-    while (n > 1000 && prefix_index < 6) {
+    while (n > 1000) {
         n /= 1000.0;
         prefix_index++;
     }
@@ -430,7 +426,7 @@ std::string unit_auto_scale(double n, const uint32_t base_unit, uint32_t precisi
     if (precision)
         string += '.' + to_string_dec_uint(fractional_part, precision, '0');
 
-    if (unit_prefix[prefix_index] != 0)
+    if (prefix_index != 3)
         string += unit_prefix[prefix_index];
 
     return string;

firmware/application/ui/ui_btngrid.cpp

@@ -28,7 +28,6 @@
 #include "rtc_time.hpp"
 #include "sd_card.hpp"
 #include <algorithm>
-#include "ui_external_items_menu_loader.hpp"
 
 namespace ui {
 
@@ -61,7 +60,6 @@ BtnGridView::BtnGridView(
 }
 
 BtnGridView::~BtnGridView() {
-    ExternalItemsMenuLoader::unload_external_items();
 }
 
 void BtnGridView::set_max_rows(int rows) {
@@ -89,7 +87,6 @@ void BtnGridView::set_parent_rect(const Rect new_parent_rect) {
             remove_child(item.get());
 
         menu_item_views.clear();
-        menu_item_views.shrink_to_fit();
     }
 
     button_w = screen_width / rows_;
@@ -140,7 +137,6 @@ void BtnGridView::set_arrow_down_enabled(bool enabled) {
 void BtnGridView::clear() {
     // clear vector and release memory, not using swap since it's causing capture to glitch/fault
     menu_items.clear();
-    menu_items.shrink_to_fit();
 
     // TODO(u-foka): Clean up my mess, move this somewhere to clear memory when the view is not visible, but not to be confused with clearing the menu items...
     for (auto& item : menu_item_views)
@@ -148,11 +144,10 @@ void BtnGridView::clear() {
 
     // clear vector and release memory, not using swap since it's causing capture to glitch/fault
     menu_item_views.clear();
-    menu_item_views.shrink_to_fit();
 }
 
 void BtnGridView::add_items(std::initializer_list<GridItem> new_items, bool inhibit_update) {
-    for (const auto& item : new_items) {
+    for (auto item : new_items) {
         if (!blacklisted_app(item))
             menu_items.push_back(item);
     }
@@ -394,34 +389,39 @@ bool BtnGridView::on_encoder(const EncoderEvent event) {
 
 /* BlackList ******************************************************/
 
-std::string blacklist_data{};
+std::unique_ptr<char> blacklist_ptr{};
+size_t blacklist_len{};
 
 void load_blacklist() {
     File f;
+
     auto error = f.open(BLACKLIST);
     if (error)
         return;
-    // Resize string to fit file + 2 commas, filling it with commas by default
-    blacklist_data.assign(f.size() + 2, ',');
-    // Read directly into the string's buffer (offset by 1 to leave the first comma)
-    if (f.read(blacklist_data.data() + 1, f.size())) {
-        // Replace any CR/LF characters with commas
-        for (char& c : blacklist_data) {
-            if (c == '\r' || c == '\n') {
-                c = ',';
-            }
+
+    // allocating two extra bytes for leading & trailing commas
+    blacklist_ptr = std::unique_ptr<char>(new char[f.size() + 2]);
+    if (f.read(blacklist_ptr.get() + 1, f.size())) {
+        blacklist_len = f.size() + 2;
+
+        // replace any CR/LF characters with comma delineator, and add comma prefix/suffix, to simplify searching
+        char* ptr = blacklist_ptr.get();
+        *ptr = ',';
+        *(ptr + blacklist_len - 1) = ',';
+        for (size_t i = 0; i < blacklist_len; i++, ptr++) {
+            if (*ptr == 0x0D || *ptr == 0x0A)
+                *ptr = ',';
         }
-    } else {
-        blacklist_data.clear();  // Clear if read fails
     }
 }
 
 bool BtnGridView::blacklisted_app(GridItem new_item) {
     std::string app_name = "," + new_item.text + ",";
-    if (blacklist_data.size() < app_name.size())
+
+    if (blacklist_len < app_name.size())
         return false;
 
-    return blacklist_data.find(app_name) != std::string::npos;
+    return std::search(blacklist_ptr.get(), blacklist_ptr.get() + blacklist_len, app_name.begin(), app_name.end()) < blacklist_ptr.get() + blacklist_len;
 }
 
 void BtnGridView::page_up() {

firmware/application/ui/ui_geomap.cpp

@@ -251,13 +251,15 @@ void GeoMap::map_read_line_bin(ui::Color* buffer, uint16_t pixels) {
             }
         }
     } else {
-        ui::Color zoom_out_buffer[(pixels * (-map_zoom))];
+        ui::Color* zoom_out_buffer = new ui::Color[(pixels * (-map_zoom))];
         map_file.read(zoom_out_buffer, (pixels * (-map_zoom)) << 1);
+
         // Zoom out:  Collapse each group of "-map_zoom" pixels into one pixel.
         // Future TODO: Average each group of pixels (in both X & Y directions if possible).
         for (int i = 0; i < width; i++) {
             buffer[i] = zoom_out_buffer[i * (-map_zoom)];
         }
+        delete[] zoom_out_buffer;
     }
 }
 
@@ -331,9 +333,8 @@ void GeoMap::set_osm_max_zoom(bool changeboth) {
     for (uint8_t i = map_osm_zoom; i > 0; i--) {
         int tile_x = lon2tile(lon_, i);
         int tile_y = lat2tile(lat_, i);
-        char path_buffer[64];
-        snprintf(path_buffer, sizeof(path_buffer), "/OSM/%d/%d/%d.bmp", i, tile_x, tile_y);
-        std::filesystem::path file_path(path_buffer);
+        std::string filename = "/OSM/" + to_string_dec_int(i) + "/" + to_string_dec_int(tile_x) + "/" + to_string_dec_int(tile_y) + ".bmp";
+        std::filesystem::path file_path(filename);
         if (file_exists(file_path)) {
             map_osm_real_zoom = i;
             if (changeboth) map_osm_zoom = i;
@@ -346,7 +347,7 @@ void GeoMap::set_osm_max_zoom(bool changeboth) {
 
 // checks if the tile file presents or not. to determine if we got osm or not
 uint8_t GeoMap::find_osm_file_tile() {
-    std::string filename = "/OSM/0/0/0.bmp";
+    std::string filename = "/OSM/" + to_string_dec_int(0) + "/" + to_string_dec_int(0) + "/" + to_string_dec_int(0) + ".bmp";
     std::filesystem::path file_path(filename);
     if (file_exists(file_path)) return 1;
     return 0;  // not found
@@ -455,24 +456,22 @@ bool GeoMap::draw_osm_file(int zoom, int tile_x, int tile_y, int relative_x, int
         display.fill_rectangle(error_rect, Theme::getInstance()->bg_darkest->background);
         return false;
     }
-
-    map_line_buffer.resize(clip_w);
-
+    std::vector<ui::Color> line(clip_w);
     if (bmp.is_bottomup()) {
         for (int y = clip_h - 1; y >= 0; --y) {
             int source_row = src_y + y;
             int dest_row = dest_y + y;
             bmp.seek(src_x, source_row);
-            bmp.read_next_px_cnt(map_line_buffer.data(), clip_w, false);
-            display.draw_pixels({dest_x + r.left(), dest_row + r.top(), clip_w, 1}, map_line_buffer);
+            bmp.read_next_px_cnt(line.data(), clip_w, false);
+            display.draw_pixels({dest_x + r.left(), dest_row + r.top(), clip_w, 1}, line);
         }
     } else {
         for (int y = 0; y < clip_h; ++y) {
             int source_row = src_y + y;
             int dest_row = dest_y + y;
             bmp.seek(src_x, source_row);
-            bmp.read_next_px_cnt(map_line_buffer.data(), clip_w, false);
-            display.draw_pixels({dest_x + r.left(), dest_row + r.top(), clip_w, 1}, map_line_buffer);
+            bmp.read_next_px_cnt(line.data(), clip_w, false);
+            display.draw_pixels({dest_x + r.left(), dest_row + r.top(), clip_w, 1}, line);
         }
     }
     return true;
@@ -480,11 +479,11 @@ bool GeoMap::draw_osm_file(int zoom, int tile_x, int tile_y, int relative_x, int
 
 void GeoMap::paint(Painter& painter) {
     const auto r = screen_rect();
+    std::vector<ui::Color> map_line_buffer;
+    map_line_buffer.resize(r.width());
     int16_t zoom_seek_x, zoom_seek_y;
 
     if (!use_osm) {
-        map_line_buffer.resize(r.width());
-
         // Ony redraw map if it moved by at least 1 pixel or the markers list was updated
         if (map_zoom <= 1) {
             // Zooming out, or no zoom
@@ -756,7 +755,7 @@ void GeoMap::draw_bearing(const Point origin, const uint16_t angle, uint32_t siz
     display.draw_pixel(origin, color);  // 1 pixel indicating center pivot point of bearing symbol
 }
 
-void GeoMap::draw_marker(Painter& painter, const ui::Point itemPoint, const uint16_t itemAngle, const std::string& itemTag, const Color color, const Color fontColor, const Color backColor) {
+void GeoMap::draw_marker(Painter& painter, const ui::Point itemPoint, const uint16_t itemAngle, const std::string itemTag, const Color color, const Color fontColor, const Color backColor) {
     const auto r = screen_rect();
 
     int tagOffset = 10;

firmware/application/ui/ui_geomap.hpp

@@ -247,7 +247,7 @@ class GeoMap : public Widget {
     ui::Point item_rect_pixel(GeoMarker& item);
     GeoPoint lat_lon_to_map_pixel(float lat, float lon);
     void draw_marker_item(Painter& painter, GeoMarker& item, const Color color, const Color fontColor = Color::white(), const Color backColor = Color::black());
-    void draw_marker(Painter& painter, const ui::Point itemPoint, const uint16_t itemAngle, const std::string& itemTag, const Color color = Color::red(), const Color fontColor = Color::white(), const Color backColor = Color::black());
+    void draw_marker(Painter& painter, const ui::Point itemPoint, const uint16_t itemAngle, const std::string itemTag, const Color color = Color::red(), const Color fontColor = Color::white(), const Color backColor = Color::black());
     void draw_markers(Painter& painter);
     void draw_mypos(Painter& painter);
     void draw_bearing(const Point origin, const uint16_t angle, uint32_t size, const Color color);
@@ -264,9 +264,6 @@ class GeoMap : public Widget {
     double lat_to_pixel_y_tile(double lat, int zoom);
     double tile_pixel_x_to_lon(int x, int zoom);
     double tile_pixel_y_to_lat(int y, int zoom);
-
-    std::vector<ui::Color> map_line_buffer{};
-
     uint8_t map_osm_zoom{5};
     uint8_t map_osm_real_zoom{5};
     double viewport_top_left_px = 0;

firmware/application/ui/ui_menu.cpp

@@ -117,7 +117,6 @@ void MenuView::set_parent_rect(const Rect new_parent_rect) {
             remove_child(item.get());
 
         menu_item_views.clear();
-        menu_item_views.shrink_to_fit();
     }
 
     for (size_t c = 0; c < displayed_max; c++) {
@@ -150,7 +149,6 @@ void MenuView::clear() {
         item->set_item(nullptr);
 
     menu_items.clear();
-    menu_items.shrink_to_fit();
     highlighted_item = 0;
     offset = 0;
 }

firmware/application/ui/ui_rssi.cpp

@@ -46,17 +46,17 @@ RSSI::RSSI(
 void RSSI::paint(Painter& painter) {
     const auto r = screen_rect();
 
+    /* RSSI scaling based on transceiver output voltage range.
+     * MAX2837 (HackRF One): 0.4V to 2.2V
+     * MAX2831 (HackRF Pro): 0.5V to 2.0V (similar enough to use same scaling)
+     */
     constexpr int rssi_sample_range = 256;
-    constexpr float rssi_voltage_min = 0.4;
-#ifdef PRALINE
-    constexpr float rssi_voltage_max = 2.4;
-#else
+    // constexpr float rssi_voltage_min = 0.4;
     constexpr float rssi_voltage_max = 2.2;
-#endif
-
+    // constexpr int raw_min = rssi_sample_range * rssi_voltage_min / adc_voltage_max;
+    constexpr int raw_min = 0;
     constexpr float adc_voltage_max = 3.3;
-    constexpr int raw_min = (rssi_sample_range * rssi_voltage_min) / adc_voltage_max;
-    constexpr int raw_max = (int)(((rssi_sample_range * rssi_voltage_max) / adc_voltage_max) + 0.5f);
+    constexpr int raw_max = rssi_sample_range * rssi_voltage_max / adc_voltage_max;
     constexpr int raw_delta = raw_max - raw_min;
 
     if (!vertical_rssi_enabled) {
@@ -117,6 +117,7 @@ void RSSI::paint(Painter& painter) {
         const Rect r_db{r.left() + x_db, r.top(), 1, r.height()};
 
         if (db_) painter.fill_rectangle(r_db, Color::green());
+
     } else {
         // vertical bottom to top level meters
         const range_t<int> y_avg_range{0, r.height() - 1};
@@ -225,6 +226,7 @@ void RSSI::on_statistics_update(const RSSIStatistics& statistics) {
     min_ = statistics.min;
     avg_ = statistics.accumulator / statistics.count;
     max_ = statistics.max;
+
     if (peak_enabled) {
         peak_duration_ = peak_duration_ + 100;
         if (max_ > peak_) {
@@ -432,38 +434,25 @@ void RSSIGraph::paint(Painter& painter) {
 void RSSIGraph::add_values(int16_t rssi_min, int16_t rssi_avg, int16_t rssi_max, int16_t db) {
     const auto r = screen_rect();
 
-    /* RSSI scaling based on transceiver output voltage range.
-     * MAX2837 (HackRF One): 0.4V to 2.2V
-     * MAX2831 (HackRF Pro): 0.4V to 2.4V
-     */
-
     constexpr int rssi_sample_range = 256;
-    constexpr float rssi_voltage_min = 0.4;
-#ifdef PRALINE
-    constexpr float rssi_voltage_max = 2.4;
-#else
+    // constexpr float rssi_voltage_min = 0.4;
     constexpr float rssi_voltage_max = 2.2;
-#endif
-
+    // constexpr int raw_min = rssi_sample_range * rssi_voltage_min / adc_voltage_max;
+    constexpr int raw_min = 0;
     constexpr float adc_voltage_max = 3.3;
-    constexpr int raw_min = (rssi_sample_range * rssi_voltage_min) / adc_voltage_max;
-    constexpr int raw_max = (int)(((rssi_sample_range * rssi_voltage_max) / adc_voltage_max) + 0.5f);
+    constexpr int raw_max = rssi_sample_range * rssi_voltage_max / adc_voltage_max;
     constexpr int raw_delta = raw_max - raw_min;
 
     // vertical bottom to top level meters
-    // y_avg
     const range_t<int> y_avg_range{0, r.height() - 1};
     const int16_t y_avg = y_avg_range.clip((rssi_avg - raw_min) * r.height() / raw_delta);
-    // y_min
     const range_t<int> y_min_range{0, y_avg};
     const int16_t y_min = y_min_range.clip((rssi_min - raw_min) * r.height() / raw_delta);
-    // y_max
-    const range_t<int> y_max_range{y_avg, r.height() - 1};
+    const range_t<int> y_max_range{y_avg + 1, r.height() - 1};
     const int16_t y_max = y_max_range.clip((rssi_max - raw_min) * r.height() / raw_delta);
-    // range
     const range_t<int> db_range{-80, 10};
     int16_t db_ = db_range.clip(db);
-    db_ -= 10;
+    db_ = db_ - 10;
     db_ = db_ * r.height() / 90;
     db_ = r.height() + db_;
 
@@ -540,6 +529,12 @@ bool RSSI::on_touch(const TouchEvent event) {
 }
 
 void RSSI::set_db(int16_t db) {
+#ifdef PRALINE
+    /* Add a +30dB global boost to align 40MHz/1.2V VCM data
+    with the UI's existing display scale. */
+    db_ = db + 30;
+#else
     db_ = db;
+#endif
 }
 } /* namespace ui */

firmware/application/ui/ui_rssi.hpp

@@ -64,11 +64,18 @@ class RSSI : public Widget {
     void set_db(int16_t db);
 
    private:
+#ifdef PRALINE
+    // Changed from int8_t to uint8_t:
     uint8_t min_ = 0;
     uint8_t avg_ = 0;
     uint8_t max_ = 0;
     uint8_t peak_ = 0;
-
+#else
+    int8_t min_ = 0;
+    int8_t avg_ = 0;
+    int8_t max_ = 0;
+    int8_t peak_ = 0;
+#endif
     size_t peak_duration_ = 0;
     int16_t db_ = 0;
     bool instant_exec_{false};

firmware/application/ui/ui_spectrum.cpp

@@ -361,8 +361,6 @@ void WaterfallView::stop() {
         baseband::spectrum_streaming_stop();
         running_ = false;
     }
-    this->channel_fifo = nullptr;
-    this->audio_spectrum_data = nullptr;
 }
 
 void WaterfallView::show_audio_spectrum_view(const bool show) {

firmware/application/ui/ui_spectrum.hpp

@@ -173,16 +173,12 @@ class WaterfallView : public View {
     MessageHandlerRegistration message_handler_channel_spectrum_config{
         Message::ID::ChannelSpectrumConfig,
         [this](const Message* const p) {
-            if (!running_)
-                return;
             const auto message = *reinterpret_cast<const ChannelSpectrumConfigMessage*>(p);
             this->channel_fifo = message.fifo;
         }};
     MessageHandlerRegistration message_handler_audio_spectrum{
         Message::ID::AudioSpectrum,
         [this](const Message* const p) {
-            if (!running_)
-                return;
             const auto message = *reinterpret_cast<const AudioSpectrumMessage*>(p);
             this->audio_spectrum_data = message.data;
             this->audio_spectrum_update = true;
@@ -190,8 +186,6 @@ class WaterfallView : public View {
     MessageHandlerRegistration message_handler_frame_sync{
         Message::ID::DisplayFrameSync,
         [this](const Message* const) {
-            if (!running_)
-                return;
             if (this->channel_fifo) {
                 ChannelSpectrum channel_spectrum;
                 while (channel_fifo->out(channel_spectrum)) {

firmware/application/ui_external_items_menu_loader.cpp

@@ -9,13 +9,7 @@
 
 namespace ui {
 
-/* static */ std::vector<std::unique_ptr<DynamicBitmap<16, 16>>> ExternalItemsMenuLoader::bitmaps;
-
-// to save ram when entering an app
-void ExternalItemsMenuLoader::unload_external_items() {
-    bitmaps.clear();
-    bitmaps.shrink_to_fit();
-}
+/* static */ std::vector<DynamicBitmap<16, 16>> ExternalItemsMenuLoader::bitmaps;
 
 // iterates over all possible ext apps-s, and if it is runnable on the current system, it'll call the callback, and pass minimal info. used to print to console, and for autostart setting's app list. where the minimal info is enough
 // please keep in sync with load_external_items
@@ -103,9 +97,8 @@ void ExternalItemsMenuLoader::unload_external_items() {
     }
 }
 
-std::vector<ExternalItemsMenuLoader::GridItemEx> ExternalItemsMenuLoader::load_external_items(app_location_t app_location, NavigationView& nav) {
+/* static */ std::vector<ExternalItemsMenuLoader::GridItemEx> ExternalItemsMenuLoader::load_external_items(app_location_t app_location, NavigationView& nav) {
     bitmaps.clear();
-    bitmaps.shrink_to_fit();
 
     std::vector<GridItemEx> external_apps;
 
@@ -133,8 +126,8 @@ std::vector<ExternalItemsMenuLoader::GridItemEx> ExternalItemsMenuLoader::load_e
 
                 gridItem.color = Color((uint16_t)appInfo->icon_color);
 
-                auto dyn_bmp = std::make_unique<DynamicBitmap<16, 16>>(appInfo->bitmap_data);
-                gridItem.bitmap = dyn_bmp->bitmap();
+                auto dyn_bmp = DynamicBitmap<16, 16>{appInfo->bitmap_data};
+                gridItem.bitmap = dyn_bmp.bitmap();
                 bitmaps.push_back(std::move(dyn_bmp));
 
                 gridItem.on_select = [&nav, appInfo, i]() {
@@ -211,8 +204,8 @@ std::vector<ExternalItemsMenuLoader::GridItemEx> ExternalItemsMenuLoader::load_e
         if (versionMatches) {
             gridItem.color = Color((uint16_t)application_information.icon_color);
 
-            auto dyn_bmp = std::make_unique<DynamicBitmap<16, 16>>(application_information.bitmap_data);
-            gridItem.bitmap = dyn_bmp->bitmap();
+            auto dyn_bmp = DynamicBitmap<16, 16>{application_information.bitmap_data};
+            gridItem.bitmap = dyn_bmp.bitmap();
             bitmaps.push_back(std::move(dyn_bmp));
 
             gridItem.on_select = [&nav, app_location, filePath]() {
@@ -262,8 +255,8 @@ std::vector<ExternalItemsMenuLoader::GridItemEx> ExternalItemsMenuLoader::load_e
 
         gridItem.color = Color((uint16_t)application_information.icon_color);
 
-        auto dyn_bmp = std::make_unique<DynamicBitmap<16, 16>>(application_information.bitmap_data);
-        gridItem.bitmap = dyn_bmp->bitmap();
+        auto dyn_bmp = DynamicBitmap<16, 16>{application_information.bitmap_data};
+        gridItem.bitmap = dyn_bmp.bitmap();
         bitmaps.push_back(std::move(dyn_bmp));
 
         gridItem.on_select = [&nav, app_location, filePath]() {
@@ -357,8 +350,6 @@ std::vector<ExternalItemsMenuLoader::GridItemEx> ExternalItemsMenuLoader::load_e
     if (checksum != EXT_APP_EXPECTED_CHECKSUM)
         return false;
 
-    nav.pop();
-    nav.set_last_menu_went_deeper(true);
     application_information.externalAppEntry(nav);
     return true;
 }
@@ -395,8 +386,7 @@ std::vector<ExternalItemsMenuLoader::GridItemEx> ExternalItemsMenuLoader::load_e
         }
     }
 
-    nav.set_last_menu_went_deeper(true);
-    nav.replace<StandaloneView>(app_image);
+    nav.push<StandaloneView>(app_image);
     return true;
 }
 
@@ -410,8 +400,7 @@ std::vector<ExternalItemsMenuLoader::GridItemEx> ExternalItemsMenuLoader::load_e
         }
     }
 
-    nav.set_last_menu_went_deeper(true);
-    nav.replace<StandaloneView>(app_image);
+    nav.push<StandaloneView>(app_image);
     return true;
 }
 

firmware/application/ui_external_items_menu_loader.hpp

@@ -27,44 +27,30 @@
 #include "ui_navigation.hpp"
 #include "external_app.hpp"
 #include "standalone_app.hpp"
-#include <cstring>
+
 #include "file.hpp"
 
 #define EXT_APP_EXPECTED_CHECKSUM 0x00000000
 
 namespace ui {
+
 template <size_t Width, size_t Height>
 class DynamicBitmap {
    public:
-    static constexpr size_t buffer_size = Width * Height / (sizeof(uint8_t) * 8);
+    static constexpr size_t buffer_size = Width * Height / (sizeof(uint8_t) * 8);  // one bit per pixel
 
-    // Main constructor
     DynamicBitmap(const uint8_t data[buffer_size])
-        : _bitmap{{Width, Height}, _buffer.data()} {
-        std::memcpy(_buffer.data(), data, buffer_size);
+        : _buffer(buffer_size, 0),
+          _bitmap{new Bitmap{{Width, Height}, &_buffer[0]}} {
+        memcpy(&_buffer[0], data, buffer_size);
     }
 
-    DynamicBitmap(const DynamicBitmap& other)
-        : _buffer(other._buffer),
-          _bitmap{{Width, Height}, _buffer.data()} {}
-
-    DynamicBitmap(DynamicBitmap&& other) noexcept
-        : _buffer(std::move(other._buffer)),
-          _bitmap{{Width, Height}, _buffer.data()} {}
-
-    DynamicBitmap& operator=(const DynamicBitmap& other) = delete;
-    DynamicBitmap& operator=(DynamicBitmap&& other) noexcept = delete;
-
-    // Destructor (Default is fine, no heap memory to free manually)
-    ~DynamicBitmap() = default;
-
-    const Bitmap* bitmap() const { return &_bitmap; }
+    const Bitmap* bitmap() { return _bitmap.get(); }
 
    private:
-    // Order matters: _buffer must be declared before _bitmap
-    // so it is initialized first and its .data() pointer is valid.
-    std::array<uint8_t, buffer_size> _buffer{};
-    Bitmap _bitmap{};
+    // Allocating both members so the class is movable without invalidation.
+    std::vector<uint8_t> _buffer;
+    std::unique_ptr<Bitmap> _bitmap;
 };
 
 class ExternalItemsMenuLoader {
@@ -79,10 +65,9 @@ class ExternalItemsMenuLoader {
     static bool run_standalone_app(ui::NavigationView&, std::filesystem::path);
     static bool run_module_app(ui::NavigationView&, uint8_t*, size_t);
     static void load_all_external_items_callback(std::function<void(AppInfoConsole&)> callback, bool module_included = false);
-    static void unload_external_items();
 
    private:
-    static std::vector<std::unique_ptr<DynamicBitmap<16, 16>>> bitmaps;
+    static std::vector<DynamicBitmap<16, 16>> bitmaps;
 };
 
 }  // namespace ui

firmware/application/ui_navigation.cpp

@@ -82,61 +82,82 @@ namespace pmem = portapack::persistent_memory;
 
 namespace ui {
 
+bool CstrCmp::operator()(const char* a, const char* b) const {
+    return strcmp(a, b) < 0;
+}
+
+static NavigationView::AppMap generate_app_map(const NavigationView::AppList& appList) {
+    NavigationView::AppMap out;
+
+    for (auto& app : appList) {
+        if (app.id == nullptr) {
+            // Skip items with no id
+            continue;
+        }
+
+        auto res = out.emplace(app.id, app);
+        if (!res.second) {
+            chDbgPanic("Application cannot be added, ID not unique!");
+        }
+    }
+
+    return out;
+}
+
 // TODO(u-foka): Check consistency of command names (where we add rx/tx postfix)
 const NavigationView::AppList NavigationView::appList = {
     /* HOME ******************************************************************/
-    {nullptr, "Receive", HOME, Color::cyan(), &bitmap_icon_receivers, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<ReceiversMenuView>(nav); }},
-    {nullptr, "Transmit", HOME, Color::cyan(), &bitmap_icon_transmit, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<TransmittersMenuView>(nav); }},
-    {nullptr, "Transceiver", HOME, Color::cyan(), &bitmap_icon_transceivers, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<TransceiversMenuView>(nav); }},
-    {"recon", "Recon", HOME, Color::green(), &bitmap_icon_scanner, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<ReconView>(nav); }},
-    {"capture", "Capture", HOME, Color::red(), &bitmap_icon_capture, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<CaptureAppView>(nav); }},
-    {"replay", "Replay", HOME, Color::green(), &bitmap_icon_replay, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<PlaylistView>(nav); }},
-    {"lookingglass", "Looking Glass", HOME, Color::green(), &bitmap_icon_looking, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<GlassView>(nav); }},
-    {nullptr, "Utilities", HOME, Color::cyan(), &bitmap_icon_utilities, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<UtilitiesMenuView>(nav); }},
-    {nullptr, "Games", HOME, Color::cyan(), &bitmap_icon_games, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<GamesMenuView>(nav); }},
-    {nullptr, "Settings", HOME, Color::cyan(), &bitmap_icon_setup, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<SettingsMenuView>(nav); }},
-
+    {nullptr, "Receive", HOME, Color::cyan(), &bitmap_icon_receivers, new ViewFactory<ReceiversMenuView>()},
+    {nullptr, "Transmit", HOME, Color::cyan(), &bitmap_icon_transmit, new ViewFactory<TransmittersMenuView>()},
+    {nullptr, "Transceiver", HOME, Color::cyan(), &bitmap_icon_transceivers, new ViewFactory<TransceiversMenuView>()},
+    {"recon", "Recon", HOME, Color::green(), &bitmap_icon_scanner, new ViewFactory<ReconView>()},
+    {"capture", "Capture", HOME, Color::red(), &bitmap_icon_capture, new ViewFactory<CaptureAppView>()},
+    {"replay", "Replay", HOME, Color::green(), &bitmap_icon_replay, new ViewFactory<PlaylistView>()},
+    {"lookingglass", "Looking Glass", HOME, Color::green(), &bitmap_icon_looking, new ViewFactory<GlassView>()},
+    {nullptr, "Utilities", HOME, Color::cyan(), &bitmap_icon_utilities, new ViewFactory<UtilitiesMenuView>()},
+    {nullptr, "Games", HOME, Color::cyan(), &bitmap_icon_games, new ViewFactory<GamesMenuView>()},
+    {nullptr, "Settings", HOME, Color::cyan(), &bitmap_icon_setup, new ViewFactory<SettingsMenuView>()},
     /* RX ********************************************************************/
-    {"adsbrx", "ADS-B", RX, Color::green(), &bitmap_icon_adsb, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<ADSBRxView>(nav); }},
-    {"ais", "AIS Boats", RX, Color::green(), &bitmap_icon_ais, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<AISAppView>(nav); }},
-    {"aprsrx", "APRS", RX, Color::green(), &bitmap_icon_aprs, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<APRSRXView>(nav); }},
-    {"audio", "Audio", RX, Color::green(), &bitmap_icon_speaker, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<AnalogAudioView>(nav); }},
-    {"blerx", "BLE Rx", RX, Color::green(), &bitmap_icon_btle, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<BLERxView>(nav); }},
-    {"pocsag", "POCSAG", RX, Color::green(), &bitmap_icon_pocsag, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<POCSAGAppView>(nav); }},
-    {"radiosonde", "Radiosnde", RX, Color::green(), &bitmap_icon_sonde, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<SondeView>(nav); }},
-    {"search", "Search", RX, Color::yellow(), &bitmap_icon_search, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<SearchView>(nav); }},
-    {"subghzd", "SubGhzD", RX, Color::yellow(), &bitmap_icon_remote, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<SubGhzDView>(nav); }},
-    {"weather", "Weather", RX, Color::green(), &bitmap_icon_thermometer, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<WeatherView>(nav); }},
-
+    {"adsbrx", "ADS-B", RX, Color::green(), &bitmap_icon_adsb, new ViewFactory<ADSBRxView>()},
+    {"ais", "AIS Boats", RX, Color::green(), &bitmap_icon_ais, new ViewFactory<AISAppView>()},
+    {"aprsrx", "APRS", RX, Color::green(), &bitmap_icon_aprs, new ViewFactory<APRSRXView>()},
+    {"audio", "Audio", RX, Color::green(), &bitmap_icon_speaker, new ViewFactory<AnalogAudioView>()},
+    {"blerx", "BLE Rx", RX, Color::green(), &bitmap_icon_btle, new ViewFactory<BLERxView>()},
+    {"pocsag", "POCSAG", RX, Color::green(), &bitmap_icon_pocsag, new ViewFactory<POCSAGAppView>()},
+    {"radiosonde", "Radiosnde", RX, Color::green(), &bitmap_icon_sonde, new ViewFactory<SondeView>()},
+    {"search", "Search", RX, Color::yellow(), &bitmap_icon_search, new ViewFactory<SearchView>()},
+    {"subghzd", "SubGhzD", RX, Color::yellow(), &bitmap_icon_remote, new ViewFactory<SubGhzDView>()},
+    {"weather", "Weather", RX, Color::green(), &bitmap_icon_thermometer, new ViewFactory<WeatherView>()},
     /* TX ********************************************************************/
-    {"aprstx", "APRS TX", TX, ui::Color::green(), &bitmap_icon_aprs, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<APRSTXView>(nav); }},
-    {"bletx", "BLE Tx", TX, ui::Color::green(), &bitmap_icon_btle, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<BLETxView>(nav); }},
-    {"ooktx", "OOK", TX, ui::Color::yellow(), &bitmap_icon_remote, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<EncodersView>(nav); }},
-    {"rdstx", "RDS", TX, ui::Color::green(), &bitmap_icon_rds, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<RDSView>(nav); }},
-    {"touchtune", "TouchTune", TX, ui::Color::green(), &bitmap_icon_touchtunes, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<TouchTunesView>(nav); }},
-
+    {"aprstx", "APRS TX", TX, ui::Color::green(), &bitmap_icon_aprs, new ViewFactory<APRSTXView>()},
+    {"bletx", "BLE Tx", TX, ui::Color::green(), &bitmap_icon_btle, new ViewFactory<BLETxView>()},
+    {"ooktx", "OOK", TX, ui::Color::yellow(), &bitmap_icon_remote, new ViewFactory<EncodersView>()},
+    {"rdstx", "RDS", TX, ui::Color::green(), &bitmap_icon_rds, new ViewFactory<RDSView>()},
+    {"touchtune", "TouchTune", TX, ui::Color::green(), &bitmap_icon_touchtunes, new ViewFactory<TouchTunesView>()},
     /* TRX ********************************************************************/
-    {"microphone", "Mic", TRX, Color::green(), &bitmap_icon_microphone, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<MicTXView>(nav); }},
-
+    {"microphone", "Mic", TRX, Color::green(), &bitmap_icon_microphone, new ViewFactory<MicTXView>()},
     /* UTILITIES *************************************************************/
-    {"filemanager", "File Manager", UTILITIES, Color::green(), &bitmap_icon_dir, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<FileManagerView>(nav); }},
-    {"freqman", "Freq. Manager", UTILITIES, Color::green(), &bitmap_icon_freqman, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<FrequencyManagerView>(nav); }},
-    {"iqtrim", "IQ Trim", UTILITIES, Color::orange(), &bitmap_icon_trim, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<IQTrimView>(nav); }},
-    {"notepad", "Notepad", UTILITIES, Color::dark_cyan(), &bitmap_icon_notepad, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<TextEditorView>(nav); }},
-    {nullptr, "Debug", UTILITIES, Color::light_grey(), &bitmap_icon_debug, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<DebugMenuView>(nav); }},
+    {"filemanager", "File Manager", UTILITIES, Color::green(), &bitmap_icon_dir, new ViewFactory<FileManagerView>()},
+    {"freqman", "Freq. Manager", UTILITIES, Color::green(), &bitmap_icon_freqman, new ViewFactory<FrequencyManagerView>()},
+    {"iqtrim", "IQ Trim", UTILITIES, Color::orange(), &bitmap_icon_trim, new ViewFactory<IQTrimView>()},
+    {"notepad", "Notepad", UTILITIES, Color::dark_cyan(), &bitmap_icon_notepad, new ViewFactory<TextEditorView>()},
+    {nullptr, "Debug", UTILITIES, Color::light_grey(), &bitmap_icon_debug, new ViewFactory<DebugMenuView>()},
+    //{"testapp", "Test App", UTILITIES, Color::dark_grey(), nullptr, new ViewFactory<TestView>()},
     // Dangerous apps.
-    {nullptr, "Flash Utility", UTILITIES, Color::red(), &bitmap_icon_peripherals_details, [](NavigationView& nav) -> std::unique_ptr<View> { return std::make_unique<FlashUtilityView>(nav); }},
+    {nullptr, "Flash Utility", UTILITIES, Color::red(), &bitmap_icon_peripherals_details, new ViewFactory<FlashUtilityView>()},
 };
 
+const NavigationView::AppMap NavigationView::appMap = generate_app_map(NavigationView::appList);
+
 bool NavigationView::StartAppByName(const char* name) {
     home(false);
 
-    for (const auto& app : appList) {
-        if (app.id != nullptr && strcmp(app.id, name) == 0) {
-            push_view(app.producer(*this));
-            return true;
-        }
+    auto it = appMap.find(name);
+    if (it != appMap.end()) {
+        push_view(std::unique_ptr<View>(it->second.viewFactory->produce(*this)));
+        return true;
     }
+
     return false;
 }
 
@@ -326,11 +347,11 @@ void SystemStatusView::on_battery_data(const BatteryStateMessage* msg) {
         // Only show charging modal when transitioning to charging state
         nav_.display_modal(
             "CHARGING",
-            "Enter deep sleep? \n \nExit: Press reset button. \n \nRX LED: Charging. \nTX LED: Charging error. \nLEDs OFF: Charge complete.",
+            "Screen on while charging?",
             YESNO,
-            [this](bool deepsleep) {
-                if (deepsleep) {
-                    EventDispatcher::charge_deep_sleep(true);
+            [this](bool keep_screen_on) {
+                if (!keep_screen_on) {
+                    EventDispatcher::set_display_sleep(true);
                 }
             });
     }
@@ -476,8 +497,9 @@ void SystemStatusView::on_camera() {
     auto error = png.create(path);
     if (error)
         return;
-    std::vector<ColorRGB888> row(ui::screen_width);
+
     for (int i = 0; i < screen_height; i++) {
+        std::vector<ColorRGB888> row(ui::screen_width);
         portapack::display.read_pixels({0, i, screen_width, 1}, row);
         png.write_scanline(row);
     }
@@ -633,7 +655,6 @@ void NavigationView::pop(bool trigger_update) {
 
     free_view();
     view_stack.pop_back();
-    view_stack.shrink_to_fit();
 
     // NB: These are executed _after_ the view has been
     // destroyed. The old view MUST NOT be referenced in
@@ -757,22 +778,10 @@ void NavigationView::handle_autostart() {
 void add_apps(NavigationView& nav, BtnGridView& grid, app_location_t loc) {
     for (auto& app : NavigationView::appList) {
         if (app.menuLocation == loc) {
-            const AppInfo* p_app = &app;
             grid.add_item({app.displayName, app.iconColor, app.icon,
-                           [&nav, p_app]() {
-                               NavigationView& local_nav = nav;
-                               if (p_app->menuLocation == HOME) {
-                                   local_nav.store_last_menu_name(p_app->displayName);
-                                   local_nav.set_last_menu_went_deeper(false);
-                                   auto new_view = p_app->producer(local_nav);
-                                   local_nav.push_view(std::move(new_view));
-                               } else {
-                                   auto new_view = p_app->producer(local_nav);
-                                   local_nav.pop();
-                                   local_nav.set_last_menu_went_deeper(true);
-                                   local_nav.push_view(std::move(new_view));
-                               }
-                           }},
+                           [&nav, &app]() {
+                            i2cdev::I2CDevManager::set_autoscan_interval(0); //if i navigate away from any menu, turn off autoscan
+                            nav.push_view(std::unique_ptr<View>(app.viewFactory->produce(nav))); }},
                           true);
         }
     };
@@ -799,11 +808,11 @@ void add_external_items(NavigationView& nav, app_location_t location, BtnGridVie
             return a.desired_position < b.desired_position;
         });
 
-        for (auto & gridItem : externalItems) {
+        for (auto const& gridItem : externalItems) {
             if (gridItem.desired_position < 0) {
-                grid.add_item(std::move(gridItem), true);
+                grid.add_item(gridItem, true);
             } else {
-                grid.insert_item(std::move(gridItem), gridItem.desired_position, true);
+                grid.insert_item(gridItem, gridItem.desired_position, true);
             }
 
         }
@@ -931,25 +940,6 @@ SystemView::SystemView(
         {{0, 0},
          {parent_rect.width(), status_view_height}});
     status_view.on_back = [this]() {
-        if (this->navigation_view.view_stack_size() == 2) {
-            const AppInfo* lastmenu = nullptr;
-            const auto last_menu_name = this->navigation_view.get_last_menu_name();
-            this->navigation_view.store_last_menu_name("");
-            if (!last_menu_name.empty()) {
-                for (const auto& app : NavigationView::appList) {
-                    if (app.displayName == last_menu_name) {
-                        lastmenu = &app;
-                        break;
-                    }
-                }
-
-                if (lastmenu && this->navigation_view.get_last_menu_went_deeper()) {
-                    this->navigation_view.pop();
-                    this->navigation_view.push_view(lastmenu->producer(this->navigation_view));
-                    return;
-                }
-            }
-        }
         this->navigation_view.pop();
     };
 
@@ -966,7 +956,6 @@ SystemView::SystemView(
     navigation_view.on_view_changed = [this](const View& new_view) {
         if (!this->navigation_view.is_top()) {
             remove_child(&info_view);
-            i2cdev::I2CDevManager::set_autoscan_interval(0);
         } else {
             add_child(&info_view);
             info_view.refresh();
@@ -1005,8 +994,7 @@ void SystemView::toggle_overlay() {
     static uint8_t last_perf_counter_status = shared_memory.request_m4_performance_counter;
     switch (++overlay_active) {
         case 1:
-            overlay = std::make_unique<DfuMenu>(navigation_view);
-            this->add_child(overlay.get());
+            this->add_child(&this->overlay);
             this->set_dirty();
             shared_memory.request_m4_performance_counter = 1;
             shared_memory.m4_performance_counter = 0;
@@ -1014,16 +1002,13 @@ void SystemView::toggle_overlay() {
             shared_memory.m4_stack_usage = 0;
             break;
         case 2:
-            this->remove_child(overlay.get());
-            overlay.reset();
-            overlay2 = std::make_unique<DfuMenu2>(navigation_view);
-            this->add_child(overlay2.get());
+            this->remove_child(&this->overlay);
+            this->add_child(&this->overlay2);
             this->set_dirty();
             shared_memory.request_m4_performance_counter = 2;
             break;
         case 3:
-            this->remove_child(overlay2.get());
-            overlay2.reset();
+            this->remove_child(&this->overlay2);
             this->set_dirty();
             shared_memory.request_m4_performance_counter = last_perf_counter_status;
             overlay_active = 0;
@@ -1034,13 +1019,15 @@ void SystemView::toggle_overlay() {
 void SystemView::paint_overlay() {
     static bool last_paint_state = false;
     if (overlay_active) {
+        // paint background only every other second
         if ((((chTimeNow() >> 10) & 0x01) == 0x01) == last_paint_state)
             return;
+
         last_paint_state = !last_paint_state;
-        if (overlay_active == 1 && overlay)
-            overlay->set_dirty();
-        else if (overlay_active == 2 && overlay2)
-            overlay2->set_dirty();
+        if (overlay_active == 1)
+            this->overlay.set_dirty();
+        else
+            this->overlay2.set_dirty();
     }
 }
 

firmware/application/ui_navigation.hpp

@@ -50,6 +50,7 @@
 #include "lfsr_random.hpp"
 #include "sd_card.hpp"
 #include "external_app.hpp"
+#include "view_factory.hpp"
 #include "battery.hpp"
 
 // for incrementing fake date when RTC battery is dead
@@ -59,9 +60,6 @@ using namespace sd_card;
 
 namespace ui {
 
-class NavigationView;
-using ViewProducer = std::unique_ptr<View> (*)(NavigationView&);
-
 void add_apps(NavigationView& nav, BtnGridView& grid, app_location_t loc);
 void add_external_items(NavigationView& nav, app_location_t location, BtnGridView& grid, uint8_t error_tile_pos, bool show_error_tile = true);
 
@@ -71,7 +69,12 @@ enum modal_t {
     ABORT
 };
 
-// Should only be used as part of the appList in NavigationView.
+class CstrCmp {
+   public:
+    bool operator()(const char* a, const char* b) const;
+};
+
+// Should only be used as part of the appList in NavigationView, the viewFactory will never be destroyed.
 class AppInfo {
    public:
     const char* id;  // MUST be unique! Used by serial command to start the app so it also has to make sense
@@ -79,7 +82,7 @@ class AppInfo {
     app_location_t menuLocation;
     Color iconColor;
     const Bitmap* icon;
-    ViewProducer producer;
+    ViewFactoryBase* viewFactory;  // Never destroyed, and I believe it's ok ;) Having a unique_ptr here breaks the initializer list of appList
 };
 
 struct AppInfoConsole {
@@ -134,19 +137,15 @@ class NavigationView : public View {
     bool set_on_pop(std::function<void()> on_pop);
 
     // App list is used to preserve order, so the menu items in the menu grid can stay in place
+    // App map is used to look up apps by id used by serial app start
+    using AppMap = std::map<const char*, const AppInfo&, CstrCmp>;
     using AppList = std::vector<AppInfo>;
+    static const AppMap appMap;
     static const AppList appList;
 
     bool StartAppByName(const char* name);  // Starts a View  (app) by name stored in appListFC. This is to start apps from console
     void handle_autostart();
 
-    void store_last_menu_name(const std::string& name) { last_menu_name_ = name; }
-    std::string get_last_menu_name() const { return last_menu_name_; }
-    size_t view_stack_size() const { return view_stack.size(); }
-
-    bool get_last_menu_went_deeper() { return last_menu_went_deeper; }
-    void set_last_menu_went_deeper(bool went_deeper) { last_menu_went_deeper = went_deeper; }
-
    private:
     struct ViewState {
         std::unique_ptr<View> view;
@@ -159,8 +158,6 @@ class NavigationView : public View {
 
     void free_view();
     void update_view();
-    std::string last_menu_name_{};  // this stores the last menu name, when we replace the menu with the app, we'll know, where to navigate back
-    bool last_menu_went_deeper = false;
 };
 
 /* Holds widgets and grows dynamically toward the left.
@@ -454,8 +451,8 @@ class SystemView : public View {
     SystemStatusView status_view{navigation_view};
     InformationView info_view{navigation_view};
     NotificationView notification_view{navigation_view};
-    std::unique_ptr<DfuMenu> overlay{nullptr};
-    std::unique_ptr<DfuMenu2> overlay2{nullptr};
+    DfuMenu overlay{navigation_view};
+    DfuMenu2 overlay2{navigation_view};
     Context& context_;
 };
 

firmware/application/ui_notifications.cpp

@@ -6,8 +6,8 @@ extern ui::SystemView* system_view_ptr;
 
 namespace ui {
 
-NotificationEntryView::NotificationEntryView(NotificationEntry entry, NotificationView* notifhandler)
-    : entry_(std::move(entry)), notifhandler_(notifhandler) {
+NotificationEntryView::NotificationEntryView(const NotificationEntry& entry, NotificationView* notifhandler)
+    : entry_(entry), notifhandler_(notifhandler) {
     add_children({&background, &border, &title_text, &message_text, &close_button});
     border.set_outline(true);
     if (entry_.icon != NOTIF_ICON_NONE) {
@@ -94,12 +94,13 @@ void NotificationView::rearrange_notifications() {
     }
 }
 
-void NotificationView::add_notification(NotificationEntry entry) {
+void NotificationView::add_notification(NotificationEntry& entry) {
     if (notification_views_.size() >= max_notifications) {
         notification_views_.erase(notification_views_.begin());
     }
+
     entry.id = ++curr_not_id;
-    notification_views_.push_back(std::make_unique<NotificationEntryView>(std::move(entry), this));
+    notification_views_.push_back(std::make_unique<NotificationEntryView>(entry, this));
 
     rearrange_notifications();
 }

firmware/application/ui_notifications.hpp

@@ -29,11 +29,11 @@ class NotificationEntry {
     uint16_t id = 0;
 
     NotificationEntry() = default;
-    NotificationEntry(std::string source_app, std::string title, std::string message, notification_icon_t icon = NOTIF_ICON_NONE, uint16_t timeout = 10000, uint16_t id = 0)
-        : source_app(std::move(source_app)), title(std::move(title)), message(std::move(message)), icon(icon), timeout(timeout), id(id) {}
+    NotificationEntry(const std::string& source_app, const std::string& title, const std::string& message, notification_icon_t icon = NOTIF_ICON_NONE, uint16_t timeout = 10000, uint16_t id = 0)
+        : source_app(source_app), title(title), message(message), icon(icon), timeout(timeout), id(id) {}
 
-    static NotificationEntry build(std::string source_app, std::string title, std::string message, notification_icon_t icon = NOTIF_ICON_NONE, uint16_t timeout = 10000) {
-        return NotificationEntry{std::move(source_app), std::move(title), std::move(message), icon, timeout, 0};
+    static NotificationEntry build(const std::string& source_app, const std::string& title, const std::string& message, notification_icon_t icon = NOTIF_ICON_NONE, uint16_t timeout = 10000) {
+        return NotificationEntry{source_app, title, message, icon, timeout, 0};
     }
 
     bool increase_time(uint16_t delta) {
@@ -47,7 +47,8 @@ class NotificationEntry {
 
 class NotificationEntryView : public View {
    public:
-    NotificationEntryView(NotificationEntry entry, NotificationView* notifhandler);
+    NotificationEntryView(const NotificationEntry& entry, NotificationView* notifhandler);
+
     NotificationEntryView(const NotificationEntryView&) = delete;
     NotificationEntryView& operator=(const NotificationEntryView&) = delete;
 
@@ -71,7 +72,7 @@ class NotificationView : public View {
     NotificationView(NavigationView& nav);
     ~NotificationView();
 
-    void add_notification(NotificationEntry entry);
+    void add_notification(NotificationEntry& entry);
     void remove_notification(uint16_t id);
     void open_notification(std::string app_name);
 

firmware/application/ui_record_view.cpp

@@ -99,9 +99,6 @@ RecordView::RecordView(
 
 RecordView::~RecordView() {
     rtc_time::signal_tick_second -= signal_token_tick_second;
-    if (is_active()) {
-        capture_thread.reset();
-    }
 }
 
 void RecordView::focus() {

firmware/application/usb_serial_shell.cpp

@@ -704,7 +704,6 @@ static void printAppInfo(BaseSequentialStream* chp, ui::AppInfoConsole& element)
 }
 
 static void printAppInfo(BaseSequentialStream* chp, const ui::AppInfo& element) {
-    if (element.id == nullptr) return;
     if (strlen(element.id) == 0) return;
     chprintf(chp, element.id);
     chprintf(chp, " ");
@@ -741,9 +740,9 @@ static void cmd_applist(BaseSequentialStream* chp, int argc, char* argv[]) {
     if (!top_widget) return;
     auto nav = static_cast<ui::SystemView*>(top_widget)->get_navigation_view();
     if (!nav) return;
-    // todo U-foka : sort the list
-    for (auto& element : ui::NavigationView::appList) {
-        printAppInfo(chp, element);
+    // TODO(u-foka): Somehow order static and dynamic app lists together
+    for (auto& element : ui::NavigationView::appMap) {  // Use the map as its ordered by id
+        printAppInfo(chp, element.second);
     }
     ui::ExternalItemsMenuLoader::load_all_external_items_callback([chp](ui::AppInfoConsole& info) {
         printAppInfo(chp, info);
@@ -1263,7 +1262,7 @@ static void cmd_settingsreset(BaseSequentialStream* chp, int argc, char* argv[])
 }
 
 static void cmd_sendpocsag(BaseSequentialStream* chp, int argc, char* argv[]) {
-    const char* usage = "usage: sendpocsag <addr> <msglen> [baud] [type] [function] [polarity:S|I] \r\n";
+    const char* usage = "usage: sendpocsag <addr> <msglen> [baud] [type] [function] [phase] \r\n";
     (void)argv;
     if (argc < 2) {
         chprintf(chp, usage);
@@ -1294,48 +1293,34 @@ static void cmd_sendpocsag(BaseSequentialStream* chp, int argc, char* argv[]) {
         }
     }
 
-    char function = 'A';
+    char function = 'D';
     if (argc >= 5) {
         function = *argv[4];
-        if (function < 'A' || function > 'D') {
+        if (function < 'A' && function > 'D') {
             chprintf(chp, "error, function can be A, B, C or D\r\n");
             return;
         }
     }
 
-    char polarity = 'S'; /* Standard = CCIR Rec. 584 (bit 1 = negative deviation) */
+    char phase = 'P';
     if (argc >= 6) {
-        polarity = *argv[5];
-        /*
-         * Legacy compatibility: old firmware used 'P'/'N' with opposite semantics.
-         *   Old 'P' (phase=positive) = inverted codewords = standard POCSAG = new 'S' (Standard)
-         *   Old 'N' (phase=negative) = no inversion = inverted POCSAG = new 'I' (Inverted)
-         * New firmware uses 'S'/'I':
-         *   'S' = Standard (CCIR Rec. 584, bit 1 = negative deviation)
-         *   'I' = Inverted (bit 1 = positive deviation)
-         */
-        if (polarity == 'P') polarity = 'S'; /* legacy 'P' maps to Standard */
-        if (polarity == 'N') polarity = 'I'; /* legacy 'N' maps to Inverted */
-        if (polarity != 'S' && polarity != 'I') {
-            chprintf(chp, "error, polarity can be S (Standard) or I (Inverted)\r\n");
+        phase = *argv[5];
+        if (phase != 'P' && phase != 'N') {
+            chprintf(chp, "error, phase can be P or N\r\n");
             return;
         }
     }
 
-    uint8_t msg[31] = {0};
-    uint8_t original_msglen = (msglen > 31) ? 31 : msglen;
-    if (original_msglen > 0) {
-        chprintf(chp, "send %d bytes\r\n", original_msglen);
-        size_t offset = 0;
-        size_t remaining = original_msglen;
-        while (remaining > 0) {
-            size_t bytes_to_read = remaining > USB_BULK_BUFFER_SIZE ? USB_BULK_BUFFER_SIZE : remaining;
-            size_t bytes_read = chSequentialStreamRead(chp, &msg[offset], bytes_to_read);
+    uint8_t msg[81] = {0};
+    if (msglen > 0) {
+        chprintf(chp, "send %d bytes\r\n", msglen);
+        do {
+            size_t bytes_to_read = msglen > USB_BULK_BUFFER_SIZE ? USB_BULK_BUFFER_SIZE : msglen;
+            size_t bytes_read = chSequentialStreamRead(chp, &msg[0], bytes_to_read);
             if (bytes_read != bytes_to_read)
                 return;
-            offset += bytes_read;
-            remaining -= bytes_read;
-        }
+            msglen -= bytes_read;
+        } while (msglen > 0);
     }
 
     auto evtd = getEventDispatcherInstance();
@@ -1349,54 +1334,7 @@ static void cmd_sendpocsag(BaseSequentialStream* chp, int argc, char* argv[]) {
         return;
     }
     chThdSleepMilliseconds(1000);  // wait for app to start
-    PocsagTosendMessage message{(uint16_t)baud, (uint8_t)type, function, polarity, original_msglen, msg, addr};
-    EventDispatcher::send_message(message);
-    chprintf(chp, "ok\r\n");
-}
-
-static void cmd_sendflex(BaseSequentialStream* chp, int argc, char* argv[]) {
-    const char* usage = "usage: sendflex <capcode> <type> <msglen>\r\n  type: 0=alpha 1=numeric 2=short/tone 3=short numeric\r\n";
-    if (argc < 3) {
-        chprintf(chp, usage);
-        return;
-    }
-    uint64_t capcode = strtoull(argv[0], nullptr, 10);
-    if (capcode < 1 || capcode > 4297068542ULL) {
-        chprintf(chp, "error, capcode 1-4297068542\r\n");
-        return;
-    }
-    int type = atoi(argv[1]);
-    if (type < 0 || type > 3) {
-        chprintf(chp, "error, type 0=alpha 1=numeric 2=short/tone 3=short numeric\r\n");
-        return;
-    }
-    int msglen = atoi(argv[2]);
-    if (msglen < 0 || msglen > 240) {
-        chprintf(chp, "error, msglen max 240\r\n");
-        return;
-    }
-
-    uint8_t msg[240] = {0};
-    if (msglen > 0) {
-        chprintf(chp, "send %d bytes\r\n", msglen);
-        int offset = 0;
-        do {
-            size_t bytes_to_read = (msglen - offset) > USB_BULK_BUFFER_SIZE ? USB_BULK_BUFFER_SIZE : (msglen - offset);
-            size_t bytes_read = chSequentialStreamRead(chp, &msg[offset], bytes_to_read);
-            if (bytes_read != bytes_to_read)
-                return;
-            offset += bytes_read;
-        } while (offset < msglen);
-    }
-
-    auto evtd = getEventDispatcherInstance();
-    if (!evtd) return;
-    auto top_widget = evtd->getTopWidget();
-    if (!top_widget) return;
-    auto nav = static_cast<ui::SystemView*>(top_widget)->get_navigation_view();
-    if (!nav) return;
-
-    FlexTosendMessage message{capcode, (uint8_t)type, (uint8_t)msglen, msg};
+    PocsagTosendMessage message{(uint16_t)baud, (uint8_t)type, function, phase, (uint8_t)msglen, msg, addr};
     EventDispatcher::send_message(message);
     chprintf(chp, "ok\r\n");
 }
@@ -1548,7 +1486,6 @@ static const ShellCommand commands[] = {
     {"pmemreset", cmd_pmemreset},
     {"settingsreset", cmd_settingsreset},
     {"sendpocsag", cmd_sendpocsag},
-    {"sendflex", cmd_sendflex},
     {"asyncmsg", cmd_asyncmsg},
     {"setfreq", cmd_setfreq},
     {"getres", cmd_getres},

firmware/application/view_factory.hpp

@@ -0,0 +1,39 @@
+/*
+ * Copyright 2024 Tamas Eisenberger <e.tamas@iwstudio.hu>
+ *
+ * This file is part of PortaPack.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2, or (at your option)
+ * any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; see the file COPYING.  If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#ifndef __VIEW_FACTORY_HPP__
+#define __VIEW_FACTORY_HPP__
+
+#include "view_factory_base.hpp"
+
+namespace ui {
+
+template <typename T>
+class ViewFactory : public ViewFactoryBase {
+   public:
+    virtual std::unique_ptr<View> produce(NavigationView& nav) const override {
+        return std::unique_ptr<View>(new T(nav));
+    }
+};
+
+}  // namespace ui
+
+#endif  //__VIEW_FACTORY_HPP__

firmware/application/view_factory_base.cpp

@@ -0,0 +1,28 @@
+/*
+ * Copyright 2024 Tamas Eisenberger <e.tamas@iwstudio.hu>
+ *
+ * This file is part of PortaPack.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2, or (at your option)
+ * any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; see the file COPYING.  If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include "view_factory_base.hpp"
+
+namespace ui {
+
+ViewFactoryBase::~ViewFactoryBase() {}
+
+}  // namespace ui

firmware/application/view_factory_base.hpp

@@ -0,0 +1,40 @@
+/*
+ * Copyright 2024 Tamas Eisenberger <e.tamas@iwstudio.hu>
+ *
+ * This file is part of PortaPack.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2, or (at your option)
+ * any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; see the file COPYING.  If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#ifndef __VIEW_FACTORY_BASE_HPP__
+#define __VIEW_FACTORY_BASE_HPP__
+
+#include <memory>
+#include "ui_widget.hpp"
+
+namespace ui {
+
+class NavigationView;
+
+class ViewFactoryBase {
+   public:
+    virtual ~ViewFactoryBase();
+    virtual std::unique_ptr<View> produce(NavigationView& nav) const = 0;
+};
+
+}  // namespace ui
+
+#endif  //__VIEW_FACTORY_BASE_HPP__

firmware/baseband/CMakeLists.txt

@@ -380,6 +380,13 @@ set(MODE_CPPSRC
 )
 DeclareTargets(PCAP capture)
 
+### ERT
+
+set(MODE_CPPSRC
+	proc_ert.cpp
+)
+DeclareTargets(PERT ert)
+
 ### Radiosonde
 
 set(MODE_CPPSRC
@@ -445,6 +452,13 @@ set(MODE_CPPSRC
 DeclareTargets(PREP replay)
 
 
+### Tones
+
+set(MODE_CPPSRC
+	proc_tones.cpp
+)
+DeclareTargets(PTON tones)
+
 
 ### Wideband Spectrum
 
@@ -669,14 +683,6 @@ set(MODE_CPPSRC
 )
 DeclareTargets(PSCD subcar)
 
-### Tone Detect RX
-
-set(MODE_CPPSRC
-    proc_tonedetect.cpp
-)
-DeclareTargets(PTNE tonedetect)
-
-
 ### Morse RX Decoder
 
 set(MODE_CPPSRC
@@ -693,15 +699,6 @@ set(MODE_CPPSRC
 DeclareTargets(PRTR rtty_rx)
 
 
-
-### ERT
-
-set(MODE_CPPSRC
-	proc_ert.cpp
-)
-DeclareTargets(PERT ert)
-
-
 ### RTTY TX
 
 set(MODE_CPPSRC
@@ -724,15 +721,6 @@ set(MODE_CPPSRC
 )
 DeclareTargets(PMRT morsetx)
 
-### Tones
-
-set(MODE_CPPSRC
-	proc_tones.cpp
-)
-DeclareTargets(PTON tones)
-
-
-
 ### Time Sink
 
 set(MODE_CPPSRC
@@ -758,8 +746,6 @@ set(MODE_CPPSRC
 	${HACKRF_PATH}/firmware/common/usb_request.c
 	${HACKRF_PATH}/firmware/common/usb_standard_request.c
 	${HACKRF_PATH}/firmware/common/platform_detect.c
-	${HACKRF_PATH}/firmware/common/platform_gpio.c
-	${HACKRF_PATH}/firmware/common/platform_scu.c
 	${HACKRF_PATH}/firmware/common/gpio_lpc.c
 	${HACKRF_PATH}/firmware/common/firmware_info.c
 	${HACKRF_PATH}/firmware/common/si5351c.c

firmware/baseband/baseband_thread.cpp

@@ -102,6 +102,31 @@ void BasebandThread::run() {
             buffer_c8_t buffer{
                 buffer_tmp.p, buffer_tmp.count, sampling_rate_};
 
+#ifdef PRALINE
+            /*
+             * Software RSSI: Copy 8 I/Q samples spread across buffer.
+             *
+             * Just pack and copy - no computation here.
+             * rssi_thread does __SMUAD power and rssi calculation.
+             * 8 samples avoids zero-crossing artifacts.
+             */
+            if (direction_ == baseband::Direction::Receive && buffer_tmp.count >= 32) {
+                const size_t step = buffer_tmp.count / 8;
+
+                for (size_t i = 0; i < 8; i++) {
+                    const size_t idx = i * step + (step / 2);
+                    const auto sample = buffer_tmp.p[idx];
+
+                    // Pack into 32 bits: Q in high 16 bits, I in low 16 bits, the safe approach:
+                    // 1. Cast to uint16_t to capture the raw 16-bit pattern (e.g., -1 becomes 0xFFFF)
+                    // 2. OR them together. The uint16_t will be promoted to uint32_t cleanly.
+                    // This is accomplished with the specific hardware instruction designed
+                    // for this __PKHBT (Pack Halfword Bottom Top).
+                    shared_memory.software_rssi_iq[i] = __PKHBT(sample.real(), sample.imag(), 16);
+                }
+            }
+#endif
+
             if (shared_memory.request_m4_performance_counter == 0x02) {
                 uint8_t max = shared_memory.m4_performance_counter;
                 for (size_t i = 0; i < buffer_tmp.count; i++) {

firmware/baseband/proc_epirb_tx.cpp

@@ -46,15 +46,15 @@ void EPIRBTXProcessor::execute(const buffer_c8_t& buffer) {
         if (mode_bpsk) {
             // BPSK Manchester beacon signal
             if (bpsk_pre_count < config_pre_count) {
-                // Pre-count state: send carrier only during pre-count
+                // Pre-count state: send a negative phase carrier during pre-count
                 bpsk_pre_count++;
-                re = i_carrier;
-                im = q_carrier;
+                re = i_neg;
+                im = q_neg;
             } else if (bpsk_post_count > 0) {
-                // Post-count: send carrier only during post-count
+                // Post-count: send a negative phase carrier during post-count
                 bpsk_post_count++;
-                re = i_carrier;
-                im = q_carrier;
+                re = i_neg;
+                im = q_neg;
                 if (bpsk_post_count >= config_post_count) {
                     // End transmission here
                     byte_index = 0;

firmware/baseband/proc_epirb_tx.hpp

@@ -60,17 +60,14 @@ class EPIRBTXProcessor : public BasebandProcessor {
     // Size of the frame to send in BPSK mode
     uint8_t frame_data_len = 0;
 
-    // BPSK parameters: Target phase +/-1.1 RAD as per COSPAS/SARSAT specifications
-    static constexpr float phase_rad = 1.1f;
+    // BPSK parameters: Target phase +/-63° as per COSPAS/SARSAT specifications
+    static constexpr float phase_rad = 63.0f * M_PI / 180.0f;
 
     // I/Q values for BPSK (positive phase and negative phase)
     int8_t i_pos = (int8_t)(cos(phase_rad) * 127);
     int8_t q_pos = (int8_t)(sin(phase_rad) * 127);
     int8_t i_neg = i_pos;
     int8_t q_neg = -q_pos;
-    // I/Q values for carrier only
-    static constexpr int8_t i_carrier = 127;
-    static constexpr int8_t q_carrier = 0;
 
     // COSPAS/SARSAT signal is manchester (2 states per bit) encoded 400 bit/sec
     static const uint32_t samples_per_halfbit = TONES_SAMPLERATE / 400 / 2;

firmware/baseband/proc_flex.cpp

@@ -7,45 +7,7 @@
 
 #include <cmath>
 #include <cstring>
-
-// BCD character table for FLEX numeric messages (index 0-15)
-static const char flex_bcd[] = "0123456789.U -][";
-
-// Lightweight string helpers (no snprintf/heap on bare-metal M4)
-namespace {
-
-char* str_append(char* dst, const char* end, const char* src) {
-    while (*src && dst < end - 1) *dst++ = *src++;
-    *dst = '\0';
-    return dst;
-}
-
-char* str_uint(char* dst, const char* end, uint32_t val, int min_digits = 1) {
-    char tmp[11];
-    int i = 0;
-    if (val == 0) {
-        tmp[i++] = '0';
-    } else {
-        while (val > 0) {
-            tmp[i++] = '0' + (val % 10);
-            val /= 10;
-        }
-    }
-    while (i < min_digits) tmp[i++] = '0';
-    for (int j = i - 1; j >= 0 && dst < end - 1; j--) *dst++ = tmp[j];
-    *dst = '\0';
-    return dst;
-}
-
-char* str_hex(char* dst, const char* end, uint32_t val, int digits) {
-    static const char hex[] = "0123456789ABCDEF";
-    for (int i = digits - 1; i >= 0 && dst < end - 1; i--)
-        *dst++ = hex[(val >> (i * 4)) & 0xF];
-    *dst = '\0';
-    return dst;
-}
-
-}  // namespace
+#include <cstdio>  // for snprintf
 
 // Constants from demod_flex.c
 #define FREQ_SAMP 24000  // Our sample rate
@@ -193,6 +155,7 @@ uint32_t bit_reverse_32(uint32_t x) {
 
 void FlexProcessor::send_debug(const char* text, uint32_t v1, uint32_t v2) {
     if (shared_memory.application_queue.is_empty()) return;
+
     FlexDebugMessage message(v1, v2, text);
     shared_memory.application_queue.push(message);
 }
@@ -440,9 +403,7 @@ int FlexProcessor::decode_fiw() {
     fiw.checksum = fiw_val & 0xF;
     fiw.cycleno = (fiw_val >> 4) & 0xF;
     fiw.frameno = (fiw_val >> 8) & 0x7F;
-    fiw.roaming = (fiw_val >> 15) & 0x01;
-    fiw.repeat = (fiw_val >> 16) & 0x01;
-    fiw.traffic = (fiw_val >> 17) & 0x0F;
+    fiw.fix3 = (fiw_val >> 15) & 0x3F;
 
     unsigned int checksum = (fiw_val & 0xF);
     checksum += ((fiw_val >> 4) & 0xF);
@@ -548,9 +509,6 @@ void FlexProcessor::flex_sym(unsigned char sym) {
             if (state.fiwcount == 48) {
                 if (decode_fiw() == 0) {
                     state.sync2_count = 0;
-                    state.sync2_shiftreg = 0;
-                    state.sync2_c_pos = -1;
-                    state.sync2_cinv_pos = -1;
                     demodulator.baud = sync.baud;
                     state.Current = flex::State::SYNC2;
                     send_debug("FIW OK", fiw.frameno, fiw.cycleno);
@@ -562,48 +520,8 @@ void FlexProcessor::flex_sym(unsigned char sym) {
             break;
         }
         case flex::State::SYNC2: {
-            /* S2 structure: BS2 + C(16 bits) + inv.BS2 + inv.C(16 bits)
-             * Total duration: 25ms at the data symbol rate.
-             *
-             * We scan for the 16-bit C pattern (0xED84) using a shift
-             * register.  If found, we validate timing.  If not found,
-             * we fall back to the nominal 25ms skip (current behavior).
-             *
-             * Only the MSB (bit_a) matters for C detection - it's a
-             * 2-level pattern even in 4FSK modes. */
-            unsigned char s2_sym = sync.polarity ? (3 - sym) : sym;
-            int bit_a = (s2_sym > 1) ? 1 : 0;
-            state.sync2_shiftreg = (state.sync2_shiftreg << 1) | bit_a;
-            state.sync2_count++;
-
-            /* Check for C pattern match (Hamming distance <= 2) */
-            if (state.sync2_count >= 16) {
-                uint16_t diff_c = state.sync2_shiftreg ^ 0xED84;
-                uint16_t diff_cinv = state.sync2_shiftreg ^ 0x127B;
-                int errs_c = __builtin_popcount(diff_c);
-                int errs_cinv = __builtin_popcount(diff_cinv);
-
-                if (errs_c <= 2 && state.sync2_c_pos < 0)
-                    state.sync2_c_pos = (int)state.sync2_count;
-                if (errs_cinv <= 2 && state.sync2_cinv_pos < 0)
-                    state.sync2_cinv_pos = (int)state.sync2_count;
-            }
-
-            /* Nominal S2 duration in symbols */
-            unsigned int s2_nominal = sync.baud * 25 / 1000;
-
-            /* Data starts after inv.C ends.  If we detected inv.C,
-             * use its position as the true data boundary.  Otherwise
-             * fall back to the nominal count. */
-            unsigned int s2_end = s2_nominal;
-            if (state.sync2_cinv_pos > 0) {
-                unsigned int cinv_end = (unsigned int)state.sync2_cinv_pos;
-                int diff = (int)cinv_end - (int)s2_nominal;
-                if (diff >= -1 && diff <= 1)
-                    s2_end = cinv_end;
-            }
-
-            if (state.sync2_count == s2_end) {
+            if (++state.sync2_count == sync.baud * 25 / 1000) {
+                state.data_count = 0;
                 // Clear phase data
                 for (int i = 0; i < 88; i++) {
                     data.PhaseA.buf[i] = 0;
@@ -617,21 +535,9 @@ void FlexProcessor::flex_sym(unsigned char sym) {
                 data.PhaseD.idle_count = 0;
                 data.phase_toggle = 0;
                 data.data_bit_counter = 0;
-                state.data_count = 0;
-
-                state.sync2_shiftreg = 0;
-                state.sync2_c_pos = -1;
-                state.sync2_cinv_pos = -1;
 
                 state.Current = flex::State::DATA;
             }
-            /* Safety: don't get stuck past nominal */
-            if (state.sync2_count > s2_nominal + 1) {
-                state.sync2_shiftreg = 0;
-                state.sync2_c_pos = -1;
-                state.sync2_cinv_pos = -1;
-                state.Current = flex::State::SYNC1;
-            }
             break;
         }
         case flex::State::DATA: {
@@ -687,204 +593,26 @@ void FlexProcessor::decode_phase(char PhaseNo) {
             return;
     }
 
-    /* Check if phase is all idle BEFORE BCH correction.
-     * Idle fill uses alternating 0xFFFFFFFF and 0x00000000 words.
-     * If every word is one of these two patterns, the phase has no
-     * real data - skip it to avoid BCH "correcting" idle into garbage. */
-    {
-        int all_idle = 1;
-        for (int i = 0; i < 88; i++) {
-            if (phaseptr[i] != 0xFFFFFFFF && phaseptr[i] != 0x00000000) {
-                all_idle = 0;
-                break;
-            }
-        }
-        if (all_idle) return;
-    }
-
-    /* BCH decode each word. Mark uncorrectable words but continue. */
-    uint8_t word_bad[88] = {0};
     for (int i = 0; i < 88; i++) {
         int decode_error = bch_fix_errors(&phaseptr[i]);
-        if (decode_error > 2) {
-            word_bad[i] = 1;
-            phaseptr[i] = 0;
-        }
-        phaseptr[i] &= 0x001FFFFF;
+        if (decode_error > 2) return;
+        phaseptr[i] &= 0x001FFFFF;  // Extract message bits
     }
 
-    /* BIW must be good to proceed */
-    if (word_bad[0]) return;
-
     uint32_t biw = phaseptr[0];
     if (biw == 0 || biw == 0x001FFFFF) return;
 
     int voffset = (biw >> 10) & 0x3f;
     int aoffset = ((biw >> 8) & 0x03) + 1;
-    int prio_count = (biw >> 4) & 0x0F;  // number of priority address words
 
-    if (voffset < aoffset || voffset >= 88) return;
-
-    /* Always send BIW1 packet so the app knows we decoded a frame.
-     * This updates the status bar even for idle frames. */
-    {
-        flex::FlexPacket bpkt{};
-        bpkt.type = 9;
-        bpkt.bitrate = sync.baud * (sync.levels == 4 ? 2 : 1);
-        bpkt.cycle = fiw.cycleno;
-        bpkt.frame = fiw.frameno;
-        bpkt.phase = PhaseNo;
-        bpkt.is_inverted = sync.polarity;
-        bpkt.fiw_roaming = fiw.roaming;
-        bpkt.function = 0;
-        bpkt.biw_field = 0xFF;
-        bpkt.message[0] = '\0';
-        send_packet(bpkt);
-    }
-
-    /* Parse BIW words (indices 1 through aoffset-1).
-     * Each BIW word has a 3-bit type field (bits 4-6) that determines content.
-     * Send each as a BIW event packet. */
-    for (int bw = 1; bw < aoffset && bw < 88; bw++) {
-        if (word_bad[bw]) continue;
-        uint32_t bword = phaseptr[bw];
-        uint32_t btype = (bword >> 4) & 0x07;
-
-        /* Skip reserved types (3, 4, 6) */
-        if (btype == 3 || btype == 4 || btype == 6) continue;
-
-        flex::FlexPacket bpkt{};
-        bpkt.type = 9;  // BIW event
-        bpkt.bitrate = sync.baud * (sync.levels == 4 ? 2 : 1);
-        bpkt.cycle = fiw.cycleno;
-        bpkt.frame = fiw.frameno;
-        bpkt.phase = PhaseNo;
-        bpkt.is_inverted = sync.polarity;
-        bpkt.fiw_roaming = fiw.roaming;
-        bpkt.function = bw;      // BIW word index
-        bpkt.biw_field = btype;  // BIW type (0,1,2,5,7)
-        bpkt.message[0] = '\0';
-
-        switch (btype) {
-            case 0:  // SSID1: v1=lid, v2=cz
-                bpkt.biw_v1 = (bword >> 12) & 0x01FF;
-                bpkt.biw_v2 = (bword >> 7) & 0x1F;
-                break;
-            case 1:  // Date: v1=year(+1994), v2=month, v3=day
-                bpkt.biw_v1 = ((bword >> 7) & 0x1F) + 1994;
-                bpkt.biw_v2 = (bword >> 17) & 0x0F;
-                bpkt.biw_v3 = (bword >> 12) & 0x1F;
-                break;
-            case 2:  // Time: v1=hour, v2=minute, v3=sec_raw(0-7)
-                bpkt.biw_v1 = (bword >> 7) & 0x1F;
-                bpkt.biw_v2 = (bword >> 12) & 0x3F;
-                bpkt.biw_v3 = (bword >> 18) & 0x07;
-                break;
-            case 5:  // SysInfo: v1=a_type, v2=info(10 bits)
-                bpkt.biw_v1 = (bword >> 7) & 0x0F;
-                bpkt.biw_v2 = (bword >> 11) & 0x03FF;
-                break;
-            case 7:  // SSID2: v1=country, v2=tmf
-                bpkt.biw_v1 = (bword >> 11) & 0x03FF;
-                bpkt.biw_v2 = (bword >> 7) & 0x0F;
-                break;
-            default:
-                continue;
-        }
-        send_packet(bpkt);
-    }
-
-    /* Pre-scan: count valid vector words using 4-bit nibble checksum.
-     * Tone-only addresses sit at the end of the address field with no
-     * corresponding vector.  We find the last vector that passes checksum.
-     * Note: for long addresses, the 2nd vector word (Vy) is a message word
-     * that won't pass checksum - so we count all passing words, not just
-     * consecutive ones from the start. */
-    int n_valid_vecs = 0;
-    for (int vi = 0; vi < (voffset - aoffset); vi++) {
-        int wi = voffset + vi;
-        if (wi >= 88) break;
-        uint32_t vw = phaseptr[wi];
-        uint32_t csum = (vw & 0xF) + ((vw >> 4) & 0xF) + ((vw >> 8) & 0xF) +
-                        ((vw >> 12) & 0xF) + ((vw >> 16) & 0xF) + ((vw >> 20) & 0x1);
-        if ((csum & 0xF) == 0xF)
-            n_valid_vecs = vi + 1;  // track highest passing index + 1
-    }
-
-    /* No addresses if voffset == aoffset */
-    if (voffset <= aoffset) return;
-
-    int vec_count = 0;
-    int addr_count = 0;  // tracks address word position for priority detection
     for (int i = aoffset; i < voffset; i++) {
-        int j = voffset + vec_count;
-        if (j >= 88) break;
+        int j = voffset + i - aoffset;
         if (phaseptr[i] == 0x00000000 || phaseptr[i] == 0x001FFFFF) continue;
 
-        /* Address word - all 21 information bits are address data
-         * per 3.8.2.  Address type is determined by value range
-         * (Table 3.8.1-1).  Temporary addresses are range
-         * 0x1F7800-0x1F780F (3.8.2.3), identified via addr_type. */
-        int is_priority = (addr_count < prio_count) ? 1 : 0;
-
         parse_capcode(phaseptr[i]);
-        decode.is_priority = is_priority;
-        addr_count++;
+        if (decode.long_address) continue;  // Skip long addresses for now
 
-        if (decode.long_address) {
-            /* Long address: 2 address words, 2 vector words.
-             * Read second address word and compute capcode from set. */
-            if (i + 1 >= voffset) break;  // truncated
-            uint32_t aw1 = phaseptr[i];
-            uint32_t aw2 = phaseptr[i + 1];
-            if (aw2 == 0x00000000 || aw2 == 0x001FFFFF) {
-                i++;
-                addr_count++;  // second address word counts
-                vec_count += 2;
-                continue;
-            }
-
-            int64_t cap = 0;
-            if (aw1 >= 0x000001 && aw1 <= 0x008000 &&
-                aw2 >= 0x1F7FFF && aw2 <= 0x1FFFFE) {
-                /* Set 1-2 */
-                cap = (int64_t)aw1 + (int64_t)(0x1FFFFF - aw2) * 32768LL + 2068480LL;
-            } else if (aw1 >= 0x000001 && aw1 <= 0x008000 &&
-                       aw2 >= 0x1E0001 && aw2 <= 0x1F0000) {
-                /* Set 1-3 / 1-4 */
-                cap = (int64_t)aw1 + (int64_t)(aw2 - 1933312) * 32768LL + 2068480LL;
-            } else if (aw1 >= 0x1F7FFF && aw1 <= 0x1FFFFE &&
-                       aw2 >= 0x1E0001 && aw2 <= 0x1F0000) {
-                /* Set 2-3 */
-                cap = (int64_t)(aw1 - 2064383) + (int64_t)(aw2 - 1867776) * 32768LL + 2068479LL;
-            } else {
-                /* Unknown set - skip */
-                i++;
-                addr_count++;  // second address word counts
-                vec_count += 2;
-                continue;
-            }
-
-            decode.capcode = cap;
-            i++;           // consumed 2 address words
-            addr_count++;  // second address word also counts
-
-            /* Long addresses always have vectors - they cannot be tone-only.
-             * (Tone-only is only for short addresses at the end of AF.)
-             * The second vector word (Vy) contains the first message word,
-             * not a checksummed vector, so skip the pre-scan check here. */
-            vec_count += 2;               // consumed 2 vector words
-            j = voffset + vec_count - 2;  // point to first vector word of pair
-        } else {
-            if (decode.capcode > 4297068542ll || decode.capcode <= 0) continue;
-
-            /* Tone-only: address beyond valid vector range */
-            if (vec_count >= n_valid_vecs) {
-                parse_tone_only(phaseptr, PhaseNo, 0);
-                continue;
-            }
-            vec_count++;
-        }
+        if (decode.capcode > 4297068542ll || decode.capcode < 0) continue;
 
         uint32_t viw = phaseptr[j];
         int type_val = (viw >> 4) & 0x07;
@@ -917,14 +645,7 @@ void FlexProcessor::decode_phase(char PhaseNo) {
         }
 
         int mw1 = (viw >> 7) & 0x7F;
-        int len;
-        /* Numeric types (3, 4, 7) have a 3-bit n field (bits 14-16)
-         * encoding word_count - 1.  Bits 17-20 are the K checksum.
-         * Alpha/hex/secure types use the full 7-bit field (bits 14-20). */
-        if (type_val == 3 || type_val == 4 || type_val == 7)
-            len = ((viw >> 14) & 0x07) + 1;
-        else
-            len = (viw >> 14) & 0x7F;
+        int len = (viw >> 14) & 0x7F;
         int mw2 = mw1 + (len - 1);
 
         if (mw1 == 0 && mw2 == 0) continue;
@@ -932,526 +653,121 @@ void FlexProcessor::decode_phase(char PhaseNo) {
 
         if (decode.type == flex::PageType::ALPHANUMERIC || decode.type == flex::PageType::SECURE) {
             if (mw1 > 87 || mw2 > 87) continue;
-            if (decode.long_address) {
-                /* For long addresses, body[0] (header with K,C,F,N,R,M) is at
-                 * Vy (j+1), not at mw1.  The vector's mw1 points to body[1]
-                 * in the message field, and len includes body[0].
-                 * parse_alphanumeric expects mw1 = header word index (it does
-                 * mw1++ internally to skip header).  So pass mw1-1 so the
-                 * skip lands on mw1 (first real data word). */
-                parse_alphanumeric(phaseptr, word_bad, PhaseNo, mw1 - 1, mw2 - 1, 0);
-            } else {
-                parse_alphanumeric(phaseptr, word_bad, PhaseNo, mw1, mw2, 0);
-            }
+            parse_alphanumeric(phaseptr, PhaseNo, mw1, mw2, 0);
         } else if (decode.type == flex::PageType::STANDARD_NUMERIC || decode.type == flex::PageType::SPECIAL_NUMERIC || decode.type == flex::PageType::NUMBERED_NUMERIC) {
-            parse_numeric(phaseptr, word_bad, PhaseNo, j);
+            parse_numeric(phaseptr, PhaseNo, j);
         } else if (decode.type == flex::PageType::TONE) {
-            /* Vector type 2: Short Message (3.9.2).
-             * Sub-type t1t0 in bits 7-8, data d0-d11 in bits 9-20. */
-            uint32_t t = (viw >> 7) & 0x03;
-            uint32_t d = (viw >> 9) & 0x0FFF;
-
-            flex::FlexPacket packet{};
-            packet.bitrate = sync.baud * (sync.levels == 4 ? 2 : 1);
-            packet.capcode = decode.capcode;
-            packet.function = t;
-            packet.cycle = fiw.cycleno;
-            packet.frame = fiw.frameno;
-            packet.phase = PhaseNo;
-            packet.is_inverted = sync.polarity;
-            packet.fiw_roaming = fiw.roaming;
-            packet.addr_type = static_cast<uint8_t>(decode.addr_type);
-            packet.is_priority = decode.is_priority;
-            packet.type = 8;  // SHORT
-
-            if (t == 0 && d == 0xCCC) {
-                /* Tone-only: all digits are space (0xC) per STD-43A
-                 * Table 3.9.2-1 note. For long addresses, also check Vy. */
-                bool tone = true;
-                if (decode.long_address && j + 1 < 88) {
-                    uint32_t vy = phaseptr[j + 1] & 0xFFFFF;
-                    if (vy != 0xCCCCC) tone = false;
-                }
-                if (tone)
-                    strcpy(packet.message, "TONE");
-                else
-                    goto short_numeric;
-            } else if (t == 0) {
-            short_numeric:
-                /* Numeric: 3 BCD digits from Vx (d0-d11).
-                 * Long addresses: 5 more digits from Vy (d12-d31),
-                 * 8 digits total. d32 is spare (set to 0). */
-                char *p = packet.message, *e = p + sizeof(packet.message);
-                p = str_append(p, e, "NUM ");
-                *p++ = flex_bcd[(d >> 0) & 0xF];
-                *p++ = flex_bcd[(d >> 4) & 0xF];
-                *p++ = flex_bcd[(d >> 8) & 0xF];
-                if (decode.long_address && j + 1 < 88) {
-                    uint32_t vy = phaseptr[j + 1];
-                    *p++ = flex_bcd[(vy >> 0) & 0xF];
-                    *p++ = flex_bcd[(vy >> 4) & 0xF];
-                    *p++ = flex_bcd[(vy >> 8) & 0xF];
-                    *p++ = flex_bcd[(vy >> 12) & 0xF];
-                    *p++ = flex_bcd[(vy >> 16) & 0xF];
-                }
-                *p = '\0';
-            } else if (t == 1) {
-                /* Source: S2S1S0 in d0-d2 */
-                char *p = packet.message, *e = p + sizeof(packet.message);
-                p = str_append(p, e, "SRC ");
-                str_uint(p, e, d & 0x07);
-            } else if (t == 2) {
-                /* Numbered: S(3) + N(6) + R(1) */
-                uint32_t src = d & 0x07;
-                uint32_t n = (d >> 3) & 0x3F;
-                uint32_t r = (d >> 9) & 0x01;
-                char *p = packet.message, *e = p + sizeof(packet.message);
-                p = str_append(p, e, "SRC ");
-                p = str_uint(p, e, src);
-                p = str_append(p, e, " N=");
-                p = str_uint(p, e, n);
-                p = str_append(p, e, " R=");
-                str_uint(p, e, r);
-            } else {
-                /* Reserved */
-                char *p = packet.message, *e = p + sizeof(packet.message);
-                p = str_append(p, e, "RESERVED ");
-                str_hex(p, e, d, 3);
-            }
-            send_packet(packet);
-        } else if (decode.type == flex::PageType::BINARY) {
-            /* HEX/Binary message.
-             * Word 1 (mw1): K(12) C(1) F(2) N(6) = header
-             * Word 2 (mw1+1, first frag only): R(1) M(1) D(1) H(1) B(4) I(1) rsvd(4) S(8)
-             * Words 3+: data */
-            if (mw1 > 87 || mw2 > 87) continue;
-
-            /* Extract header from word 1 */
-            uint8_t hex_c = 0, hex_f = 0, hex_n = 0;
-            int hex_hdr_valid = 0;
-            if (!word_bad[mw1]) {
-                uint32_t hw1 = phaseptr[mw1];
-                hex_c = (hw1 >> 12) & 0x01;
-                hex_f = (hw1 >> 13) & 0x03;
-                hex_n = (hw1 >> 15) & 0x3F;
-                hex_hdr_valid = 1;
-            }
-
-            /* Extract word 2 flags (first fragment: F=3) */
-            uint8_t hex_r = 0, hex_m = 0, hex_d = 0, hex_b = 0;
-            int data_start = mw1 + 1;  // default: data starts after header
-            if (hex_f == 3 && (mw1 + 1) <= mw2 && !word_bad[mw1 + 1]) {
-                uint32_t hw2 = phaseptr[mw1 + 1];
-                hex_r = (hw2 >> 0) & 0x01;
-                hex_m = (hw2 >> 1) & 0x01;
-                hex_d = (hw2 >> 2) & 0x01;
-                hex_b = (hw2 >> 4) & 0x0F;
-                data_start = mw1 + 2;  // skip both header words
-            }
-
-            /* Dump data words as hex */
-            char message[256] = {0};
-            char *mp = message, *me = message + 250;
-            for (int w = data_start; w <= mw2 && mp < me; w++) {
-                if (word_bad[w]) {
-                    mp = str_append(mp, me, "?????? ");
-                } else {
-                    mp = str_hex(mp, me, phaseptr[w] & 0x1FFFFF, 5);
-                    if (mp < me) *mp++ = ' ';
-                    *mp = '\0';
-                }
-            }
-            if (mp > message && *(mp - 1) == ' ') {
-                mp--;
-                *mp = '\0';
-            }
-            int pos = (int)(mp - message);
-
-            flex::FlexPacket packet{};
-            packet.bitrate = sync.baud * (sync.levels == 4 ? 2 : 1);
-            packet.capcode = decode.capcode;
-            packet.function = 0;
-            packet.type = 6;  // HEX
-            packet.status = 0;
-            packet.cycle = fiw.cycleno;
-            packet.frame = fiw.frameno;
-            packet.phase = PhaseNo;
-            packet.is_inverted = sync.polarity;
-            packet.fiw_roaming = fiw.roaming;
-            packet.addr_type = static_cast<uint8_t>(decode.addr_type);
-            packet.is_priority = decode.is_priority;
-            if (hex_hdr_valid) {
-                packet.frag = hex_f;
-                packet.more_frag = hex_c;
-                packet.seq = hex_n;
-                packet.has_flags = 1;
-                if (hex_f == 3) {
-                    packet.is_new = hex_r;
-                    packet.maildrop = hex_m;
-                    /* Store b and d in function field: low nibble=b, bit4=d */
-                    packet.function = (hex_d << 4) | hex_b;
-                }
-            }
-            memcpy(packet.message, message, pos + 1);
-            send_packet(packet);
-        } else if (decode.type == flex::PageType::SHORT_INSTRUCTION) {
-            /* Short instruction: 14-bit data in vector bits 7-20.
-             * i2i1i0 (bits 0-2 of data) = instruction type.
-             * Remaining bits = instruction-specific data. */
-            uint32_t instr_data = (viw >> 7) & 0x3FFF;
-            uint32_t itype = instr_data & 0x07;
-
-            flex::FlexPacket packet{};
-            packet.bitrate = sync.baud * (sync.levels == 4 ? 2 : 1);
-            packet.capcode = decode.capcode;
-            packet.function = 0;
-            packet.type = 1;  // INS
-            packet.cycle = fiw.cycleno;
-            packet.frame = fiw.frameno;
-            packet.phase = PhaseNo;
-            packet.is_inverted = sync.polarity;
-            packet.fiw_roaming = fiw.roaming;
-            packet.addr_type = static_cast<uint8_t>(decode.addr_type);
-            packet.is_priority = decode.is_priority;
-
-            if (itype == 0) {
-                uint32_t tgt_frame = (instr_data >> 3) & 0x7F;
-                uint32_t slot = (instr_data >> 10) & 0x0F;
-                packet.biw_v1 = slot;
-                packet.biw_v2 = tgt_frame;
-                {
-                    char *p = packet.message, *e = p + sizeof(packet.message);
-                    p = str_append(p, e, "i=temp|slot=");
-                    p = str_uint(p, e, slot);
-                    p = str_append(p, e, "|target=");
-                    str_uint(p, e, tgt_frame);
-                }
-            } else if (itype == 1) {
-                uint32_t flags = (instr_data >> 3) & 0x7FF;
-                {
-                    char *p = packet.message, *e = p + sizeof(packet.message);
-                    p = str_append(p, e, "i=event|flags=");
-                    str_hex(p, e, flags, 3);
-                }
-            } else {
-                {
-                    char *p = packet.message, *e = p + sizeof(packet.message);
-                    p = str_append(p, e, "i=rsvd|type=");
-                    p = str_uint(p, e, itype);
-                    p = str_append(p, e, "|raw=");
-                    str_hex(p, e, instr_data, 4);
-                }
-            }
-            send_packet(packet);
+            parse_tone_only(phaseptr, PhaseNo, j);
+        } else {
+            // Unknown or unsupported
         }
     }
 }
 
 void FlexProcessor::parse_capcode(uint32_t aw1) {
-    /* Classify address word by range. */
-    decode.long_address = 0;
-    decode.addr_type = flex::AddrType::SHORT;
-
-    if ((aw1 >= 0x000001 && aw1 <= 0x008000) || /* LA1 */
-        (aw1 >= 0x1E0001 && aw1 <= 0x1E8000) || /* LA3 */
-        (aw1 >= 0x1E8001 && aw1 <= 0x1F0000) || /* LA4 */
-        (aw1 >= 0x1F7FFF && aw1 <= 0x1FFFFE)) { /* LA2 */
-        decode.long_address = 1;
-        decode.addr_type = flex::AddrType::LONG;
-    } else if (aw1 >= 0x1F7800 && aw1 <= 0x1F780F) {
-        decode.addr_type = flex::AddrType::TEMPORARY;
-    } else if (aw1 >= 0x1F7810 && aw1 <= 0x1F781F) {
-        decode.addr_type = flex::AddrType::OPERATOR;
-    } else if (aw1 >= 0x1F6800 && aw1 <= 0x1F77FF) {
-        decode.addr_type = flex::AddrType::NETWORK;
-    } else if (aw1 >= 0x1F2800 && aw1 <= 0x1F67FF) {
-        decode.addr_type = flex::AddrType::INFO_SVC;
-    } else if ((aw1 >= 0x1F0001 && aw1 <= 0x1F27FF) ||
-               (aw1 >= 0x1F7820 && aw1 <= 0x1F7FFE)) {
-        decode.addr_type = flex::AddrType::RESERVED;
-    } else if (aw1 >= 0x008001 && aw1 <= 0x1E0000) {
-        decode.addr_type = flex::AddrType::SHORT;
-    } else {
-        decode.addr_type = flex::AddrType::UNKNOWN;
-    }
-
+    decode.long_address = (aw1 < 0x008001L) || (aw1 > 0x1E0000L) || (aw1 > 0x1E7FFEL);
     decode.capcode = aw1 - 0x8000;
 }
 
-void FlexProcessor::parse_alphanumeric(uint32_t* phaseptr, const uint8_t* word_bad, char PhaseNo, int mw1, int mw2, int) {
-    char message[256] = {0};
+void FlexProcessor::parse_alphanumeric(uint32_t* phaseptr, char, int mw1, int mw2, int) {
+    char message[128] = {0};  // Fixed buffer for message
     int currentChar = 0;
 
-    /* First message word is the header (K, C, F, N, R, M fields).
-     * Extract flags before skipping to content. */
-    uint8_t hdr_c = 0, hdr_f = 0, hdr_n = 0, hdr_r = 0, hdr_m = 0;
-    uint8_t hdr_sig = 0;
-    int hdr_valid = 0;
-    if (mw1 >= 0 && mw1 < 88 && !word_bad[mw1]) {
-        uint32_t hdr = phaseptr[mw1];
-        hdr_c = (hdr >> 10) & 0x01;  // bit 10
-        hdr_f = (hdr >> 11) & 0x03;  // bits 11-12
-        hdr_n = (hdr >> 13) & 0x3F;  // bits 13-18
-        hdr_r = (hdr >> 19) & 0x01;  // bit 19
-        hdr_m = (hdr >> 20) & 0x01;  // bit 20
-        hdr_valid = 1;
-    }
-    mw1++;
+    // int frag = (phaseptr[mw1] >> 11) & 0x03;
+    // int cont = (phaseptr[mw1] >> 0x0A) & 0x01;
+    // Helper logic for fragmentation (ignored for basic display)
 
-    /* Extract signature from first data word (bits 0-6) */
-    if (mw1 >= 0 && mw1 < 88 && !word_bad[mw1]) {
-        hdr_sig = phaseptr[mw1] & 0x7F;
-    }
+    mw1++;
 
     for (int i = mw1; i <= mw2; i++) {
         unsigned int dw = phaseptr[i];
         unsigned char ch;
-        int bad = (i >= 0 && i < 88) ? word_bad[i] : 1;
 
+        // Extract chars (7-bit ASCII)
+        // If i > mw1 (not first word) or fragment check (simplified here)
         if (i > mw1) {
             ch = dw & 0x7F;
-            if (bad) {
-                if (currentChar < 255) message[currentChar++] = '?';
-            } else if (ch >= 0x20 || ch == 0x0A || ch == 0x0D) {
-                if (currentChar < 255) message[currentChar++] = ch;
-            } else if (ch == 0x03 || ch == 0x00) {
-                if (currentChar < 255) message[currentChar++] = '\x03';
-            }
+            if (ch != 0x03 && currentChar < 127) message[currentChar++] = ch;
         }
 
         ch = (dw >> 7) & 0x7F;
-        if (bad) {
-            if (currentChar < 255) message[currentChar++] = '?';
-        } else if (ch >= 0x20 || ch == 0x0A || ch == 0x0D) {
-            if (currentChar < 255) message[currentChar++] = ch;
-        } else if (ch == 0x03 || ch == 0x00) {
-            if (currentChar < 255) message[currentChar++] = '\x03';
-        }
+        if (ch != 0x03 && currentChar < 127) message[currentChar++] = ch;
 
         ch = (dw >> 14) & 0x7F;
-        if (bad) {
-            if (currentChar < 255) message[currentChar++] = '?';
-        } else if (ch >= 0x20 || ch == 0x0A || ch == 0x0D) {
-            if (currentChar < 255) message[currentChar++] = ch;
-        } else if (ch == 0x03 || ch == 0x00) {
-            if (currentChar < 255) message[currentChar++] = '\x03';
-        }
-    }
-
-    /* Post-process: trim trailing ETX/NUL padding, but if printable chars
-     * appear after an ETX/NUL, show each ETX/NUL as '?' (invalid char). */
-    {
-        /* First find the last printable character */
-        int last_printable = -1;
-        for (int k = 0; k < currentChar; k++) {
-            if (message[k] != '\x03') last_printable = k;
-        }
-        /* Now output up to last_printable, replacing ETX with '?' */
-        int out = 0;
-        for (int k = 0; k <= last_printable && out < 255; k++) {
-            if (message[k] == '\x03')
-                message[out++] = '?';
-            else
-                message[out++] = message[k];
-        }
-        currentChar = out;
+        if (ch != 0x03 && currentChar < 127) message[currentChar++] = ch;
     }
     message[currentChar] = '\0';
 
-    flex::FlexPacket packet{};
-    packet.bitrate = sync.baud * (sync.levels == 4 ? 2 : 1);
+    flex::FlexPacket packet;
+    packet.bitrate = sync.baud;
     packet.capcode = decode.capcode;
-    packet.function = 0;
-    packet.type = (decode.type == flex::PageType::SECURE) ? 0 : 5;
-    packet.status = 0;
-    packet.cycle = fiw.cycleno;
-    packet.frame = fiw.frameno;
-    packet.phase = PhaseNo;
-    packet.is_inverted = sync.polarity;
-    packet.fiw_roaming = fiw.roaming;
-    packet.addr_type = static_cast<uint8_t>(decode.addr_type);
-    packet.is_priority = decode.is_priority;
-    if (hdr_valid) {
-        packet.frag = hdr_f;
-        packet.more_frag = hdr_c;
-        packet.seq = hdr_n;
-        packet.is_new = hdr_r;
-        packet.maildrop = hdr_m;
-        packet.sig = hdr_sig;
-        packet.has_flags = 1;
-        if (decode.type == flex::PageType::SECURE) {
-            /* Secure: bits 19-20 are t1t0 (encoding type), not R/M */
-            packet.sec_enc = (hdr_r) | (hdr_m << 1);  // t0=bit19, t1=bit20
-            packet.is_new = 0;
-            packet.maildrop = 0;
-        }
-    }
+    packet.function = 0;  // TODO extract function if available
+    packet.type = 5;      // ALPHANUMERIC
+    packet.status = 0;    // OK
     memcpy(packet.message, message, currentChar + 1);
 
     send_packet(packet);
 }
 
-void FlexProcessor::parse_numeric(uint32_t* phaseptr, const uint8_t* word_bad, char PhaseNo, int j) {
-    char message[256] = {0};
-
-    /* Extract NNUM header fields from first message word if applicable.
-     * Layout: K5K4(2) + N0-N5(6) + R0(1) + S0(1) + BCD digits... */
-    uint8_t nnum_n = 0, nnum_r = 0, nnum_s = 0;
-    int is_nnum = (decode.type == flex::PageType::NUMBERED_NUMERIC);
+void FlexProcessor::parse_numeric(uint32_t* phaseptr, char, int j) {
+    // Simplified numeric parsing
+    char message[128] = {0};
+    const char flex_bcd[] = "0123456789 U -][";
 
     int w1 = phaseptr[j] >> 7;
     int w2 = w1 >> 7;
     w1 = w1 & 0x7f;
-    int n_field = w2 & 0x07;  // word_count - 1
-    w2 = n_field + w1;
+    w2 = (w2 & 0x07) + w1;
 
-    // Bounds check: phase buffer is 88 words (indices 0-87)
-    if (w1 > 87) return;
-    if (w2 > 87) w2 = 87;
-
-    /* For long addresses (3.9.1):
-     * 1-word: b field points to Vy. body[0] at w1.
-     * Multi-word: body[0] at Vy (j+1). b field points to MF body[1]. */
-    int body0_idx;
-    if (decode.long_address && n_field > 0)
-        body0_idx = j + 1;  // Vy = 2nd vector word
-    else
-        body0_idx = w1;
-    if (body0_idx < 0 || body0_idx >= 88) return;
-
-    int dw = phaseptr[body0_idx];
-
-    if (is_nnum) {
-        /* Extract N, R, S from the first message word's BCD stream.
-         * After K5K4 (2 bits), next 6 bits = N, then R, then S.
-         * These are consumed by the skip count (count starts at 4+10=14). */
-        nnum_n = (dw >> 2) & 0x3F;  // bits 2-7
-        nnum_r = (dw >> 8) & 0x01;  // bit 8
-        nnum_s = (dw >> 9) & 0x01;  // bit 9
-    }
+    int dw;
+    // Handle short vs long logic if needed (simplified)
+    dw = phaseptr[w1];
+    w1++;
+    w2++;
 
     unsigned char digit = 0;
-    int count = 4;
-    if (is_nnum)
-        count += 10;  // skip K5K4(2) + N(6) + R(1) + S(1)
+    int count = 4;  // Standard numeric skip
+    if (decode.type == flex::PageType::NUMBERED_NUMERIC)
+        count += 10;
     else
-        count += 2;  // skip K5K4(2)
+        count += 2;
 
     int idx = 0;
-
-    /* Phase 1: decode body[0] bits.
-     * For short addresses, body[0] is at w1 and we advance to w1+1.
-     * For long addresses, body[0] is at Vy (j+1), then we continue from w1. */
-    if (word_bad[body0_idx]) {
-        /* Uncorrectable word — emit '?' for each digit slot */
-        int data_bits = 21 - (count - 4); /* bits available after skip */
-        int lost_digits = data_bits / 4;
-        while (lost_digits-- > 0 && idx < 255)
-            message[idx++] = '?';
-        count = 4; /* reset for next word */
-        digit = 0;
-    } else {
+    for (int i = w1; i <= w2; i++) {
         for (int k = 0; k < 21; k++) {
             digit = (digit >> 1) & 0x0F;
             if (dw & 0x01) digit ^= 0x08;
             dw >>= 1;
             if (--count == 0) {
-                if (idx < 255) {
+                if (digit != 0x0C && idx < 127) {
                     message[idx++] = flex_bcd[digit];
                 }
                 count = 4;
             }
         }
-    }
-
-    /* Phase 2: decode remaining body words from MF.
-     * Short: body[1..n] at w1+1 .. w2.
-     * Long: MF has n_field words at w1 .. w1+n_field-1.
-     *   (n_field = total_words - 1; body[0] is at Vy, not in MF) */
-    int start, end;
-    if (decode.long_address) {
-        start = w1;
-        end = w1 + n_field - 1;  // empty when n_field=0
-    } else {
-        start = w1 + 1;
-        end = w2;
-    }
-    for (int i = start; i <= end && i < 88; i++) {
-        if (word_bad[i]) {
-            /* Uncorrectable word — emit '?' for each digit slot (5 per word) */
-            int lost_digits = 21 / 4; /* 5 digits per 21-bit word */
-            while (lost_digits-- > 0 && idx < 255)
-                message[idx++] = '?';
-            count = 4;
-            digit = 0;
-            continue;
-        }
         dw = phaseptr[i];
-        for (int k = 0; k < 21; k++) {
-            digit = (digit >> 1) & 0x0F;
-            if (dw & 0x01) digit ^= 0x08;
-            dw >>= 1;
-            if (--count == 0) {
-                if (idx < 255) {
-                    message[idx++] = flex_bcd[digit];
-                }
-                count = 4;
-            }
-        }
     }
-
-    /* Trim trailing BCD space padding (0x0C = ' ').
-     * The encoder pads unused nibble slots with 0x0C */
-    while (idx > 0 && message[idx - 1] == ' ')
-        idx--;
     message[idx] = '\0';
 
-    flex::FlexPacket packet{};
-    packet.bitrate = sync.baud * (sync.levels == 4 ? 2 : 1);
+    flex::FlexPacket packet;
+    packet.bitrate = sync.baud;
     packet.capcode = decode.capcode;
     packet.function = 0;
-    /* Set correct type: 3=NUM, 4=SNUM, 7=NNUM */
-    if (decode.type == flex::PageType::SPECIAL_NUMERIC)
-        packet.type = 4;
-    else if (is_nnum)
-        packet.type = 7;
-    else
-        packet.type = 3;
+    packet.type = 3;  // NUMERIC
     packet.status = 0;
-    packet.cycle = fiw.cycleno;
-    packet.frame = fiw.frameno;
-    packet.phase = PhaseNo;
-    packet.is_inverted = sync.polarity;
-    packet.fiw_roaming = fiw.roaming;
-    packet.addr_type = static_cast<uint8_t>(decode.addr_type);
-    packet.is_priority = decode.is_priority;
-    if (is_nnum) {
-        packet.seq = nnum_n;
-        packet.is_new = nnum_r;
-        packet.nnum_s = nnum_s;
-        packet.has_flags = 1;
-    }
     memcpy(packet.message, message, idx + 1);
 
     send_packet(packet);
 }
 
-void FlexProcessor::parse_tone_only(uint32_t*, char PhaseNo, int) {
-    if (decode.capcode == 1) return;  // idle artifact
-    flex::FlexPacket packet{};
-    packet.bitrate = sync.baud * (sync.levels == 4 ? 2 : 1);
+void FlexProcessor::parse_tone_only(uint32_t*, char, int) {
+    flex::FlexPacket packet;
+    packet.bitrate = sync.baud;
     packet.capcode = decode.capcode;
     packet.function = 0;
     packet.type = 2;  // TONE
     packet.status = 0;
-    packet.cycle = fiw.cycleno;
-    packet.frame = fiw.frameno;
-    packet.phase = PhaseNo;
-    packet.is_inverted = sync.polarity;
-    packet.fiw_roaming = fiw.roaming;
-    packet.addr_type = static_cast<uint8_t>(decode.addr_type);
-    packet.is_priority = decode.is_priority;
-    strcpy(packet.message, "");
+    snprintf(packet.message, sizeof(packet.message), "Tone Only");
 
     send_packet(packet);
 }

firmware/baseband/proc_flex.hpp

@@ -66,11 +66,6 @@ struct FlexStateInfo {
     unsigned int fiwcount = 0;
     State Current = State::SYNC1;
     State Previous = State::SYNC1;
-
-    // S2 C-pattern detection
-    uint16_t sync2_shiftreg = 0;  // 16-bit shift register for C match
-    int sync2_c_pos = -1;         // symbol position where C was found (-1=not found)
-    int sync2_cinv_pos = -1;      // symbol position where inv.C was found
 };
 
 struct FlexSync {
@@ -86,9 +81,7 @@ struct FlexFIW {
     unsigned int checksum = 0;
     unsigned int cycleno = 0;
     unsigned int frameno = 0;
-    unsigned int roaming = 0;  // bit 15: n (1=roaming provided)
-    unsigned int repeat = 0;   // bit 16: r (1=multiple transmission)
-    unsigned int traffic = 0;  // bits 17-20: t3-t0
+    unsigned int fix3 = 0;
 };
 
 struct FlexPhase {
@@ -105,23 +98,10 @@ struct FlexData {
     FlexPhase PhaseD;
 };
 
-enum class AddrType : uint8_t {
-    SHORT,      // normal individual
-    LONG,       // 9-10 digit
-    TEMPORARY,  // 0x1F7800-0F (16 group slots)
-    OPERATOR,   // 0x1F7810-1F (system messages)
-    NETWORK,    // 0x1F6800-77FF (NID)
-    INFO_SVC,   // 0x1F2800-67FF (under study)
-    RESERVED,   // reserved ranges
-    UNKNOWN
-};
-
 struct FlexDecode {
     PageType type = PageType::ALPHANUMERIC;
     int long_address = 0;
     int64_t capcode = 0;
-    AddrType addr_type = AddrType::SHORT;
-    int is_priority = 0;
 };
 
 }  // namespace flex
@@ -181,8 +161,8 @@ class FlexProcessor : public BasebandProcessor {
 
     // Parsing
     void parse_capcode(uint32_t aw1);
-    void parse_alphanumeric(uint32_t* phaseptr, const uint8_t* word_bad, char PhaseNo, int mw1, int mw2, int flex_groupmessage);
-    void parse_numeric(uint32_t* phaseptr, const uint8_t* word_bad, char PhaseNo, int j);
+    void parse_alphanumeric(uint32_t* phaseptr, char PhaseNo, int mw1, int mw2, int flex_groupmessage);
+    void parse_numeric(uint32_t* phaseptr, char PhaseNo, int j);
     void parse_tone_only(uint32_t* phaseptr, char PhaseNo, int j);
     void parse_unknown(uint32_t* phaseptr, char PhaseNo, int mw1, int mw2);
 

firmware/baseband/proc_pocsag2.cpp

@@ -38,7 +38,14 @@ using namespace std;
 namespace {
 /* Count of bits that differ between the two values. */
 uint8_t diff_bit_count(uint32_t left, uint32_t right) {
-    return __builtin_popcount(left ^ right);
+    uint32_t diff = left ^ right;
+    uint8_t count = 0;
+    for (size_t i = 0; i < sizeof(diff) * 8; ++i) {
+        if (((diff >> i) & 0x1) == 1)
+            ++count;
+    }
+
+    return count;
 }
 }  // namespace
 
@@ -419,7 +426,6 @@ void POCSAGProcessor::send_packet() {
     packet.set_flag(pocsag::PacketFlag::NORMAL);
     packet.set_timestamp(Timestamp::now());
     packet.set_bitrate(bit_extractor.baud_rate());
-    packet.set_inverted(word_extractor.inverted());
     packet.set(word_extractor.batch());
 
     POCSAGPacketMessage message(packet);

firmware/baseband/proc_pocsag2.hpp

@@ -153,9 +153,6 @@ class CodewordExtractor {
     /* Returns true if the batch has as sync frame. */
     bool has_sync() const { return has_sync_; }
 
-    /* Returns true if the signal was received with inverted polarity. */
-    bool inverted() const { return inverted_; }
-
    private:
     /* Sync frame codeword. */
     static constexpr uint32_t sync_codeword = 0x7cd215d8;

firmware/baseband/proc_tonedetect.cpp

@@ -1,332 +0,0 @@
-/*
- * Copyright (C) 2024 PortaPack Mayhem
- *
- * This file is part of PortaPack.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2, or (at your option)
- * any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street,
- * Boston, MA 02110-1301, USA.
- */
-
-#include "proc_tonedetect.hpp"
-#include "audio_dma.hpp"
-#include "portapack_shared_memory.hpp"
-#include "event_m4.hpp"
-#include <cmath>
-
-static constexpr float SAMPLE_RATE = 24000.0f;
-static constexpr uint32_t WINDOW_SAMPLES = 960;  // 40 ms at 24 kHz (30 execute() calls)
-static constexpr uint32_t WINDOW_MS = (1000 * WINDOW_SAMPLES) / (uint32_t)SAMPLE_RATE;
-static constexpr uint32_t AUDIO_BLOCK_SAMPLES = 32;  // demod_fm emits 32 audio samples per execute()
-static constexpr uint32_t SQUELCH_HOLD_BLOCKS =
-    (100 * (uint32_t)SAMPLE_RATE) / (1000 * AUDIO_BLOCK_SAMPLES);  // 100 ms hold at execute() block rate
-static constexpr float PI_F = 3.14159265f;
-
-// Motorola/EIA QCII paging frequencies (×10 to avoid float in table)
-static constexpr uint32_t MOTO_FREQS_X10[45] = {
-    2885,
-    3047,
-    3217,
-    3396,
-    3586,
-    3786,
-    3998,
-    4221,
-    4457,
-    4705,
-    4968,
-    5246,
-    5539,
-    5848,
-    6174,
-    6519,
-    6883,
-    7268,
-    7674,
-    8102,
-    8555,
-    9032,
-    9537,
-    10073,
-    10642,
-    11225,
-    11247,
-    11534,
-    11852,
-    11885,
-    12178,
-    12514,
-    12555,
-    12858,
-    13258,
-    13576,
-    13950,
-    13996,
-    14768,
-    15579,
-    16430,
-    17325,
-    18262,
-    19245,
-    20275,
-};
-
-// Minimum coherent Goertzel energy for MOTO tone detection.
-// For amplitude A over WINDOW_SAMPLES: energy ≈ (A × N/2)² = (A × 240)².
-// Threshold 1000 → requires A > ~13% of FM demod full scale (~650 Hz deviation).
-// Set high enough that FM broadband noise (σ ≈ 0.3, expected per-bin energy ≈ 43)
-// never triggers a false detection even when the carrier gate is briefly open.
-static constexpr float MOTO_ENERGY_THRESHOLD = 1000.0f;
-
-// Fixed carrier-detect threshold for the detection gate (independent of user squelch).
-// FMSquelch returns true when HF noise is BELOW this value (= FM carrier present).
-// 0.20 opens reliably on any clean FM carrier without false-opening on noise.
-static constexpr float CARRIER_DETECT_THRESHOLD = 0.20f;
-
-// Goertzel energy threshold for CTCSS detection.
-// Pure CTCSS at 5% amplitude over 960 samples → energy ≈ (0.05 × 480)² = 576.
-static constexpr float CTCSS_ENERGY_THRESHOLD = 30.0f;
-
-void ToneDetectProcessor::configure(uint8_t squelch, uint32_t ctcss_f_x10) {
-    configured = false;
-    user_squelch_level = squelch;
-    ctcss_freq_x10 = ctcss_f_x10;
-
-    decim_0.configure(taps_11k0_decim_0.taps);
-    decim_1.configure(taps_11k0_decim_1.taps);
-    channel_filter.configure(taps_11k0_channel.taps, 2);
-    demod_fm.configure(24000, 5000);
-    audio_output.configure(false);
-    fm_squelch.set_threshold((float)user_squelch_level / 100.0f);
-    channel_spectrum.set_decimation_factor(1);
-
-    // Precompute Goertzel coefficient for CTCSS (if active).
-    // k = nearest DFT bin for the CTCSS frequency over WINDOW_SAMPLES.
-    if (ctcss_freq_x10 > 0) {
-        const float freq = (float)ctcss_freq_x10 / 10.0f;
-        const float k = roundf((float)WINDOW_SAMPLES * freq / SAMPLE_RATE);
-        const float omega = 2.0f * PI_F * k / (float)WINDOW_SAMPLES;
-        goertzel_coeff = 2.0f * cosf(omega);
-    } else {
-        goertzel_coeff = 0.0f;
-    }
-
-    // Precompute Goertzel coefficients for all 45 MOTO frequencies.
-    // Each filter is tuned to the EXACT MOTO frequency (not the nearest DFT bin center)
-    // so that every entry has a unique coefficient and maximum energy only at its
-    // specific frequency.  This eliminates bin-sharing ambiguity and gives the best
-    // discrimination between close entries such as 1357.6 Hz and 1395.0 Hz.
-    for (size_t i = 0; i < 45; i++) {
-        const float freq = (float)MOTO_FREQS_X10[i] / 10.0f;
-        const float omega = 2.0f * PI_F * freq / SAMPLE_RATE;
-        moto_coeff[i] = 2.0f * cosf(omega);
-        moto_s1[i] = 0.0f;
-        moto_s2[i] = 0.0f;
-    }
-
-    // Fixed carrier-detect squelch — threshold never changes with user settings.
-    carrier_sq.set_threshold(CARRIER_DETECT_THRESHOLD);
-
-    // Reset all per-window state
-    goertzel_s1 = 0.0f;
-    goertzel_s2 = 0.0f;
-    window_sample_count = 0;
-    was_ctcss_detected = false;
-    tone_duration_windows = 0;
-    squelch_is_open = false;
-    squelch_hold = 0;
-    carrier_is_open = false;
-    carrier_hold = 0;
-
-    configured = true;
-}
-
-void ToneDetectProcessor::execute(const buffer_c8_t& buffer) {
-    if (!configured) return;
-
-    const auto decim_0_out = decim_0.execute(buffer, dst_buffer);
-    const auto decim_1_out = decim_1.execute(decim_0_out, dst_buffer);
-
-    // Feed IQ data into spectrum collector for the RF waterfall.
-    channel_spectrum.feed(decim_1_out, -5500, 5500, 3400);
-
-    const auto channel_out = channel_filter.execute(decim_1_out, dst_buffer);
-    auto audio_buf = demod_fm.execute(channel_out, audio_buffer);
-
-    // --- Audio muting squelch (user-adjustable level) ---
-    // FMSquelch returns true when HF noise is LOW (carrier present).
-    const bool fm_open = fm_squelch.execute(audio_buf);
-    if (fm_open) {
-        squelch_hold = SQUELCH_HOLD_BLOCKS;
-        squelch_is_open = true;
-    } else if (squelch_hold > 0) {
-        squelch_hold--;
-    } else {
-        squelch_is_open = false;
-    }
-
-    // --- Fixed carrier-detect gate (independent of user squelch level) ---
-    // carrier_sq always uses CARRIER_DETECT_THRESHOLD (0.20) regardless of squelch_val.
-    // This ensures the detection gate closes when the carrier disappears even when the
-    // user sets squelch=0 (always-open audio), preventing the state machine from
-    // accumulating noise windows or getting stuck between transmissions.
-    const bool carrier_raw = carrier_sq.execute(audio_buf);
-    if (carrier_raw) {
-        carrier_hold = SQUELCH_HOLD_BLOCKS;
-        carrier_is_open = true;
-    } else if (carrier_hold > 0) {
-        carrier_hold--;
-    } else {
-        carrier_is_open = false;
-    }
-
-    for (size_t i = 0; i < audio_buf.count; i++) {
-        const float s = audio_buf.p[i];
-
-        // Mute audio output when FM squelch is closed (does not affect Goertzel).
-        if (!squelch_is_open) audio_buf.p[i] = 0.0f;
-
-        // CTCSS Goertzel step (CTCSS mode only).
-        // Uses original unmuted sample so CTCSS energy is unaffected by audio muting.
-        if (ctcss_freq_x10 > 0) {
-            const float s0 = s + goertzel_coeff * goertzel_s1 - goertzel_s2;
-            goertzel_s2 = goertzel_s1;
-            goertzel_s1 = s0;
-        }
-
-        // MOTO frequency bank — Goertzel step for all 45 MOTO bins.
-        // Runs unconditionally so the full window always contributes to energy.
-        // Benefit over zero-crossing: coherent detection, no warm-up period,
-        // accurate on the very first window after the gate opens.
-        for (size_t j = 0; j < 45; j++) {
-            const float s0 = s + moto_coeff[j] * moto_s1[j] - moto_s2[j];
-            moto_s2[j] = moto_s1[j];
-            moto_s1[j] = s0;
-        }
-
-        // Window boundary: every WINDOW_SAMPLES samples = one 40 ms estimate window
-        if (++window_sample_count >= WINDOW_SAMPLES) {
-            window_sample_count = 0;
-
-            // --- Detection gate ---
-            // Carrier presence (carrier_is_open) is always required — without it,
-            // the FM demod outputs broadband noise that floods every Goertzel bin and
-            // triggers false detections regardless of the CTCSS threshold.
-            // CTCSS mode adds a second requirement: coherent CTCSS energy must also
-            // be present.  This is the standard two-condition squelch used in real radios.
-            bool gate_open;
-            if (ctcss_freq_x10 > 0) {
-                const float power = goertzel_s1 * goertzel_s1 + goertzel_s2 * goertzel_s2 - goertzel_coeff * goertzel_s1 * goertzel_s2;
-                gate_open = carrier_is_open && (power > CTCSS_ENERGY_THRESHOLD);
-                goertzel_s1 = 0.0f;
-                goertzel_s2 = 0.0f;
-            } else {
-                gate_open = carrier_is_open;
-            }
-
-            // --- MOTO frequency identification via Goertzel energy ---
-            // Find the MOTO table entry with the highest coherent energy this window.
-            // Reset all states regardless of gate so each window starts fresh.
-            float energies[45]{};
-            uint32_t best_idx = 45;  // 45 = sentinel (no match)
-            float best_energy = MOTO_ENERGY_THRESHOLD;
-            for (size_t j = 0; j < 45; j++) {
-                const float pwr = moto_s1[j] * moto_s1[j] + moto_s2[j] * moto_s2[j] - moto_coeff[j] * moto_s1[j] * moto_s2[j];
-                energies[j] = pwr;
-                moto_s1[j] = 0.0f;
-                moto_s2[j] = 0.0f;
-                if (pwr > best_energy) {
-                    best_energy = pwr;
-                    best_idx = j;
-                }
-            }
-            // Report a raw estimate from the local energy centroid around the best
-            // entry, and let the UI do the final table snap from the phase average.
-            uint32_t win_freq_hz = 0;
-            if (best_idx < 45) {
-                const size_t start = (best_idx > 0) ? (best_idx - 1) : best_idx;
-                const size_t end = (best_idx + 1 < 45) ? (best_idx + 1) : best_idx;
-                float weight_sum = 0.0f;
-                float weighted_freq_x10 = 0.0f;
-                for (size_t j = start; j <= end; j++) {
-                    const float weight = energies[j] - MOTO_ENERGY_THRESHOLD;
-                    if (weight > 0.0f) {
-                        weight_sum += weight;
-                        weighted_freq_x10 += weight * (float)MOTO_FREQS_X10[j];
-                    }
-                }
-                if (weight_sum > 0.0f) {
-                    win_freq_hz = (uint32_t)((weighted_freq_x10 / weight_sum) / 10.0f + 0.5f);
-                } else {
-                    win_freq_hz = MOTO_FREQS_X10[best_idx] / 10;
-                }
-            }
-
-            if (gate_open) {
-                if (!was_ctcss_detected) {
-                    tone_duration_windows = 0;
-                }
-                tone_duration_windows++;
-                was_ctcss_detected = true;
-
-                data_message.freq_hz = win_freq_hz;
-                data_message.duration_ms = tone_duration_windows * WINDOW_MS;
-                data_message.tone_end = false;
-                shared_memory.application_queue.push(data_message);
-
-            } else {
-                if (was_ctcss_detected) {
-                    // Gate just closed — signal tone end to application
-                    data_message.freq_hz = 0;
-                    data_message.duration_ms = tone_duration_windows * WINDOW_MS;
-                    data_message.tone_end = true;
-                    shared_memory.application_queue.push(data_message);
-                    tone_duration_windows = 0;
-                }
-                was_ctcss_detected = false;
-            }
-        }
-    }
-
-    audio_output.write(audio_buf);
-}
-
-void ToneDetectProcessor::on_message(const Message* const p) {
-    switch (p->id) {
-        case Message::ID::ToneDetectConfig: {
-            const auto& msg = *reinterpret_cast<const ToneDetectConfigureMessage*>(p);
-            configure(msg.squelch_level, msg.ctcss_freq_x10);
-            break;
-        }
-        case Message::ID::NBFMConfigure: {
-            const auto& msg = *reinterpret_cast<const NBFMConfigureMessage*>(p);
-            user_squelch_level = msg.squelch_level;
-            fm_squelch.set_threshold((float)user_squelch_level / 100.0f);
-            break;
-        }
-        case Message::ID::UpdateSpectrum:
-        case Message::ID::SpectrumStreamingConfig:
-            channel_spectrum.on_message(p);
-            break;
-        default:
-            break;
-    }
-}
-
-int main() {
-    audio::dma::init_audio_out();
-    EventDispatcher event_dispatcher{std::make_unique<ToneDetectProcessor>()};
-    event_dispatcher.run();
-    return 0;
-}

firmware/baseband/proc_tonedetect.hpp

@@ -1,94 +0,0 @@
-/*
- * Copyright (C) 2024 PortaPack Mayhem
- *
- * This file is part of PortaPack.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2, or (at your option)
- * any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; see the file COPYING.  If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street,
- * Boston, MA 02110-1301, USA.
- */
-
-#ifndef __PROC_TONEDETECT_H__
-#define __PROC_TONEDETECT_H__
-
-#include "baseband_processor.hpp"
-#include "baseband_thread.hpp"
-#include "message.hpp"
-#include "dsp_decimate.hpp"
-#include "dsp_demodulate.hpp"
-#include "audio_output.hpp"
-#include "dsp_fir_taps.hpp"
-#include "rssi_thread.hpp"
-#include "spectrum_collector.hpp"
-#include "dsp_squelch.hpp"
-
-class ToneDetectProcessor : public BasebandProcessor {
-   public:
-    ToneDetectProcessor() {}
-
-    void execute(const buffer_c8_t& buffer) override;
-    void on_message(const Message* const p) override;
-
-   private:
-    void configure(uint8_t squelch, uint32_t ctcss_freq_x10);
-
-    BasebandThread baseband_thread{3072000, this, baseband::Direction::Receive};
-    RSSIThread rssi_thread{};
-
-    std::array<complex16_t, 512> dst{};
-    const buffer_c16_t dst_buffer{dst.data(), dst.size()};
-    std::array<float, 32> audio{};
-    const buffer_f32_t audio_buffer{audio.data(), audio.size()};
-
-    dsp::decimate::FIRC8xR16x24FS4Decim8 decim_0{};
-    dsp::decimate::FIRC16xR16x32Decim8 decim_1{};
-    dsp::decimate::FIRAndDecimateComplex channel_filter{};
-    dsp::demodulate::FM demod_fm{};
-    AudioOutput audio_output{};
-
-    bool configured{false};
-    uint8_t user_squelch_level{0};
-    FMSquelch fm_squelch{};  // user-adjustable: drives audio muting only
-    FMSquelch carrier_sq{};  // fixed threshold: drives detection gate
-
-    // Audio muting squelch state (user-adjustable level, has hold for smooth audio)
-    bool squelch_is_open{false};
-    uint32_t squelch_hold{0};
-
-    // Carrier-detect gate state (fixed 0.20 threshold, separate from audio squelch)
-    bool carrier_is_open{false};
-    uint32_t carrier_hold{0};
-
-    // CTCSS gate via Goertzel algorithm (per 40 ms window)
-    uint32_t ctcss_freq_x10{0};  // 0 = None → fall back to FMSquelch gate
-    float goertzel_coeff{0.0f};  // 2 * cos(2π * k / WINDOW_SAMPLES)
-    float goertzel_s1{0.0f};
-    float goertzel_s2{0.0f};
-
-    // 40 ms measurement window
-    uint32_t window_sample_count{0};
-    bool was_ctcss_detected{false};
-    uint32_t tone_duration_windows{0};
-
-    // MOTO frequency bank — one Goertzel filter per MOTO table entry.
-    // States reset each window; coefficients set once in configure().
-    float moto_coeff[45]{};
-    float moto_s1[45]{};
-    float moto_s2[45]{};
-
-    ToneDetectDataMessage data_message{};
-    SpectrumCollector channel_spectrum{};
-};
-
-#endif /* __PROC_TONEDETECT_H__ */

firmware/baseband/rssi_thread.cpp

@@ -28,6 +28,110 @@
 #include "message.hpp"
 #include "portapack_shared_memory.hpp"
 
+#ifdef PRALINE
+/*
+ * =============================================================================
+ * PRALINE Software RSSI
+ * =============================================================================
+ *
+ * Architecture:
+ * - baseband_thread: Copies 8 packed I/Q samples (no computation)
+ * - rssi_thread: __SMUAD power calc, avg power, LUT, trackers
+ *
+ * All DSP happens here to keep baseband_thread minimal.
+ */
+
+/*
+ * Power-to-RSSI Lookup Table (32 entries)
+ *
+ * Maps I²+Q² power to RSSI (0-255) using logarithmic scaling.
+ * For 8-bit I/Q: max |I|=|Q|=127, so max I²+Q² = 32258
+ *
+ * For example, the formula: rssi = 32 * log2((index * 8) + 1), clamped to 255
+ * where using  >> 8 scaling provide 4x more sensitive than >> 10:
+ *
+ * The trade-off: more sensitivity means the meter saturates (hits max) at lower signal levels.
+ * We'll want the bar to be mid-range at typical signal levels, not pegged at max.
+ * - Index 0: power 0-255 (I/Q magnitude ~11)
+ * - Index 31: power 7936+ (I/Q magnitude ~63+)
+ */
+static constexpr uint8_t power_to_rssi_lut[32] = {
+    0, 101, 130, 148, 161, 171, 179, 186,
+    192, 197, 202, 206, 210, 213, 217, 220,
+    222, 225, 227, 230, 232, 234, 236, 238,
+    240, 241, 243, 244, 246, 247, 249, 255};
+
+/*
+ * Convert power to RSSI using 32-entry LUT.
+ * If more sensitivity thank >> 10 is needed:
+ *     use power >= 8192 & >> 8, yields 4x more sensitivity than >> 10.
+ *     use power >= 4096 & >> 7, yields 8x more sensitivity than >> 10
+ *     use power >= 2048 & >> 6, yields 16x more sensitivity than >> 10
+ *     use power >= 1024 & >> 5, yields 32x more sensitivity than >> 10
+ */
+static inline uint8_t power_to_rssi(uint32_t power) {
+    // uint8_t index = (power >= 32768) ? 31 : static_cast<uint8_t>(power >> 10);
+    uint8_t index = (power >= 2048) ? 31 : static_cast<uint8_t>(power >> 6);
+    return power_to_rssi_lut[index];
+}
+
+/*
+ * IIR Smoothing Filter (Exponential Moving Average)
+ * Formula: smooth = (current + 7*smooth) / 8  (α = 1/8)
+ */
+class IIRFilter {
+   public:
+    uint8_t update(uint8_t current) {
+        uint16_t current_q8 = static_cast<uint16_t>(current) << 8;
+        smooth_q8_ = (current_q8 + 7 * smooth_q8_) >> 3;
+        return static_cast<uint8_t>(smooth_q8_ >> 8);
+    }
+
+   private:
+    uint16_t smooth_q8_ = 0;
+};
+
+/*
+ * Running min tracker with decay.
+ * Instantly captures new minimums, slowly decays upward.
+ */
+class MinTracker {
+   public:
+    uint8_t update(uint8_t current) {
+        if (current < min_) {
+            min_ = current;
+        } else {
+            // Slow decay upward (α = 1/16)
+            min_ = min_ + ((current - min_) >> 4);
+        }
+        return min_;
+    }
+
+   private:
+    uint8_t min_ = 255;
+};
+
+/*
+ * Running max tracker with decay.
+ * Instantly captures new maximums, slowly decays downward.
+ */
+class MaxTracker {
+   public:
+    uint8_t update(uint8_t current) {
+        if (current > max_) {
+            max_ = current;
+        } else {
+            // Slow decay downward (α = 1/16)
+            max_ = max_ - ((max_ - current) >> 4);
+        }
+        return max_;
+    }
+
+   private:
+    uint8_t max_ = 0;
+};
+#endif  // PRALINE
+
 WORKING_AREA(rssi_thread_wa, 128);
 
 Thread* RSSIThread::thread = nullptr;
@@ -54,6 +158,85 @@ void RSSIThread::start() {
 }
 
 void RSSIThread::run() {
+#ifdef PRALINE
+
+    /*
+     * PRALINE (HackRF Pro): Software RSSI from I/Q samples
+     *
+     * Hardware ADC-based RSSI doesn't work on HackRF Pro.
+     *
+     * baseband_thread copies 8 packed I/Q samples.
+     * We use __SMUAD to compute power, then apply LUT and
+     * maintain running stats.
+     */
+
+    IIRFilter avg_filter;
+    MinTracker min_tracker;
+    MaxTracker max_tracker;
+
+    RSSIStatistics stats{};
+    uint32_t accumulator = 0;
+    uint32_t sample_count = 0;
+
+    constexpr uint32_t samples_per_report = 50;  // ~10Hz reporting at 2ms poll
+
+    while (!chThdShouldTerminate()) {
+        chThdSleepMilliseconds(2);  // Poll at ~500Hz
+
+        /*
+         * SIMD-accelerated I/Q power calculation for Cortex-M4.
+         *
+         * Uses __SMUAD (Signed Multiply Accumulate Dual) instruction to compute
+         * sum of products of packed halfwords: (a0*a0) + (a1*a1)
+         *
+         * Processes complex samples per iteration, computing I²+Q² with SIMD.
+         * SIMD-accelerated I/Q power calculation for Cortex-M4.
+         * ~4x faster than scalar loop.
+         * Sum power from all 8 samples (more stable than peak).
+         *
+         * __SMUAD(val, val) computes:
+         *   (low16 * low16) + (high16 * high16) = I² + Q²
+         */
+
+        uint32_t total_power = 0;
+
+        for (size_t i = 0; i < 8; i++) {
+            const uint32_t packed = shared_memory.software_rssi_iq[i];
+            total_power += __SMUAD(packed, packed);
+        }
+
+        // Average the 8 samples for min, and avg power
+        const uint32_t avg_power = total_power >> 3;
+
+        // Convert to RSSI scale (0-255) via LUT
+        const uint8_t avg_rssi = power_to_rssi(avg_power);
+
+        // Update running trackers
+        const uint8_t smooth_min = min_tracker.update(avg_rssi);
+        const uint8_t smooth_avg = avg_filter.update(avg_rssi);
+        const uint8_t smooth_max = max_tracker.update(avg_rssi);
+
+        // Accumulate for periodic report
+        accumulator += smooth_avg;
+        sample_count++;
+
+        // Report periodically
+        if (sample_count >= samples_per_report) {
+            stats.min = smooth_min;
+            stats.max = smooth_max;
+            stats.accumulator = accumulator;
+            stats.count = sample_count;
+
+            const RSSIStatisticsMessage message{stats};
+            shared_memory.application_queue.push(message);
+
+            // Reset accumulator for next period
+            accumulator = 0;
+            sample_count = 0;
+        }
+    }
+#else
+    /* HackRF One: Use hardware ADC-based RSSI */
     rf::rssi::init();
     rf::rssi::dma::allocate(4, 400);
 
@@ -77,4 +260,5 @@ void RSSIThread::run() {
 
     rf::rssi::stop();
     rf::rssi::dma::free();
+#endif
 }

firmware/baseband/sd_over_usb/hackrf_core.c

@@ -35,9 +35,6 @@
 #include "i2c_lpc.h"
 #include "cpld_jtag.h"
 #include "platform_detect.h"
-#include "platform_gpio.h"
-#include "platform_scu.h"
-#include "fixed_point.h"
 #include "clkin.h"
 #include <libopencm3/lpc43xx/cgu.h>
 #include <libopencm3/lpc43xx/ccu.h>
@@ -51,7 +48,7 @@
 #include "gpio_lpc.h"
 
 /* GPIO Output PinMux */
-static struct gpio gpio_led[] = {
+static struct gpio_t gpio_led[] = {
     GPIO(2, 1),
     GPIO(2, 2),
     GPIO(2, 8),
@@ -61,89 +58,90 @@ static struct gpio gpio_led[] = {
 };
 
 // clang-format off
-static struct gpio gpio_1v8_enable        = GPIO(3,  6);
+static struct gpio_t gpio_1v8_enable        = GPIO(3,  6);
 
 /* MAX283x GPIO (XCVR_CTL) PinMux */
-static struct gpio gpio_max283x_select    = GPIO(0, 15);
+static struct gpio_t gpio_max283x_select    = GPIO(0, 15);
 
 /* MAX5864 SPI chip select (AD_CS) GPIO PinMux */
-static struct gpio gpio_max5864_select    = GPIO(2,  7);
+static struct gpio_t gpio_max5864_select    = GPIO(2,  7);
 
 /* RFFC5071 GPIO serial interface PinMux */
 // #ifdef RAD1O
-// static struct gpio gpio_rffc5072_select   = GPIO(2, 13);
-// static struct gpio gpio_rffc5072_clock    = GPIO(5,  6);
-// static struct gpio gpio_rffc5072_data     = GPIO(3,  3);
-// static struct gpio gpio_rffc5072_reset    = GPIO(2, 14);
+// static struct gpio_t gpio_rffc5072_select   = GPIO(2, 13);
+// static struct gpio_t gpio_rffc5072_clock    = GPIO(5,  6);
+// static struct gpio_t gpio_rffc5072_data     = GPIO(3,  3);
+// static struct gpio_t gpio_rffc5072_reset    = GPIO(2, 14);
 // #endif
 
 /* RF supply (VAA) control */
 #ifdef HACKRF_ONE
-static struct gpio gpio_vaa_disable       = GPIO(2, 9);
+static struct gpio_t gpio_vaa_disable       = GPIO(2, 9);
 #endif
 #ifdef RAD1O
-static struct gpio gpio_vaa_enable        = GPIO(2, 9);
+static struct gpio_t gpio_vaa_enable        = GPIO(2, 9);
 #endif
 
-static struct gpio gpio_w25q80bv_hold     = GPIO(1, 14);
-static struct gpio gpio_w25q80bv_wp       = GPIO(1, 15);
+static struct gpio_t gpio_w25q80bv_hold     = GPIO(1, 14);
+static struct gpio_t gpio_w25q80bv_wp       = GPIO(1, 15);
+static struct gpio_t gpio_w25q80bv_select   = GPIO(5, 11);
 
 /* RF switch control */
 #ifdef HACKRF_ONE
-static struct gpio gpio_hp                = GPIO(2,  0);
-static struct gpio gpio_lp                = GPIO(2, 10);
-static struct gpio gpio_tx_mix_bp         = GPIO(2, 11);
-static struct gpio gpio_no_mix_bypass     = GPIO(1,  0);
-static struct gpio gpio_rx_mix_bp         = GPIO(2, 12);
-static struct gpio gpio_tx_amp            = GPIO(2, 15);
-static struct gpio gpio_tx                = GPIO(5, 15);
-static struct gpio gpio_mix_bypass        = GPIO(5, 16);
-static struct gpio gpio_rx                = GPIO(5,  5);
-static struct gpio gpio_no_tx_amp_pwr     = GPIO(3,  5);
-static struct gpio gpio_amp_bypass        = GPIO(0, 14);
-static struct gpio gpio_rx_amp            = GPIO(1, 11);
-static struct gpio gpio_no_rx_amp_pwr     = GPIO(1, 12);
+static struct gpio_t gpio_hp                = GPIO(2,  0);
+static struct gpio_t gpio_lp                = GPIO(2, 10);
+static struct gpio_t gpio_tx_mix_bp         = GPIO(2, 11);
+static struct gpio_t gpio_no_mix_bypass     = GPIO(1,  0);
+static struct gpio_t gpio_rx_mix_bp         = GPIO(2, 12);
+static struct gpio_t gpio_tx_amp            = GPIO(2, 15);
+static struct gpio_t gpio_tx                = GPIO(5, 15);
+static struct gpio_t gpio_mix_bypass        = GPIO(5, 16);
+static struct gpio_t gpio_rx                = GPIO(5,  5);
+static struct gpio_t gpio_no_tx_amp_pwr     = GPIO(3,  5);
+static struct gpio_t gpio_amp_bypass        = GPIO(0, 14);
+static struct gpio_t gpio_rx_amp            = GPIO(1, 11);
+static struct gpio_t gpio_no_rx_amp_pwr     = GPIO(1, 12);
 #endif
 #ifdef RAD1O
-static struct gpio gpio_tx_rx_n           = GPIO(1,  11);
-static struct gpio gpio_tx_rx             = GPIO(0,  14);
-static struct gpio gpio_by_mix            = GPIO(1,  12);
-static struct gpio gpio_by_mix_n          = GPIO(2,  10);
-static struct gpio gpio_by_amp            = GPIO(1,  0);
-static struct gpio gpio_by_amp_n          = GPIO(5,  5);
-static struct gpio gpio_mixer_en          = GPIO(5,  16);
-static struct gpio gpio_low_high_filt     = GPIO(2,  11);
-static struct gpio gpio_low_high_filt_n   = GPIO(2,  12);
-static struct gpio gpio_tx_amp            = GPIO(2,  15);
-static struct gpio gpio_rx_lna            = GPIO(5,  15);
+static struct gpio_t gpio_tx_rx_n           = GPIO(1,  11);
+static struct gpio_t gpio_tx_rx             = GPIO(0,  14);
+static struct gpio_t gpio_by_mix            = GPIO(1,  12);
+static struct gpio_t gpio_by_mix_n          = GPIO(2,  10);
+static struct gpio_t gpio_by_amp            = GPIO(1,  0);
+static struct gpio_t gpio_by_amp_n          = GPIO(5,  5);
+static struct gpio_t gpio_mixer_en          = GPIO(5,  16);
+static struct gpio_t gpio_low_high_filt     = GPIO(2,  11);
+static struct gpio_t gpio_low_high_filt_n   = GPIO(2,  12);
+static struct gpio_t gpio_tx_amp            = GPIO(2,  15);
+static struct gpio_t gpio_rx_lna            = GPIO(5,  15);
 #endif
 
 /* CPLD JTAG interface GPIO pins */
-static struct gpio gpio_cpld_tdo          = GPIO(5, 18);
-static struct gpio gpio_cpld_tck          = GPIO(3,  0);
+static struct gpio_t gpio_cpld_tdo          = GPIO(5, 18);
+static struct gpio_t gpio_cpld_tck          = GPIO(3,  0);
 #if (defined HACKRF_ONE || defined RAD1O)
-static struct gpio gpio_cpld_tms          = GPIO(3,  4);
-static struct gpio gpio_cpld_tdi          = GPIO(3,  1);
+static struct gpio_t gpio_cpld_tms          = GPIO(3,  4);
+static struct gpio_t gpio_cpld_tdi          = GPIO(3,  1);
 #else
-static struct gpio gpio_cpld_tms          = GPIO(3,  1);
-static struct gpio gpio_cpld_tdi          = GPIO(3,  4);
+static struct gpio_t gpio_cpld_tms          = GPIO(3,  1);
+static struct gpio_t gpio_cpld_tdi          = GPIO(3,  4);
 #endif
 
 #ifdef HACKRF_ONE
-static struct gpio gpio_cpld_pp_tms       = GPIO(1,  1);
-static struct gpio gpio_cpld_pp_tdo       = GPIO(1,  8);
+static struct gpio_t gpio_cpld_pp_tms       = GPIO(1,  1);
+static struct gpio_t gpio_cpld_pp_tdo       = GPIO(1,  8);
 #endif
 
 /* other CPLD interface GPIO pins */
-static struct gpio gpio_hw_sync_enable    = GPIO(5, 12);
-static struct gpio gpio_q_invert          = GPIO(0, 13);
+static struct gpio_t gpio_hw_sync_enable    = GPIO(5, 12);
+static struct gpio_t gpio_q_invert          = GPIO(0, 13);
 
 /* HackRF One r9 */
 #ifdef HACKRF_ONE
-static struct gpio gpio_h1r9_rx             = GPIO(0, 7);
-static struct gpio gpio_h1r9_1v8_enable     = GPIO(2, 9);
-static struct gpio gpio_h1r9_vaa_disable    = GPIO(3, 6);
-static struct gpio gpio_h1r9_hw_sync_enable = GPIO(5, 5);
+static struct gpio_t gpio_h1r9_rx             = GPIO(0, 7);
+static struct gpio_t gpio_h1r9_1v8_enable     = GPIO(2, 9);
+static struct gpio_t gpio_h1r9_vaa_disable    = GPIO(3, 6);
+static struct gpio_t gpio_h1r9_hw_sync_enable = GPIO(5, 5);
 #endif
 // clang-format on
 
@@ -218,10 +216,11 @@ max5864_driver_t max5864 = {
     .target_init = max5864_target_init,
 };
 
-ssp_config_t ssp_config_w25q80bv = {
+const ssp_config_t ssp_config_w25q80bv = {
     .data_bits = SSP_DATA_8BITS,
     .serial_clock_rate = 2,
     .clock_prescale_rate = 2,
+    .gpio_select = &gpio_w25q80bv_select,
 };
 
 spi_bus_t spi_bus_ssp0 = {
@@ -432,105 +431,96 @@ bool sample_rate_frac_set(uint32_t rate_num, uint32_t rate_denom) {
     return true;
 }
 
-/*
- * Configure clock generator to produce sample clock in units of 1/(2**24) Hz.
- * Can be called with program=false for a dry run that returns the resultant
- * frequency without actually configuring the clock generator.
- */
-fp_40_24_t sample_rate_set(const fp_40_24_t sample_rate, const bool program) {
-    const fp_40_24_t vco = 800 * FP_ONE_MHZ;
-    uint64_t p1, p2, p3;
-    uint64_t n, d, q;
-    fp_40_24_t remainder, resultant_rate;
+bool sample_rate_set(const uint32_t sample_rate_hz) {
+    uint32_t p1 = 4608;
+    uint32_t p2 = 0;
+    uint32_t p3 = 0;
 
-    fp_40_24_t rate = sample_rate * 2;
+    switch (sample_rate_hz) {
+        case 8000000:
+            p1 = SI_INTDIV(50);  // 800MHz / 50 = 16 MHz (SGPIO), 8 MHz (codec)
+            break;
 
-    p1 = ((128 * vco) / rate) - 512;
-    if (vco % rate) {
-        n = (128 * vco) - (rate * (p1 + 512));
-        d = rate / FP_ONE_HZ;
-        n += (d / 2);
-        p2 = n / d;
-        p3 = 1 << 24;
+        case 9216000:
+            // 43.40277777777778: a = 43; b = 29; c = 72
+            p1 = 5043;
+            p2 = 40;
+            p3 = 72;
+            break;
 
-        unsigned int shift = p2 ? __builtin_ctzll(p2) : 24;
-        p2 >>= shift;
-        p3 >>= shift;
+        case 10000000:
+            p1 = SI_INTDIV(40);  // 800MHz / 40 = 20 MHz (SGPIO), 10 MHz (codec)
+            break;
 
-        const uint64_t p3_max = 0xfffff;
-        if (p3 > p3_max) {
-            p2 *= p3_max;
-            p2 += (p3 / 2);
-            p2 /= p3;
-            p3 = p3_max;
-        }
+        case 12288000:
+            // 32.552083333333336: a = 32; b = 159; c = 288
+            p1 = 3654;
+            p2 = 192;
+            p3 = 288;
+            break;
 
-        if (p2 >= p3) {
-            p1++;
-            p2 = 0;
-        }
-    } else {
-        p2 = 0;
-    }
+        case 12500000:
+            p1 = SI_INTDIV(32);  // 800MHz / 32 = 25 MHz (SGPIO), 12.5 MHz (codec)
+            break;
 
-    if (p1 > 0x3fe00) {
-        p1 = 0x3fe00;
-        p2 = 0;
-    }
+        case 16000000:
+            p1 = SI_INTDIV(25);  // 800MHz / 25 = 32 MHz (SGPIO), 16 MHz (codec)
+            break;
 
-    if (p2 == 0) {
-        p3 = 1;
-        n = (vco * 128);
-        d = (p1 + 512);
-        n += (d / 2);
-        resultant_rate = n / d;
-    } else {
-        const uint64_t vco_hz = vco / FP_ONE_HZ;
-        n = p3 * vco_hz * 128;
-        d = p3 * (p1 + 512) + p2;
-        const uint64_t rate_hz = n / d;
-        remainder = (n - (d * rate_hz)) * FP_ONE_HZ;
-        remainder += (d / 2);
-        q = remainder / d;
-        resultant_rate = (rate_hz * FP_ONE_HZ) + q;
-    }
+        case 18432000:
+            // 21.70138888889: a = 21; b = 101; c = 144
+            p1 = 2265;
+            p2 = 112;
+            p3 = 144;
+            break;
 
-    resultant_rate = (resultant_rate + 1) / 2;
+        case 20000000:
+            p1 = SI_INTDIV(20);  // 800MHz / 20 = 40 MHz (SGPIO), 20 MHz (codec)
+            break;
 
-    if (!program) {
-        return resultant_rate;
-    }
-
-    bool streaming = sgpio_cpld_stream_is_enabled(&sgpio_config);
-
-    if (streaming) {
-        sgpio_cpld_stream_disable(&sgpio_config);
-    }
-
-    if (p1 & 0x1 || p2) {
-        si5351c_set_int_mode(&clock_gen, 0, 0);
-    } else {
-        si5351c_set_int_mode(&clock_gen, 0, 1);
+        default:
+            return false;
     }
 
     if (detected_platform() == BOARD_ID_HACKRF1_R9) {
+        /*
+         * On HackRF One r9 all sample clocks are externally derived
+         * from MS1/CLK1 operating at twice the sample rate.
+         */
         si5351c_configure_multisynth(&clock_gen, 1, p1, p2, p3, 0);
     } else {
+        /*
+         * On other platforms the clock generator produces three
+         * different sample clocks, all derived from multisynth 0.
+         */
+        /* MS0/CLK0 is the source for the MAX5864/CPLD (CODEC_CLK). */
         si5351c_configure_multisynth(&clock_gen, 0, p1, p2, p3, 1);
-        si5351c_configure_multisynth(&clock_gen, 1, 0, 0, 0, 0);
-        si5351c_configure_multisynth(&clock_gen, 2, 0, 0, 0, 0);
+
+        /* MS0/CLK1 is the source for the CPLD (CODEC_X2_CLK). */
+        si5351c_configure_multisynth(
+            &clock_gen,
+            1,
+            p1,
+            0,
+            1,
+            0);  // p1 doesn't matter
+
+        /* MS0/CLK2 is the source for SGPIO (CODEC_X2_CLK) */
+        si5351c_configure_multisynth(
+            &clock_gen,
+            2,
+            p1,
+            0,
+            1,
+            0);  // p1 doesn't matter
     }
 
-    if (streaming) {
-        sgpio_cpld_stream_enable(&sgpio_config);
-    }
-
-    return resultant_rate;
+    return true;
 }
 
 bool baseband_filter_bandwidth_set(const uint32_t bandwidth_hz) {
     uint32_t bandwidth_hz_real;
-    bandwidth_hz_real = max283x_set_lpf_bandwidth(&max283x, MAX283x_MODE_RX, bandwidth_hz);
+    bandwidth_hz_real = max283x_set_lpf_bandwidth(&max283x, bandwidth_hz);
 
     if (bandwidth_hz_real) {
         hackrf_ui()->set_filter_bw(bandwidth_hz_real);
@@ -625,8 +615,8 @@ void cpu_clock_init(void) {
     si5351c_power_down_all_clocks(&clock_gen);
     si5351c_set_crystal_configuration(&clock_gen);
     si5351c_enable_xo_and_ms_fanout(&clock_gen);
-    si5351c_configure_pll_sources(&clock_gen, PLL_SOURCE_XTAL);
-    si5351c_configure_pll_multisynth(&clock_gen, PLL_SOURCE_XTAL);
+    si5351c_configure_pll_sources(&clock_gen);
+    si5351c_configure_pll_multisynth(&clock_gen);
 
     /*
      * Clocks on HackRF One r9:
@@ -677,7 +667,7 @@ void cpu_clock_init(void) {
     /* MS7/CLK7 is unused. */
 
     /* Set to 10 MHz, the common rate between Jawbreaker and HackRF One. */
-    sample_rate_set(10000000 * (fp_40_24_t)FP_ONE_HZ, true);
+    sample_rate_set(10000000);
 
     si5351c_set_clock_source(&clock_gen, PLL_SOURCE_XTAL);
     // soft reset
@@ -864,8 +854,6 @@ void ssp1_set_mode_max5864(void) {
 }
 
 void pin_setup(void) {
-    const platform_scu_t* scu = platform_scu();
-
     /* Configure all GPIO as Input (safe state) */
     // gpio_init();
 
@@ -884,26 +872,26 @@ void pin_setup(void) {
      * LPC43xx pull-up and pull-down resistors are approximately 53K.
      */
 #ifdef HACKRF_ONE
-    scu_pinmux(scu->PINMUX_PP_TMS, SCU_GPIO_PUP | SCU_CONF_FUNCTION0);
-    scu_pinmux(scu->PINMUX_PP_TDO, SCU_GPIO_PDN | SCU_CONF_FUNCTION0);
+    scu_pinmux(SCU_PINMUX_PP_TMS, SCU_GPIO_PUP | SCU_CONF_FUNCTION0);
+    scu_pinmux(SCU_PINMUX_PP_TDO, SCU_GPIO_PDN | SCU_CONF_FUNCTION0);
 #endif
-    scu_pinmux(scu->PINMUX_CPLD_TMS, SCU_GPIO_NOPULL | SCU_CONF_FUNCTION0);
-    scu_pinmux(scu->PINMUX_CPLD_TDI, SCU_GPIO_NOPULL | SCU_CONF_FUNCTION0);
-    scu_pinmux(scu->PINMUX_CPLD_TDO, SCU_GPIO_PDN | SCU_CONF_FUNCTION4);
-    scu_pinmux(scu->PINMUX_CPLD_TCK, SCU_GPIO_PDN | SCU_CONF_FUNCTION0);
+    scu_pinmux(SCU_PINMUX_CPLD_TMS, SCU_GPIO_NOPULL | SCU_CONF_FUNCTION0);
+    scu_pinmux(SCU_PINMUX_CPLD_TDI, SCU_GPIO_NOPULL | SCU_CONF_FUNCTION0);
+    scu_pinmux(SCU_PINMUX_CPLD_TDO, SCU_GPIO_PDN | SCU_CONF_FUNCTION4);
+    scu_pinmux(SCU_PINMUX_CPLD_TCK, SCU_GPIO_PDN | SCU_CONF_FUNCTION0);
 
     /* Configure SCU Pin Mux as GPIO */
-    scu_pinmux(scu->PINMUX_LED1, SCU_GPIO_NOPULL);
-    scu_pinmux(scu->PINMUX_LED2, SCU_GPIO_NOPULL);
-    scu_pinmux(scu->PINMUX_LED3, SCU_GPIO_NOPULL);
+    scu_pinmux(SCU_PINMUX_LED1, SCU_GPIO_NOPULL);
+    scu_pinmux(SCU_PINMUX_LED2, SCU_GPIO_NOPULL);
+    scu_pinmux(SCU_PINMUX_LED3, SCU_GPIO_NOPULL);
 #ifdef RAD1O
-    scu_pinmux(scu->PINMUX_LED4, SCU_GPIO_NOPULL | SCU_CONF_FUNCTION4);
+    scu_pinmux(SCU_PINMUX_LED4, SCU_GPIO_NOPULL | SCU_CONF_FUNCTION4);
 #endif
 
     /* Configure USB indicators */
 #ifdef JAWBREAKER
-    scu_pinmux(scu->PINMUX_USB_LED0, SCU_CONF_FUNCTION3);
-    scu_pinmux(scu->PINMUX_USB_LED1, SCU_CONF_FUNCTION3);
+    scu_pinmux(SCU_PINMUX_USB_LED0, SCU_CONF_FUNCTION3);
+    scu_pinmux(SCU_PINMUX_USB_LED1, SCU_CONF_FUNCTION3);
 #endif
 
     gpio_output(&gpio_led[0]);
@@ -917,11 +905,11 @@ void pin_setup(void) {
     if (detected_platform() == BOARD_ID_HACKRF1_R9) {
 #ifdef HACKRF_ONE
         gpio_output(&gpio_h1r9_1v8_enable);
-        scu_pinmux(scu->H1R9_EN1V8, SCU_GPIO_FAST | SCU_CONF_FUNCTION0);
+        scu_pinmux(SCU_H1R9_EN1V8, SCU_GPIO_FAST | SCU_CONF_FUNCTION0);
 #endif
     } else {
         gpio_output(&gpio_1v8_enable);
-        scu_pinmux(scu->PINMUX_EN1V8, SCU_GPIO_FAST | SCU_CONF_FUNCTION0);
+        scu_pinmux(SCU_PINMUX_EN1V8, SCU_GPIO_FAST | SCU_CONF_FUNCTION0);
     }
 
 #ifdef HACKRF_ONE
@@ -947,8 +935,8 @@ void pin_setup(void) {
     scu_pinmux(CLK0, SCU_CLK_IN | SCU_CONF_FUNCTION7);
     scu_pinmux(CLK2, SCU_CLK_IN | SCU_CONF_FUNCTION7);
 
-    scu_pinmux(scu->PINMUX_GPIO3_10, SCU_GPIO_PDN | SCU_CONF_FUNCTION0);
-    scu_pinmux(scu->PINMUX_GPIO3_11, SCU_GPIO_PDN | SCU_CONF_FUNCTION0);
+    scu_pinmux(SCU_PINMUX_GPIO3_10, SCU_GPIO_PDN | SCU_CONF_FUNCTION0);
+    scu_pinmux(SCU_PINMUX_GPIO3_11, SCU_GPIO_PDN | SCU_CONF_FUNCTION0);
 
 #endif
 
@@ -968,7 +956,7 @@ void pin_setup(void) {
     rf_path_pin_setup(&rf_path);
 
     /* Configure external clock in */
-    scu_pinmux(scu->PINMUX_GP_CLKIN, SCU_CLK_IN | SCU_CONF_FUNCTION1);
+    scu_pinmux(SCU_PINMUX_GP_CLKIN, SCU_CLK_IN | SCU_CONF_FUNCTION1);
 
     sgpio_configure_pin_functions(&sgpio_config);
 }

firmware/baseband/sd_over_usb/scsi.c

@@ -22,7 +22,6 @@
 
 #include "scsi.h"
 #include "diskio.h"
-#include "gpio_lpc.h"
 #include <libopencm3/lpc43xx/scu.h>
 #include <libopencm3/lpc43xx/rgu.h>
 #include <libopencm3/lpc43xx/wwdt.h>
@@ -287,7 +286,7 @@ void scsi_command(msd_cbw_t* msd_cbw_data) {
 
         case SCSI_CMD_START_STOP_UNIT:
             SCU_SFSP2_8 = (SCU_SFSP2_8 & ~(7)) | 4;
-            struct gpio dfu = GPIO(5, 7);
+            struct gpio_t dfu = GPIO(5, 7);
             gpio_output(&dfu);
             gpio_clear(&dfu);
 

firmware/chibios-portapack/boards/PORTAPACK_APPLICATION/fpga_bridge.h

@@ -17,16 +17,16 @@ extern "C" {
 #ifdef PRALINE
 
 /* FPGA Register Map Address 0x03 (Dual Purpose) */
-#define FPGA_REG_RX_DIGITAL_GAIN 0x03 /* Digital Shift / scaling (RX Mode) */
-#define FPGA_REG_TX_CONTROL 0x03      /* NCO_EN and TX flags (TX Mode) */
+#define FPGA_REG_RX_DIGITAL_GAIN   0x03  /* Digital Shift / scaling (RX Mode) */
+#define FPGA_REG_TX_CONTROL        0x03  /* NCO_EN and TX flags (TX Mode) */
 
 /* FPGA Register Map Address 0x04 (Shared) */
-#define FPGA_REG_RX_DC_BLOCK_WIDTH 0x04 /* Notch filter cutoff (RX Mode) */
-#define FPGA_REG_TX_INTERP 0x04         /* Interpolation ratio (TX Mode) */
+#define FPGA_REG_RX_DC_BLOCK_WIDTH  0x04  /* Notch filter cutoff (RX Mode) */
+#define FPGA_REG_TX_INTERP           0x04  /* Interpolation ratio (TX Mode) */
 
 /* FPGA Register Map Address 0x05 (Shared) */
-#define FPGA_REG_RX_DC_ADAPT_RATE 0x05 /* Settle time/Integration (RX Mode) */
-#define FPGA_REG_TX_PHASE_STEP 0x05    /* NCO frequency step (TX Mode) */
+#define FPGA_REG_RX_DC_ADAPT_RATE   0x05  /* Settle time/Integration (RX Mode) */
+#define FPGA_REG_TX_PHASE_STEP      0x05  /* NCO frequency step (TX Mode) */
 
 /*
  * FPGA Operating Mode
@@ -41,60 +41,60 @@ typedef enum {
  * FPGA Register Addresses
  * Note: Registers 3-5 are dual-purpose (meaning depends on RX/TX mode)
  */
-#define FPGA_REG_CTRL 0x01     /* Control register */
-#define FPGA_REG_DECIM 0x02    /* Decimation (RX) / unused (TX) */
-#define FPGA_REG_SHARED_3 0x03 /* Dual-purpose register */
-#define FPGA_REG_SHARED_4 0x04 /* Dual-purpose register */
-#define FPGA_REG_SHARED_5 0x05 /* Dual-purpose register */
+#define FPGA_REG_CTRL              0x01  /* Control register */
+#define FPGA_REG_DECIM             0x02  /* Decimation (RX) / unused (TX) */
+#define FPGA_REG_SHARED_3          0x03  /* Dual-purpose register */
+#define FPGA_REG_SHARED_4          0x04  /* Dual-purpose register */
+#define FPGA_REG_SHARED_5          0x05  /* Dual-purpose register */
 
 /*
  * Register 1 (CTRL) Bit Definitions
  */
-#define FPGA_CTRL_DC_BLOCK_EN (1 << 0)      /* DC block enable */
-#define FPGA_CTRL_QUARTER_SHIFT_EN (1 << 1) /* Quarter-rate shift enable */
-#define FPGA_CTRL_QUARTER_SHIFT_UP (1 << 2) /* Shift direction: 1=up, 0=down */
-#define FPGA_CTRL_TX_MODE (1 << 5)          /* TX mode indicator (if applicable) */
-#define FPGA_CTRL_PRBS_EN (1 << 6)          /* PRBS test mode */
-#define FPGA_CTRL_TRIGGER_EN (1 << 7)       /* External trigger enable */
+#define FPGA_CTRL_DC_BLOCK_EN      (1 << 0)  /* DC block enable */
+#define FPGA_CTRL_QUARTER_SHIFT_EN (1 << 1)  /* Quarter-rate shift enable */
+#define FPGA_CTRL_QUARTER_SHIFT_UP (1 << 2)  /* Shift direction: 1=up, 0=down */
+#define FPGA_CTRL_TX_MODE          (1 << 5)  /* TX mode indicator (if applicable) */
+#define FPGA_CTRL_PRBS_EN          (1 << 6)  /* PRBS test mode */
+#define FPGA_CTRL_TRIGGER_EN       (1 << 7)  /* External trigger enable */
 
 /*
  * Register 3 Dual-Purpose Definitions
  */
 /* RX Mode: Digital gain/shift */
-#define FPGA_REG3_RX_DIGITAL_GAIN 0x03
-#define FPGA_RX_GAIN_SHIFT_MASK 0x0F /* Bits [3:0] - shift amount */
+#define FPGA_REG3_RX_DIGITAL_GAIN  0x03
+#define FPGA_RX_GAIN_SHIFT_MASK    0x0F  /* Bits [3:0] - shift amount */
 
 /* TX Mode: NCO control */
-#define FPGA_REG3_TX_NCO_CTRL 0x03
-#define FPGA_TX_NCO_EN (1 << 0)     /* NCO enable */
-#define FPGA_TX_NCO_INVERT (1 << 1) /* Invert spectrum */
+#define FPGA_REG3_TX_NCO_CTRL      0x03
+#define FPGA_TX_NCO_EN             (1 << 0)  /* NCO enable */
+#define FPGA_TX_NCO_INVERT         (1 << 1)  /* Invert spectrum */
 
 /*
  * Register 4 Dual-Purpose Definitions
  */
 /* RX Mode: DC block notch width */
-#define FPGA_REG4_RX_DC_WIDTH 0x04
-#define FPGA_RX_DC_WIDTH_MASK 0x07 /* Bits [2:0] */
+#define FPGA_REG4_RX_DC_WIDTH      0x04
+#define FPGA_RX_DC_WIDTH_MASK      0x07  /* Bits [2:0] */
 
 /* TX Mode: Interpolation ratio */
-#define FPGA_REG4_TX_INTERP 0x04
-#define FPGA_TX_INTERP_MASK 0x07 /* Bits [2:0] */
+#define FPGA_REG4_TX_INTERP        0x04
+#define FPGA_TX_INTERP_MASK        0x07  /* Bits [2:0] */
 
 /*
  * Register 5 Dual-Purpose Definitions
  */
 /* RX Mode: DC block adaptation rate */
-#define FPGA_REG5_RX_DC_RATE 0x05
-#define FPGA_RX_DC_RATE_MASK 0xFF /* Bits [7:0] */
+#define FPGA_REG5_RX_DC_RATE       0x05
+#define FPGA_RX_DC_RATE_MASK       0xFF  /* Bits [7:0] */
 
 /* TX Mode: NCO phase step (frequency) */
-#define FPGA_REG5_TX_PHASE_STEP 0x05
-#define FPGA_TX_PHASE_STEP_MASK 0xFF /* Bits [7:0] */
+#define FPGA_REG5_TX_PHASE_STEP    0x05
+#define FPGA_TX_PHASE_STEP_MASK    0xFF  /* Bits [7:0] */
 
 /* Export default values so other methods can use them */
 #define FPGA_RX_DEFAULT_DIGITAL_GAIN 0x00
-#define FPGA_RX_DEFAULT_DC_WIDTH 0x04
-#define FPGA_RX_DEFAULT_ADAPT_RATE 0x08
+#define FPGA_RX_DEFAULT_DC_WIDTH     0x04
+#define FPGA_RX_DEFAULT_ADAPT_RATE   0x08
 
 /*
  * Core Functions
@@ -102,7 +102,7 @@ typedef enum {
 
 /* Initialize the FPGA - loads bitstream from SPIFI flash
  * Returns: 0 on success, non-zero on failure */
-int fpga_bridge_init(uint8_t* mem_base);
+int fpga_bridge_init(void);
 
 /* Set operating mode - MUST be called before using mode-specific functions
  * This ensures registers 3-5 are interpreted correctly */

firmware/chibios-portapack/os/hal/platforms/LPC43xx/lpc43xx.inc

@@ -1167,21 +1167,6 @@ typedef struct {
   __IO uint32_t AYRS;
 } LPC_RTC_Type;
 
-// ------------------------------------------------------------------------------------------------
-// -----                                         EVENT ROUTER                                 -----
-// ------------------------------------------------------------------------------------------------
-
-typedef struct {
-  __IO uint32_t HILO;       /* +0x000 */
-  __IO uint32_t EDGE;       /* +0x004 */
-  __O  uint32_t CLR_EN;     /* +0x008 */
-  __O  uint32_t SET_EN;     /* +0x00C */
-  __I  uint32_t STATUS;     /* +0x010 */
-  __I  uint32_t ENABLE;     /* +0x014 */
-  __O  uint32_t CLR_STAT;   /* +0x018 */
-  __O  uint32_t SET_STAT;   /* +0x01C */
-} LPC_EVENTROUTER_Type;
-
 // ------------------------------------------------------------------------------------------------
 // -----                                       USART0/2/3                                     -----
 // ------------------------------------------------------------------------------------------------
@@ -1481,7 +1466,6 @@ typedef struct {
 #define LPC_ADC1                  ((LPC_ADCx_Type           *) LPC_ADC1_BASE)
 #define LPC_GPIO                  ((LPC_GPIO_Type           *) LPC_GPIO_BASE)
 #define LPC_SGPIO                 ((LPC_SGPIO_Type          *) LPC_SGPIO_BASE)
-#define LPC_EVENTROUTER           ((LPC_EVENTROUTER_Type *) LPC_EVENT_ROUTER_BASE)
 
 #ifdef __cplusplus
 }

firmware/common/ak4951.cpp

@@ -130,15 +130,15 @@ bool AK4951::reset() {
     return true;
 }
 
-bool AK4951::set_digtal_volume_control(const reg_t value) {
+void AK4951::set_digtal_volume_control(const reg_t value) {
     map.r.l_ch_digital_volume_control.DV = value;
-    return update(Register::LchDigitalVolumeControl);
+    update(Register::LchDigitalVolumeControl);
 }
 
-bool AK4951::set_headphone_volume(const volume_t volume) {
+void AK4951::set_headphone_volume(const volume_t volume) {
     const auto normalized = headphone_gain_range().normalize(volume);
     auto n = normalized.centibel() / 5;
-    return set_digtal_volume_control(0xcb - n);
+    set_digtal_volume_control(0xcb - n);
 }
 
 void AK4951::headphone_mute() {
@@ -602,13 +602,13 @@ reg_t AK4951::read(const address_t reg_address) {
     return rx[0];
 }
 
-bool AK4951::update(const Register reg) {
-    return write(toUType(reg), map.w[toUType(reg)]);
+void AK4951::update(const Register reg) {
+    write(toUType(reg), map.w[toUType(reg)]);
 }
 
-bool AK4951::write(const address_t reg_address, const reg_t value) {
+void AK4951::write(const address_t reg_address, const reg_t value) {
     const std::array<uint8_t, 2> tx{reg_address, value};
-    return bus.transmit(bus_address, tx.data(), tx.size());
+    bus.transmit(bus_address, tx.data(), tx.size());
 }
 
 } /* namespace ak4951 */