Marks the correctness and search-depth phases as delivered, notes what
is still outstanding inside them, and records the measured cost of
widening the scan. Frames the review section as the state at the time
of writing, since several findings no longer describe the code.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DzALEq9gGWwFmwTdgAiFcY
The unit-test job runs format:check before the tests, so an unformatted
markdown file failed the job while every test passed.
Promote the bold pseudo-headings in the Phase 3 section to real
subheadings. They previously sat directly above numbered list items,
which the formatter reads as one paragraph and collapses into a run-on
line, mangling items 13-27.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DzALEq9gGWwFmwTdgAiFcY
The review stated the finder had no e2e coverage and that
209-rundown-shortcuts.spec.ts never opened it. Both are wrong: a
"Find in rundown" smoke test opens the modal and closes it with
Escape. Describe the coverage that exists and what it leaves unguarded.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DzALEq9gGWwFmwTdgAiFcY
Reviews the existing rundown Finder and sets out a phased roadmap.
Findings:
- bare queries search title only; note and custom fields are never
searched, making custom field data unfindable
- selected index is never reset when results change, so a shrinking
result list can dereference undefined
- row clicks read selection from state rather than the clicked element,
so touch input navigates to the wrong entry
- no visible affordance anywhere, leaving the feature unreachable on
touch devices where no keyboard is available
- cuesheet already registers a scroll handler for finder jumps but the
Finder is never mounted there
Roadmap covers correctness, search depth, visibility and polish,
cuesheet reach, and a find-and-replace expansion. Records the
constraints that shape the work: cuesheet URL preset column permissions,
index memoisation on rundown revision, and the absence of any undo.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DzALEq9gGWwFmwTdgAiFcY
* chore: migrate eslint to oxlint
* chore: migrate prettier to oxfmt
* chore: migrate typescript
* chore: toThrow should have a expected value
* chore: cast test value as Day
* chore: small title fix
* chore: mocks should be hoisted
* chore: incorrect async useage
* chore: test should be inside description
* chore: test sohuld include an expeced
* chore: oxfmt
---------
Co-authored-by: alex-Arc <omnivox@LAPTOP-RC5SNBVV.localdomain>
* chore: escalate stack trace to console
* refactor: event finding in roll
* docs: initial roll specification
* refactor: call to roll
* refactor: normalise index
* refactor: roll into next event
* refactor: hot reload on waiting to roll
* refactor: wait to roll next