cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-08-18 13:44:12 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

docs(spec): correct finder test coverage claim

Browse Source 
The review stated the finder had no e2e coverage and that
209-rundown-shortcuts.spec.ts never opened it. Both are wrong: a
"Find in rundown" smoke test opens the modal and closes it with
Escape. Describe the coverage that exists and what it leaves unguarded.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DzALEq9gGWwFmwTdgAiFcY
This commit is contained in:
Claude
2026-08-17 14:52:35 +00:00
parent d6fe8305fb
commit 1506ab76ed
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/spec/finder.md
+4 -2
View File
@@ -79,8 +79,10 @@ refetch). Build from raw `rundown.entries` + `flatOrder`, memoised on **`rundown
### 1.6 Tests
None — no unit, no component, no e2e. `useSelectAndRevealEntry` is untested too.
`e2e/tests/features/209-rundown-shortcuts.spec.ts` never opens the Finder.
No unit or component tests, and `useSelectAndRevealEntry` is untested too. E2E coverage is a single
smoke test — `Find in rundown` in `e2e/tests/features/209-rundown-shortcuts.spec.ts` opens the modal
with `mod+F` and closes it with `Escape`. Nothing exercises searching, selecting, or navigating
results, so every behaviour described above is unguarded.
---