mirror of
https://github.com/cpvalente/ontime.git
synced 2026-08-22 15:39:11 +00:00
fix: rolling over midnight wrongly classified as skip
This commit is contained in:
committed by
Carlos Valente
parent
29e682ee06
commit
e6dfe9c363
@@ -1,7 +1,7 @@
|
|||||||
import { MILLIS_PER_MINUTE } from 'ontime-utils';
|
import { MILLIS_PER_MINUTE } from 'ontime-utils';
|
||||||
|
|
||||||
export const timerConfig = {
|
export const timerConfig = {
|
||||||
skipLimit: 1000, // threshold of skip for recalculating
|
skipLimit: 1000, // threshold of skip for recalculating, values lower than updateRate can cause issues with rolling over midnight
|
||||||
updateRate: 32, // how often do we update the timer
|
updateRate: 32, // how often do we update the timer
|
||||||
notificationRate: 1000, // how often do we notify clients and integrations
|
notificationRate: 1000, // how often do we notify clients and integrations
|
||||||
triggerAhead: 10, // how far ahead do we trigger the end event
|
triggerAhead: 10, // how far ahead do we trigger the end event
|
||||||
|
|||||||
@@ -99,10 +99,15 @@ class RuntimeService {
|
|||||||
});
|
});
|
||||||
this.handleLoadNext();
|
this.handleLoadNext();
|
||||||
this.rollLoaded(keepOffset);
|
this.rollLoaded(keepOffset);
|
||||||
} else if (skippedOutOfEvent(newState, this.lastIntegrationClockUpdate, timerConfig.skipLimit)) {
|
} else if (
|
||||||
|
// if there is no previous clock, we could not have skipped
|
||||||
|
RuntimeService.previousState?.clock &&
|
||||||
|
skippedOutOfEvent(newState, RuntimeService.previousState.clock, timerConfig.skipLimit)
|
||||||
|
) {
|
||||||
// if we have skipped out of the event, we will recall roll
|
// if we have skipped out of the event, we will recall roll
|
||||||
// to push the playback to the right place
|
// to push the playback to the right place
|
||||||
// this comes with the caveat that we will lose our runtime data
|
// this comes with the caveat that we will lose our runtime data
|
||||||
|
logger.warning(LogOrigin.Playback, 'Time skip detected, reloading roll');
|
||||||
this.roll(true);
|
this.roll(true);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user