refactor: offset cannot be null

This commit is contained in:
Carlos Valente
2024-07-07 20:26:41 +02:00
committed by Carlos Valente
parent e90e94828d
commit 938c5fbb4c
5 changed files with 7 additions and 7 deletions
@@ -1558,7 +1558,7 @@ describe('getRuntimeOffset()', () => {
} as RuntimeState;
const offset = getRuntimeOffset(state);
expect(offset).toBe(null);
expect(offset).toBe(0);
});
it('handles loaded event', () => {
+2 -2
View File
@@ -299,10 +299,10 @@ export const updateRoll = (state: RuntimeState) => {
* Positive offset is time ahead
* Negative offset is time delayed
*/
export function getRuntimeOffset(state: RuntimeState): MaybeNumber {
export function getRuntimeOffset(state: RuntimeState): number {
// nothing to calculate if there are no loaded events or if we havent started
if (state.eventNow === null || state.runtime.actualStart === null) {
return null;
return 0;
}
const { clock } = state;
@@ -201,7 +201,7 @@ describe('mutation on runtimeState', () => {
stop();
newState = getState();
expect(newState.runtime.actualStart).toBeNull();
expect(newState.runtime.offset).toBeNull();
expect(newState.runtime.offset).toBe(0);
expect(newState.runtime.expectedEnd).toBeNull();
});
+2 -2
View File
@@ -19,7 +19,7 @@ import { timerConfig } from '../config/config.js';
const initialRuntime: Runtime = {
selectedEventIndex: null,
numEvents: 0,
offset: null,
offset: 0,
plannedStart: 0,
plannedEnd: 0,
actualStart: null,
@@ -82,7 +82,7 @@ export function clear() {
runtimeState.eventNext = null;
runtimeState.publicEventNext = null;
runtimeState.runtime.offset = null;
runtimeState.runtime.offset = 0;
runtimeState.runtime.actualStart = null;
runtimeState.runtime.expectedEnd = null;
runtimeState.runtime.selectedEventIndex = null;
@@ -3,7 +3,7 @@ import type { MaybeNumber } from '../../utils/utils.type.js';
export type Runtime = {
numEvents: number;
selectedEventIndex: MaybeNumber;
offset: MaybeNumber;
offset: number;
plannedStart: MaybeNumber;
actualStart: MaybeNumber;
plannedEnd: MaybeNumber;