refactor: rename negative to overtime

apps/client/src/features/control/playback/playback-timer/PlaybackTimer.tsx

@@ -44,7 +44,7 @@ export default function PlaybackTimer(props: PropsWithChildren<PlaybackTimerProp
 
   const isRolling = playback === Playback.Roll;
   const isWaiting = timer.secondaryTimer !== null && timer.secondaryTimer > 0 && timer.current === null;
-  const isOvertime = timer.phase === TimerPhase.Negative;
+  const isOvertime = timer.phase === TimerPhase.Overtime;
   const hasAddedTime = Boolean(timer.addedTime);
 
   const rollLabel = isRolling ? 'Roll mode active' : '';

apps/client/src/features/viewers/minimal-timer/MinimalTimer.tsx

@@ -127,7 +127,7 @@ export default function MinimalTimer(props: MinimalTimerProps) {
   const isPlaying = time.playback !== Playback.Pause;
 
   const shouldShowModifiers = time.timerType !== TimerType.Clock && time.timerType !== TimerType.CountUp;
-  const finished = time.phase === TimerPhase.Negative;
+  const finished = time.phase === TimerPhase.Overtime;
   const showEndMessage = finished && viewSettings.endMessage && !hideEndMessage;
   const showFinished = finished && !userOptions?.hideOvertime && (shouldShowModifiers || showEndMessage);
 

apps/client/src/features/viewers/timer/Timer.tsx

@@ -111,7 +111,7 @@ export default function Timer(props: TimerProps) {
 
   const timerIsTimeOfDay = time.timerType === TimerType.Clock;
 
-  const finished = time.phase === TimerPhase.Negative;
+  const finished = time.phase === TimerPhase.Overtime;
   const totalTime = (time.duration ?? 0) + (time.addedTime ?? 0);
 
   const shouldShowModifiers = time.timerType !== TimerType.Clock && time.timerType !== TimerType.CountUp;

apps/server/src/services/__tests__/timerUtils.test.ts

@@ -1779,7 +1779,7 @@ describe('getTimerPhase()', () => {
     expect(phase).toBe(TimerPhase.None);
   });
 
-  it('can be negative', () => {
+  it('can be in overtime', () => {
     const state = {
       timer: {
         addedTime: 0,
@@ -1794,7 +1794,7 @@ describe('getTimerPhase()', () => {
     } as RuntimeState;
 
     const phase = getTimerPhase(state);
-    expect(phase).toBe(TimerPhase.Negative);
+    expect(phase).toBe(TimerPhase.Overtime);
   });
 
   it('can be danger', () => {

apps/server/src/services/timerUtils.ts

@@ -391,7 +391,7 @@ export function getTimerPhase(state: RuntimeState): TimerPhase {
   }
 
   if (current < 0) {
-    return TimerPhase.Negative;
+    return TimerPhase.Overtime;
   }
 
   const danger = state.eventNow.timeDanger;

packages/types/src/definitions/runtime/TimerState.type.ts

@@ -6,7 +6,7 @@ export enum TimerPhase {
   Default = 'default',
   Warning = 'warning',
   Danger = 'danger',
-  Negative = 'negative',
+  Overtime = 'overtime',
   Pending = 'pending', // used for waiting to roll
 }