cpvalente/ontime
1
0
Fork 0
mirror of https://github.com/cpvalente/ontime.git synced 2026-08-09 17:33:55 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix: Correct boundary condition in applyDelay

Browse Source 
The `applyDelay` function had a condition that incorrectly used `rundown.order.length` instead of `rundownMetadata.flatEntryOrder.length` to check if a delay entry was the last in the sequence. `rundown.order` only contains top-level entries, while `flatEntryOrder` contains all entries, including those within blocks, which is the relevant list for this check.

This commit corrects the condition to use `rundownMetadata.flatEntryOrder.length`.

Existing tests in `rundown.dao.test.ts` (specifically the test `removes delays in last position without applying changes`) already cover this scenario and pass with the correction, ensuring the fix behaves as expected.
This commit is contained in:
google-labs-jules[bot]
2025-06-10 16:33:25 +00:00
committed by Carlos Valente
parent 2de7221653
commit 02c30c9681
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/server/src/api-data/rundown/rundown.dao.ts
+1 -1
View File
@@ -329,7 +329,7 @@ function applyDelay(rundown: Rundown, delay: OntimeDelay) {
// if the delay is empty, or the last element
// there is nothing do apply
if (delay.duration === 0 || delayIndex === rundown.order.length - 1) {
if (delay.duration === 0 || delayIndex === rundownMetadata.flatEntryOrder.length - 1) {
return;
}