tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-07 12:33:42 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

transform: fix incorrect alignment of heap-to-stack transform

Browse Source 
It assumed the maximum alignment was equal to sizeof(void*), which is
definitely not the case. So this only worked more or less by accident
previously.

It now uses the alignment as specified by the frontend, or else
`unsafe.Alignof(complex128)` which is typically the maximum alignment of
a given platform (though this shouldn't really happen in practice: the
optimizer should keep the 'align' attribute in place).
This commit is contained in:
Ayke van Laethem
2024-06-25 20:14:05 +02:00
committed by Ron Evans
parent 571447c7c1
commit e6caa3fe9e
5 changed files with 62 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
transform/testdata/allocs.out.ll
Vendored
+22 -3
View File
@@ -22,14 +22,33 @@ define i16 @testArray() {
ret i16 %val
}
define void @testUnknownAlign() {
%stackalloc4 = alloca [32 x i8], align 8
%stackalloc3 = alloca [24 x i8], align 8
%stackalloc2 = alloca [12 x i8], align 8
%stackalloc1 = alloca [6 x i8], align 8
%stackalloc = alloca [3 x i8], align 8
store [32 x i8] zeroinitializer, ptr %stackalloc4, align 8
store i8 5, ptr %stackalloc4, align 1
store [24 x i8] zeroinitializer, ptr %stackalloc3, align 8
store i16 5, ptr %stackalloc3, align 2
store [12 x i8] zeroinitializer, ptr %stackalloc2, align 8
store i16 5, ptr %stackalloc2, align 2
store [6 x i8] zeroinitializer, ptr %stackalloc1, align 8
store i16 5, ptr %stackalloc1, align 2
store [3 x i8] zeroinitializer, ptr %stackalloc, align 8
store i16 5, ptr %stackalloc, align 2
ret void
}
define void @testEscapingCall() {
%alloc = call ptr @runtime.alloc(i32 4, ptr null)
%alloc = call align 4 ptr @runtime.alloc(i32 4, ptr null)
%val = call ptr @escapeIntPtr(ptr %alloc)
ret void
}
define void @testEscapingCall2() {
%alloc = call ptr @runtime.alloc(i32 4, ptr null)
%alloc = call align 4 ptr @runtime.alloc(i32 4, ptr null)
%val = call ptr @escapeIntPtrSometimes(ptr %alloc, ptr %alloc)
ret void
}
@@ -42,7 +61,7 @@ define void @testNonEscapingCall() {
}
define ptr @testEscapingReturn() {
%alloc = call ptr @runtime.alloc(i32 4, ptr null)
%alloc = call align 4 ptr @runtime.alloc(i32 4, ptr null)
ret ptr %alloc
}