os.Remove: avoid double-wrapping err; fixes TODO in test

This commit is contained in:
Dan Kegel
2021-11-26 18:53:33 -08:00
committed by Ron Evans
parent f79f6b0e62
commit e354a3523b
2 changed files with 2 additions and 3 deletions
+1 -1
View File
@@ -47,7 +47,7 @@ func Remove(path string) error {
} }
err := fs.Remove(suffix) err := fs.Remove(suffix)
if err != nil { if err != nil {
return &PathError{"remove", path, err} return err
} }
return nil return nil
} }
+1 -2
View File
@@ -63,9 +63,8 @@ func TestRemove(t *testing.T) {
t.Errorf("TestRemove: PathError returned path %q, expected %q", pe.Path, f) t.Errorf("TestRemove: PathError returned path %q, expected %q", pe.Path, f)
} }
} }
// TODO: make this pass.
if !IsNotExist(err) { if !IsNotExist(err) {
t.Logf("TestRemove: TODO: expected IsNotExist(err) true, got false; err %q", err.Error()) t.Errorf("TestRemove: expected IsNotExist(err) true, got false; err %q", err.Error())
} }
} }