From e27b2c4ad67f1cc3e7914ab1a1e82de95038dcd4 Mon Sep 17 00:00:00 2001 From: Dan Kegel Date: Mon, 12 Aug 2024 14:55:53 -0700 Subject: [PATCH] circleci: our version of misspell is no longer supported with go < 1.21, so disable lint in go 1.19 ci job I jumped through quite a few hoops to get test-llvm15-go119 to work, but this last hoop seems not worth jumping through: cd internal/tools && go generate -tags tools ./ /go/pkg/mod/github.com/golangci/misspell@v0.6.0/mime.go:10:2: package slices is not in GOROOT (/usr/local/go/src/slices) tools.go:12: running "go": exit status 1 make: *** [GNUmakefile:952: tools] Error 1 I mean, we could patch misspell to not use slices, or to use the prerelease slices, but... --- .circleci/config.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 8d104de04..f694a4ee1 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -104,6 +104,8 @@ jobs: steps: - test-linux: llvm: "15" + # "make lint" fails before go 1.21 because internal/tools/go.mod specifies packages that require go 1.21 + fmt-check: false resource_class: large test-llvm18-go122: docker: