tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-10 05:53:39 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

compiler: compare slice against nil

Browse Source
This commit is contained in:
Ayke van Laethem
2018-10-20 17:22:51 +02:00
parent 3f05490846
commit da89464a63
3 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/compiler.go
+13
View File
@@ -2863,6 +2863,19 @@ func (c *Compiler) parseBinOp(frame *Frame, binop *ssa.BinOp) (llvm.Value, error
default:
return llvm.Value{}, errors.New("todo: binop on pointer: " + binop.Op.String())
}
case *types.Slice:
// Slices are in general not comparable, but can be compared against
// nil. Assume at least one of them is nil to make the code easier.
xPtr := c.builder.CreateExtractValue(x, 0, "")
yPtr := c.builder.CreateExtractValue(y, 0, "")
switch binop.Op {
case token.EQL: // ==
return c.builder.CreateICmp(llvm.IntEQ, xPtr, yPtr, ""), nil
case token.NEQ: // !=
return c.builder.CreateICmp(llvm.IntNE, xPtr, yPtr, ""), nil
default:
return llvm.Value{}, errors.New("todo: binop on slice: " + binop.Op.String())
}
default:
return llvm.Value{}, errors.New("unknown binop type: " + binop.X.Type().String())
}