tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-13 07:23:39 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

avr: unify GPIO pin/port code

Browse Source 
All the AVRs that I've looked at had the same pin/port structure, with
the possible states being input/floating, input/pullup, low, and high
(with the same PORT/DDR registers). The main difference is the number of
available ports and pins. To reduce the amount of code and avoid
duplication (and thus errors) I decided to centralize this, following
the design used by the atmega2560 but while using a trick to save
tracking a few registers.

In the process, I noticed that the Pin.Get() function was incorrect on
the atmega2560 implementation. It is now fixed in the unified code.
This commit is contained in:
Ayke van Laethem
2020-05-14 23:18:15 +02:00
committed by Ron Evans
parent 424d775bf4
commit da505a6b17
5 changed files with 111 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/machine/machine_atmega328p.go
+8 -44
View File
@@ -9,51 +9,15 @@ import (
const irq_USART0_RX = avr.IRQ_USART_RX
// Configure sets the pin to input or output.
func (p Pin) Configure(config PinConfig) {
if config.Mode == PinOutput { // set output bit
switch p / 8 {
case 0: // port B
avr.DDRB.SetBits(1 << uint8(p))
case 1: // port C
avr.DDRC.SetBits(1 << uint8(p-8))
case 2: // port D
avr.DDRD.SetBits(1 << uint8(p-16))
}
} else { // configure input: clear output bit
switch p / 8 {
case 0: // port B
avr.DDRB.ClearBits(1 << uint8(p))
case 1: // port C
avr.DDRC.ClearBits(1 << uint8(p-8))
case 2: // port D
avr.DDRD.ClearBits(1 << uint8(p-16))
}
}
}
// Get returns the current value of a GPIO pin.
func (p Pin) Get() bool {
var val uint8
switch p / 8 {
case 0: // port B
val = avr.PINB.Get() & (1 << uint8(p))
case 1: // port C
val = avr.PINC.Get() & (1 << uint8(p-8))
case 2: // port D
val = avr.PIND.Get() & (1 << uint8(p-16))
}
return val != 0
}
// getPortMask returns the PORTx register and mask for the pin.
func (p Pin) getPortMask() (*volatile.Register8, uint8) {
switch p / 8 {
case 0: // port B
return avr.PORTB, 1 << uint8(p)
case 1:
return avr.PORTC, 1 << uint8(p-8)
default:
return avr.PORTD, 1 << uint8(p-16)
switch {
case p >= PB0 && p <= PB7: // port B
return avr.PORTB, 1 << uint8(p-portB)
case p >= PC0 && p <= PC7: // port C
return avr.PORTC, 1 << uint8(p-portC)
default: // port D
return avr.PORTD, 1 << uint8(p-portD)
}
}