From d59c706e60c4771c4135ad3a813a98fd97c4ae7b Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Sat, 4 Jul 2026 11:39:23 -0700 Subject: [PATCH] GNUmakefile: increase encoding/xml test stack Top-level tests now run in goroutines, which puts stdlib tests on TinyGo's default host goroutine stack. encoding/xml's depth-limit test needs a larger stack on Linux and Darwin, so run just that package with a larger stack while leaving the rest of the host stdlib tests on the default stack. --- GNUmakefile | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/GNUmakefile b/GNUmakefile index 8bd91521d..ec4c6a1a5 100644 --- a/GNUmakefile +++ b/GNUmakefile @@ -493,10 +493,12 @@ report-stdlib-tests-pass: ifeq ($(uname),Darwin) TEST_PACKAGES_HOST := $(TEST_PACKAGES_FAST) $(TEST_PACKAGES_DARWIN) TEST_IOFS := true +TEST_ENCODING_XML := true endif ifeq ($(uname),Linux) TEST_PACKAGES_HOST := $(TEST_PACKAGES_FAST) $(TEST_PACKAGES_LINUX) TEST_IOFS := true +TEST_ENCODING_XML := true endif ifeq ($(OS),Windows_NT) TEST_PACKAGES_HOST := $(TEST_PACKAGES_FAST) $(TEST_PACKAGES_WINDOWS) @@ -512,7 +514,10 @@ TEST_ADDITIONAL_FLAGS ?= tinygo-test: @# TestExtraMethods: used by many crypto packages and uses reflect.Type.Method which is not implemented. @# TestParseAndBytesRoundTrip/P256/Generic: needs Goexit to run defers on wasm. - $(TINYGO) test $(TEST_ADDITIONAL_FLAGS) $(TEST_SKIP_FLAG) $(TEST_PACKAGES_HOST) $(TEST_PACKAGES_SLOW) + $(TINYGO) test $(TEST_ADDITIONAL_FLAGS) $(TEST_SKIP_FLAG) $(filter-out encoding/xml,$(TEST_PACKAGES_HOST)) $(TEST_PACKAGES_SLOW) +ifeq ($(TEST_ENCODING_XML),true) + $(TINYGO) test $(TEST_ADDITIONAL_FLAGS) $(TEST_SKIP_FLAG) -stack-size=16MB encoding/xml +endif @# io/fs requires os.ReadDir, not yet supported on windows or wasi. It also @# requires a large stack-size. Hence, io/fs is only run conditionally. @# For more details, see the comments on issue #3143.