tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-22 13:29:01 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

transform: fix memory corruption issues

Browse Source 
There was a bug in the wasm ABI lowering pass (found using
AddressSanitizer on LLVM 15) that resulted in a rather subtle memory
corruption. This commit fixes this issues.
This commit is contained in:
Ayke van Laethem
2022-10-12 21:46:50 +02:00
committed by Ron Evans
parent 62df1d7490
commit d435fc868b
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
transform/wasm-abi.go
+1 -2
View File
@@ -88,8 +88,7 @@ func ExternalInt64AsPtr(mod llvm.Module, config *compileopts.Config) error {
// Update all users to call the external function. // Update all users to call the external function.
// The old $i64wrapper function could be removed, but it may as well // The old $i64wrapper function could be removed, but it may as well
// be left in place. // be left in place.
for use := fn.FirstUse(); !use.IsNil(); use = use.NextUse() { for _, call := range getUses(fn) {
call := use.User()
entryBlockBuilder.SetInsertPointBefore(call.InstructionParent().Parent().EntryBasicBlock().FirstInstruction()) entryBlockBuilder.SetInsertPointBefore(call.InstructionParent().Parent().EntryBasicBlock().FirstInstruction())
builder.SetInsertPointBefore(call) builder.SetInsertPointBefore(call)
callParams := []llvm.Value{} callParams := []llvm.Value{}