mirror of
https://github.com/tinygo-org/tinygo.git
synced 2026-08-13 07:23:39 +00:00
runtime,syscall,internal/poll,os: wasip1 poll_oneoff scheduler integration + net.FileListener (#5386)
* runtime,syscall,internal/poll,os: wasip1 poll_oneoff scheduler integration + net.FileListener On wasip1 today every syscall.Read/Write blocks the entire wasm module — the cooperative scheduler invokes poll_oneoff only for sleep/timer wakeups, and there's no path from the net package to a working TCP server. This change fixes both: it threads poll_oneoff through the scheduler's idle path so a goroutine doing FD I/O parks instead of blocking the module, and it provides enough internal/poll / os / syscall surface that upstream Go's net.FileListener / net.FileConn works on a host-pre-opened TCP socket. * runtime: keep scheduler_cooperative idle-wait calls direct TestBinarySize/hifive1b/examples/echo regressed by 32 bytes after the previous commit routed the scheduler's idle wait through a schedulerIdleWait helper. The extra call frame + branch landed on every non-wasip1 cooperative target, where the original direct sleepTicks / waitForEvents calls compile to a single inlined call.
This commit is contained in:
+16
-3
@@ -37,9 +37,19 @@ func rename(oldname, newname string) error {
|
||||
// can overwrite this data, which could cause the finalizer
|
||||
// to close the wrong file descriptor.
|
||||
type file struct {
|
||||
handle FileHandle
|
||||
name string
|
||||
dirinfo *dirInfo // nil unless directory being read
|
||||
handle FileHandle
|
||||
name string
|
||||
dirinfo *dirInfo // nil unless directory being read
|
||||
|
||||
// pfd is set on wasip1 by (*File).PollFD to a *poll.FD that wraps
|
||||
// the underlying syscall FD. When set, Close routes through it so
|
||||
// the refcount semantics shared with net.FileListener / net.FileConn
|
||||
// are honoured. On non-wasip1 builds pfd is a literal empty struct
|
||||
// (see pollfd_other.go) and stays at zero bytes — provided it's not
|
||||
// the last field of this struct, which is why it lives here above
|
||||
// appendMode rather than at the end.
|
||||
pfd pollFD
|
||||
|
||||
appendMode bool
|
||||
}
|
||||
|
||||
@@ -48,6 +58,9 @@ func (f *file) close() (err error) {
|
||||
f.dirinfo.close()
|
||||
f.dirinfo = nil
|
||||
}
|
||||
if f.pfd.Exist() {
|
||||
return f.pfd.Close()
|
||||
}
|
||||
return f.handle.Close()
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user