tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-20 04:19:04 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

runtime: zero map key/value on deletion to so GC doesn't see them

Browse Source
This commit is contained in:
Damian Gryski
2023-03-26 17:47:11 -07:00
committed by Ron Evans
parent 5fee3428bc
commit cb9c6f0074
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/runtime/hashmap.go
+5
View File
@@ -342,6 +342,11 @@ func hashmapDelete(m *hashmap, key unsafe.Pointer, hash uint32) {
if m.keyEqual(key, slotKey, m.keySize) { if m.keyEqual(key, slotKey, m.keySize) {
// Found the key, delete it. // Found the key, delete it.
bucket.tophash[i] = 0 bucket.tophash[i] = 0
// Zero out the key and value so garbage collector doesn't pin the allocations.
memzero(slotKey, m.keySize)
slotValueOffset := unsafe.Sizeof(hashmapBucket{}) + m.keySize*8 + m.valueSize*uintptr(i)
slotValue := unsafe.Add(unsafe.Pointer(bucket), slotValueOffset)
memzero(slotValue, m.valueSize)
m.count-- m.count--
return return
} }