tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-17 11:13:27 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

compiler: fix min/max on floats by using intrinsics

Browse Source 
This fixes two edge cases for min/max:
min/max(+0.0, -0.0) = -0.0, +0.0
min/max(number, NaN) = NaN, NaN

The compare and select method does not work here.
I switched to the llvm.minimum/llvm.maximum intrinsics which match the intended behavior.

The integer min/max were also swapped over to using intrinsics.
The compare and select path is now only used by strings.
This commit is contained in:
Nia Waldvogel
2025-12-28 09:44:58 -05:00
committed by Ron Evans
parent 8ef36ed939
commit bc9708f51a
4 changed files with 105 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files
testdata/go1.21.txt
Vendored
+2
View File
@@ -1,5 +1,7 @@
min/max: -3 5
min/max: -3.000000e+000 +5.000000e+000
min/max: -0.000000e+000 +0.000000e+000
min/max: NaN NaN
cleared s[:3]: 0 0 0 4 5
cleared map: 0
added to cleared map: four 1