tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-09 13:33:39 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

tests: do not cast pointers to uintptr

Browse Source 
uintptr is not tracked by the GC, while any pointer type (including
unsafe.Pointer) is tracked. Make sure to only cast pointers to uintptr
when absolutely necessary.

This fixes a bug found in #3162.
This commit is contained in:
Ayke van Laethem
2022-09-30 14:27:25 +02:00
parent 03d1c44265
commit a73e7ff67a
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/runtime_wasi/malloc_test.go
+13 -13
View File
@@ -23,13 +23,13 @@ func libc_calloc(nmemb, size uintptr) unsafe.Pointer
//export realloc //export realloc
func libc_realloc(ptr unsafe.Pointer, size uintptr) unsafe.Pointer func libc_realloc(ptr unsafe.Pointer, size uintptr) unsafe.Pointer
func getFilledBuffer_malloc() uintptr { func getFilledBuffer_malloc() unsafe.Pointer {
ptr := libc_malloc(5) ptr := libc_malloc(5)
fillPanda(ptr) fillPanda(ptr)
return uintptr(ptr) return ptr
} }
func getFilledBuffer_calloc() uintptr { func getFilledBuffer_calloc() unsafe.Pointer {
ptr := libc_calloc(2, 5) ptr := libc_calloc(2, 5)
fillPanda(ptr) fillPanda(ptr)
*(*byte)(unsafe.Add(ptr, 5)) = 'b' *(*byte)(unsafe.Add(ptr, 5)) = 'b'
@@ -37,23 +37,23 @@ func getFilledBuffer_calloc() uintptr {
*(*byte)(unsafe.Add(ptr, 7)) = 'a' *(*byte)(unsafe.Add(ptr, 7)) = 'a'
*(*byte)(unsafe.Add(ptr, 8)) = 'r' *(*byte)(unsafe.Add(ptr, 8)) = 'r'
*(*byte)(unsafe.Add(ptr, 9)) = 's' *(*byte)(unsafe.Add(ptr, 9)) = 's'
return uintptr(ptr) return ptr
} }
func getFilledBuffer_realloc() uintptr { func getFilledBuffer_realloc() unsafe.Pointer {
origPtr := getFilledBuffer_malloc() origPtr := getFilledBuffer_malloc()
ptr := libc_realloc(unsafe.Pointer(origPtr), 9) ptr := libc_realloc(origPtr, 9)
*(*byte)(unsafe.Add(ptr, 5)) = 'b' *(*byte)(unsafe.Add(ptr, 5)) = 'b'
*(*byte)(unsafe.Add(ptr, 6)) = 'e' *(*byte)(unsafe.Add(ptr, 6)) = 'e'
*(*byte)(unsafe.Add(ptr, 7)) = 'a' *(*byte)(unsafe.Add(ptr, 7)) = 'a'
*(*byte)(unsafe.Add(ptr, 8)) = 'r' *(*byte)(unsafe.Add(ptr, 8)) = 'r'
return uintptr(ptr) return ptr
} }
func getFilledBuffer_reallocNil() uintptr { func getFilledBuffer_reallocNil() unsafe.Pointer {
ptr := libc_realloc(nil, 5) ptr := libc_realloc(nil, 5)
fillPanda(ptr) fillPanda(ptr)
return uintptr(ptr) return ptr
} }
func fillPanda(ptr unsafe.Pointer) { func fillPanda(ptr unsafe.Pointer) {
@@ -64,10 +64,10 @@ func fillPanda(ptr unsafe.Pointer) {
*(*byte)(unsafe.Add(ptr, 4)) = 'a' *(*byte)(unsafe.Add(ptr, 4)) = 'a'
} }
func checkFilledBuffer(t *testing.T, ptr uintptr, content string) { func checkFilledBuffer(t *testing.T, ptr unsafe.Pointer, content string) {
t.Helper() t.Helper()
buf := *(*string)(unsafe.Pointer(&reflect.StringHeader{ buf := *(*string)(unsafe.Pointer(&reflect.StringHeader{
Data: ptr, Data: uintptr(ptr),
Len: uintptr(len(content)), Len: uintptr(len(content)),
})) }))
if buf != content { if buf != content {
@@ -78,7 +78,7 @@ func checkFilledBuffer(t *testing.T, ptr uintptr, content string) {
func TestMallocFree(t *testing.T) { func TestMallocFree(t *testing.T) {
tests := []struct { tests := []struct {
name string name string
getBuffer func() uintptr getBuffer func() unsafe.Pointer
content string content string
}{ }{
{ {
@@ -121,7 +121,7 @@ func TestMallocFree(t *testing.T) {
checkFilledBuffer(t, bufPtr, tt.content) checkFilledBuffer(t, bufPtr, tt.content)
libc_free(unsafe.Pointer(bufPtr)) libc_free(bufPtr)
}) })
} }
} }