tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-15 08:23:41 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

lint: add "make lint" target, run it from ci

Browse Source 
See https://github.com/tinygo-org/tinygo/issues/4225

Runs in both circleci and github, circleci is run on branch push, github is run on PR

Revive builds so fast, don't bother installing it; saves us wondering which one we get

Uses tools.go idiom to give control over linter versions to go.mod.

Also pacifies linter re AppendToGlobal as a token first fix.

TODO: gradually expand the number of directories that are linted,
uncomment more entries in revive.toml, and fix or suppress the
warnings lint finds.

TODO: add linters "go vet" and staticcheck

NOT TODO: don't add metalinters like golangci-lint that pull in
lots of new of dependencies; we'd rather not clutter go.mod that
much, let alone open ourselves up to the additional attack surface.
This commit is contained in:
Dan Kegel
2024-04-12 12:19:48 -07:00
committed by Ron Evans
parent 85b59e66da
commit 9d6e30701b
8 changed files with 103 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
GNUmakefile
+6
View File
@@ -911,3 +911,9 @@ ifneq ($(RELEASEONLY), 1)
release: build/release
deb: build/release
endif
lint:
# Only run on compiler dir for now, expand as we clean up other dirs
# This obviously won't scale, but it's a start, and it's fast
go run github.com/mgechev/revive --version
go run github.com/mgechev/revive --config revive.toml compiler/...