all: move OptimizeMaps to transforms and add tests

compiler/optimizer.go

@@ -44,7 +44,7 @@ func (c *Compiler) Optimize(optLevel, sizeLevel int, inlinerThreshold uint) erro
 		goPasses.Run(c.mod)
 
 		// Run Go-specific optimization passes.
-		c.OptimizeMaps()
+		transform.OptimizeMaps(c.mod)
 		c.OptimizeStringToBytes()
 		transform.OptimizeAllocs(c.mod)
 		c.LowerInterfaces()
@@ -154,48 +154,6 @@ func (c *Compiler) replacePanicsWithTrap() {
 	}
 }
 
-// Eliminate created but not used maps.
-//
-// In the future, this should statically allocate created but never modified
-// maps. This has not yet been implemented, however.
-func (c *Compiler) OptimizeMaps() {
-	hashmapMake := c.mod.NamedFunction("runtime.hashmapMake")
-	if hashmapMake.IsNil() {
-		// nothing to optimize
-		return
-	}
-
-	hashmapBinarySet := c.mod.NamedFunction("runtime.hashmapBinarySet")
-	hashmapStringSet := c.mod.NamedFunction("runtime.hashmapStringSet")
-
-	for _, makeInst := range getUses(hashmapMake) {
-		updateInsts := []llvm.Value{}
-		unknownUses := false // are there any uses other than setting a value?
-
-		for _, use := range getUses(makeInst) {
-			if use := use.IsACallInst(); !use.IsNil() {
-				switch use.CalledValue() {
-				case hashmapBinarySet, hashmapStringSet:
-					updateInsts = append(updateInsts, use)
-				default:
-					unknownUses = true
-				}
-			} else {
-				unknownUses = true
-			}
-		}
-
-		if !unknownUses {
-			// This map can be entirely removed, as it is only created but never
-			// used.
-			for _, inst := range updateInsts {
-				inst.EraseFromParentAsInstruction()
-			}
-			makeInst.EraseFromParentAsInstruction()
-		}
-	}
-}
-
 // Transform runtime.stringToBytes(...) calls into const []byte slices whenever
 // possible. This optimizes the following pattern:
 //     w.Write([]byte("foo"))