internal/gclayout: make gclayout values constants

The previous versions calculated at init() prevented `interp` from running
in many cases, increasing compile times due to the increased need to revert
the partially interpreted results and also increasing binary runtime because
fewer optimizations had happened during interp.
This commit is contained in:
Damian Gryski
2025-07-08 15:20:49 -07:00
committed by Ron Evans
parent 3bb092d4d4
commit 8c5886060f
5 changed files with 25 additions and 34 deletions
+15 -24
View File
@@ -5,29 +5,20 @@ import "unsafe"
// Internal constants for gc layout
// See runtime/gc_precise.go
var (
NoPtrs unsafe.Pointer
Pointer unsafe.Pointer
String unsafe.Pointer
Slice unsafe.Pointer
type Layout uintptr
const (
// 16-bit int => bits = 4
// 32-bit int => bits = 5
// 64-bit int => bits = 6
sizeBits = 4 + unsafe.Sizeof(uintptr(0))/4
sizeShift = sizeBits + 1
NoPtrs = Layout(uintptr(0b0<<sizeShift) | uintptr(0b1<<1) | uintptr(1))
Pointer = Layout(uintptr(0b1<<sizeShift) | uintptr(0b1<<1) | uintptr(1))
String = Layout(uintptr(0b01<<sizeShift) | uintptr(0b10<<1) | uintptr(1))
Slice = Layout(uintptr(0b001<<sizeShift) | uintptr(0b11<<1) | uintptr(1))
)
func init() {
var sizeBits uintptr
switch unsafe.Sizeof(uintptr(0)) {
case 8:
sizeBits = 6
case 4:
sizeBits = 5
case 2:
sizeBits = 4
}
var sizeShift = sizeBits + 1
NoPtrs = unsafe.Pointer(uintptr(0b0<<sizeShift) | uintptr(0b1<<1) | uintptr(1))
Pointer = unsafe.Pointer(uintptr(0b1<<sizeShift) | uintptr(0b1<<1) | uintptr(1))
String = unsafe.Pointer(uintptr(0b01<<sizeShift) | uintptr(0b10<<1) | uintptr(1))
Slice = unsafe.Pointer(uintptr(0b001<<sizeShift) | uintptr(0b11<<1) | uintptr(1))
}
func (l Layout) AsPtr() unsafe.Pointer { return unsafe.Pointer(l) }
+4 -4
View File
@@ -708,16 +708,16 @@ func (r *RawType) gcLayout() unsafe.Pointer {
kind := r.Kind()
if kind < String {
return gclayout.NoPtrs
return gclayout.NoPtrs.AsPtr()
}
switch kind {
case Pointer, UnsafePointer, Chan, Map:
return gclayout.Pointer
return gclayout.Pointer.AsPtr()
case String:
return gclayout.String
return gclayout.String.AsPtr()
case Slice:
return gclayout.Slice
return gclayout.Slice.AsPtr()
}
// Unknown (for now); let the conservative pointer scanning handle it