GNUmakefile: add spellfix target, use it. (#4387)

TODO: Remove the go.mod/go.sum in internal/tools once doing so doesn't break CI (e.g. once we drop support for go 1.19)

* builder/cc1as.h: fix typo found by 'make spell'
* GNUmakefile: remove exception for inbetween, fix instance now found by 'make spell'
* GNUmakefile: remove exception for programmmer, fix instance now found by 'make spell'
* go.mod: use updated misspell. GNUmakefile: add spellfix target, use it.
* ignore directories properly when invoking spellchecker.
* make spell: give internal/tools its own go.mod, as misspell requires newer go
* make lint: depend on tools and run the installed revive
(which was perhaps implied by the change that added revive to internal/tools,
but not required in GNUmakefile until we gave internal/tools its own temporary go.mod)
* .github: now that 'make spell' works well, run it from CI
* GNUmakefile: make spell now aborts if it finds misspelt words, so what it finds doesn't get lost in CI logs
* GNUmakefile: tools: avoid -C option on go generate to make test-llvm15-go119 circleci job happy, see
https://cs.opensource.google/go/go/+/2af48cbb7d85e5fdc635e75b99f949010c607786
* internal/tools/go.mod: fix format of go version to leave out patchlevel, else go complains.

src/machine/machine_atmega1280.go

@@ -180,7 +180,7 @@ func (pwm PWM) Configure(config PWMConfig) error {
 			// Set the PWM mode to fast PWM (mode = 3).
 			avr.TCCR0A.Set(avr.TCCR0A_WGM00 | avr.TCCR0A_WGM01)
 			// monotonic timer is using the same time as PWM:0
-			// we must adust internal settings of monotonic timer when PWM:0 settings changed
+			// we must adjust internal settings of monotonic timer when PWM:0 settings changed
 			adjustMonotonicTimer()
 		} else {
 			avr.TCCR2B.Set(prescaler)
@@ -718,7 +718,7 @@ func (pwm PWM) Set(channel uint8, value uint32) {
 			}
 		}
 		// monotonic timer is using the same time as PWM:0
-		// we must adust internal settings of monotonic timer when PWM:0 settings changed
+		// we must adjust internal settings of monotonic timer when PWM:0 settings changed
 		adjustMonotonicTimer()
 	case 1:
 		mask := interrupt.Disable()

src/machine/machine_atmega328.go

@@ -56,7 +56,7 @@ func (pwm PWM) Configure(config PWMConfig) error {
 			// Set the PWM mode to fast PWM (mode = 3).
 			avr.TCCR0A.Set(avr.TCCR0A_WGM00 | avr.TCCR0A_WGM01)
 			// monotonic timer is using the same time as PWM:0
-			// we must adust internal settings of monotonic timer when PWM:0 settings changed
+			// we must adjust internal settings of monotonic timer when PWM:0 settings changed
 			adjustMonotonicTimer()
 		} else {
 			avr.TCCR2B.Set(prescaler)
@@ -385,7 +385,7 @@ func (pwm PWM) Set(channel uint8, value uint32) {
 			}
 		}
 		// monotonic timer is using the same time as PWM:0
-		// we must adust internal settings of monotonic timer when PWM:0 settings changed
+		// we must adjust internal settings of monotonic timer when PWM:0 settings changed
 		adjustMonotonicTimer()
 	case 1:
 		mask := interrupt.Disable()

src/machine/machine_esp32c3.go

@@ -480,7 +480,7 @@ func (uart *UART) enableTransmitter() {
 	uart.Bus.SetCONF0_TXFIFO_RST(0)
 	// TXINFO empty threshold is when txfifo_empty_int interrupt produced after the amount of data in Tx-FIFO is less than this register value.
 	uart.Bus.SetCONF1_TXFIFO_EMPTY_THRHD(uart_empty_thresh_default)
-	// we are not using interrut on TX since write we are waiting for FIFO to have space.
+	// we are not using interrupt on TX since write we are waiting for FIFO to have space.
 	// uart.Bus.INT_ENA.SetBits(esp.UART_INT_ENA_TXFIFO_EMPTY_INT_ENA)
 }
 

src/machine/machine_mimxrt1062.go

@@ -451,7 +451,7 @@ func (p Pin) getGPIO() (norm *nxp.GPIO_Type, fast *nxp.GPIO_Type) {
 	}
 }
 
-// getPad returns both the pad and mux configration registers for a given Pin.
+// getPad returns both the pad and mux configuration registers for a given Pin.
 func (p Pin) getPad() (pad *volatile.Register32, mux *volatile.Register32) {
 	switch p.getPort() {
 	case portA:

src/machine/machine_rp2040_i2c.go

@@ -24,7 +24,7 @@ var (
 // here: https://github.com/vmilea/pico_i2c_slave
 
 // Features: Taken from datasheet.
-// Default controller mode, with target mode available (not simulataneously).
+// Default controller mode, with target mode available (not simultaneously).
 // Default target address of RP2040: 0x055
 // Supports 10-bit addressing in controller mode
 // 16-element transmit buffer

src/machine/machine_stm32f103.go

@@ -399,7 +399,7 @@ func (i2c *I2C) getFreqRange(config I2CConfig) uint32 {
 	// pclk1 clock speed is main frequency divided by PCLK1 prescaler (div 2)
 	pclk1 := CPUFrequency() / 2
 
-	// set freqency range to PCLK1 clock speed in MHz
+	// set frequency range to PCLK1 clock speed in MHz
 	// aka setting the value 36 means to use 36 MHz clock
 	return pclk1 / 1000000
 }

src/machine/machine_stm32l0.go

@@ -256,10 +256,10 @@ func (spi SPI) getBaudRate(config SPIConfig) uint32 {
 	}
 
 	// set frequency dependent on PCLK prescaler. Since these are rather weird
-	// speeds due to the CPU freqency, pick a range up to that frquency for
+	// speeds due to the CPU frequency, pick a range up to that frequency for
 	// clients to use more human-understandable numbers, e.g. nearest 100KHz
 
-	// These are based on APB2 clock frquency (84MHz on the discovery board)
+	// These are based on APB2 clock frequency (84MHz on the discovery board)
 	// TODO: also include the MCU/APB clock setting in the equation
 	switch {
 	case localFrequency < 328125:

src/machine/machine_stm32l4.go

@@ -327,10 +327,10 @@ func (spi SPI) getBaudRate(config SPIConfig) uint32 {
 	localFrequency := config.Frequency
 
 	// set frequency dependent on PCLK prescaler. Since these are rather weird
-	// speeds due to the CPU freqency, pick a range up to that frquency for
+	// speeds due to the CPU frequency, pick a range up to that frequency for
 	// clients to use more human-understandable numbers, e.g. nearest 100KHz
 
-	// These are based on 80MHz peripheral clock frquency
+	// These are based on 80MHz peripheral clock frequency
 	switch {
 	case localFrequency < 312500:
 		conf = stm32.SPI_CR1_BR_Div256