tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-21 04:49:04 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

reflect: delete incorrect optimization

Browse Source
This commit is contained in:
Jaden Weiss
2019-09-23 10:46:08 -04:00
committed by Ayke van Laethem
parent 368abeeb9a
commit 6c9e55bd06
1 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/reflect.go
+2 -9
View File
@@ -126,15 +126,8 @@ type typeCodeAssignmentState struct {
// that is ever stored in an interface. It tries to use the smallest possible // that is ever stored in an interface. It tries to use the smallest possible
// numbers to make the code that works with interfaces as small as possible. // numbers to make the code that works with interfaces as small as possible.
func (c *Compiler) assignTypeCodes(typeSlice typeInfoSlice) { func (c *Compiler) assignTypeCodes(typeSlice typeInfoSlice) {
fn := c.mod.NamedFunction("reflect.ValueOf") // if reflect were not used, we could skip generating the sidetable
if fn.IsNil() { // this does not help in practice, and is difficult to do correctly
// reflect.ValueOf is never used, so we can use the most efficient
// encoding possible.
for i, t := range typeSlice {
t.num = uint64(i + 1)
}
return
}
// Assign typecodes the way the reflect package expects. // Assign typecodes the way the reflect package expects.
state := typeCodeAssignmentState{ state := typeCodeAssignmentState{