cgo: refactor union support

Instead of putting the magic in the AST, generate regular accessor
methods. This avoids a number of special cases in the compiler, and
avoids missing any of them.

The resulting union accesses are somewhat clunkier to use, but the
compiler implementation has far less coupling between the CGo
implementation and the IR generator.

compiler/compiler.go

@@ -493,33 +493,6 @@ func (c *Compiler) getLLVMType(goType types.Type) llvm.Type {
 		for i := 0; i < typ.NumFields(); i++ {
 			members[i] = c.getLLVMType(typ.Field(i).Type())
 		}
-		if len(members) > 2 && typ.Field(0).Name() == "C union" {
-			// Not a normal struct but a C union emitted by cgo.
-			// Such a field name cannot be entered in regular Go code, this must
-			// be manually inserted in the AST so this is safe.
-			maxAlign := 0
-			maxSize := uint64(0)
-			mainType := members[0]
-			for _, member := range members {
-				align := c.targetData.ABITypeAlignment(member)
-				size := c.targetData.TypeAllocSize(member)
-				if align > maxAlign {
-					maxAlign = align
-					mainType = member
-				} else if align == maxAlign && size > maxSize {
-					maxAlign = align
-					maxSize = size
-					mainType = member
-				} else if size > maxSize {
-					maxSize = size
-				}
-			}
-			members = []llvm.Type{mainType}
-			mainTypeSize := c.targetData.TypeAllocSize(mainType)
-			if mainTypeSize < maxSize {
-				members = append(members, llvm.ArrayType(c.ctx.Int8Type(), int(maxSize-mainTypeSize)))
-			}
-		}
 		return c.ctx.StructType(members, false)
 	case *types.Tuple:
 		members := make([]llvm.Type, typ.Len())
@@ -1478,18 +1451,6 @@ func (c *Compiler) parseExpr(frame *Frame, expr ssa.Value) (llvm.Value, error) {
 		return c.builder.CreateExtractValue(value, expr.Index, ""), nil
 	case *ssa.Field:
 		value := c.getValue(frame, expr.X)
-		if s := expr.X.Type().Underlying().(*types.Struct); s.NumFields() > 2 && s.Field(0).Name() == "C union" {
-			// Extract a field from a CGo union.
-			// This could be done directly, but as this is a very infrequent
-			// operation it's much easier to bitcast it through an alloca.
-			resultType := c.getLLVMType(expr.Type())
-			alloca, allocaPtr, allocaSize := c.createTemporaryAlloca(value.Type(), "union.alloca")
-			c.builder.CreateStore(value, alloca)
-			bitcast := c.builder.CreateBitCast(alloca, llvm.PointerType(resultType, 0), "union.bitcast")
-			result := c.builder.CreateLoad(bitcast, "union.result")
-			c.emitLifetimeEnd(allocaPtr, allocaSize)
-			return result, nil
-		}
 		result := c.builder.CreateExtractValue(value, expr.Field, "")
 		return result, nil
 	case *ssa.FieldAddr:
@@ -1499,20 +1460,12 @@ func (c *Compiler) parseExpr(frame *Frame, expr ssa.Value) (llvm.Value, error) {
 		// > pointer of type *T to x. [...] If the evaluation of x would cause a
 		// > run-time panic, then the evaluation of &x does too.
 		c.emitNilCheck(frame, val, "gep")
-		if s := expr.X.Type().(*types.Pointer).Elem().Underlying().(*types.Struct); s.NumFields() > 2 && s.Field(0).Name() == "C union" {
-			// This is not a regular struct but actually an union.
-			// That simplifies things, as we can just bitcast the pointer to the
-			// right type.
-			ptrType := c.getLLVMType(expr.Type())
-			return c.builder.CreateBitCast(val, ptrType, ""), nil
-		} else {
-			// Do a GEP on the pointer to get the field address.
-			indices := []llvm.Value{
-				llvm.ConstInt(c.ctx.Int32Type(), 0, false),
-				llvm.ConstInt(c.ctx.Int32Type(), uint64(expr.Field), false),
-			}
-			return c.builder.CreateInBoundsGEP(val, indices, ""), nil
+		// Do a GEP on the pointer to get the field address.
+		indices := []llvm.Value{
+			llvm.ConstInt(c.ctx.Int32Type(), 0, false),
+			llvm.ConstInt(c.ctx.Int32Type(), uint64(expr.Field), false),
 		}
+		return c.builder.CreateInBoundsGEP(val, indices, ""), nil
 	case *ssa.Function:
 		panic("function is not an expression")
 	case *ssa.Global: