tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-17 11:13:27 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

compiler: fix typeassert without comma-ok for unused types

Browse Source
This commit is contained in:
Ayke van Laethem
2018-09-13 16:58:44 +02:00
parent d948abdf82
commit 57661a3c76
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler.go
+12 -1
View File
@@ -2334,7 +2334,18 @@ func (c *Compiler) parseExpr(frame *Frame, expr ssa.Value) (llvm.Value, error) {
assertedTypeNum, typeExists := c.ir.TypeNum(expr.AssertedType) assertedTypeNum, typeExists := c.ir.TypeNum(expr.AssertedType)
if !typeExists { if !typeExists {
// Static analysis has determined this type assert will never apply. // Static analysis has determined this type assert will never apply.
return llvm.ConstStruct([]llvm.Value{valueNil, llvm.ConstInt(llvm.Int1Type(), 0, false)}, false), nil // Using undef here so that LLVM knows we'll never get here and
// can optimize accordingly.
undef := llvm.Undef(assertedType)
commaOk := llvm.ConstInt(llvm.Int1Type(), 0, false)
if expr.CommaOk {
return llvm.ConstStruct([]llvm.Value{undef, commaOk}, false), nil
} else {
fn := c.mod.NamedFunction("runtime.interfaceTypeAssert")
c.builder.CreateCall(fn, []llvm.Value{commaOk}, "")
c.builder.CreateUnreachable()
return undef, nil
}
} }
if assertedTypeNum >= 1<<16 { if assertedTypeNum >= 1<<16 {
return llvm.Value{}, errors.New("interface typecodes do not fit in a 16-bit integer") return llvm.Value{}, errors.New("interface typecodes do not fit in a 16-bit integer")