tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-21 21:09:02 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

targets: fail fast on duplicate values in target field slices

Browse Source
This commit is contained in:
Yurii Soldak
2022-08-26 21:37:56 +02:00
committed by Ron Evans
parent b8a6a1f62b
commit 55573c6729
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compileopts/target.go
+10 -1
View File
@@ -88,8 +88,17 @@ func (spec *TargetSpec) overrideProperties(child *TargetSpec) {
if !src.IsNil() { if !src.IsNil() {
dst.Set(src) dst.Set(src)
} }
case reflect.Slice: // for slices, append the field case reflect.Slice: // for slices, append the field and check for duplicates
dst.Set(reflect.AppendSlice(dst, src)) dst.Set(reflect.AppendSlice(dst, src))
for i := 0; i < dst.Len(); i++ {
v := dst.Index(i).String()
for j := i + 1; j < dst.Len(); j++ {
w := dst.Index(j).String()
if v == w {
panic("duplicate value '" + v + "' in field : " + field.Name)
}
}
}
default: default:
panic("unknown field type : " + kind.String()) panic("unknown field type : " + kind.String())
} }