runtime: refactor markGlobals to findGlobals

Instead of markGlobals calling markRoots unconditionally (which doesn't
make sense for -gc=none and -gc=leaking), provide markRoots as a
callback function.

This is in preparation for -gc=boehm, where the previous design is even
more awkward and a callback makes far more sense.

I've tested the size impact using `make smoketest XTENSA=0`. There is
none, except for two cases:

  * One with `-opt=0` so const-propagation for the callback didn't take
    place.
  * One other on AVR, I don't know why but as it's only 16 bytes in a
    very specific case I'm going to assume it's just a random change in
    compiler output that caused a size difference.
This commit is contained in:
Ayke van Laethem
2023-09-01 17:50:41 +02:00
committed by Ron Evans
parent dc449882ad
commit 4643401a1d
8 changed files with 20 additions and 27 deletions
+1 -1
View File
@@ -420,7 +420,7 @@ func runGC() (freeBytes uintptr) {
// Mark phase: mark all reachable objects, recursively.
markStack()
markGlobals()
findGlobals(markRoots)
if baremetal && hasScheduler {
// Channel operations in interrupts may move task pointers around while we are marking.