tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-14 07:53:40 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

compiler: simplify code for builtin len()

Browse Source 
Strings and slices now have the len element at the same location.
This commit is contained in:
Ayke van Laethem
2018-09-06 10:52:36 +02:00
parent 31f494e611
commit 41a50ec336
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler.go
+4 -10
View File
@@ -1550,14 +1550,10 @@ func (c *Compiler) parseBuiltin(frame *Frame, args []ssa.Value, callName string)
if err != nil { if err != nil {
return llvm.Value{}, err return llvm.Value{}, err
} }
switch typ := args[0].Type().(type) { switch args[0].Type().(type) {
case *types.Basic: case *types.Basic, *types.Slice:
switch typ.Kind() { // string or slice
case types.String: return c.builder.CreateExtractValue(value, 1, "len"), nil
return c.builder.CreateExtractValue(value, 1, "len"), nil
default:
return llvm.Value{}, errors.New("todo: len: unknown basic type")
}
case *types.Map: case *types.Map:
indices := []llvm.Value{ indices := []llvm.Value{
llvm.ConstInt(llvm.Int32Type(), 0, false), llvm.ConstInt(llvm.Int32Type(), 0, false),
@@ -1565,8 +1561,6 @@ func (c *Compiler) parseBuiltin(frame *Frame, args []ssa.Value, callName string)
} }
ptr := c.builder.CreateGEP(value, indices, "lenptr") ptr := c.builder.CreateGEP(value, indices, "lenptr")
return c.builder.CreateLoad(ptr, "len"), nil return c.builder.CreateLoad(ptr, "len"), nil
case *types.Slice:
return c.builder.CreateExtractValue(value, 1, "len"), nil
default: default:
return llvm.Value{}, errors.New("todo: len: unknown type") return llvm.Value{}, errors.New("todo: len: unknown type")
} }