mirror of
https://github.com/tinygo-org/tinygo.git
synced 2026-08-12 06:53:40 +00:00
libclang: do not make error locations relative
This is done at a later time anyway, so doesn't need to be done in the cgo package. In fact, _not_ doing it there makes it easier to print correct relative packages.
This commit is contained in:
@@ -642,13 +642,6 @@ func (p *cgoPackage) addErrorAfter(pos token.Pos, after, msg string) {
|
|||||||
|
|
||||||
// addErrorAt is a utility function to add an error to the list of errors.
|
// addErrorAt is a utility function to add an error to the list of errors.
|
||||||
func (p *cgoPackage) addErrorAt(position token.Position, msg string) {
|
func (p *cgoPackage) addErrorAt(position token.Position, msg string) {
|
||||||
if filepath.IsAbs(position.Filename) {
|
|
||||||
// Relative paths for readability, like other Go parser errors.
|
|
||||||
relpath, err := filepath.Rel(p.currentDir, position.Filename)
|
|
||||||
if err == nil {
|
|
||||||
position.Filename = relpath
|
|
||||||
}
|
|
||||||
}
|
|
||||||
p.errors = append(p.errors, scanner.Error{
|
p.errors = append(p.errors, scanner.Error{
|
||||||
Pos: position,
|
Pos: position,
|
||||||
Msg: msg,
|
Msg: msg,
|
||||||
|
|||||||
Vendored
+2
-5
@@ -7,9 +7,6 @@ import "C"
|
|||||||
func main() {
|
func main() {
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO: this error should be relative to the current directory (so cgo.go
|
|
||||||
// instead of testdata/errors/cgo.go).
|
|
||||||
|
|
||||||
// ERROR: # command-line-arguments
|
// ERROR: # command-line-arguments
|
||||||
// ERROR: testdata/errors/cgo.go:3:5: error: hello
|
// ERROR: cgo.go:3:5: error: hello
|
||||||
// ERROR: testdata/errors/cgo.go:4:4: error: expected identifier or '('
|
// ERROR: cgo.go:4:4: error: expected identifier or '('
|
||||||
|
|||||||
Reference in New Issue
Block a user