tinygo-org/tinygo
1
0
Fork 0
mirror of https://github.com/tinygo-org/tinygo.git synced 2026-08-11 06:23:39 +00:00
Code Issues Packages Projects Releases 6 Wiki Activity

Lint: lint and fix src/{os,reflect} (#4228)

Browse Source 
* lint: expand to src/{os,reflect}, fix or suppress what it found

* internal/tools/tools.go: the tools idiom requires a build tag guard to avoid go test complaints
This commit is contained in:
dkegel-fastly
2024-04-22 11:10:13 -07:00
committed by GitHub
parent 1154212c15
commit 3d433fe9f1
7 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
GNUmakefile
+6 -4
View File
@@ -915,7 +915,9 @@ deb: build/release
endif
lint:
# Only run on compiler dir for now, expand as we clean up other dirs
# This obviously won't scale, but it's a start, and it's fast
go run github.com/mgechev/revive --version
go run github.com/mgechev/revive --config revive.toml compiler/...
go run github.com/mgechev/revive -version
# TODO: lint more directories!
# revive.toml isn't flexible enough to filter out just one kind of error from a checker, so do it with grep here.
# Can't use grep with friendly formatter. Plain output isn't too bad, though.
# Use 'grep .' to get rid of stray blank line
go run github.com/mgechev/revive -config revive.toml compiler/... src/{os,reflect}/*.go | grep -v "should have comment or be unexported" | grep '.' | awk '{print}; END {exit NR>0}'