mirror of
https://github.com/tinygo-org/tinygo.git
synced 2026-08-08 13:03:39 +00:00
wasm: remove -wasm-abi= flag
This flag controls whether to convert external i64 parameters for use in a browser-like environment. This flag was needed in the past because back then we only supported wasm on browsers but no WASI. Now, I can't think of a reason why anybody would want to change the default. For `-target=wasm` (used for browser-like environments), the wasm_exec.js file expects this i64-via-stack ABI. For WASI, there is no limitation on i64 values and `-wasm-abi=generic` is the default.
This commit is contained in:
committed by
Ron Evans
parent
8906584fb9
commit
268140ae40
@@ -14,8 +14,7 @@ import (
|
||||
// resolved, this pass may be avoided. For more details:
|
||||
// https://github.com/WebAssembly/design/issues/1172
|
||||
//
|
||||
// This pass can be enabled/disabled with the -wasm-abi flag, and is enabled by
|
||||
// default as of december 2019.
|
||||
// This pass is enabled via the wasm-abi JSON target key.
|
||||
func ExternalInt64AsPtr(mod llvm.Module, config *compileopts.Config) error {
|
||||
ctx := mod.Context()
|
||||
builder := ctx.NewBuilder()
|
||||
@@ -145,7 +144,7 @@ func ExternalInt64AsPtr(mod llvm.Module, config *compileopts.Config) error {
|
||||
builder.SetInsertPointAtEnd(entryBlock)
|
||||
var callParams []llvm.Value
|
||||
if fnType.ReturnType() == int64Type {
|
||||
return errors.New("not yet implemented: exported function returns i64 with -wasm-abi=js; " +
|
||||
return errors.New("not yet implemented: exported function returns i64 with the JS wasm-abi; " +
|
||||
"see https://tinygo.org/compiler-internals/calling-convention/")
|
||||
}
|
||||
for i, origParam := range fn.Params() {
|
||||
|
||||
Reference in New Issue
Block a user