tinygo-org/drivers
1
0
Fork 0
mirror of https://github.com/tinygo-org/drivers.git synced 2026-08-09 01:13:40 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

vl53l1x: Fix switch-case semantics

Browse Source 
The source code has been ported from C. It seems, the different
semantics of switch-case in Go has not been ported properly.
To fix this, remove 'break' statements and introduce 'fallthrough' where
necessary.

Signed-off-by: Oliver Stäbler <oliver.staebler@bytesatwork.ch>
This commit is contained in:
Oliver Stäbler
2022-04-19 11:16:58 +02:00
committed by Ron Evans
parent 2476cd7bd8
commit ec98f2dc2c
1 changed files with 4 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
vl53l1x/vl53l1x.go
+4 -17
View File
@@ -157,7 +157,6 @@ func (d *Device) SetDistanceMode(mode DistanceMode) bool {
d.writeReg(SD_CONFIG_WOI_SD1, 0x05) d.writeReg(SD_CONFIG_WOI_SD1, 0x05)
d.writeReg(SD_CONFIG_INITIAL_PHASE_SD0, 6) d.writeReg(SD_CONFIG_INITIAL_PHASE_SD0, 6)
d.writeReg(SD_CONFIG_INITIAL_PHASE_SD1, 6) d.writeReg(SD_CONFIG_INITIAL_PHASE_SD1, 6)
break
case MEDIUM: case MEDIUM:
// timing config // timing config
d.writeReg(RANGE_CONFIG_VCSEL_PERIOD_A, 0x0B) d.writeReg(RANGE_CONFIG_VCSEL_PERIOD_A, 0x0B)
@@ -169,7 +168,6 @@ func (d *Device) SetDistanceMode(mode DistanceMode) bool {
d.writeReg(SD_CONFIG_WOI_SD1, 0x09) d.writeReg(SD_CONFIG_WOI_SD1, 0x09)
d.writeReg(SD_CONFIG_INITIAL_PHASE_SD0, 10) d.writeReg(SD_CONFIG_INITIAL_PHASE_SD0, 10)
d.writeReg(SD_CONFIG_INITIAL_PHASE_SD1, 10) d.writeReg(SD_CONFIG_INITIAL_PHASE_SD1, 10)
break
case LONG: case LONG:
// timing config // timing config
d.writeReg(RANGE_CONFIG_VCSEL_PERIOD_A, 0x0F) d.writeReg(RANGE_CONFIG_VCSEL_PERIOD_A, 0x0F)
@@ -181,7 +179,6 @@ func (d *Device) SetDistanceMode(mode DistanceMode) bool {
d.writeReg(SD_CONFIG_WOI_SD1, 0x0D) d.writeReg(SD_CONFIG_WOI_SD1, 0x0D)
d.writeReg(SD_CONFIG_INITIAL_PHASE_SD0, 14) d.writeReg(SD_CONFIG_INITIAL_PHASE_SD0, 14)
d.writeReg(SD_CONFIG_INITIAL_PHASE_SD1, 14) d.writeReg(SD_CONFIG_INITIAL_PHASE_SD1, 14)
break
default: default:
return false return false
} }
@@ -333,44 +330,35 @@ func (d *Device) AmbientRate() int32 {
func (d *Device) getRangingData() { func (d *Device) getRangingData() {
d.rangingData.mm = uint16((uint32(d.results.mmCrosstalkSD0)*2011 + 0x0400) / 0x0800) d.rangingData.mm = uint16((uint32(d.results.mmCrosstalkSD0)*2011 + 0x0400) / 0x0800)
switch d.results.status { switch d.results.status {
case 17: // MULTCLIPFAIL case 1, // VCSELCONTINUITYTESTFAILURE
case 2: // VCSELWATCHDOGTESTFAILURE 2, // VCSELWATCHDOGTESTFAILURE
case 1: // VCSELCONTINUITYTESTFAILURE 3, // NOVHVVALUEFOUND
case 3: // NOVHVVALUEFOUND 17: // MULTCLIPFAIL
d.rangingData.status = HardwareFail d.rangingData.status = HardwareFail
break
case 13: // USERROICLIP case 13: // USERROICLIP
d.rangingData.status = MinRangeFail d.rangingData.status = MinRangeFail
break
case 18: // GPHSTREAMCOUNT0READY case 18: // GPHSTREAMCOUNT0READY
d.rangingData.status = SynchronizationInt d.rangingData.status = SynchronizationInt
break
case 5: // RANGEPHASECHECK case 5: // RANGEPHASECHECK
d.rangingData.status = OutOfBoundsFail d.rangingData.status = OutOfBoundsFail
break
case 4: // MSRCNOTARGET case 4: // MSRCNOTARGET
d.rangingData.status = SignalFail d.rangingData.status = SignalFail
break
case 6: // SIGMATHRESHOLDCHECK case 6: // SIGMATHRESHOLDCHECK
d.rangingData.status = SignalFail d.rangingData.status = SignalFail
break
case 7: // PHASECONSISTENCY case 7: // PHASECONSISTENCY
d.rangingData.status = WrapTargetFail d.rangingData.status = WrapTargetFail
break
case 12: // RANGEIGNORETHRESHOLD case 12: // RANGEIGNORETHRESHOLD
d.rangingData.status = XtalkSignalFail d.rangingData.status = XtalkSignalFail
break
case 8: // MINCLIP case 8: // MINCLIP
d.rangingData.status = RangeValidMinRangeClipped d.rangingData.status = RangeValidMinRangeClipped
break
case 9: // RANGECOMPLETE case 9: // RANGECOMPLETE
if d.results.streamCount == 0 { if d.results.streamCount == 0 {
@@ -378,7 +366,6 @@ func (d *Device) getRangingData() {
} else { } else {
d.rangingData.status = RangeValid d.rangingData.status = RangeValid
} }
break
default: default:
d.rangingData.status = None d.rangingData.status = None