revision: modify proposed pin HAL.

Signed-off-by: deadprogram <ron@hybridgroup.com>

mcp2515/mcp2515.go

@@ -11,13 +11,13 @@ import (
 	"time"
 
 	"tinygo.org/x/drivers"
-	"tinygo.org/x/drivers/internal/legacy"
+	"tinygo.org/x/drivers/internal/pin"
 )
 
 // Device wraps MCP2515 SPI CAN Module.
 type Device struct {
 	spi           SPI
-	cs            drivers.PinOutput
+	cs            pin.OutputFunc
 	msg           *CANMsg
 	mcpMode       byte
 	configurePins func()
@@ -37,7 +37,7 @@ const (
 )
 
 // New returns a new MCP2515 driver. Pass in a fully configured SPI bus.
-func New(b drivers.SPI, csPin legacy.PinOutput) *Device {
+func New(b drivers.SPI, csPin pin.Output) *Device {
 	d := &Device{
 		spi: SPI{
 			bus: b,
@@ -47,7 +47,7 @@ func New(b drivers.SPI, csPin legacy.PinOutput) *Device {
 		cs:  csPin.Set,
 		msg: &CANMsg{},
 		configurePins: func() {
-			legacy.ConfigurePinOut(csPin)
+			pin.ConfigureOutput(csPin)
 		},
 	}
 
@@ -57,7 +57,7 @@ func New(b drivers.SPI, csPin legacy.PinOutput) *Device {
 // Configure sets up the device for communication.
 func (d *Device) Configure() {
 	if d.configurePins == nil {
-		panic(legacy.ErrConfigBeforeInstantiated)
+		panic(pin.ErrConfigBeforeInstantiated)
 	}
 	d.configurePins()
 }
@@ -166,9 +166,9 @@ func (d *Device) init(speed, clock byte) error {
 
 // Reset resets mcp2515.
 func (d *Device) Reset() error {
-	d.cs(false)
+	d.cs.Low()
 	_, err := d.spi.readWrite(mcpReset)
-	d.cs(true)
+	d.cs.High()
 	// time.Sleep(time.Microsecond * 4)
 	if err != nil {
 		return err
@@ -456,8 +456,8 @@ func (d *Device) readMsg() error {
 
 func (d *Device) readRxBuffer(loadAddr uint8) error {
 	msg := d.msg
-	d.cs(false)
-	defer d.cs(true)
+	d.cs.Low()
+	defer d.cs.High()
 	_, err := d.spi.readWrite(loadAddr)
 	if err != nil {
 		return err
@@ -524,8 +524,8 @@ func (d *Device) getNextFreeTxBuf() (uint8, uint8, error) {
 }
 
 func (d *Device) writeCANMsg(bufNum uint8, canid uint32, ext, rtrBit, dlc uint8, data []byte) error {
-	d.cs(false)
-	defer d.cs(true)
+	d.cs.Low()
+	defer d.cs.High()
 	_, err := d.spi.readWrite(txSidhToLoad(bufNum))
 	if err != nil {
 		return err
@@ -544,7 +544,7 @@ func (d *Device) writeCANMsg(bufNum uint8, canid uint32, ext, rtrBit, dlc uint8,
 	}
 	// Since cs.Low and cs.High are executed in d.startTransmission,
 	// it is necessary to set cs.High once to separate the instruction of mcp2515.
-	d.cs(true)
+	d.cs.High()
 
 	err = d.startTransmission(bufNum)
 	if err != nil {
@@ -612,9 +612,9 @@ func (s *SPI) setTxBufData(canid uint32, ext, rtrBit, dlc uint8, data []byte) er
 }
 
 func (d *Device) startTransmission(bufNum uint8) error {
-	d.cs(false)
+	d.cs.Low()
 	_, err := d.spi.readWrite(txSidhToRTS(bufNum))
-	d.cs(true)
+	d.cs.High()
 	if err != nil {
 		return err
 	}
@@ -708,8 +708,8 @@ func txSidhToLoad(i uint8) uint8 {
 }
 
 func (d *Device) setRegister(addr, value byte) error {
-	d.cs(false)
-	defer d.cs(true)
+	d.cs.Low()
+	defer d.cs.High()
 	_, err := d.spi.readWrite(mcpWrite)
 	if err != nil {
 		return err
@@ -728,8 +728,8 @@ func (d *Device) setRegister(addr, value byte) error {
 }
 
 func (d *Device) readRegister(addr byte) (byte, error) {
-	d.cs(false)
-	defer d.cs(true)
+	d.cs.Low()
+	defer d.cs.High()
 	_, err := d.spi.readWrite(mcpRead)
 	if err != nil {
 		return 0, err
@@ -747,8 +747,8 @@ func (d *Device) readRegister(addr byte) (byte, error) {
 }
 
 func (d *Device) modifyRegister(addr, mask, data byte) error {
-	d.cs(false)
-	defer d.cs(true)
+	d.cs.Low()
+	defer d.cs.High()
 	_, err := d.spi.readWrite(mcpBitMod)
 	if err != nil {
 		return err
@@ -790,8 +790,8 @@ func (d *Device) requestNewMode(newMode byte) error {
 }
 
 func (d *Device) readStatus() (byte, error) {
-	d.cs(false)
-	defer d.cs(true)
+	d.cs.Low()
+	defer d.cs.High()
 	_, err := d.spi.readWrite(mcpReadStatus)
 	if err != nil {
 		return 0, err