From 9fb57e22fbd94c160ef1efe7a11f4e8e315f07e8 Mon Sep 17 00:00:00 2001
From: soypat <graded.sp@gmail.com>
Date: Wed, 9 Jul 2025 12:04:37 -0300
Subject: [PATCH] fix pullups not available on fe310

---
 internal/legacy/pinhal_baremetal.go |  4 ++--
 internal/legacy/pinhal_nopulls.go   | 10 ++++++++++
 internal/legacy/pinhal_pulls.go     | 10 ++++++++++
 3 files changed, 22 insertions(+), 2 deletions(-)
 create mode 100644 internal/legacy/pinhal_nopulls.go
 create mode 100644 internal/legacy/pinhal_pulls.go

diff --git a/internal/legacy/pinhal_baremetal.go b/internal/legacy/pinhal_baremetal.go
index ee4b09a..b63e06d 100644
--- a/internal/legacy/pinhal_baremetal.go
+++ b/internal/legacy/pinhal_baremetal.go
@@ -9,7 +9,7 @@ func configurePinOut(p PinOutput) {
 }
 
 func configurePinInputPulldown(p PinInput) {
-	configurePin(p, machine.PinInputPulldown)
+	configurePin(p, pulldown) // some chips do not have pull down, in which case pulldown==machine.PinInput.
 }
 
 func configurePinInput(p PinInput) {
@@ -17,7 +17,7 @@ func configurePinInput(p PinInput) {
 }
 
 func configurePinInputPullup(p PinInput) {
-	configurePin(p, machine.PinInputPullup)
+	configurePin(p, pullup) // some chips do not have pull up, in which case pullup==machine.PinInput.
 }
 
 func pinIsNoPin(a any) bool {
diff --git a/internal/legacy/pinhal_nopulls.go b/internal/legacy/pinhal_nopulls.go
new file mode 100644
index 0000000..1fc6138
--- /dev/null
+++ b/internal/legacy/pinhal_nopulls.go
@@ -0,0 +1,10 @@
+//go:build baremetal && fe310
+
+package legacy
+
+import "machine"
+
+const (
+	pulldown = machine.PinInput
+	pullup   = machine.PinInput
+)
diff --git a/internal/legacy/pinhal_pulls.go b/internal/legacy/pinhal_pulls.go
new file mode 100644
index 0000000..082e546
--- /dev/null
+++ b/internal/legacy/pinhal_pulls.go
@@ -0,0 +1,10 @@
+//go:build baremetal && !fe310
+
+package legacy
+
+import "machine"
+
+const (
+	pulldown = machine.PinInputPulldown
+	pullup   = machine.PinInputPullup
+)