tinygo-org/drivers
1
0
Fork 0
mirror of https://github.com/tinygo-org/drivers.git synced 2026-08-20 22:49:02 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

pca9685: fix on=0 bug

Browse Source 
Setting on to zero caused PWM signal to be set to high.
This commit is contained in:
Patricio Whittingslow
2022-02-25 10:41:42 -03:00
committed by Ron Evans
parent 01fed475e1
commit 2476cd7bd8
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pca9685/pca9685.go
+3 -7
View File
@@ -89,18 +89,14 @@ func (d Dev) Top() uint32 {
} }
// Set sets the `on` value of a PWM channel in the range [0..15]. // Set sets the `on` value of a PWM channel in the range [0..15].
// Max value `on` can take is 4095.
// Example: // Example:
// d.Set(1, d.Top()/4) // d.Set(1, d.Top()/4)
// sets the dutycycle of second (LED1) channel to 25%. // sets the dutycycle of second (LED1) channel to 25%.
func (d Dev) Set(channel uint8, on uint32) { func (d Dev) Set(channel uint8, on uint32) {
switch { if on > maxtop {
case on > maxtop: panic("pca9685: value must be in range 0..4095")
panic("pca9685: value must be in range 0..4096")
case on == 0:
d.SetPhased(channel, 0, maxtop)
return
} }
d.SetPhased(channel, on, 0) d.SetPhased(channel, on, 0)
} }