chore: bump minimum Go version to 1.24 (#85)

Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
This commit is contained in:
Marvin Drees
2026-04-16 22:21:23 +02:00
committed by GitHub
parent 9d436c1d86
commit f87761f777
34 changed files with 100 additions and 125 deletions
+2 -2
View File
@@ -307,7 +307,7 @@ func TestPendingSegment_RetransmitAfter3DupACKs(t *testing.T) {
tcb.HelperInitRcv(remoteISS, remoteISS+1, wnd)
// Three duplicate ACKs against UNA must trigger retransmit state
for i := 0; i < 3; i++ {
for i := range 3 {
dup := Segment{
SEQ: remoteISS + 1,
ACK: iss, // UNA (duplicate, no progress)
@@ -405,7 +405,7 @@ func TestACKLoop_MutualOutOfWindow(t *testing.T) {
tcbA.pending[0] = FlagACK
const maxRounds = 50
for round := 0; round < maxRounds; round++ {
for range maxRounds {
segA, okA := tcbA.PendingSegment(0)
if okA {
tcbA.Send(segA)
-7
View File
@@ -431,13 +431,6 @@ func (h *Handler) IsTxOver() bool {
state == StateTimeWait && !h.scb.HasPending()
}
func min(a, b int) int {
if a < b {
return a
}
return b
}
func errstr(err error) string {
if err == nil {
return "<nil>"
+4 -4
View File
@@ -1002,7 +1002,7 @@ func TestHandler_RetransmitAfter3DupACKs(t *testing.T) {
if !client.scb.IncomingIsDupACK(dup.ACK) {
t.Fatal("MakeRetransmitDupACK return should be considered a duplicate ACK by remote")
}
for i := 0; i < 3; i++ {
for i := range 3 {
fb, _ := NewFrame(pkt[:])
fb.SetSourcePort(server.LocalPort())
fb.SetDestinationPort(client.LocalPort())
@@ -1083,7 +1083,7 @@ func TestHandler_RetransmitAfterMultipleLossesBothDirections(t *testing.T) {
if !sender.scb.IncomingIsDupACK(dup.ACK) {
t.Fatal("dup ACK not recognized as dupack by sender")
}
for i := 0; i < 3; i++ {
for i := range 3 {
clear(pkt[:])
fb, _ := NewFrame(pkt[:])
fb.SetSourcePort(receiver.LocalPort())
@@ -1144,8 +1144,8 @@ func TestHandler_RetransmitAfterMultipleLossesBothDirections(t *testing.T) {
}
// Do several losses in client->server direction
for i := 0; i < loops; i++ {
payload := []byte(fmt.Sprintf("C->S loss %d", i))
for i := range loops {
payload := fmt.Appendf(nil, "C->S loss %d", i)
sendWithLoss(client, server, payload)
sendWithLoss(client, server, payload)
sendWithLoss(server, client, payload)
+2 -2
View File
@@ -86,7 +86,7 @@ func TestRSTQueue_DrainNegativeOffset(t *testing.T) {
func TestRSTQueue_Full(t *testing.T) {
var q RSTQueue
addr := []byte{10, 0, 0, 1}
for i := 0; i < 4; i++ {
for i := range 4 {
q.Queue(addr, uint16(i), 1234, Value(i), 0, FlagRST)
}
if q.Pending() != 4 {
@@ -143,7 +143,7 @@ func TestRSTQueue_MultipleDrains(t *testing.T) {
const offsetToTCP = 34
// Drain all 3 entries.
for i := 0; i < 3; i++ {
for i := range 3 {
setIPv4Version(carrier, offsetToIP)
n, err := q.Drain(carrier, offsetToIP, offsetToTCP)
if err != nil {
+2 -2
View File
@@ -161,7 +161,7 @@ func (sc *SYNCookieJar) hashTuple(srcAddr, dstAddr []byte, srcPort, dstPort uint
// Handle remaining bytes of srcAddr
if rem := len(srcAddr) % 4; rem != 0 {
var last uint32
for i := 0; i < rem; i++ {
for i := range rem {
last |= uint32(srcAddr[len(srcAddr)-rem+i]) << (i * 8)
}
h3 ^= last
@@ -174,7 +174,7 @@ func (sc *SYNCookieJar) hashTuple(srcAddr, dstAddr []byte, srcPort, dstPort uint
// Handle remaining bytes of dstAddr
if rem := len(dstAddr) % 4; rem != 0 {
var last uint32
for i := 0; i < rem; i++ {
for i := range rem {
last |= uint32(dstAddr[len(dstAddr)-rem+i]) << (i * 8)
}
h0 ^= last
+10 -10
View File
@@ -27,9 +27,9 @@ func TestRingTx_op(t *testing.T) {
dataSent := make([]byte, 0, maxBuf*10)
var rtx ringTx
rng := rand.New(rand.NewSource(0))
for iseed := int64(0); iseed < 1000; iseed++ {
for iseed := range int64(1000) {
rng.Seed(iseed + rng.Int63())
for itest := 0; itest < 32; itest++ {
for itest := range 32 {
bufsize := rng.Intn(maxBuf/2) + maxBuf/2
iss := Value(0)
npackets := rng.Intn(maxpkt-1) + 1
@@ -45,7 +45,7 @@ func TestRingTx_op(t *testing.T) {
nacked := 0
dataWritten = dataWritten[:0]
dataSent = dataSent[:0]
for iop := 0; iop < Nops; iop++ {
for iop := range Nops {
free := bufsize - nsent - nunsent
availPkt := rtx.slist.Free()
op := op(rng.Intn(int(opmax)))
@@ -180,7 +180,7 @@ func TestSentlist_simple(t *testing.T) {
// Test partial ack.
sl.AddPacket(pkt, 0, bufsize, sl.ssn)
for i := Value(0); i < pkt-1; i++ {
for range Value(pkt - 1) {
ack++
sl.RecvAck(ack, bufsize)
oldest = sl.Oldest()
@@ -208,7 +208,7 @@ func TestTxQueue_multipacket(t *testing.T) {
internalbuff := make([]byte, mtu)
rng := rand.New(rand.NewSource(3))
var wbuf, rbuf [mtu]byte
for itest := 0; itest < 32; itest++ {
for itest := range 32 {
rng.Seed(int64(itest))
err := rtx.Reset(internalbuff, maxPkts, iss)
if err != nil {
@@ -217,7 +217,7 @@ func TestTxQueue_multipacket(t *testing.T) {
numWrites := rng.Intn(maxWrites) + 1
total := 0
woff := 0
for iw := 0; iw < numWrites; iw++ {
for range numWrites {
wlen := rng.Intn(maxWriteSize) + 1
towrite := wbuf[woff : woff+wlen]
rng.Read(towrite)
@@ -234,7 +234,7 @@ func TestTxQueue_multipacket(t *testing.T) {
npkt := rng.Intn(maxPkts) + 1
roff := 0
seq := Value(iss)
for ipkt := 0; ipkt < npkt; ipkt++ {
for range npkt {
maxToPacket := min(total-roff, maxWriteSize)
pktlen := rng.Intn(maxToPacket) + 1
pkt := rbuf[roff : roff+pktlen]
@@ -289,7 +289,7 @@ func TestTxQueue(t *testing.T) {
name: "SequentialMessages",
test: func(t *testing.T) {
const startAck = 0
for i := 0; i < 10; i++ {
for range 10 {
rng.Read(msgBuf[:])
msgs := removeEmptyMsgs(bytes.SplitAfter(msgBuf[:], []byte{0}))
currentAck := Value(startAck)
@@ -314,7 +314,7 @@ func TestTxQueue(t *testing.T) {
name: "N-Messages",
test: func(t *testing.T) {
const startAck = 0
for i := 0; i < 10; i++ {
for range 10 {
rng.Read(msgBuf[:])
msgs := removeEmptyMsgs(bytes.SplitAfter(msgBuf[:], []byte{0}))
currentAck := Value(startAck)
@@ -362,7 +362,7 @@ func TestTxQueue(t *testing.T) {
const packets = 100
const maxPacketSize = bufsize / 4
var datalens [][]byte
for i := 0; i < 10; i++ {
for range 10 {
rng.Read(msgBuf[:])
err := rtx.Reset(ringBuf[:], packets, startAck)
if err != nil {