apply some of @ddirect suggestions

This commit is contained in:
Patricio Whittingslow
2025-12-22 18:41:14 -03:00
parent 5e631a1b3d
commit f6bc73ee6c
7 changed files with 104 additions and 41 deletions
+3 -3
View File
@@ -359,7 +359,7 @@ func (s *Stack) StartLookupIP(host string) error {
var u internet.StackUDPPort
dns4 := dnsSrvs.As4()
u.SetStackNode(&s.dns, dns4[:], dns.ServerPort)
err = s.udps.Register(&u, nil)
err = s.udps.Register(&u)
if err != nil {
return err
}
@@ -405,7 +405,7 @@ func (s *Stack) BeginDHCPRequest(request [4]byte) error {
}
var u internet.StackUDPPort
u.SetStackNode(&s.dhcp, nil, dhcpv4.DefaultServerPort)
err = s.udps.Register(&u, nil)
err = s.udps.Register(&u)
if err != nil {
return err
}
@@ -417,7 +417,7 @@ func (s *Stack) StartNTP(addr netip.Addr) error {
var u internet.StackUDPPort
addr4 := addr.As4()
u.SetStackNode(&s.ntp, addr4[:], ntp.ServerPort)
err := s.udps.Register(&u, nil)
err := s.udps.Register(&u)
return err
}
+2 -2
View File
@@ -239,7 +239,7 @@ func (stack *Stack) OpenTCPListener(port uint16) (*internet.NodeTCPListener, err
if err != nil {
return nil, err
}
err = stack.tcpports.Register(&listener, nil) // Passive TCP requires no MAC setting.
err = stack.tcpports.Register(&listener) // Passive TCP requires no MAC setting.
if err != nil {
return nil, err
}
@@ -261,7 +261,7 @@ func (stack *Stack) OpenPassiveTCP(port uint16, iss tcp.Value) (*tcp.Conn, error
if err != nil {
return nil, err
}
err = stack.tcpports.Register(conn, nil) // Passive MAC with no listening.
err = stack.tcpports.Register(conn) // Passive MAC with no listening.
if err != nil {
return nil, err
}