soypat/lneto
1
0
Fork 0
mirror of https://github.com/soypat/lneto.git synced 2026-08-12 02:43:44 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

explicit naming of headerCapacityKV value in kvBuffer.Reset

Browse Source
This commit is contained in:
Patricio Whittingslow
2026-07-30 01:05:51 -03:00
parent 7503e88cb1
commit aa259d1efd
5 changed files with 34 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files
http/httphi/example_test.go
+1 -1
View File
@@ -80,7 +80,7 @@ func ExampleMuxSlice_query_forms_multipart() {
// Request Body Form. The form owns the memory: hand it a buffer and
// forbid growth to bound what a request may spend.
var form httpraw.Form
form.Reset(make([]byte, 0, 1024), 8)
form.Reset(make([]byte, 0, 1024), 8) // Room for 8 pairs.
form.EnableBufferGrowth(false)
err := ex.RequestParseForm(&form, false, false)
if err != nil {
http/httphi/exchange_test.go
+5 -35
View File
@@ -23,6 +23,10 @@ func nopBackoff(consecutiveBackoffs uint) time.Duration { return lneto.BackoffFl
// where it says so.
const defaultNumHeaderKVCap = 32
// defaultKVCap is the pair table size tests hand to [httpraw.Form.Reset], a
// bounded form needing room for the pairs it parses. See [httpraw.Form.Reset].
const defaultKVCap = 8
// newExchange returns an Exchange acquired on conn, ready to serve a request.
func newExchange(t *testing.T, conn conn, cfg ExchangeConfig) *Exchange {
t.Helper()
@@ -872,7 +876,7 @@ func TestExchangeRequestParseForm(t *testing.T) {
// The form owns the memory: bufSize bounds it here, growth off so an
// oversized body is reported rather than allocated for.
var form httpraw.Form
form.Reset(make([]byte, 0, bufSize), 8)
form.Reset(make([]byte, 0, bufSize), defaultKVCap)
form.EnableBufferGrowth(false)
var gotErr error
var sm MuxSlice
@@ -1482,40 +1486,6 @@ func TestExchangeRequestParseFormFoldedTransferEncoding(t *testing.T) {
}
}
// StageHeaderInt defaults to base 10, the only base an HTTP field value uses,
// so callers do not repeat it at every site.
func TestExchangeStageHeaderIntDefaultsBase10(t *testing.T) {
conn := newConn("")
exch := newExchange(t, conn, ExchangeConfig{RawBuf: make([]byte, 256), RequestBufferLim: 128})
if !exch.StageHeaderInt("Content-Length", 1234567890) {
t.Fatal("want field staged")
}
exch.WriteHeader(200)
const want = "HTTP/1.1 200 OK\r\nContent-Length:1234567890\r\n\r\n"
if got := conn.ViewWritten(); got != want {
t.Errorf("want %q, got %q", want, got)
}
}
// StageHeaderBytes stages a value already held as bytes without the caller
// converting it to a string first.
func TestExchangeStageHeaderBytes(t *testing.T) {
conn := newConn("")
exch := newExchange(t, conn, ExchangeConfig{RawBuf: make([]byte, 256), RequestBufferLim: 128})
value := []byte("text/html")
if !exch.StageHeaderBytes("Content-Type", value) {
t.Fatal("want field staged")
}
// The value must be copied, not aliased: mutating it after staging must not
// change what reaches the wire.
value[0] = 'X'
exch.WriteHeader(200)
const want = "HTTP/1.1 200 OK\r\nContent-Type:text/html\r\n\r\n"
if got := conn.ViewWritten(); got != want {
t.Errorf("want %q, got %q", want, got)
}
}
// Respond replaces the stage/stage/stage/write boilerplate every handler paid,
// deriving Content-Length from the body so it cannot disagree with what is sent.
func TestExchangeRespond(t *testing.T) {