do not rely on unspecified Go behaviour; fix TCP ring buffer bug (#16)

* do not rely on unspecified Go behaviour; fix TCP ring buffer bug

* even more stricter error handling on tcp connections

* stricter lock copying in tcp.Conn, even though likely not a problem

* add listener and tcp pool logging

* forgot reqAddr unused

* add logging to TCPConn and friends
This commit is contained in:
Pat Whittingslow
2026-01-05 10:03:24 -03:00
committed by GitHub
parent 018f9258ac
commit 7698b9fb81
14 changed files with 570 additions and 112 deletions
+14 -5
View File
@@ -304,20 +304,29 @@ func (h *Handler) SizeRx() int {
// Write implements [io.Writer] by copying b to a internal buffer to be sent over the network on the next
// [Handler.Send] call that can send data to remote peer. Use [Handler.Free] to know the maximum length the argument slice can be before erroring.
func (h *Handler) Write(b []byte) (int, error) {
state := h.State()
if h.closing {
return 0, errConnectionClosing
} else if h.State().IsClosed() { // Reject write call if data cannot be sent.
} else if !state.TxDataOpen() { // Reject write call if data cannot be sent.
return 0, net.ErrClosed
}
return h.bufTx.Write(b)
}
// Read implements [io.Reader] by reading received data from remote peer in internal buffer.
func (h *Handler) Read(b []byte) (int, error) {
if h.State().IsClosed() { // Reject read call if state is at StateClosed. Note this is less strict than Write call condition.
return 0, net.ErrClosed
func (h *Handler) Read(b []byte) (n int, err error) {
if h.bufRx.Buffered() > 0 {
n, err = h.bufRx.Read(b)
}
return h.bufRx.Read(b)
if n == 0 && err == nil {
state := h.State()
if state.IsClosed() {
err = net.ErrClosed
} else if !state.RxDataOpen() {
err = io.EOF
}
}
return n, err
}
// BufferedInput returns amount of bytes buffered in receive(input) buffer and ready to read