soypat/lneto
1
0
Fork 0
mirror of https://github.com/soypat/lneto.git synced 2026-07-26 10:38:47 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Checksum fixes (#24)

Browse Source 
* Checksum 0x0000 is returned as 0xFFFF (mandatory for UDP, common for TCP)

* Both checksum zero values (0x0000 and 0xFFFF) are accepted when receiving

* Rename parameter in VerifySum16 to expectedSum16

---------

Co-authored-by: Pat Whittingslow <graded.sp@gmail.com>
This commit is contained in:
ddirect
2026-01-26 22:22:54 +02:00
committed by GitHub
parent 85f018a02c
commit 5e61b4600d
3 changed files with 38 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internet/stack-ip.go
+11 -9
View File
@@ -90,11 +90,12 @@ func (sb *StackIP) Demux(carrierData []byte, offset int) error {
sb.handlers.error("ip:Demux.validate")
return err
}
gotCRC := ifrm.CRC()
wantCRC := ifrm.CalculateHeaderCRC()
if gotCRC != wantCRC {
sb.handlers.error("StackIP:Demux:crc-mismatch", slog.Uint64("want", uint64(wantCRC)), slog.Uint64("got", uint64(gotCRC)))
return lneto.ErrBadCRC
// Incoming CRC Validation of common IP Protocols.
var crc lneto.CRC791
ifrm.CRCWriteHeader(&crc)
if !crc.VerifySum16(ifrm.CRC()) {
sb.handlers.error("ip:demux.crc")
}
off := ifrm.HeaderLength()
totalLen := ifrm.TotalLength()
@@ -110,7 +111,7 @@ func (sb *StackIP) Demux(carrierData []byte, offset int) error {
return lneto.ErrPacketDrop
}
// Incoming CRC Validation of common IP Protocols.
var crc lneto.CRC791
crc.Reset()
switch proto {
case lneto.IPProtoTCP:
ifrm.CRCWriteTCPPseudo(&crc)
@@ -119,7 +120,7 @@ func (sb *StackIP) Demux(carrierData []byte, offset int) error {
return err
}
tfrm.CRCWrite(&crc)
if crc.Sum16() != tfrm.CRC() {
if !crc.VerifySum16(tfrm.CRC()) {
sb.handlers.error("ip:demux.tcpcrc")
return lneto.ErrBadCRC
}
@@ -130,7 +131,8 @@ func (sb *StackIP) Demux(carrierData []byte, offset int) error {
return err
}
ufrm.CRCWriteIPv4(&crc)
if crc.Sum16() != ufrm.CRC() {
// checksums are optional in UDP: the field is set to zero in this case
if gotCrc := ufrm.CRC(); gotCrc != 0 && !crc.VerifySum16(gotCrc) {
sb.handlers.error("ip:demux.udpcrc")
return lneto.ErrBadCRC
}
@@ -210,7 +212,7 @@ func (sb *StackIP) recvicmp(carrierData []byte, offset int) error {
return err
}
cfrm.CRCWrite(&crc)
if crc.Sum16() != cfrm.CRC() {
if !crc.VerifySum16(cfrm.CRC()) {
return errors.New("ICMP CRC mismatch")
}
return nil