mirror of
https://github.com/soypat/lneto.git
synced 2026-09-08 07:49:05 +00:00
feat(tcp): implement window scaling (RFC 7323) (rebased) (#197)
* feat(tcp): implement window scaling (RFC 7323) The window-scale option was parsed for length validation but never applied: the effective receive window was capped at the 16-bit field, which caps throughput at 65535/RTT (about 4MB/s on a 15ms path) no matter how large the receive buffer is. Worse, a receive buffer over 64KiB silently WRAPPED the advertised window on the SYN (uint16 truncation): a 128KiB buffer went on the wire as a near-zero window. Design: scaling lives purely at the wire seam in Handler. The ControlBlock always holds real octet counts; conversion happens on frame read (peer windows shifted up by the peer's offer, never on SYN segments) and frame write (wireWnd: our shift down, SYN never scaled, saturation instead of wrap when the value still does not fit). The local shift derives from the receive buffer size in SetBuffers; every active SYN offers it (a zero shift still lets the peer scale, RFC 7323 §2.5) and a SYN-ACK echoes it only when the peer's SYN carried the option. The ControlBlock's three 2**16 window caps move to the scaled maximum (65535<<14). Tests: on-wire negotiation with asymmetric buffers (shift values, unscaled saturated SYN windows, first scaled advertisement, peer scaling back up); a transfer proving more than 64KiB genuinely in flight without a single ACK, received intact; wire-safety corners (no echo without an offer, saturation not wrap, so the pre-existing 128KiB SYN wrap bug stays pinned). Fuzzers clean: 9.1M TCB execs, 4.9M full-stack HTTP execs, 7.2M TCB actions. * use min instead of if statement * omitting use of min saves 8 bytes * fix option offset bug and add OptionCodec.Next method --------- Co-authored-by: Derek den Haas <d.haas@directcode.com>
This commit is contained in:
+1
-1
@@ -329,7 +329,7 @@ func TestWindowReject_ChallengeACK(t *testing.T) {
|
||||
SEQ: issB + 512,
|
||||
ACK: issA,
|
||||
Flags: FlagACK,
|
||||
WND: Size(1 << 17), // > MaxUint16.
|
||||
WND: Size(maxWindow + 1), // beyond even the largest scaled window (RFC 7323).
|
||||
}
|
||||
err := tcb.Recv(seg)
|
||||
if err == nil {
|
||||
|
||||
Reference in New Issue
Block a user