soypat/lneto
1
0
Fork 0
mirror of https://github.com/soypat/lneto.git synced 2026-09-04 13:59:04 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

dhcpv4: fixes (#19)

Browse Source 
* dhcpv4: fix several issues

* condition flipped in Encapsulate
* check for correct bounds in ForEachOption
* getMessageType didn't check for opt

* dhcpv4: preserve backing buffer in reset
This commit is contained in:
Egon Elbre
2026-01-13 22:38:00 +02:00
committed by GitHub
parent e49e3d96c1
commit 3d5999a9d8
3 changed files with 374 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dhcpv4/frame.go
+6 -6
View File
@@ -132,9 +132,6 @@ func (frm Frame) ForEachOption(fn func(off int, op OptNum, data []byte) error) e
}
callback := fn != nil
for ptr+1 < len(frm.buf) {
if int(frm.buf[ptr+1]) >= len(frm.buf) {
return errDHCPBadOption
}
optnum := OptNum(frm.buf[ptr])
if optnum == 0xff {
break
@@ -142,14 +139,17 @@ func (frm Frame) ForEachOption(fn func(off int, op OptNum, data []byte) error) e
ptr++
continue
}
optlen := frm.buf[ptr+1]
optlen := int(frm.buf[ptr+1])
if ptr+2+optlen > len(frm.buf) {
return errDHCPBadOption
}
if callback {
optionData := frm.buf[ptr+2 : ptr+2+int(optlen)]
optionData := frm.buf[ptr+2 : ptr+2+optlen]
if err := fn(ptr, optnum, optionData); err != nil {
return err
}
}
ptr += int(optlen) + 2
ptr += optlen + 2
}
return nil
}