mirror of
https://github.com/portapack-mayhem/mayhem-firmware.git
synced 2026-09-15 02:52:58 +00:00
Mo
d72b5ed0b1
* Refactor app display to use scrollable menu Removed specific app name text fields and replaced them with a scrollable menu for an unlimited app list. * Refactor app display logic in ExternalModuleView Refactor ExternalModuleView to manage app display more efficiently by using a menu instead of individual text fields. * Update menu item color to use theme foreground color * Ext Module: self-heal app list on transient read failures Only skip rebuilding the scrollable app list when the reported app count is unchanged AND the current menu already holds that many items. If some getStandaloneAppInfo() calls failed transiently (e.g. an I2C read glitch), the menu is incomplete; rebuilding on a later tick lets it self-heal instead of staying permanently truncated. Addresses Copilot review feedback on #3314.
92 lines
2.4 KiB
C++
92 lines
2.4 KiB
C++
/*
|
|
* Copyright (C) 2024 Bernd Herzog
|
|
*
|
|
* This file is part of PortaPack.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2, or (at your option)
|
|
* any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; see the file COPYING. If not, write to
|
|
* the Free Software Foundation, Inc., 51 Franklin Street,
|
|
* Boston, MA 02110-1301, USA.
|
|
*/
|
|
|
|
#ifndef __UI_EXTERNAL_MODULE_VIEW_H
|
|
#define __UI_EXTERNAL_MODULE_VIEW_H
|
|
|
|
#include "ui.hpp"
|
|
#include "ui_widget.hpp"
|
|
#include "ui_painter.hpp"
|
|
#include "ui_menu.hpp"
|
|
#include "ui_navigation.hpp"
|
|
|
|
#include "rffc507x.hpp"
|
|
#include "portapack.hpp"
|
|
#include "memory_map.hpp"
|
|
#include "irq_controls.hpp"
|
|
|
|
#include <functional>
|
|
#include <utility>
|
|
|
|
#include "i2cdevmanager.hpp"
|
|
#include "i2cdev_ppmod.hpp"
|
|
|
|
namespace ui {
|
|
|
|
class ExternalModuleView : public View {
|
|
public:
|
|
ExternalModuleView(NavigationView& nav)
|
|
: nav_(nav) {
|
|
add_children({&text_header,
|
|
&text_name,
|
|
&text_version,
|
|
&text_number_apps,
|
|
&menu_apps});
|
|
|
|
text_header.set("No module connected");
|
|
|
|
signal_token_tick_second = rtc_time::signal_tick_second += [this]() {
|
|
on_tick_second();
|
|
};
|
|
}
|
|
|
|
~ExternalModuleView() {
|
|
rtc_time::signal_tick_second -= signal_token_tick_second;
|
|
}
|
|
|
|
std::string title() const override { return "Ext Module"; };
|
|
void focus() override;
|
|
|
|
private:
|
|
NavigationView& nav_;
|
|
Text text_header{{16, 16, 208, 16}};
|
|
Text text_name{{24, 32, 200, 16}};
|
|
Text text_version{{24, 48, 200, 16}};
|
|
Text text_number_apps{{24, 64, 200, 16}};
|
|
|
|
// Scrollable, unlimited app list.
|
|
MenuView menu_apps{
|
|
{0, 84, screen_width, screen_height - 84},
|
|
true};
|
|
|
|
// Rebuild the list only when the reported app count changes, so the user
|
|
// can scroll without it resetting every second.
|
|
int32_t shown_count_{-1};
|
|
|
|
SignalToken signal_token_tick_second{};
|
|
|
|
void on_tick_second();
|
|
};
|
|
|
|
} // namespace ui
|
|
|
|
#endif
|