Fixes (#3032)

firmware/baseband/fprotos/subcarprotos.hpp

@@ -28,8 +28,8 @@ So include here the .hpp, and add a new element to the protos vector in the cons
 
 class SubCarProtos : public FProtoListGeneral {
    public:
-    SubCarProtos(const SubCarProtos&) { SubCarProtos(); };          // won't use, but makes compiler happy
-    SubCarProtos& operator=(const SubCarProtos&) { return *this; }  // won't use, but makes compiler happy
+    SubCarProtos(const SubCarProtos&) = delete;
+    SubCarProtos& operator=(const SubCarProtos&) = delete;
     SubCarProtos() {
         // add protos
         protos[FPC_SUZUKI] = new FProtoSubCarSuzuki();

firmware/baseband/fprotos/subghzdprotos.hpp

@@ -62,8 +62,8 @@ So include here the .hpp, and add a new element to the protos vector in the cons
 
 class SubGhzDProtos : public FProtoListGeneral {
    public:
-    SubGhzDProtos(const SubGhzDProtos&) { SubGhzDProtos(); };         // won't use, but makes compiler happy
-    SubGhzDProtos& operator=(const SubGhzDProtos&) { return *this; }  // won't use, but makes compiler happy
+    SubGhzDProtos(const SubGhzDProtos&) = delete;
+    SubGhzDProtos& operator=(const SubGhzDProtos&) = delete;
     SubGhzDProtos() {
         // add protos
         protos[FPS_PRINCETON] = new FProtoSubGhzDPrinceton();

firmware/baseband/fprotos/weatherprotos.hpp

@@ -41,8 +41,8 @@ So include here the .hpp, and add a new element to the protos vector in the cons
 
 class WeatherProtos : public FProtoListGeneral {
    public:
-    WeatherProtos(const WeatherProtos&) { WeatherProtos(); };         // won't use, but makes compiler happy
-    WeatherProtos& operator=(const WeatherProtos&) { return *this; }  // won't use, but makes compiler happy
+    WeatherProtos(const WeatherProtos&) = delete;
+    WeatherProtos& operator=(const WeatherProtos&) = delete;
     WeatherProtos() {
         // add protos
         protos[FPW_NexusTH] = new FProtoWeatherNexusTH();

firmware/baseband/proc_ble_tx.cpp

@@ -195,7 +195,7 @@ void BTLETxProcessor::scramble(char* bit_in, int num_bit, int channel_number, ch
 void BTLETxProcessor::disp_bit_in_hex(char* bit, int num_bit) {
     int i, a;
 
-    for (i = 0; i < num_bit; i = i + 8) {
+    for (i = 0; i + 7 < num_bit; i = i + 8) {
         a = bit[i] + bit[i + 1] * 2 + bit[i + 2] * 4 + bit[i + 3] * 8 + bit[i + 4] * 16 + bit[i + 5] * 32 + bit[i + 6] * 64 + bit[i + 7] * 128;
 
         data_message.is_data = true;

firmware/baseband/proc_mictx.cpp

@@ -101,6 +101,10 @@ void MicTXProcessor::on_message(const Message* const msg) {
 
     switch (msg->id) {
         case Message::ID::AudioTXConfig:
+            if (modulator) {
+                delete modulator;
+                modulator = NULL;
+            }
             if (fm_enabled) {
                 dsp::modulate::FM* fm = new dsp::modulate::FM();